checkpatch: Add test for consecutive string fragments

PATCH New Joe Perches 1 participant 1 message Nov 7, 2014 Checkpatch

lore

Share & tools

lore

Joe Perches

author maintainer

2014-11-07 06:40 UTC #0 lore raw

PATCH 1/1 checkpatch: Add test for consecutive string fragments

Emit a warning when single line string coalescing occurs.

Code that uses compiler string concatenation on a single line like:

	printk("foo" "bar");
is generally better to read concatenated like:
	printk("foobar");

Signed-off-by Joe Perches <[email protected]>

---
 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

scripts/checkpatch.pl +6 -0

index 893cbd5..508037a 100755
@@ -4462,6 +4462,12 @@ sub process {
 			    "Concatenated strings should use spaces between elements\n" . $herecurr);
 		}
 
+# uncoalesced string fragments
+		if ($line =~ /"X*"\s*"/) {
+			WARN("STRING_FRAGMENTS",
+			     "Consecutive strings are generally better as a single string\n" . $herecurr);
+		}
+
 # warn about #if 0
 		if ($line =~ /^.\s*\#\s*if\s+0\b/) {
 			CHK("REDUNDANT_CODE",