drm/i915: Plug memory leak in intel_shared_dpll_start_config()
Subsystems (2)
PATCH 1/1 drm/i915: Plug memory leak in intel_shared_dpll_start_config()
The cleanup path would reset pll->new_config to NULL but wouldn't free the allocated memory.
Signed-off-by Ander Conselvan de Oliveira <[email protected]>
--- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -3940,6 +3940,7 @@ static int intel_shared_dpll_start_config(struct drm_i915_private *dev_priv, cleanup:while (--i >=0 ) { pll = &dev_priv->shared_dplls[i]; +kfree (pll->new_config); pll->new_config =NULL ; }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
2014-11-07 10:07 GMT-02:00 Ander Conselvan de Oliveira <[email protected]>:
Quoted 2 lines
The cleanup path would reset
pll->new_configto NULL but wouldn't free the allocated memory.
Reviewed-by Paulo Zanoni <[email protected]>
Quoted 25 lines
Signed-off-by Ander Conselvan de Oliveira <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_display.c +1
-1@@ -3940,6 +3940,7 @@ static int intel_shared_dpll_start_config(struct drm_i915_private *dev_priv, cleanup:while (--i >=0 ) { pll = &dev_priv->shared_dplls[i]; +kfree (pll->new_config); pll->new_config =NULL ; } --1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Paulo Zanoni _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 6 lines · Paulo Zanoni
2014-11-07 10:07 GMT-02:00 Ander Conselvan de Oliveira <[email protected]>:
Quoted 2 lines
The cleanup path would reset
pll->new_configto NULL but wouldn't free the allocated memory.Reviewed-by Paulo Zanoni <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx