Skip to contentSkip to conversation

stmmac: remove custom implementation of print_hex_dump()

PATCH Applied Andy Shevchenko 2 participants 2 messages Nov 7, 2014

Subsystems (4)
Networking Network drivers Arm STM32 stmmac Ethernet driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH v2 1/1 stmmac: remove custom implementation of print_hex_dump()

There is a kernel helper to dump buffers in a hexdecimal format. This patch substitutes the open coded function by calling that helper.

The output is slightly changed:
- no lead space
- ASCII part will be printed along with the dump
- offset is longer than 3 characters (now 8)

Signed-off-by Andy Shevchenko <[email protected]>

---
Since v1:
- address Joe's comments
- describe output change

 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -8
index fa598b9..53db11b 100644
@@ -191,14 +191,8 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv)
 
 static void print_pkt(unsigned char *buf, int len)
 {
-	int j;
-	pr_debug("len = %d byte, buf addr: 0x%p", len, buf);
-	for (j = 0; j < len; j++) {
-		if ((j % 16) == 0)
-			pr_debug("\n %03x:", j);
-		pr_debug(" %02x", buf[j]);
-	}
-	pr_debug("\n");
+	pr_debug("len = %d byte, buf addr: 0x%p\n", len, buf);
+	print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len);
 }
 
 /* minimum number of free TX descriptors required to wake up TX process */
Signature · 1 line
2.1.3
maintainer Applied
#1 lore raw

From: Andy Shevchenko <[email protected]>
Date: Fri, 7 Nov 2014 16:53:12 +0200

Quoted 8 lines

There is a kernel helper to dump buffers in a hexdecimal format. This patch substitutes the open coded function by calling that helper.

The output is slightly changed:
- no lead space
- ASCII part will be printed along with the dump
- offset is longer than 3 characters (now 8)

Quoted 6 lines
Signed-off-by Andy Shevchenko <[email protected]>

---
Since v1:
- address Joe's comments
- describe output change

 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++--------

Applied to net-next, thanks.