Skip to contentSkip to conversation

ASoC: mxs: mxs-saif: Register the irq with the device name

PATCH Applied Fabio Estevam 2 participants 2 messages Nov 10, 2014

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ASoC: mxs: mxs-saif: Register the irq with the device name

From: Fabio Estevam <[email protected]>

Instead of registering the irq name with the driver name, it's better to pass the device name so that we have a more explicit indication as to what saif instance the irq is related:

$ cat /proc/interrupts 
           CPU0       
...
214:          4         -  59  80042000.saif
215:          0         -  58  80046000.saif
---
 sound/soc/mxs/mxs-saif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mxs/mxs-saif.c +1 -1
index eade2742..d986508 100644
@@ -773,7 +773,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
 
 	saif->dev = &pdev->dev;
 	ret = devm_request_irq(&pdev->dev, saif->irq, mxs_saif_irq, 0,
-			       "mxs-saif", saif);
+			       dev_name(&pdev->dev), saif);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to request irq\n");
 		return ret;
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Instead of registering the irq name with the driver name, it's better to pass the device name so that we have a more explicit indication as to what saif instance the irq is related:

Applied, thanks.