Skip to contentSkip to conversation

ASoC: sgtl5000: Fix SMALL_POP bit definition

PATCH Applied Fabio Estevam 2 participants 2 messages Nov 14, 2014

Subsystems (3)
Sound ASoC NXP SGTL5000 driver
lore
Share & tools
lore

Fabio Estevam

author maintainer
#0 lore raw

PATCH 1/1 ASoC: sgtl5000: Fix SMALL_POP bit definition

From: Fabio Estevam <[email protected]>

On a mx28evk with a sgtl5000 codec we notice a loud 'click' sound to happen 5 seconds after the end of a playback.

The SMALL_POP bit should fix this, but its definition is incorrect:
according to the sgtl5000 manual it is bit 0 of CHIP_REF_CTRL register, not bit 1.

Fix the definition accordingly and enable the bit as intended per the code comment.

After applying this change, no loud 'click' sound is heard after playback

Signed-off-by Fabio Estevam <[email protected]>
---
 sound/soc/codecs/sgtl5000.c | 3 +--
 sound/soc/codecs/sgtl5000.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
sound/soc/codecs/sgtl5000.c +1 -2
index 6bb77d7..dab9b15 100644
@@ -1299,8 +1299,7 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
 
 	/* enable small pop, introduce 400ms delay in turning off */
 	snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL,
-				SGTL5000_SMALL_POP,
-				SGTL5000_SMALL_POP);
+				SGTL5000_SMALL_POP, 1);
 
 	/* disable short cut detector */
 	snd_soc_write(codec, SGTL5000_CHIP_SHORT_CTRL, 0);
sound/soc/codecs/sgtl5000.h +1 -1
index 2f8c889..bd7a344 100644
@@ -275,7 +275,7 @@
 #define SGTL5000_BIAS_CTRL_MASK			0x000e
 #define SGTL5000_BIAS_CTRL_SHIFT		1
 #define SGTL5000_BIAS_CTRL_WIDTH		3
-#define SGTL5000_SMALL_POP			0x0001
+#define SGTL5000_SMALL_POP			0
 
 /*
  * SGTL5000_CHIP_MIC_CTRL
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

On a mx28evk with a sgtl5000 codec we notice a loud 'click' sound to happen 5 seconds after the end of a playback.

Applied, thanks.