Skip to contentSkip to conversation

ASoC: rt5677: Modify the default value and add it to patch table

PATCH In review Oder Chiou 2 participants 2 messages Nov 14, 2014

Subsystems (3)
Sound ASoC Realtek audio codecs
lore
Share & tools
lore

Oder Chiou

author maintainer
#0 lore raw

PATCH 1/1 ASoC: rt5677: Modify the default value and add it to patch table

Modify the default value and add it to patch table

Signed-off-by Oder Chiou <[email protected]>
---
 sound/soc/codecs/rt5677.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
sound/soc/codecs/rt5677.c +3 -2
index 5d317c68..9ae2e84 100644
@@ -55,7 +55,8 @@ static const struct regmap_range_cfg rt5677_ranges[] = {
 };
 
 static const struct reg_default init_list[] = {
-	{RT5677_PR_BASE + 0x3d,	0x364d},
+	{RT5677_ASRC_12, 0x0018},
+	{RT5677_PR_BASE + 0x3d, 0x364d},
 	{RT5677_PR_BASE + 0x17, 0x4fc0},
 	{RT5677_PR_BASE + 0x13, 0x0312},
 	{RT5677_PR_BASE + 0x1e, 0x0000},

@@ -173,7 +174,7 @@ static const struct reg_default rt5677_reg[] = {
 	{RT5677_ASRC_9			, 0x0000},
 	{RT5677_ASRC_10			, 0x0000},
 	{RT5677_ASRC_11			, 0x0000},
-	{RT5677_ASRC_12			, 0x0008},
+	{RT5677_ASRC_12			, 0x0018},
 	{RT5677_ASRC_13			, 0x0000},
 	{RT5677_ASRC_14			, 0x0000},
 	{RT5677_ASRC_15			, 0x0000},
Signature · 1 line
1.9.1
maintainer
#1 lore raw

sound/soc/codecs/rt5677.c static const struct regmap_range_cfg rt5677_ranges[] = { · line 59

Quoted 6 lines · Oder Chiou

Modify the default value and add it to patch table

static const struct reg_default init_list[] = {

sound/soc/codecs/rt5677.c +2 -1
-	{RT5677_PR_BASE + 0x3d,	0x364d},
+	{RT5677_ASRC_12, 0x0018},
+	{RT5677_PR_BASE + 0x3d, 0x364d},

These are named registers, you really need to provide some more clear description of what is being changed and why (especially given that you are changing the patch table as well so it's clear that this isn't just the register default being wrong in the table).