Skip to contentSkip to conversation

drm/atomic: rip out unnecessary locking checks

PATCH New Rob Clark 1 participant 1 message Nov 14, 2014

Subsystems (2)
DRM drivers DRM misc
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/atomic: rip out unnecessary locking checks

For async commit, it is *intentional* that those locks are not held.

Reviewed-by Daniel Vetter <[email protected]>
Signed-off-by Rob Clark <[email protected]>

---
opps, hit send too soon, disregard last one

 drivers/gpu/drm/drm_atomic_helper.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/drm_atomic_helper.c +0 -4
index c0a07cb..fad2b93 100644
@@ -1006,8 +1006,6 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev,
 		if (!crtc)
 			continue;
 
-		WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
-
 		funcs = crtc->helper_private;
 
 		if (!funcs || !funcs->atomic_begin)

@@ -1023,8 +1021,6 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev,
 		if (!plane)
 			continue;
 
-		WARN_ON(!drm_modeset_is_locked(&plane->mutex));
-
 		funcs = plane->helper_private;
 
 		if (!funcs || !funcs->atomic_update)
Signature · 6 lines
1.9.3

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel