Skip to contentSkip to conversation

staging:lustre:lnet:lnet Function must be static

PATCH In review sunwxg 2 participants 2 messages Nov 16, 2014 – Nov 22, 2014 Staging

lore
Share & tools
lore

sunwxg

author
#0 lore raw

PATCH 1/1 staging:lustre:lnet:lnet Function must be static

From: Sun Wang <[email protected]>

Function must be static if function will not be used in other files.

Signed-off-by Sun Wang <[email protected]>
---
 drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lnet/lnet/module.c renamed from drivers/staging/lustre/lnet/lnet/module.c.org +1 -1
index e84d59d..4ca7b1d 100644
@@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
 
 static struct mutex lnet_config_mutex;
 
-int
+static int
 lnet_configure(void *arg)
 {
 	/* 'arg' only there so I can be passed to cfs_create_thread() */
maintainer
#1 lore raw
Quoted 15 lines · sunwxg

From: Sun Wang <[email protected]>

Function must be static if function will not be used in other files.

Signed-off-by Sun Wang <[email protected]>
---
 drivers/staging/lustre/lnet/lnet/{module.c.org => module.c} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lnet/lnet/module.c renamed from drivers/staging/lustre/lnet/lnet/module.c.org +0 -0
index e84d59d..4ca7b1d 100644

drivers/staging/lustre/lnet/lnet/module.c MODULE_PARM_DESC(config_on_load, "configure network at module load"); · line 49

Quoted 8 lines
drivers/staging/lustre/lnet/lnet/module.c renamed from drivers/staging/lustre/lnet/lnet/module.c.org +1 -1
@@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
 
 static struct mutex lnet_config_mutex;
 
-int
+static int
 lnet_configure(void *arg)
 {
 	/* 'arg' only there so I can be passed to cfs_create_thread() */

Does not apply :(