tests/Android.mk: add gem_fence_upload excluded tests
PATCH 1/1 tests/Android.mk: add gem_fence_upload excluded tests
From: Tim Gore <[email protected]>
gem_fence_upload implements some performance measurements, but fails on both android and linux systems and does not generally seem to be a usefull test, so exclude it.
--- tests/Android.mk | 3 +++ 1 file changed, 3 insertions(+)
tests/Android.mk +3 -0
@@ -31,6 +31,9 @@ skip_tests_list := skip_tests_list += testdisplay # needs glib.h skip_tests_list += pm_rpm +# some tests are rusty +skip_tests_list += gem_fence_upload + # set local compilation flags for IGT tests IGT_LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM -DANDROID -UNDEBUG IGT_LOCAL_CFLAGS += -include "check-ndebug.h" -std=c99
Signature · 6 lines
2.1.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · On Tue, Nov 18, 2014 at 03:03:28PM +0000, [email protected] wrote:
From: Tim Gore <[email protected]>
gem_fence_uploadimplements some performance measurements, but fails on both android and linux systems and does not generally seem to be a usefull test, so exclude it.Signed-off-by Tim Gore <[email protected]>
Nack. Just because the test tests something that doesn't yet work doesn't mean we should skip it by default.
And if you need skip lists because of your validation process then that should be managed within your test environment, preferrably per-platform. -Daniel
Quoted 25 lines
--- tests/Android.mk | 3 +++ 1 file changed, 3 insertions(+)tests/Android.mk +3
-0@@ -31,6 +31,9 @@ skip_tests_list := skip_tests_list += testdisplay # needs glib.h skip_tests_list += pm_rpm +# some tests are rusty +skip_tests_list += gem_fence_upload + # set local compilation flags for IGT tests IGT_LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM -DANDROID -UNDEBUG IGT_LOCAL_CFLAGS += -include "check-ndebug.h" -std=c99Signature · 6 lines
2.1.3 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Daniel Vetter
Quoted 7 lines · On Tue, Nov 18, 2014 at 03:03:28PM +0000, [email protected] wrote:
From: Tim Gore <[email protected]>
gem_fence_uploadimplements some performance measurements, but fails on both android and linux systems and does not generally seem to be a usefull test, so exclude it.Signed-off-by Tim Gore <[email protected]>Nack. Just because the test tests something that doesn't yet work doesn't mean we should skip it by default.
Especially since it is a testcase that we were specifically asked to improve...
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx