Skip to contentSkip to conversation

gw_ventana: Use the generic spl_sd.cfg

PATCH New Fabio Estevam 2 participants 2 messages Nov 20, 2014 – Nov 24, 2014

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 gw_ventana: Use the generic spl_sd.cfg

From: Fabio Estevam <[email protected]>

gw_ventana can boot from SPI or NAND and both of these interfaces boot from the same 0x400 offset.

This means that we could simplify the code and replace the custom gw_ventana.cfg with the generic spl_sd.cfg, as it provides the same boot offset of 0x400.

Cc Tim Harvey <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 board/gateworks/gw_ventana/gw_ventana.cfg | 23 -----------------------
 configs/gwventana_defconfig               |  2 +-
 2 files changed, 1 insertion(+), 24 deletions(-)
 delete mode 100644 board/gateworks/gw_ventana/gw_ventana.cfg
board/gateworks/gw_ventana/gw_ventana.cfg deleted +0 -23
deleted file mode 100644
index dd8aa61..0000000
@@ -1,23 +0,0 @@
-/*
- * Copyright (C) 2013 Gateworks Corporation
- *
- * SPDX-License-Identifier: GPL-2.0+
- *
- * Refer doc/README.imximage for more details about how-to configure
- * and create imximage boot image
- *
- * The syntax is taken as close as possible with the kwbimage
- */
-
-/* image version */
-IMAGE_VERSION 2
-
-/*
- * Boot Device : one of
- * spi, sd, nand, sata
- */
-#ifdef CONFIG_SPI_FLASH
-BOOT_FROM      spi
-#else
-BOOT_FROM      nand
-#endif
configs/gwventana_defconfig +1 -1
index f185329..4cddbdd 100644
@@ -1,4 +1,4 @@
 CONFIG_SPL=y
-CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/gateworks/gw_ventana/gw_ventana.cfg,MX6QDL"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL"
 +S:CONFIG_ARM=y
 +S:CONFIG_TARGET_GW_VENTANA=y
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 gw_ventana: Use the generic spl_sd.cfg

Hi Fabio, Tim

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

gw_ventana can boot from SPI or NAND and both of these interfaces boot from the same 0x400 offset.

This means that we could simplify the code and replace the custom gw_ventana.cfg with the generic spl_sd.cfg, as it provides the same boot offset of 0x400.

Cc Tim Harvey <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---

Tim, this factorize common code - I think it can harmless flow into mainline.

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================