staging: lustre: Coalesce string fragments
PATCH 1/1 staging: lustre: Coalesce string fragments
Join the string fragments to make it easier to grep.
Ignored all the 80+ column lines.
Added many missing spaces when coalescing formats.
---
I used this directory as a test for a new "coalesce string fragments" checkpatch rule. Might as well submit the change.
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 12 +- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 34 ++--- .../lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c | 3 +- .../staging/lustre/lnet/klnds/socklnd/socklnd.c | 49 +++--- .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 89 +++++------ .../lustre/lnet/klnds/socklnd/socklnd_proto.c | 15 +- drivers/staging/lustre/lnet/lnet/lib-move.c | 82 +++++----- drivers/staging/lustre/lnet/lnet/lib-ptl.c | 3 +- drivers/staging/lustre/lnet/lnet/router.c | 34 ++--- drivers/staging/lustre/lnet/lnet/router_proc.c | 9 +- drivers/staging/lustre/lnet/selftest/console.c | 6 +- drivers/staging/lustre/lnet/selftest/framework.c | 25 ++- drivers/staging/lustre/lnet/selftest/module.c | 4 +- drivers/staging/lustre/lnet/selftest/rpc.c | 29 ++-- drivers/staging/lustre/lustre/include/linux/obd.h | 3 +- .../staging/lustre/lustre/include/lustre_disk.h | 3 +- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 3 +- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 4 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 168 +++++++++------------ drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 11 +- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 10 +- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 37 ++--- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 19 +-- drivers/staging/lustre/lustre/libcfs/debug.c | 8 +- drivers/staging/lustre/lustre/libcfs/hash.c | 3 +- .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 32 ++-- .../lustre/lustre/libcfs/linux/linux-tcpip.c | 3 +- drivers/staging/lustre/lustre/libcfs/tracefile.c | 35 +++-- drivers/staging/lustre/lustre/llite/dcache.c | 4 +- drivers/staging/lustre/lustre/llite/dir.c | 25 ++- drivers/staging/lustre/lustre/llite/file.c | 16 +- drivers/staging/lustre/lustre/llite/llite_capa.c | 3 +- drivers/staging/lustre/lustre/llite/llite_close.c | 16 +- .../staging/lustre/lustre/llite/llite_internal.h | 12 +- drivers/staging/lustre/lustre/llite/llite_lib.c | 58 +++---- drivers/staging/lustre/lustre/llite/llite_mmap.c | 9 +- drivers/staging/lustre/lustre/llite/llite_rmtacl.c | 7 +- drivers/staging/lustre/lustre/llite/lloop.c | 4 +- drivers/staging/lustre/lustre/llite/lproc_llite.c | 29 ++-- drivers/staging/lustre/lustre/llite/namei.c | 14 +- drivers/staging/lustre/lustre/llite/rw.c | 20 +-- drivers/staging/lustre/lustre/llite/statahead.c | 21 +-- drivers/staging/lustre/lustre/llite/symlink.c | 4 +- drivers/staging/lustre/lustre/llite/vvp_io.c | 5 +- drivers/staging/lustre/lustre/llite/vvp_page.c | 3 +- drivers/staging/lustre/lustre/llite/xattr.c | 3 +- drivers/staging/lustre/lustre/lmv/lmv_fld.c | 3 +- drivers/staging/lustre/lustre/lmv/lmv_intent.c | 8 +- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 36 ++--- drivers/staging/lustre/lustre/lov/lov_ea.c | 5 +- drivers/staging/lustre/lustre/lov/lov_obd.c | 32 ++-- drivers/staging/lustre/lustre/mgc/mgc_request.c | 6 +- drivers/staging/lustre/lustre/obdclass/capa.c | 8 +- drivers/staging/lustre/lustre/obdclass/cl_io.c | 3 +- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 3 +- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +- drivers/staging/lustre/lustre/obdclass/genops.c | 18 +-- .../lustre/lustre/obdclass/linux/linux-sysctl.c | 5 +- drivers/staging/lustre/lustre/obdclass/llog.c | 4 +- drivers/staging/lustre/lustre/obdclass/llog_cat.c | 10 +- drivers/staging/lustre/lustre/obdclass/llog_swab.c | 3 +- .../lustre/lustre/obdclass/lprocfs_status.c | 10 +- drivers/staging/lustre/lustre/obdclass/lu_object.c | 3 +- .../staging/lustre/lustre/obdclass/obd_config.c | 9 +- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 38 ++--- .../staging/lustre/lustre/obdecho/echo_client.c | 3 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +- drivers/staging/lustre/lustre/osc/osc_lock.c | 6 +- drivers/staging/lustre/lustre/osc/osc_object.c | 3 +- drivers/staging/lustre/lustre/osc/osc_page.c | 11 +- drivers/staging/lustre/lustre/osc/osc_request.c | 47 +++--- drivers/staging/lustre/lustre/ptlrpc/client.c | 44 +++--- drivers/staging/lustre/lustre/ptlrpc/events.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/import.c | 108 +++++-------- drivers/staging/lustre/lustre/ptlrpc/layout.c | 20 +-- drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 3 +- .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 13 +- drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 33 ++-- .../staging/lustre/lustre/ptlrpc/pack_generic.c | 33 ++-- drivers/staging/lustre/lustre/ptlrpc/pinger.c | 16 +- drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/recover.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/sec.c | 22 ++- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 3 +- drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 4 +- drivers/staging/lustre/lustre/ptlrpc/service.c | 90 +++++------ 87 files changed, 684 insertions(+), 1003 deletions(-)
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c +4 -8
@@ -930,8 +930,7 @@ kiblnd_close_peer_conns_locked (kib_peer_t *peer, int why) list_for_each_safe (ctmp, cnxt, &peer->ibp_conns) { conn =list_entry (ctmp, kib_conn_t, ibc_list); -CDEBUG (D_NET ,"Closing conn -> %s, " -"version: %x, reason: %d\n" , +CDEBUG (D_NET ,"Closing conn -> %s, version: %x, reason: %d\n" ,libcfs_nid2str (peer->ibp_nid), conn->ibc_version, why);
@@ -958,8 +957,7 @@ kiblnd_close_stale_conns_locked (kib_peer_t *peer, conn->ibc_incarnation == incarnation)continue ; -CDEBUG (D_NET ,"Closing stale conn -> %s version: %x, " -"incarnation:%#llx(%x, %#llx)\n" , +CDEBUG (D_NET ,"Closing stale conn -> %s version: %x, incarnation:%#llx(%x, %#llx)\n" ,libcfs_nid2str (peer->ibp_nid), conn->ibc_version, conn->ibc_incarnation, version, incarnation);
@@ -1599,8 +1597,7 @@ kiblnd_fmr_pool_map(kib_fmr_poolset_t *fps, __u64 *pages, int npages,if (fps->fps_increasing) {spin_unlock (&fps->fps_lock); -CDEBUG (D_NET ,"Another thread is allocating new " -"FMR pool, waiting for her to complete\n" ); +CDEBUG (D_NET ,"Another thread is allocating new FMR pool, waiting for her to complete\n" );schedule (); goto again;
@@ -1801,8 +1798,7 @@ kiblnd_pool_alloc_node(kib_poolset_t *ps)if (ps->ps_increasing) {/* another thread is allocating a new pool */ spin_unlock (&ps->ps_lock); -CDEBUG (D_NET ,"Another thread is allocating new " -"%s pool, waiting for her to complete\n" , +CDEBUG (D_NET ,"Another thread is allocating new %s pool, waiting for her to complete\n" , ps->ps_name);schedule (); goto again;
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c +12 -22
@@ -1116,8 +1116,7 @@ kiblnd_init_rdma (kib_conn_t *conn, kib_tx_t *tx, int type, }if (tx->tx_nwrq ==IBLND_RDMA_FRAGS (conn->ibc_version)) { - CERROR("RDMA too fragmented for %s (%d): " - "%d/%d src %d/%d dst frags\n", + CERROR("RDMA too fragmented for %s (%d): %d/%d src %d/%d dst frags\n", libcfs_nid2str(conn->ibc_peer->ibp_nid), IBLND_RDMA_FRAGS(conn->ibc_version), srcidx, srcrd->rd_nfrags,
@@ -2254,8 +2253,8 @@ kiblnd_passive_connect (struct rdma_cm_id *cmid, void *priv, int priv_nob)if (ni ==NULL ||/* no matching net */ ni->ni_nid != reqmsg->ibm_dstnid ||/* right NET, wrong NID! */ net->ibn_dev != ibdev) {/* wrong device */ - CERROR("Can't accept %s on %s (%s:%d:%pI4h): " - "bad dst nid %s\n", libcfs_nid2str(nid), + CERROR("Can't accept %s on %s (%s:%d:%pI4h): bad dst nid %s\n", + libcfs_nid2str(nid), ni == NULL ? "NA" : libcfs_nid2str(ni->ni_nid), ibdev->ibd_ifname, ibdev->ibd_nnets, &ibdev->ibd_ifip,
@@ -2295,8 +2294,7 @@ kiblnd_passive_connect (struct rdma_cm_id *cmid, void *priv, int priv_nob)if (reqmsg->ibm_u.connparams.ibcp_max_frags !=IBLND_RDMA_FRAGS (version)) { -CERROR ("Can't accept %s(version %x): " -"incompatible max_frags %d (%d wanted)\n" , +CERROR ("Can't accept %s(version %x): incompatible max_frags %d (%d wanted)\n" ,libcfs_nid2str (nid), version, reqmsg->ibm_u.connparams.ibcp_max_frags,IBLND_RDMA_FRAGS (version));
@@ -2502,8 +2500,7 @@ kiblnd_reconnect (kib_conn_t *conn, int version,break ; } - CNETERR("%s: retrying (%s), %x, %x, " - "queue_dep: %d, max_frag: %d, msg_size: %d\n", + CNETERR("%s: retrying (%s), %x, %x, queue_dep: %d, max_frag: %d, msg_size: %d\n", libcfs_nid2str(peer->ibp_nid), reason, IBLND_MSG_VERSION, version, cp != NULL? cp->ibcp_queue_depth :IBLND_MSG_QUEUE_SIZE(version),
@@ -2679,8 +2676,7 @@ kiblnd_check_connreply (kib_conn_t *conn, void *priv, int priv_nob) }if (ver != msg->ibm_version) { -CERROR ("%s replied version %x is different with " -"requested version %x\n" , +CERROR ("%s replied version %x is different with requested version %x\n" ,libcfs_nid2str (peer->ibp_nid), msg->ibm_version, ver); rc = -EPROTO ; goto failed;
@@ -2724,8 +2720,7 @@ kiblnd_check_connreply (kib_conn_t *conn, void *priv, int priv_nob)read_unlock_irqrestore (&kiblnd_data.kib_global_lock, flags);if (rc !=0 ) { -CERROR ("Bad connection reply from %s, rc = %d, " -"version: %x max_frags: %d\n" , +CERROR ("Bad connection reply from %s, rc = %d, version: %x max_frags: %d\n" ,libcfs_nid2str (peer->ibp_nid), rc, msg->ibm_version, msg->ibm_u.connparams.ibcp_max_frags); goto failed;
@@ -3060,8 +3055,7 @@ kiblnd_check_conns (int idx) }if (timedout) { - CERROR("Timed out RDMA with %s (%lu): " - "c: %u, oc: %u, rc: %u\n", + CERROR("Timed out RDMA with %s (%lu): c: %u, oc: %u, rc: %u\n", libcfs_nid2str(peer->ibp_nid), cfs_duration_sec(cfs_time_current() - peer->ibp_last_alive),
@@ -3334,10 +3328,8 @@ kiblnd_scheduler(void *arg) rc =cfs_cpt_bind (lnet_cpt_table (), sched->ibs_cpt);if (rc !=0 ) { -CWARN ("Failed to bind on CPT %d, please verify whether " -"all CPUs are healthy and reload modules if necessary, " -"otherwise your system might under risk of low " -"performance\n" , sched->ibs_cpt); +CWARN ("Failed to bind on CPT %d, please verify whether all CPUs are healthy and reload modules if necessary, otherwise your system might under risk of low performance\n" , + sched->ibs_cpt); }spin_lock_irqsave (&sched->ibs_lock, flags);
@@ -3369,8 +3361,7 @@ kiblnd_scheduler(void *arg) rc =ib_req_notify_cq (conn->ibc_cq,IB_CQ_NEXT_COMP );if (rc <0 ) { -CWARN ("%s: ib_req_notify_cq failed: %d, " -"closing connection\n" , +CWARN ("%s: ib_req_notify_cq failed: %d, closing connection\n" ,libcfs_nid2str (conn->ibc_peer->ibp_nid), rc);kiblnd_close_conn (conn, -EIO );kiblnd_conn_decref (conn);
@@ -3383,8 +3374,7 @@ kiblnd_scheduler(void *arg) }if (rc <0 ) { -CWARN ("%s: ib_poll_cq failed: %d, " -"closing connection\n" , +CWARN ("%s: ib_poll_cq failed: %d, closing connection\n" ,libcfs_nid2str (conn->ibc_peer->ibp_nid), rc);kiblnd_close_conn (conn, -EIO );
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c +1 -2
@@ -222,8 +222,7 @@ kiblnd_tunables_init (void) *kiblnd_tunables.kib_concurrent_sends = *kiblnd_tunables.kib_peertxcredits /2 ;if (*kiblnd_tunables.kib_concurrent_sends < *kiblnd_tunables.kib_peertxcredits) { -CWARN ("Concurrent sends %d is lower than message queue size: %d, " -"performance may drop slightly.\n" , +CWARN ("Concurrent sends %d is lower than message queue size: %d, performance may drop slightly.\n" , *kiblnd_tunables.kib_concurrent_sends, *kiblnd_tunables.kib_peertxcredits); }
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c +20 -29
103 lines not on this page · raw message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c +35 -54
184 lines not on this page · raw message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_proto.c +7 -8
@@ -515,8 +515,8 @@ ksocknal_send_hello_v1 (ksock_conn_t *conn, ksock_hello_msg_t *hello) hello->kshm_nips *sizeof (__u32), lnet_acceptor_timeout());if (rc !=0 ) { -CNETERR ("Error %d sending HELLO payload (%d)" -" to %pI4h/%d\n" , rc, hello->kshm_nips, +CNETERR ("Error %d sending HELLO payload (%d) to %pI4h/%d\n" , + rc, hello->kshm_nips, &conn->ksnc_ipaddr, conn->ksnc_port); } out:
@@ -560,8 +560,8 @@ ksocknal_send_hello_v2 (ksock_conn_t *conn, ksock_hello_msg_t *hello) hello->kshm_nips *sizeof (__u32), lnet_acceptor_timeout());if (rc !=0 ) { -CNETERR ("Error %d sending HELLO payload (%d)" -" to %pI4h/%d\n" , rc, hello->kshm_nips, +CNETERR ("Error %d sending HELLO payload (%d) to %pI4h/%d\n" , + rc, hello->kshm_nips, &conn->ksnc_ipaddr, conn->ksnc_port); }
@@ -595,10 +595,9 @@ ksocknal_recv_hello_v1(ksock_conn_t *conn, ksock_hello_msg_t *hello,/* ...and check we got what we expected */ if (hdr->type !=cpu_to_le32 (LNET_MSG_HELLO )) { -CERROR ("Expecting a HELLO hdr," -" but got type %d from %pI4h\n" , -le32_to_cpu (hdr->type), - &conn->ksnc_ipaddr); +CERROR ("Expecting a HELLO hdr, but got type %d from %pI4h\n" , +le32_to_cpu (hdr->type), + &conn->ksnc_ipaddr); rc = -EPROTO ; goto out; }
drivers/staging/lustre/lnet/lnet/lib-move.c +34 -48
174 lines not on this page · raw message
drivers/staging/lustre/lnet/lnet/lib-ptl.c +1 -2
@@ -192,8 +192,7 @@ lnet_try_match_md(lnet_libmd_t *md, }/* Commit to this ME/MD */ -CDEBUG (D_NET ,"Incoming %s index %x from %s of " -"length %d/%d into md %#llx [%d] + %d\n" , +CDEBUG (D_NET ,"Incoming %s index %x from %s of length %d/%d into md %#llx [%d] + %d\n" , (info->mi_opc ==LNET_MD_OP_PUT ) ?"put" :"get" , info->mi_portal,libcfs_id2str (info->mi_id), mlength, info->mi_rlength, md->md_lh.lh_cookie, md->md_niov, offset);
drivers/staging/lustre/lnet/lnet/router.c +14 -20
@@ -457,8 +457,7 @@ lnet_check_routes(void)lnet_net_unlock (cpt); -CERROR ("Routes to %s via %s and %s not " -"supported\n" , +CERROR ("Routes to %s via %s and %s not supported\n" ,libcfs_net2str (net),libcfs_nid2str (nid1),libcfs_nid2str (nid2));
@@ -959,8 +958,7 @@ lnet_ping_router_locked (lnet_peer_t *rtr) secs =lnet_router_check_interval (rtr);CDEBUG (D_NET , -"rtr %s %d: deadline %lu ping_notsent %d alive %d " -"alive_count %d lp_ping_timestamp %lu\n" , +"rtr %s %d: deadline %lu ping_notsent %d alive %d alive_count %d lp_ping_timestamp %lu\n" ,libcfs_nid2str (rtr->lp_nid), secs, rtr->lp_ping_deadline, rtr->lp_ping_notsent, rtr->lp_alive, rtr->lp_alive_count, rtr->lp_ping_timestamp);
@@ -1010,9 +1008,7 @@ lnet_router_checker_start(void)if (check_routers_before_use && dead_router_check_interval <=0 ) { -LCONSOLE_ERROR_MSG (0x10a ,"'dead_router_check_interval' must be" -" set if 'check_routers_before_use' is set" -"\n" ); +LCONSOLE_ERROR_MSG (0x10a ,"'dead_router_check_interval' must be set if 'check_routers_before_use' is set\n" );return -EINVAL ; }
@@ -1370,8 +1366,8 @@ lnet_nrb_tiny_calculate(int npages)if (tiny_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"tiny_router_buffers=%d invalid when " -"routing enabled\n" , tiny_router_buffers); +"tiny_router_buffers=%d invalid when routing enabled\n" , + tiny_router_buffers);return -1 ; }
@@ -1389,8 +1385,8 @@ lnet_nrb_small_calculate(int npages)if (small_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"small_router_buffers=%d invalid when " -"routing enabled\n" , small_router_buffers); +"small_router_buffers=%d invalid when routing enabled\n" , + small_router_buffers);return -1 ; }
@@ -1408,8 +1404,8 @@ lnet_nrb_large_calculate(int npages)if (large_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"large_router_buffers=%d invalid when " -"routing enabled\n" , large_router_buffers); +"large_router_buffers=%d invalid when routing enabled\n" , + large_router_buffers);return -1 ; }
@@ -1442,8 +1438,7 @@ lnet_rtrpools_alloc(int im_a_router) }else if (!strcmp (forwarding,"enabled" )) {/* explicitly enabled */ }else { -LCONSOLE_ERROR_MSG (0x10b ,"'forwarding' not set to either " -"'enabled' or 'disabled'\n" ); +LCONSOLE_ERROR_MSG (0x10b ,"'forwarding' not set to either 'enabled' or 'disabled'\n" );return -EINVAL ; }
@@ -1520,11 +1515,10 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)/* can't do predictions... */ if (cfs_time_after (when, now)) { -CWARN ("Ignoring prediction from %s of %s %s " -"%ld seconds in the future\n" , - (ni ==NULL ) ?"userspace" :libcfs_nid2str (ni->ni_nid), -libcfs_nid2str (nid), alive ?"up" :"down" , -cfs_duration_sec (cfs_time_sub (when, now))); +CWARN ("Ignoring prediction from %s of %s %s %ld seconds in the future\n" , + (ni ==NULL ) ?"userspace" :libcfs_nid2str (ni->ni_nid), +libcfs_nid2str (nid), alive ?"up" :"down" , +cfs_duration_sec (cfs_time_sub (when, now)));return -EINVAL ; }
drivers/staging/lustre/lnet/lnet/router_proc.c +3 -6
@@ -791,20 +791,17 @@ static struct lnet_portal_rotors portal_rotors[] = { { .pr_value = LNET_PTL_ROTOR_ON, .pr_name = "ON", - .pr_desc ="round-robin dispatch all PUT messages for " -"wildcard portals" + .pr_desc ="round-robin dispatch all PUT messages for wildcard portals" }, { .pr_value = LNET_PTL_ROTOR_RR_RT, .pr_name = "RR_RT", - .pr_desc ="round-robin dispatch routed PUT message for " -"wildcard portals" + .pr_desc ="round-robin dispatch routed PUT message for wildcard portals" }, { .pr_value = LNET_PTL_ROTOR_HASH_RT, .pr_name = "HASH_RT", - .pr_desc ="dispatch routed PUT message by hashing source " -"NID for wildcard portals" + .pr_desc ="dispatch routed PUT message by hashing source NID for wildcard portals" }, { .pr_value = -1,
drivers/staging/lustre/lnet/selftest/console.c +2 -4
@@ -1208,8 +1208,7 @@ again:lstcon_rpc_trans_destroy (trans);/* return if any error */ -CDEBUG (D_NET ,"Failed to add test %s, " -"RPC error %d, framework error %d\n" , +CDEBUG (D_NET ,"Failed to add test %s, RPC error %d, framework error %d\n" , transop ==LST_TRANS_TSBCLIADD ?"client" :"server" ,lstcon_trans_stat ()->trs_rpc_errno,lstcon_trans_stat ()->trs_fwk_errno);
@@ -1885,8 +1884,7 @@ lstcon_session_feats_check(unsigned feats)spin_unlock (&console_session.ses_rpc_lock);if (rc !=0 ) { -CERROR ("remote features %x do not match with " -"session features %x of console\n" , +CERROR ("remote features %x do not match with session features %x of console\n" , feats, console_session.ses_features); }
drivers/staging/lustre/lnet/selftest/framework.c +9 -16
@@ -291,8 +291,7 @@ sfw_server_rpc_done(struct srpc_server_rpc *rpc)int status = rpc->srpc_status;CDEBUG (D_NET , -"Incoming framework RPC done: " -"service %s, peer %s, status %s:%d\n" , +"Incoming framework RPC done: service %s, peer %s, status %s:%d\n" , sv->sv_name,libcfs_id2str (rpc->srpc_peer),swi_state2str (rpc->srpc_wi.swi_state), status);
@@ -310,8 +309,7 @@ sfw_client_rpc_fini (srpc_client_rpc_t *rpc)LASSERT (atomic_read (&rpc->crpc_refcount) ==0 );CDEBUG (D_NET , -"Outgoing framework RPC done: " -"service %d, peer %s, status %s:%d:%d\n" , +"Outgoing framework RPC done: service %d, peer %s, status %s:%d:%d\n" , rpc->crpc_service,libcfs_id2str (rpc->crpc_dest),swi_state2str (rpc->crpc_wi.swi_state), rpc->crpc_aborted, rpc->crpc_status);
@@ -575,8 +573,8 @@ sfw_load_test(struct sfw_test_instance *tsi) rc =srpc_service_add_buffers (svc, nbuf);if (rc !=0 ) { -CWARN ("Failed to reserve enough buffers: " -"service %s, %d needed: %d\n" , svc->sv_name, nbuf, rc); +CWARN ("Failed to reserve enough buffers: service %s, %d needed: %d\n" , + svc->sv_name, nbuf, rc);/* NB: this error handler is not strictly correct, because * it may release more buffers than already allocated, * but it doesn't matter because request portal should
@@ -1270,8 +1268,7 @@ sfw_handle_server_rpc(struct srpc_server_rpc *rpc)if (sn !=NULL && sn->sn_features != request->msg_ses_feats) { -CNETERR ("Features of framework RPC don't match " -"features of current session: %x/%x\n" , +CNETERR ("Features of framework RPC don't match features of current session: %x/%x\n" , request->msg_ses_feats, sn->sn_features); reply->msg_body.reply.status =EPROTO ; reply->msg_body.reply.sid = sn->sn_id;
@@ -1348,8 +1345,7 @@ sfw_bulk_ready(struct srpc_server_rpc *rpc, int status)spin_lock (&sfw_data.fw_lock);if (status !=0 ) { -CERROR ("Bulk transfer failed for RPC: " -"service %s, peer %s, status %d\n" , +CERROR ("Bulk transfer failed for RPC: service %s, peer %s, status %d\n" , sv->sv_name,libcfs_id2str (rpc->srpc_peer), status);spin_unlock (&sfw_data.fw_lock);return -EIO ;
@@ -1664,12 +1660,10 @@ sfw_startup (void) }if (session_timeout ==0 ) -CWARN ("Zero session_timeout specified " -"- test sessions never expire.\n" ); +CWARN ("Zero session_timeout specified - test sessions never expire.\n" );if (rpc_timeout ==0 ) -CWARN ("Zero rpc_timeout specified " -"- test RPC never expire.\n" ); +CWARN ("Zero rpc_timeout specified - test RPC never expire.\n" );memset (&sfw_data,0 ,sizeof (struct smoketest_framework ));
@@ -1727,8 +1721,7 @@ sfw_startup (void) rc =srpc_service_add_buffers (sv, sv->sv_wi_total);if (rc !=0 ) { -CWARN ("Failed to reserve enough buffers: " -"service %s, %d needed: %d\n" , +CWARN ("Failed to reserve enough buffers: service %s, %d needed: %d\n" , sv->sv_name, sv->sv_wi_total, rc); error = -ENOMEM ; }
drivers/staging/lustre/lnet/selftest/module.c +2 -2
@@ -119,8 +119,8 @@ lnet_selftest_init(void) rc =cfs_wi_sched_create ("lst_t" ,lnet_cpt_table (), i, nthrs, &lst_sched_test[i]);if (rc !=0 ) { -CERROR ("Failed to create CPT affinity WI scheduler " -"%d for LST\n" , i); +CERROR ("Failed to create CPT affinity WI scheduler %d for LST\n" , + i); goto error; } }
drivers/staging/lustre/lnet/selftest/rpc.c +12 -17
@@ -678,9 +678,7 @@ srpc_finish_service(struct srpc_service *sv) rpc =list_entry (scd->scd_rpc_active.next, struct srpc_server_rpc, srpc_list); - CNETERR("Active RPC %p on shutdown: sv %s, peer %s, " - "wi %s scheduled %d running %d, " - "ev fired %d type %d status %d lnet %d\n", + CNETERR("Active RPC %p on shutdown: sv %s, peer %s, wi %s scheduled %d running %d, ev fired %d type %d status %d lnet %d\n", rpc, sv->sv_name, libcfs_id2str(rpc->srpc_peer), swi_state2str(rpc->srpc_wi.swi_state), rpc->srpc_wi.swi_workitem.wi_scheduled,
@@ -1236,20 +1234,18 @@ srpc_send_rpc (swi_workitem_t *wi)if (reply->msg_type != type || (reply->msg_magic !=SRPC_MSG_MAGIC && reply->msg_magic !=__swab32 (SRPC_MSG_MAGIC ))) { -CWARN ("Bad message from %s: type %u (%d expected)," -" magic %u (%d expected).\n" , -libcfs_id2str (rpc->crpc_dest), - reply->msg_type, type, - reply->msg_magic,SRPC_MSG_MAGIC ); +CWARN ("Bad message from %s: type %u (%d expected), magic %u (%d expected).\n" , +libcfs_id2str (rpc->crpc_dest), + reply->msg_type, type, + reply->msg_magic,SRPC_MSG_MAGIC ); rc = -EBADMSG ;break ; }if (do_bulk && reply->msg_body.reply.status !=0 ) { -CWARN ("Remote error %d at %s, unlink bulk buffer in " -"case peer didn't initiate bulk transfer\n" , - reply->msg_body.reply.status, -libcfs_id2str (rpc->crpc_dest)); +CWARN ("Remote error %d at %s, unlink bulk buffer in case peer didn't initiate bulk transfer\n" , + reply->msg_body.reply.status, +libcfs_id2str (rpc->crpc_dest));LNetMDUnlink (rpc->crpc_bulk.bk_mdh); }
@@ -1504,11 +1500,10 @@ srpc_lnet_ev_handler(lnet_event_t *ev) msg->msg_type != __swab32(type)) || (msg->msg_magic != SRPC_MSG_MAGIC && msg->msg_magic != __swab32(SRPC_MSG_MAGIC))) { -CERROR ("Dropping RPC (%s) from %s: " -"status %d mlength %d type %u magic %u.\n" , - sv->sv_name,libcfs_id2str (ev->initiator), - ev->status, ev->mlength, - msg->msg_type, msg->msg_magic); +CERROR ("Dropping RPC (%s) from %s: status %d mlength %d type %u magic %u.\n" , + sv->sv_name,libcfs_id2str (ev->initiator), + ev->status, ev->mlength, + msg->msg_type, msg->msg_magic);/* NB can't call srpc_service_recycle_buffer here since * it may call LNetM[DE]Attach. The invalid magic tells
drivers/staging/lustre/lustre/include/linux/obd.h +1 -2
@@ -87,8 +87,7 @@ static inline void __client_obd_list_lock(client_obd_lock_t *lock,if (task ==NULL )continue ; - LCONSOLE_WARN("%s:%d: lock %p was acquired" - " by <%s:%d:%s:%d> for %lu seconds.\n", + LCONSOLE_WARN("%s:%d: lock %p was acquired by <%s:%d:%s:%d> for %lu seconds.\n", current->comm, current->pid, lock, task->comm, task->pid, lock->func, lock->line,
drivers/staging/lustre/lustre/include/lustre_disk.h +1 -2
@@ -368,8 +368,7 @@ static inline void check_lcd(char *obd_name, int index,if (strnlen ((char *)lcd->lcd_uuid, length) == length) { lcd->lcd_uuid[length -1 ] ='\0' ; -LCONSOLE_ERROR ("the client UUID (%s) on %s for exports" -"stored in last_rcvd(index = %d) is bad!\n" , +LCONSOLE_ERROR ("the client UUID (%s) on %s for exports stored in last_rcvd(index = %d) is bad!\n" , lcd->lcd_uuid, obd_name, index); } }
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c +1 -2
@@ -619,8 +619,7 @@ ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)return 0 ; } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"sleeping" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, sleeping" ); fwd.fwd_lock = lock; obd =class_exp2obd (lock->l_conn_export);
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c +2 -2
@@ -858,8 +858,8 @@ void ldlm_dump_export_locks(struct obd_export *exp)if (!list_empty (&exp->exp_locks_list)) {struct ldlm_lock *lock; -CERROR ("dumping locks for export %p," -"ignore if the unmount doesn't hang\n" , exp); +CERROR ("dumping locks for export %p,ignore if the unmount doesn't hang\n" , + exp);list_for_each_entry (lock, &exp->exp_locks_list, l_exp_refs_link)LDLM_ERROR (lock,"lock:" );
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +74 -94
222 lines not on this page · raw message
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +4 -7
@@ -210,9 +210,7 @@ static void ldlm_handle_cp_callback(struct ptlrpc_request *req,LASSERT (lock->l_lvb_data !=NULL );if (unlikely (lock->l_lvb_len < lvb_len)) { -LDLM_ERROR (lock,"Replied LVB is larger than " -"expectation, expected = %d, " -"replied = %d" , +LDLM_ERROR (lock,"Replied LVB is larger than expectation, expected = %d, replied = %d" , lock->l_lvb_len, lvb_len); rc = -EINVAL ; goto out;
@@ -639,8 +637,8 @@ static int ldlm_callback_handler(struct ptlrpc_request *req) lock =ldlm_handle2lock_long (&dlm_req->lock_handle[0 ],0 );if (!lock) { -CDEBUG (D_DLMTRACE ,"callback on lock %#llx - lock " -"disappeared\n" , dlm_req->lock_handle[0 ].cookie); +CDEBUG (D_DLMTRACE ,"callback on lock %#llx - lock disappeared\n" , + dlm_req->lock_handle[0 ].cookie); rc =ldlm_callback_reply (req, -EINVAL );ldlm_callback_errmsg (req,"Operate with invalid parameter" , rc, &dlm_req->lock_handle[0 ]);
@@ -663,8 +661,7 @@ static int ldlm_callback_handler(struct ptlrpc_request *req)if (((lock->l_flags &LDLM_FL_CANCELING ) && (lock->l_flags &LDLM_FL_BL_DONE )) || (lock->l_flags &LDLM_FL_FAILED )) { -LDLM_DEBUG (lock,"callback on lock " -"%#llx - lock disappeared\n" , +LDLM_DEBUG (lock,"callback on lock %#llx - lock disappeared\n" , dlm_req->lock_handle[0 ].cookie);unlock_res_and_lock (lock);LDLM_LOCK_RELEASE (lock);
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c +4 -6
@@ -614,8 +614,8 @@ int ldlm_pool_shrink(struct ldlm_pool *pl, int nr,lprocfs_counter_add (pl->pl_stats,LDLM_POOL_SHRINK_FREED_STAT , cancel); -CDEBUG (D_DLMTRACE ,"%s: request to shrink %d locks, " -"shrunk %d\n" , pl->pl_name, nr, cancel); +CDEBUG (D_DLMTRACE ,"%s: request to shrink %d locks, shrunk %d\n" , + pl->pl_name, nr, cancel); } }return cancel;
@@ -1194,10 +1194,8 @@ int ldlm_pools_recalc(ldlm_side_t client)* of limit. */ if (nr_l >=2 * (LDLM_POOL_HOST_L /3 )) { -CWARN ("\"Modest\" pools eat out 2/3 of server locks " -"limit (%d of %lu). This means that you have too " -"many clients for this amount of server RAM. " -"Upgrade server!\n" , nr_l,LDLM_POOL_HOST_L ); +CWARN ("\"Modest\" pools eat out 2/3 of server locks limit (%d of %lu). This means that you have too many clients for this amount of server RAM. Upgrade server!\n" , + nr_l,LDLM_POOL_HOST_L ); equal =1 ; }
drivers/staging/lustre/lustre/ldlm/ldlm_request.c +13 -24
@@ -102,9 +102,7 @@ int ldlm_expired_completion_wait(void *data) lock->l_last_activity,cfs_time_sub (get_seconds (), lock->l_last_activity)); -LDLM_DEBUG (lock,"lock timed out (enqueued at " CFS_TIME_T ", " -CFS_DURATION_T "s ago); not entering recovery in " -"server code, just going back to sleep" , +LDLM_DEBUG (lock,"lock timed out (enqueued at " CFS_TIME_T ", " CFS_DURATION_T "s ago); not entering recovery in server code, just going back to sleep" , lock->l_last_activity,cfs_time_sub (get_seconds (), lock->l_last_activity));
@@ -191,8 +189,7 @@ int ldlm_completion_ast_async(struct ldlm_lock *lock, __u64 flags, void *data)return ldlm_completion_tail (lock); } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"going forward" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, going forward" );ldlm_reprocess_all (lock->l_resource);return 0 ; }
@@ -240,8 +237,7 @@ int ldlm_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)return 0 ; } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"sleeping" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, sleeping" ); noreproc:
@@ -324,8 +320,7 @@ int ldlm_blocking_ast_nocheck(struct ldlm_lock *lock)if (rc <0 )CERROR ("ldlm_cli_cancel: %d\n" , rc); }else { -LDLM_DEBUG (lock,"Lock still has references, will be " -"cancelled later" ); +LDLM_DEBUG (lock,"Lock still has references, will be cancelled later" ); }return 0 ; }
@@ -483,8 +478,7 @@ static void failed_lock_cleanup(struct ldlm_namespace *ns,if (need_cancel)LDLM_DEBUG (lock, -"setting FL_LOCAL_ONLY | LDLM_FL_FAILED | " -"LDLM_FL_ATOMIC_CB | LDLM_FL_CBPENDING" ); +"setting FL_LOCAL_ONLY | LDLM_FL_FAILED | LDLM_FL_ATOMIC_CB | LDLM_FL_CBPENDING" );else LDLM_DEBUG (lock,"lock was granted or failed in race" );
@@ -557,8 +551,7 @@ int ldlm_cli_enqueue_fini(struct obd_export *exp, struct ptlrpc_request *req, rc = size; goto cleanup; }else if (unlikely (size > lvb_len)) { -LDLM_ERROR (lock,"Replied LVB is larger than " -"expectation, expected = %d, replied = %d" , +LDLM_ERROR (lock,"Replied LVB is larger than expectation, expected = %d, replied = %d" , lvb_len, size); rc = -EINVAL ; goto cleanup;
@@ -1107,8 +1100,7 @@ static __u64 ldlm_cli_cancel_local(struct ldlm_lock *lock)unlock_res_and_lock (lock);if (local_only) { -CDEBUG (D_DLMTRACE ,"not sending request (at caller's " -"instruction)\n" ); +CDEBUG (D_DLMTRACE ,"not sending request (at caller's instruction)\n" ); rc =LDLM_FL_LOCAL_ONLY ; }ldlm_lock_cancel (lock);
@@ -1223,8 +1215,7 @@ int ldlm_cli_cancel_req(struct obd_export *exp, struct list_head *cancels, rc =ptlrpc_queue_wait (req); }if (rc ==LUSTRE_ESTALE ) { -CDEBUG (D_DLMTRACE ,"client/server (nid %s) " -"out of sync -- not fatal\n" , +CDEBUG (D_DLMTRACE ,"client/server (nid %s) out of sync -- not fatal\n" ,libcfs_nid2str (req->rq_import-> imp_connection->c_peer.nid)); rc =0 ;
@@ -1235,8 +1226,8 @@ int ldlm_cli_cancel_req(struct obd_export *exp, struct list_head *cancels, }else if (rc !=ELDLM_OK ) {/* -ESHUTDOWN is common on umount */ CDEBUG_LIMIT (rc == -ESHUTDOWN ?D_DLMTRACE :D_ERROR , -"Got rc %d from cancel RPC: " -"canceling anyway\n" , rc); +"Got rc %d from cancel RPC: canceling anyway\n" , + rc);break ; } sent = count;
@@ -2114,8 +2105,7 @@ static int replay_lock_interpret(const struct lu_env *env, lock =ldlm_handle2lock (&aa->lock_handle);if (!lock) { -CERROR ("received replay ack for unknown local cookie %#llx" -" remote cookie %#llx from server %s id %s\n" , +CERROR ("received replay ack for unknown local cookie %#llx remote cookie %#llx from server %s id %s\n" , aa->lock_handle.cookie, reply->lock_handle.cookie, req->rq_export->exp_client_uuid.uuid,libcfs_id2str (req->rq_peer));
@@ -2243,9 +2233,8 @@ static void ldlm_cancel_unused_locks_for_replay(struct ldlm_namespace *ns)int canceled;LIST_HEAD (cancels); -CDEBUG (D_DLMTRACE ,"Dropping as many unused locks as possible before" -"replay for namespace %s (%d)\n" , -ldlm_ns_name (ns), ns->ns_nr_unused); +CDEBUG (D_DLMTRACE ,"Dropping as many unused locks as possible before replay for namespace %s (%d)\n" , +ldlm_ns_name (ns), ns->ns_nr_unused);/* We don't need to care whether or not LRU resize is enabled * because the LDLM_CANCEL_NO_WAIT policy doesn't use the
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c +8 -11
@@ -215,8 +215,8 @@ static ssize_t lprocfs_lru_size_seq_write(struct file *file, LDLM_CANCEL_PASSED);if (canceled < unused) {CDEBUG (D_DLMTRACE , -"not all requested locks are canceled, " -"requested: %d, canceled: %d\n" , unused, +"not all requested locks are canceled, requested: %d, canceled: %d\n" , + unused, canceled);return -EINVAL ; }
@@ -735,8 +735,7 @@ static void cleanup_resource(struct ldlm_resource *res, struct list_head *q, }else {ldlm_resource_unlink_lock (lock);unlock_res (res); -LDLM_DEBUG (lock,"Freeing a lock still held by a " -"client node" ); +LDLM_DEBUG (lock,"Freeing a lock still held by a client node" );ldlm_lock_destroy (lock); }LDLM_LOCK_RELEASE (lock);
@@ -818,16 +817,14 @@ force_wait:/* Forced cleanups should be able to reclaim all references, * so it's safe to wait forever... we can't leak locks... */ if (force && rc == -ETIMEDOUT ) { -LCONSOLE_ERROR ("Forced cleanup waiting for %s " -"namespace with %d resources in use, " -"(rc=%d)\n" ,ldlm_ns_name (ns), +LCONSOLE_ERROR ("Forced cleanup waiting for %s namespace with %d resources in use, (rc=%d)\n" , +ldlm_ns_name (ns),atomic_read (&ns->ns_bref), rc); goto force_wait; }if (atomic_read (&ns->ns_bref)) { -LCONSOLE_ERROR ("Cleanup waiting for %s namespace " -"with %d resources in use, (rc=%d)\n" , +LCONSOLE_ERROR ("Cleanup waiting for %s namespace with %d resources in use, (rc=%d)\n" ,ldlm_ns_name (ns),atomic_read (&ns->ns_bref), rc);return ELDLM_NAMESPACE_EXISTS ;
@@ -1404,8 +1401,8 @@ void ldlm_resource_dump(int level, struct ldlm_resource *res)LDLM_DEBUG_LIMIT (level, lock,"###" );if (!(level &D_CANTMASK ) && ++granted > ldlm_dump_granted_max) { -CDEBUG (level,"only dump %d granted locks to " -"avoid DDOS.\n" , granted); +CDEBUG (level,"only dump %d granted locks to avoid DDOS.\n" , + granted);break ; } }
drivers/staging/lustre/lustre/libcfs/debug.c +3 -5
@@ -318,9 +318,7 @@ libcfs_debug_str2mask(int *mask, const char *str, int is_subsys)if (t >=1 && matched == n) {/* don't print warning for lctl set_param debug=0 or -1 */ if (m !=0 && m !=-1 ) -CWARN ("You are trying to use a numerical value for the " -"mask - this will be deprecated in a future " -"release.\n" ); +CWARN ("You are trying to use a numerical value for the mask - this will be deprecated in a future release.\n" ); *mask = m;return 0 ; }
@@ -375,8 +373,8 @@ void libcfs_debug_dumplog(void) (void *)(long )current_pid (), "libcfs_debug_dumper");if (IS_ERR (dumper)) -pr_err ("LustreError: cannot start log dump thread:" -" %ld\n" ,PTR_ERR (dumper)); +pr_err ("LustreError: cannot start log dump thread: %ld\n" , +PTR_ERR (dumper));else schedule ();
drivers/staging/lustre/lustre/libcfs/hash.c +1 -2
@@ -1121,8 +1121,7 @@ cfs_hash_destroy(struct cfs_hash *hs)cfs_hash_bd_for_each_hlist (hs, &bd, hhead) {hlist_for_each_safe (hnode, pos, hhead) {LASSERTF (!cfs_hash_with_assert_empty (hs), -"hash %s bucket %u(%u) is not " -" empty: %u items left\n" , +"hash %s bucket %u(%u) is not empty: %u items left\n" , hs->hs_name, bd.bd_bucket->hsb_index, bd.bd_offset, bd.bd_bucket->hsb_count);/* can't assert key valicate, because we
drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c +12 -20
@@ -333,8 +333,8 @@ cfs_cpt_unset_cpu(struct cfs_cpt_table *cptab, int cpt, int cpu)/* caller doesn't know the partition ID */ cpt = cptab->ctb_cpu2cpt[cpu];if (cpt <0 ) {/* not set in this CPT-table */ -CDEBUG (D_INFO ,"Try to unset cpu %d which is " -"not in CPT-table %p\n" , cpt, cptab); +CDEBUG (D_INFO ,"Try to unset cpu %d which is not in CPT-table %p\n" , + cpt, cptab);return ; }
@@ -384,8 +384,8 @@ cfs_cpt_set_cpumask(struct cfs_cpt_table *cptab, int cpt, cpumask_t *mask)int i;if (cpus_weight (*mask) ==0 ||any_online_cpu (*mask) ==NR_CPUS ) { -CDEBUG (D_INFO ,"No online CPU is found in the CPU mask " -"for CPU partition %d\n" , cpt); +CDEBUG (D_INFO ,"No online CPU is found in the CPU mask for CPU partition %d\n" , + cpt);return 0 ; }
@@ -579,9 +579,8 @@ cfs_cpt_bind(struct cfs_cpt_table *cptab, int cpt) }if (any_online_cpu (*cpumask) ==NR_CPUS ) { -CERROR ("No online CPU found in CPU partition %d, did someone " -"do CPU hotplug on system? You might need to reload " -"Lustre modules to keep system working well.\n" , cpt); +CERROR ("No online CPU found in CPU partition %d, did someone do CPU hotplug on system? You might need to reload Lustre modules to keep system working well.\n" , + cpt);return -EINVAL ; }
@@ -737,16 +736,12 @@ cfs_cpt_table_create(int ncpt) ncpt = rc;if (ncpt >num_online_cpus () || ncpt >4 * rc) { -CWARN ("CPU partition number %d is larger than suggested " -"value (%d), your system may have performance" -"issue or run out of memory while under pressure\n" , +CWARN ("CPU partition number %d is larger than suggested value (%d), your system may have performance issue or run out of memory while under pressure\n" , ncpt, rc); }if (num_online_cpus () % ncpt !=0 ) { -CERROR ("CPU number %d is not multiple of cpu_npartition %d, " -"please try different cpu_npartitions value or" -"set pattern string by cpu_pattern=STRING\n" , +CERROR ("CPU number %d is not multiple of cpu_npartition %d, please try different cpu_npartitions value or set pattern string by cpu_pattern=STRING\n" , (int )num_online_cpus (), ncpt); goto failed; }
@@ -796,8 +791,7 @@ cfs_cpt_table_create(int ncpt)if (cpt != ncpt || num !=cpus_weight (*cptab->ctb_parts[ncpt -1 ].cpt_cpumask)) { -CERROR ("Expect %d(%d) CPU partitions but got %d(%d), " -"CPU hotplug/unplug while setting?\n" , +CERROR ("Expect %d(%d) CPU partitions but got %d(%d), CPU hotplug/unplug while setting?\n" , cptab->ctb_nparts, num, cpt,cpus_weight (*cptab->ctb_parts[ncpt -1 ].cpt_cpumask)); goto failed;
@@ -808,8 +802,7 @@ cfs_cpt_table_create(int ncpt)return cptab; failed: -CERROR ("Failed to setup CPU-partition-table with %d " -"CPU-partitions, online HW nodes: %d, HW cpus: %d.\n" , +CERROR ("Failed to setup CPU-partition-table with %d CPU-partitions, online HW nodes: %d, HW cpus: %d.\n" , ncpt,num_online_nodes (),num_online_cpus ());if (mask !=NULL )
@@ -975,9 +968,8 @@ cfs_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu) warn =any_online_cpu (*cpt_data.cpt_cpumask) >= nr_cpu_ids;mutex_unlock (&cpt_data.cpt_mutex);CDEBUG (warn ?D_WARNING :D_INFO , -"Lustre: can't support CPU plug-out well now, " -"performance and stability could be impacted " -"[CPU %u action: %lx]\n" , cpu, action); +"Lustre: can't support CPU plug-out well now, performance and stability could be impacted [CPU %u action: %lx]\n" , + cpu, action); }return NOTIFY_OK ;
drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c +1 -2
@@ -279,8 +279,7 @@ libcfs_sock_write (struct socket *sock, void *buffer, int nob, int timeout) rc =kernel_setsockopt (sock,SOL_SOCKET ,SO_SNDTIMEO , (char *)&tv,sizeof (tv));if (rc !=0 ) { -CERROR ("Can't set socket send timeout " -"%ld.%06d: %d\n" , +CERROR ("Can't set socket send timeout %ld.%06d: %d\n" , (long )tv.tv_sec, (int )tv.tv_usec, rc);return rc; }
drivers/staging/lustre/lustre/libcfs/tracefile.c +17 -18
@@ -357,8 +357,8 @@ int libcfs_debug_vmsg2(struct libcfs_debug_msg_data *msgdata, }if (*(string_buf+needed-1 ) !='\n' ) -printk (KERN_INFO "format at %s:%d:%s doesn't end in " -"newline\n" , file, msgdata->msg_line, msgdata->msg_fn); +printk (KERN_INFO "format at %s:%d:%s doesn't end in newline\n" , + file, msgdata->msg_line, msgdata->msg_fn); header.ph_len = known_size + needed; debug_buf = (char *)page_address (tage->page) + tage->used;
@@ -715,8 +715,8 @@ int cfs_tracefile_dump_all_pages(char *filename)kunmap (tage->page);if (rc != (int )tage->used) { -printk (KERN_WARNING "wanted to write %u but wrote " -"%d\n" , tage->used, rc); +printk (KERN_WARNING "wanted to write %u but wrote %d\n" , + tage->used, rc);put_pages_back (&pc);__LASSERT (list_empty (&pc.pc_pages));break ;
@@ -875,8 +875,8 @@ int cfs_trace_daemon_command(char *str)strcpy (cfs_tracefile, str);printk (KERN_INFO -"Lustre: debug daemon will attempt to start writing " -"to %s (%lukB max)\n" , cfs_tracefile, +"Lustre: debug daemon will attempt to start writing to %s (%lukB max)\n" , + cfs_tracefile, (long )(cfs_tracefile_size >>10 ));cfs_trace_start_thread ();
@@ -914,15 +914,15 @@ int cfs_trace_set_debug_mb(int mb)if (mb <num_possible_cpus ()) {printk (KERN_WARNING -"Lustre: %d MB is too small for debug buffer size, " -"setting it to %d MB.\n" , mb,num_possible_cpus ()); +"Lustre: %d MB is too small for debug buffer size, setting it to %d MB.\n" , + mb,num_possible_cpus ()); mb =num_possible_cpus (); }if (mb > limit) {printk (KERN_WARNING -"Lustre: %d MB is too large for debug buffer size, " -"setting it to %d MB.\n" , mb, limit); +"Lustre: %d MB is too large for debug buffer size, setting it to %d MB.\n" , + mb, limit); mb = limit; }
@@ -1004,8 +1004,8 @@ static int tracefiled(void *arg)if (IS_ERR (filp)) { rc =PTR_ERR (filp); filp =NULL ; -printk (KERN_WARNING "couldn't open %s: " -"%d\n" , cfs_tracefile, rc); +printk (KERN_WARNING "couldn't open %s: %d\n" , + cfs_tracefile, rc); } }cfs_tracefile_read_unlock ();
@@ -1034,8 +1034,8 @@ static int tracefiled(void *arg)kunmap (tage->page);if (rc != (int )tage->used) { -printk (KERN_WARNING "wanted to write %u " -"but wrote %d\n" , tage->used, rc); +printk (KERN_WARNING "wanted to write %u but wrote %d\n" , + tage->used, rc);put_pages_back (&pc);__LASSERT (list_empty (&pc.pc_pages)); }
@@ -1047,8 +1047,7 @@ static int tracefiled(void *arg)if (!list_empty (&pc.pc_pages)) {int i; -printk (KERN_ALERT "Lustre: trace pages aren't " -" empty\n" ); +printk (KERN_ALERT "Lustre: trace pages aren't empty\n" );printk (KERN_ERR "total cpus(%d): " ,num_possible_cpus ());for (i =0 ; i <num_possible_cpus (); i++)
@@ -1061,8 +1060,8 @@ static int tracefiled(void *arg) i =0 ;list_for_each_entry_safe (tage, tmp, &pc.pc_pages, linkage) -printk (KERN_ERR "page %d belongs to cpu " -"%d\n" , ++i, tage->cpu); +printk (KERN_ERR "page %d belongs to cpu %d\n" , + ++i, tage->cpu);printk (KERN_ERR "There are %d pages unwritten\n" , i); }
drivers/staging/lustre/lustre/llite/dcache.c +2 -2
@@ -259,8 +259,8 @@ void ll_invalidate_aliases(struct inode *inode)ll_lock_dcache (inode);ll_d_hlist_for_each_entry (dentry, p, &inode->i_dentry, d_u.d_alias) { -CDEBUG (D_DENTRY ,"dentry in drop %pd (%p) parent %p " -"inode %p flags %d\n" , dentry, dentry, dentry->d_parent, +CDEBUG (D_DENTRY ,"dentry in drop %pd (%p) parent %p inode %p flags %d\n" , + dentry, dentry, dentry->d_parent, dentry->d_inode, dentry->d_flags);if (unlikely (dentry == dentry->d_sb->s_root)) {
drivers/staging/lustre/lustre/llite/dir.c +11 -14
@@ -228,8 +228,8 @@ static int ll_dir_filler(void *_hash, struct page *page0)if (ll_pagevec_add (&lru_pvec, page) ==0 )ll_pagevec_lru_add_file (&lru_pvec); }else { -CDEBUG (D_VFSTRACE ,"page %lu add to page cache failed:" -" %d\n" , offset, ret); +CDEBUG (D_VFSTRACE ,"page %lu add to page cache failed: %d\n" , + offset, ret); }page_cache_release (page); }
@@ -600,8 +600,8 @@ static int ll_readdir(struct file *filp, struct dir_context *ctx)int api32 =ll_need_32bit_api (sbi);int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:inode=%lu/%u(%p) pos %lu/%llu " -" 32bit_api %d\n" , inode->i_ino, inode->i_generation, +CDEBUG (D_VFSTRACE ,"VFS Op:inode=%lu/%u(%p) pos %lu/%llu 32bit_api %d\n" , + inode->i_ino, inode->i_generation, inode, (unsigned long )lfd->lfd_pos,i_size_read (inode), api32);if (lfd->lfd_pos ==MDS_DIR_END_OFF ) {
@@ -715,10 +715,9 @@ int ll_dir_setstripe(struct inode *inode, struct lov_user_md *lump,break ; }default : { -CDEBUG (D_IOCTL ,"bad userland LOV MAGIC:" -" %#08x != %#08x nor %#08x\n" , - lump->lmm_magic,LOV_USER_MAGIC_V1 , -LOV_USER_MAGIC_V3 ); +CDEBUG (D_IOCTL ,"bad userland LOV MAGIC: %#08x != %#08x nor %#08x\n" , + lump->lmm_magic,LOV_USER_MAGIC_V1 , +LOV_USER_MAGIC_V3 );return -EINVAL ; } }
@@ -814,8 +813,8 @@ int ll_dir_getstripe(struct inode *inode, struct lov_mds_md **lmmp, rc =md_getattr (sbi->ll_md_exp, op_data, &req);ll_finish_md_op_data (op_data);if (rc <0 ) { -CDEBUG (D_INFO ,"md_getattr failed on inode " -"%lu/%u: rc %d\n" , inode->i_ino, +CDEBUG (D_INFO ,"md_getattr failed on inode %lu/%u: rc %d\n" , + inode->i_ino, inode->i_generation, rc); goto out; }
@@ -1013,8 +1012,7 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy) copy->hc_hai.hai_action == HSMA_ARCHIVE);iput (inode);if (rc) { -CDEBUG (D_HSM ,"Could not read file data version. " -"Request could not be confirmed.\n" ); +CDEBUG (D_HSM ,"Could not read file data version. Request could not be confirmed.\n" );if (hpk.hpk_errval ==0 ) hpk.hpk_errval = -rc; goto progress;
@@ -1028,8 +1026,7 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy)* to check anyway. */ if ((copy->hc_hai.hai_action ==HSMA_ARCHIVE ) && (copy->hc_data_version != data_version)) { -CDEBUG (D_HSM ,"File data version mismatched. " -"File content was changed during archiving. " +CDEBUG (D_HSM ,"File data version mismatched. File content was changed during archiving. " DFID ", start:%#llx current:%#llx\n" ,PFID (©->hc_hai.hai_fid), copy->hc_data_version, data_version);
drivers/staging/lustre/lustre/llite/file.c +8 -8
@@ -170,8 +170,8 @@ static int ll_close_inode_openhandle(struct obd_export *md_exp,* OSTs and send setattr to back to MDS. */ rc =ll_som_update (inode, op_data);if (rc) { -CERROR ("inode %lu mdc Size-on-MDS update failed: " -"rc = %d\n" , inode->i_ino, rc); +CERROR ("inode %lu mdc Size-on-MDS update failed: rc = %d\n" , + inode->i_ino, rc); rc =0 ; } }else if (rc) {
@@ -976,8 +976,8 @@ int ll_inode_getattr(struct inode *inode, struct obdo *obdo,struct ost_id *oi = lsm ? &lsm->lsm_oi : &obdo->o_oi;obdo_refresh_inode (inode, obdo, obdo->o_valid); -CDEBUG (D_INODE ,"objid " DOSTID " size %llu, blocks %llu," -" blksize %lu\n" ,POSTID (oi),i_size_read (inode), +CDEBUG (D_INODE ,"objid " DOSTID " size %llu, blocks %llu, blksize %lu\n" , +POSTID (oi),i_size_read (inode), (unsigned long long )inode->i_blocks,1UL << inode->i_blkbits); }
@@ -1404,8 +1404,8 @@ int ll_lov_getstripe_ea_info(struct inode *inode, const char *filename, rc =md_getattr_name (sbi->ll_md_exp, op_data, &req);ll_finish_md_op_data (op_data);if (rc <0 ) { -CDEBUG (D_INFO ,"md_getattr_name failed " -"on %s: rc %d\n" , filename, rc); +CDEBUG (D_INFO ,"md_getattr_name failed on %s: rc %d\n" , + filename, rc); goto out; }
@@ -2222,8 +2222,8 @@ ll_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg)if (cmd ==LL_IOC_SETFLAGS ) {if ((flags &LL_FILE_IGNORE_LOCK ) && !(file->f_flags &O_DIRECT )) { -CERROR ("%s: unable to disable locking on " -"non-O_DIRECT file\n" , current->comm); +CERROR ("%s: unable to disable locking on non-O_DIRECT file\n" , + current->comm);return -EINVAL ; }
drivers/staging/lustre/lustre/llite/llite_capa.c +1 -2
@@ -540,8 +540,7 @@ static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa)if (rc == -EIO && !capa_is_expired (ocapa)) {delay_capa_renew (ocapa,120 );DEBUG_CAPA (D_ERROR , &ocapa->c_capa, -"renewal failed: -EIO, " -"retry in 2 mins" ); +"renewal failed: -EIO, retry in 2 mins" ); ll_capa_renewal_retries++; goto retry; }else {
drivers/staging/lustre/lustre/llite/llite_close.c +7 -9
@@ -90,8 +90,7 @@ void ll_queue_done_writing(struct inode *inode, unsigned long flags)struct ll_close_queue *lcq =ll_i2sbi (inode)->ll_lcq;if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CWARN ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , +CWARN ("ino %lu/%u(flags %u) som valid it just after recovery\n" , inode->i_ino, inode->i_generation, lli->lli_flags);/* DONE_WRITING is allowed and inode has no dirty page. */
@@ -124,8 +123,8 @@ void ll_done_writing_attr(struct inode *inode, struct md_op_data *op_data) op_data->op_flags |=MF_SOM_CHANGE ;/* Check if Size-on-MDS attributes are valid. */ if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CERROR ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , inode->i_ino, inode->i_generation, +CERROR ("ino %lu/%u(flags %u) som valid it just after recovery\n" , + inode->i_ino, inode->i_generation, lli->lli_flags);if (!cl_local_size (inode)) {
@@ -218,8 +217,8 @@ int ll_som_update(struct inode *inode, struct md_op_data *op_data)LASSERT (op_data !=NULL );if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CERROR ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , inode->i_ino, inode->i_generation, +CERROR ("ino %lu/%u(flags %u) som valid it just after recovery\n" , + inode->i_ino, inode->i_generation, lli->lli_flags);OBDO_ALLOC (oa);
@@ -238,9 +237,8 @@ int ll_som_update(struct inode *inode, struct md_op_data *op_data)if (rc) { oa->o_valid =0 ;if (rc != -ENOENT ) -CERROR ("inode_getattr failed (%d): unable to " -"send a Size-on-MDS attribute update " -"for inode %lu/%u\n" , rc, inode->i_ino, +CERROR ("inode_getattr failed (%d): unable to send a Size-on-MDS attribute update for inode %lu/%u\n" , + rc, inode->i_ino, inode->i_generation); }else { CDEBUG(D_INODE, "Size-on-MDS update on "DFID"\n",
drivers/staging/lustre/lustre/llite/llite_internal.h +6 -6
@@ -1435,8 +1435,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode,* case the dcache being cleared */ if (it->d.lustre.it_remote_lock_mode) { handle.cookie = it->d.lustre.it_remote_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode %p" -"(%lu/%u) for remote lock %#llx\n" , inode, +CDEBUG (D_DLMTRACE ,"setting l_data to inode %p(%lu/%u) for remote lock %#llx\n" , + inode, inode->i_ino, inode->i_generation, handle.cookie);md_set_lock_data (exp, &handle.cookie, inode,NULL );
@@ -1444,8 +1444,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode, handle.cookie = it->d.lustre.it_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode %p (%lu/%u)" -" for lock %#llx\n" , inode, inode->i_ino, +CDEBUG (D_DLMTRACE ,"setting l_data to inode %p (%lu/%u) for lock %#llx\n" , + inode, inode->i_ino, inode->i_generation, handle.cookie); md_set_lock_data(exp, &handle.cookie, inode,
@@ -1489,8 +1489,8 @@ static inline void __d_lustre_invalidate(struct dentry *dentry)*/ static inline void d_lustre_invalidate (struct dentry *dentry,int nested) { -CDEBUG (D_DENTRY ,"invalidate dentry %pd (%p) parent %p inode %p " -"refc %d\n" , dentry, dentry, +CDEBUG (D_DENTRY ,"invalidate dentry %pd (%p) parent %p inode %p refc %d\n" , + dentry, dentry, dentry->d_parent, dentry->d_inode,d_count (dentry)); spin_lock_nested(&dentry->d_lock,
drivers/staging/lustre/lustre/llite/llite_lib.c +22 -36
142 lines not on this page · raw message
drivers/staging/lustre/lustre/llite/llite_mmap.c +3 -6
@@ -234,8 +234,7 @@ static int ll_page_mkwrite0(struct vm_area_struct *vma, struct page *vmpage,*/ unlock_page (vmpage); -CDEBUG (D_MMAP ,"Race on page_mkwrite %p/%lu, page has " -"been written out, retry.\n" , +CDEBUG (D_MMAP ,"Race on page_mkwrite %p/%lu, page has been written out, retry.\n" , vmpage, vmpage->index); *retry = true;
@@ -366,8 +365,7 @@ restart: vmf->page =NULL ;if (!printed && ++count >16 ) { -CWARN ("the page is under heavy contention," -"maybe your app(%s) needs revising :-)\n" , +CWARN ("the page is under heavy contention, maybe your app(%s) needs revising :-)\n" , current->comm); printed = true; }
@@ -393,8 +391,7 @@ static int ll_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) result =ll_page_mkwrite0 (vma, vmf->page, &retry);if (!printed && ++count >16 ) { -CWARN ("app(%s): the page %lu of file %lu is under heavy" -" contention.\n" , +CWARN ("app(%s): the page %lu of file %lu is under heavy contention.\n" , current->comm, vmf->pgoff,file_inode (vma->vm_file)->i_ino); printed = true;
drivers/staging/lustre/lustre/llite/llite_rmtacl.c +3 -4
@@ -131,8 +131,8 @@ int rct_add(struct rmtacl_ctl_table *rct, pid_t key, int ops)spin_lock (&rct->rct_lock); e =__rct_search (rct, key);if (unlikely (e !=NULL )) { -CWARN ("Unexpected stale rmtacl_entry found: " -"[key: %d] [ops: %d]\n" , (int )key, ops); +CWARN ("Unexpected stale rmtacl_entry found: [key: %d] [ops: %d]\n" , + (int )key, ops);rce_free (e); }list_add_tail (&rce->rce_list, &rct->rct_entries[rce_hashfunc (key)]);
@@ -263,8 +263,7 @@ int ee_add(struct eacl_table *et, pid_t key, struct lu_fid *fid, int type,spin_lock (&et->et_lock); e =__et_search_del (et, key, fid, type);if (unlikely (e !=NULL )) { -CWARN ("Unexpected stale eacl_entry found: " -"[key: %d] [fid: " DFID "] [type: %d]\n" , +CWARN ("Unexpected stale eacl_entry found: [key: %d] [fid: " DFID "] [type: %d]\n" , (int )key,PFID (fid), type);ee_free (e); }
drivers/staging/lustre/lustre/llite/lloop.c +2 -2
@@ -777,8 +777,8 @@ static int __init lloop_init(void)if (max_loop <1 || max_loop >256 ) { max_loop =MAX_LOOP_DEFAULT ; -CWARN ("lloop: invalid max_loop (must be between" -" 1 and 256), using default (%u)\n" , max_loop); +CWARN ("lloop: invalid max_loop (must be between 1 and 256), using default (%u)\n" , + max_loop); } lloop_major =register_blkdev (0 ,"lloop" );
drivers/staging/lustre/lustre/llite/lproc_llite.c +12 -17
@@ -284,8 +284,7 @@ static ssize_t ll_max_readahead_per_file_mb_seq_write(struct file *file,if (pages_number <0 || pages_number > sbi->ll_ra_info.ra_max_pages) { -CERROR ("can't set file readahead more than" -"max_read_ahead_mb %lu MB\n" , +CERROR ("can't set file readahead more thanmax_read_ahead_mb %lu MB\n" , sbi->ll_ra_info.ra_max_pages);return -ERANGE ; }
@@ -330,9 +329,8 @@ static ssize_t ll_max_read_ahead_whole_mb_seq_write(struct file *file,* algorithm does this anyway so it's pointless to set it larger. */ if (pages_number <0 || pages_number > sbi->ll_ra_info.ra_max_pages_per_file) { -CERROR ("can't set max_read_ahead_whole_mb more than " -"max_read_ahead_per_file_mb: %lu\n" , - sbi->ll_ra_info.ra_max_pages_per_file >> (20 -PAGE_CACHE_SHIFT )); +CERROR ("can't set max_read_ahead_whole_mb more than max_read_ahead_per_file_mb: %lu\n" , + sbi->ll_ra_info.ra_max_pages_per_file >> (20 -PAGE_CACHE_SHIFT ));return -ERANGE ; }
@@ -619,8 +617,8 @@ static ssize_t ll_statahead_max_seq_write(struct file *file,if (val >=0 && val <=LL_SA_RPC_MAX ) sbi->ll_sa_max = val;else -CERROR ("Bad statahead_max value %d. Valid values are in the " -"range [0, %d]\n" , val,LL_SA_RPC_MAX ); +CERROR ("Bad statahead_max value %d. Valid values are in the range [0, %d]\n" , + val,LL_SA_RPC_MAX );return count; }
@@ -770,8 +768,8 @@ static int ll_sbi_flags_seq_show(struct seq_file *m, void *v)while (flags !=0 ) {if (ARRAY_SIZE (str) <= i) { -CERROR ("%s: Revise array LL_SBI_FLAGS to match sbi " -"flags please.\n" ,ll_get_fsname (sb,NULL ,0 )); +CERROR ("%s: Revise array LL_SBI_FLAGS to match sbi flags please.\n" , +ll_get_fsname (sb,NULL ,0 ));return -EINVAL ; }
@@ -1143,8 +1141,8 @@ static void ll_display_extents_info(struct ll_rw_extents_info *io_extents, read_cum += r; write_cum += w; end =1 << (i +LL_HIST_START - units); -seq_printf (seq,"%4lu%c - %4lu%c%c: %14lu %4lu %4lu | " -"%14lu %4lu %4lu\n" , start, *unitp, end, *unitp, +seq_printf (seq,"%4lu%c - %4lu%c%c: %14lu %4lu %4lu | %14lu %4lu %4lu\n" , + start, *unitp, end, *unitp, (i ==LL_HIST_MAX -1 ) ?'+' :' ' , r,pct (r, read_tot),pct (read_cum, read_tot), w,pct (w, write_tot),pct (write_cum, write_tot));
@@ -1170,8 +1168,7 @@ static int ll_rw_extents_stats_pp_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; } seq_printf(seq, "snapshot_time: %lu.%lu (secs.usecs)\n",
@@ -1249,8 +1246,7 @@ static int ll_rw_extents_stats_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; } seq_printf(seq, "snapshot_time: %lu.%lu (secs.usecs)\n",
@@ -1428,8 +1424,7 @@ static int ll_rw_offset_stats_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; }spin_lock (&sbi->ll_process_lock);
drivers/staging/lustre/lustre/llite/namei.c +6 -8
@@ -83,8 +83,8 @@ static int ll_set_inode(struct inode *inode, void *opaque) lli->lli_fid = body->fid1;if (unlikely (!(body->valid &OBD_MD_FLTYPE ))) { -CERROR ("Can not initialize inode " DFID " without object type: " -"valid = %#llx\n" ,PFID (&lli->lli_fid), body->valid); +CERROR ("Can not initialize inode " DFID " without object type: valid = %#llx\n" , +PFID (&lli->lli_fid), body->valid);return -EINVAL ; }
@@ -598,8 +598,7 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry,long long lookup_flags =LOOKUP_OPEN ;int rc =0 ; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd,dir=%lu/%u(%p),file %p," -"open_flags %x,mode %x opened %d\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x opened %d\n" , dentry, dir->i_ino, dir->i_generation, dir, file, open_flags, mode, *opened);
@@ -843,8 +842,7 @@ static int ll_create_nd(struct inode *dir, struct dentry *dentry, {int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd,dir=%lu/%u(%p)," -"flags=%u, excl=%d\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:name=%pd,dir=%lu/%u(%p),flags=%u, excl=%d\n" , dentry, dir->i_ino, dir->i_generation, dir, mode, want_excl);
@@ -1111,8 +1109,8 @@ static int ll_rename(struct inode *old_dir, struct dentry *old_dentry,int err;CDEBUG (D_VFSTRACE , -"VFS Op:oldname=%pd,src_dir=%lu/%u(%p),newname=%pd," -"tgt_dir=%lu/%u(%p)\n" , old_dentry, +"VFS Op:oldname=%pd,src_dir=%lu/%u(%p),newname=%pd,tgt_dir=%lu/%u(%p)\n" , + old_dentry, old_dir->i_ino, old_dir->i_generation, old_dir, new_dentry, new_dir->i_ino, new_dir->i_generation, new_dir);
drivers/staging/lustre/lustre/llite/rw.c +10 -10
@@ -121,8 +121,8 @@ static struct ll_cl_context *ll_cl_init(struct file *file,/* this is too bad. Someone is trying to write the * page w/o holding inode mutex. This means we can * add dirty pages into cache during truncate */ -CERROR ("Proc %s is dirting page w/o inode lock, this" -"will break truncate.\n" , current->comm); +CERROR ("Proc %s is dirtying page w/o inode lock, this will break truncate.\n" , + current->comm);dump_stack ();LBUG ();return ERR_PTR (-EIO );
@@ -606,8 +606,8 @@ stride_pg_count(pgoff_t st_off, unsigned long st_len, unsigned long st_pgs,else pg_count = start_left + st_pgs * (end - start -1 ) + end_left; -CDEBUG (D_READA ,"st_off %lu, st_len %lu st_pgs %lu off %lu length %lu" -"pgcount %lu\n" , st_off, st_len, st_pgs, off, length, pg_count); +CDEBUG (D_READA ,"st_off %lu, st_len %lu st_pgs %lu off %lu length %lupgcount %lu\n" , + st_off, st_len, st_pgs, off, length, pg_count);return pg_count; }
@@ -667,10 +667,10 @@ static int ll_read_ahead_pages(const struct lu_env *env,/* FIXME: This assertion only is valid when it is for * forward read-ahead, it will be fixed when backward * read-ahead is implemented */ -LASSERTF (page_idx > ria->ria_stoff,"Invalid page_idx %lu" -"rs %lu re %lu ro %lu rl %lu rp %lu\n" , page_idx, - ria->ria_start, ria->ria_end, ria->ria_stoff, - ria->ria_length, ria->ria_pages); +LASSERTF (page_idx > ria->ria_stoff,"Invalid page_idx %lu rs %lu re %lu ro %lu rl %lu rp %lu\n" , + page_idx, + ria->ria_start, ria->ria_end, ria->ria_stoff, + ria->ria_length, ria->ria_pages); offset = page_idx - ria->ria_stoff; offset = offset % (ria->ria_length);if (offset > ria->ria_pages) {
@@ -927,8 +927,8 @@ static void ras_stride_increase_window(struct ll_readahead_state *ras,LASSERT (ras->ras_stride_length >0 );LASSERTF (ras->ras_window_start + ras->ras_window_len - >= ras->ras_stride_offset,"window_start %lu, window_len %lu" -" stride_offset %lu\n" , ras->ras_window_start, + >= ras->ras_stride_offset,"window_start %lu, window_len %lu stride_offset %lu\n" , + ras->ras_window_start, ras->ras_window_len, ras->ras_stride_offset); stride_len = ras->ras_window_start + ras->ras_window_len -
drivers/staging/lustre/lustre/llite/statahead.c +8 -13
@@ -1491,10 +1491,7 @@ ll_sai_unplug(struct ll_statahead_info *sai, struct ll_sa_entry *entry) sai->sai_consecutive_miss++;if (sa_low_hit (sai) &&thread_is_running (thread)) {atomic_inc (&sbi->ll_sa_wrong); -CDEBUG (D_READA ,"Statahead for dir " DFID " hit " -"ratio too low: hit/miss %llu/%llu" -", sent/replied %llu/%llu, stopping " -"statahead thread\n" , +CDEBUG (D_READA ,"Statahead for dir " DFID " hit ratio too low: hit/miss %llu/%llu, sent/replied %llu/%llu, stopping statahead thread\n" ,PFID (&lli->lli_fid), sai->sai_hit, sai->sai_miss, sai->sai_sent, sai->sai_replied);
@@ -1612,13 +1609,12 @@ int do_statahead_enter(struct inode *dir, struct dentry **dentryp, }else if ((*dentryp)->d_inode != inode) {/* revalidate, but inode is recreated */ CDEBUG (D_READA , -"stale dentry %pd inode %lu/%u, " -"statahead inode %lu/%u\n" , - *dentryp, - (*dentryp)->d_inode->i_ino, - (*dentryp)->d_inode->i_generation, - inode->i_ino, - inode->i_generation); +"stale dentry %pd inode %lu/%u, statahead inode %lu/%u\n" , + *dentryp, + (*dentryp)->d_inode->i_ino, + (*dentryp)->d_inode->i_generation, + inode->i_ino, + inode->i_generation);ll_sai_unplug (sai, entry);return -ESTALE ; }else {
@@ -1665,8 +1661,7 @@ int do_statahead_enter(struct inode *dir, struct dentry **dentryp,if (unlikely (sai->sai_inode != parent->d_inode)) {struct ll_inode_info *nlli =ll_i2info (parent->d_inode); -CWARN ("Race condition, someone changed %pd just now: " -"old parent " DFID ", new parent " DFID "\n" , +CWARN ("Race condition, someone changed %pd just now: old parent " DFID ", new parent " DFID "\n" , *dentryp,PFID (&lli->lli_fid),PFID (&nlli->lli_fid));dput (parent);
drivers/staging/lustre/lustre/llite/symlink.c +2 -2
@@ -100,8 +100,8 @@ static int ll_readlink_internal(struct inode *inode,if (*symname ==NULL ||strnlen (*symname, symlen) != symlen -1 ) {/* not full/NULL terminated */ -CERROR ("inode %lu: symlink not NULL terminated string" -"of length %d\n" , inode->i_ino, symlen -1 ); +CERROR ("inode %lu: symlink not NULL terminated string of length %d\n" , + inode->i_ino, symlen -1 ); rc = -EPROTO ; goto failed; }
drivers/staging/lustre/lustre/llite/vvp_io.c +2 -3
@@ -720,9 +720,8 @@ static int vvp_io_fault_start(const struct lu_env *env, last_index =cl_index (obj, size -1 );if (last_index < fio->ft_index) {CDEBUG (D_PAGE , -"llite: mkwrite and truncate race happened: " -"%p: 0x%lx 0x%lx\n" , - vmpage->mapping, fio->ft_index, last_index); +"llite: mkwrite and truncate race happened: %p: 0x%lx 0x%lx\n" , + vmpage->mapping, fio->ft_index, last_index);/* * We need to return if we are * passed the end of the file. This will propagate
drivers/staging/lustre/lustre/llite/vvp_page.c +1 -2
@@ -376,8 +376,7 @@ static int vvp_page_print(const struct lu_env *env,struct ccc_page *vp =cl2ccc_page (slice);struct page *vmpage = vp->cpg_page; - (*printer)(env, cookie,LUSTRE_VVP_NAME "-page@%p(%d:%d:%d) " -"vm@%p " , + (*printer)(env, cookie,LUSTRE_VVP_NAME "-page@%p(%d:%d:%d) vm@%p " , vp, vp->cpg_defer_uptodate, vp->cpg_ra_used, vp->cpg_write_queued, vmpage);if (vmpage !=NULL ) {
drivers/staging/lustre/lustre/llite/xattr.c +1 -2
@@ -201,8 +201,7 @@ int ll_setxattr_common(struct inode *inode, const char *name,#endif if (rc) {if (rc == -EOPNOTSUPP && xattr_type ==XATTR_USER_T ) { -LCONSOLE_INFO ("Disabling user_xattr feature because " -"it is not supported on the server\n" ); +LCONSOLE_INFO ("Disabling user_xattr feature because it is not supported on the server\n" ); sbi->ll_flags &= ~LL_SBI_USER_XATTR ; }return rc;
drivers/staging/lustre/lustre/lmv/lmv_fld.c +1 -2
@@ -75,8 +75,7 @@ int lmv_fld_lookup(struct lmv_obd *lmv, *mds, PFID(fid));if (*mds >= lmv->desc.ld_tgt_count) { -CERROR ("FLD lookup got invalid mds #%x (max: %x) " -"for fid=" DFID "\n" , *mds, lmv->desc.ld_tgt_count, +CERROR ("FLD lookup got invalid mds #%x (max: %x) for fid=" DFID "\n" , *mds, lmv->desc.ld_tgt_count,PFID (fid)); rc = -EINVAL ; }
drivers/staging/lustre/lustre/lmv/lmv_intent.c +4 -4
@@ -186,8 +186,8 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,return rc; } -CDEBUG (D_INODE ,"OPEN_INTENT with fid1=" DFID ", fid2=" DFID "," -" name='%s' -> mds #%d\n" ,PFID (&op_data->op_fid1), +CDEBUG (D_INODE ,"OPEN_INTENT with fid1=" DFID ", fid2=" DFID ", name='%s' -> mds #%d\n" , +PFID (&op_data->op_fid1),PFID (&op_data->op_fid2), op_data->op_name, tgt->ltd_idx); rc = md_intent_lock(tgt->ltd_exp, op_data, lmm, lmmsize, it, flags,
@@ -226,8 +226,8 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,* this is normal situation, we should not print error here, * only debug info. */ -CDEBUG (D_INODE ,"Can't handle remote %s: dir " DFID "(" DFID "):" -"%*s: %d\n" ,LL_IT2STR (it),PFID (&op_data->op_fid2), +CDEBUG (D_INODE ,"Can't handle remote %s: dir " DFID "(" DFID "):%*s: %d\n" , +LL_IT2STR (it),PFID (&op_data->op_fid2),PFID (&op_data->op_fid1), op_data->op_namelen, op_data->op_name, rc);return rc;
drivers/staging/lustre/lustre/lmv/lmv_obd.c +16 -20
@@ -325,8 +325,8 @@ static int lmv_init_ea_size(struct obd_export *exp, int easize, rc =md_init_ea_size (lmv->tgts[i]->ltd_exp, easize, def_easize, cookiesize, def_cookiesize);if (rc) { -CERROR ("%s: obd_init_ea_size() failed on MDT target %d:" -" rc = %d.\n" , obd->obd_name, i, rc); +CERROR ("%s: obd_init_ea_size() failed on MDT target %d: rc = %d.\n" , + obd->obd_name, i, rc);break ; } }
@@ -427,8 +427,7 @@ int lmv_connect_mdc(struct obd_device *obd, struct lmv_tgt_desc *tgt) mdc_obd->obd_type->typ_name, mdc_obd->obd_name);if (mdc_symlink ==NULL ) { -CERROR ("Could not register LMV target " -"/proc/fs/lustre/%s/%s/target_obds/%s." , +CERROR ("Could not register LMV target /proc/fs/lustre/%s/%s/target_obds/%s." , obd->obd_type->typ_name, obd->obd_name, mdc_obd->obd_name);lprocfs_remove (&lmv_proc_dir);
@@ -474,8 +473,8 @@ static int lmv_add_target(struct obd_device *obd, struct obd_uuid *uuidp,if ((index < lmv->tgts_size) && (lmv->tgts[index] !=NULL )) { tgt = lmv->tgts[index]; -CERROR ("%s: UUID %s already assigned at LOV target index %d:" -" rc = %d\n" , obd->obd_name, +CERROR ("%s: UUID %s already assigned at LOV target index %d: rc = %d\n" , + obd->obd_name,obd_uuid2str (&tgt->ltd_uuid), index, -EEXIST );lmv_init_unlock (lmv);return -EEXIST ;
@@ -600,8 +599,7 @@ int lmv_check_connect(struct obd_device *obd) --lmv->desc.ld_active_tgt_count; rc2 =obd_disconnect (tgt->ltd_exp);if (rc2) { -CERROR ("LMV target %s disconnect on " -"MDC idx %d: error %d\n" , +CERROR ("LMV target %s disconnect on MDC idx %d: error %d\n" , tgt->ltd_uuid.uuid, i, rc2); } }
@@ -865,10 +863,9 @@ static int lmv_hsm_ct_register(struct lmv_obd *lmv, unsigned int cmd, int len,if (err) {if (lmv->tgts[i]->ltd_active) {/* permanent error */ -CERROR ("error: iocontrol MDC %s on MDT" -"idx %d cmd %x: err = %d\n" , - lmv->tgts[i]->ltd_uuid.uuid, - i, cmd, err); +CERROR ("error: iocontrol MDC %s on MDT idx %d cmd %x: err = %d\n" , + lmv->tgts[i]->ltd_uuid.uuid, + i, cmd, err); rc = err; lk->lk_flags |=LK_FLG_STOP ;/* unregister from previous MDS */
@@ -1147,10 +1144,9 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,return err; }else if (err) {if (lmv->tgts[i]->ltd_active) { -CERROR ("error: iocontrol MDC %s on MDT" -"idx %d cmd %x: err = %d\n" , - lmv->tgts[i]->ltd_uuid.uuid, - i, cmd, err); +CERROR ("error: iocontrol MDC %s on MDT idx %d cmd %x: err = %d\n" , + lmv->tgts[i]->ltd_uuid.uuid, + i, cmd, err);if (!rc) rc = err; }
@@ -1234,8 +1230,8 @@ static int lmv_placement_policy(struct obd_device *obd,if (lum->lum_type ==LMV_STRIPE_TYPE && lum->lum_stripe_offset !=-1 ) {if (lum->lum_stripe_offset >= lmv->desc.ld_tgt_count) { -CERROR ("%s: Stripe_offset %d > MDT count %d:" -" rc = %d\n" , obd->obd_name, +CERROR ("%s: Stripe_offset %d > MDT count %d: rc = %d\n" , + obd->obd_name, lum->lum_stripe_offset, lmv->desc.ld_tgt_count, -ERANGE );return -ERANGE ;
@@ -1298,8 +1294,8 @@ int lmv_fid_alloc(struct obd_export *exp, struct lu_fid *fid, rc =lmv_placement_policy (obd, op_data, &mds);if (rc) { -CERROR ("Can't get target for allocating fid, " -"rc %d\n" , rc); +CERROR ("Can't get target for allocating fid, rc %d\n" , + rc);return rc; }
drivers/staging/lustre/lustre/lov/lov_ea.c +2 -3
@@ -348,9 +348,8 @@ const struct lsm_operations lsm_v3_ops = {void dump_lsm (unsigned int level,const struct lov_stripe_md *lsm) { - CDEBUG(level, "lsm %p, objid "DOSTID", maxbytes %#llx, magic 0x%08X," - " stripe_size %u, stripe_count %u, refc: %d," - " layout_gen %u, pool ["LOV_POOLNAMEF"]\n", lsm, + CDEBUG(level, "lsm %p, objid " DOSTID ", maxbytes %#llx, magic 0x%08X, stripe_size %u, stripe_count %u, refc: %d, layout_gen %u, pool [" LOV_POOLNAMEF "]\n", + lsm, POSTID(&lsm->lsm_oi), lsm->lsm_maxbytes, lsm->lsm_magic, lsm->lsm_stripe_size, lsm->lsm_stripe_count, atomic_read(&lsm->lsm_refc), lsm->lsm_layout_gen,
drivers/staging/lustre/lustre/lov/lov_obd.c +14 -18
@@ -168,8 +168,8 @@ int lov_connect_obd(struct obd_device *obd, __u32 index, int activate,if (imp->imp_invalid) { -CDEBUG (D_CONFIG ,"not connecting OSC %s; administratively " -"disabled\n" ,obd_uuid2str (tgt_uuid)); +CDEBUG (D_CONFIG ,"not connecting OSC %s; administratively disabled\n" , +obd_uuid2str (tgt_uuid));return 0 ; }
@@ -201,10 +201,9 @@ int lov_connect_obd(struct obd_device *obd, __u32 index, int activate, osc_obd->obd_type->typ_name, osc_obd->obd_name);if (osc_symlink ==NULL ) { -CERROR ("could not register LOV target " -"/proc/fs/lustre/%s/%s/target_obds/%s." , - obd->obd_type->typ_name, obd->obd_name, - osc_obd->obd_name); +CERROR ("could not register LOV target /proc/fs/lustre/%s/%s/target_obds/%s." , + obd->obd_type->typ_name, obd->obd_name, + osc_obd->obd_name);lprocfs_remove (&lov_proc_dir); obd->obd_proc_private =NULL ; }
@@ -726,8 +725,7 @@ void lov_fix_desc_stripe_size(__u64 *val) {if (*val <LOV_MIN_STRIPE_SIZE ) {if (*val !=0 ) -LCONSOLE_INFO ("Increasing default stripe size to " -"minimum %u\n" , +LCONSOLE_INFO ("Increasing default stripe size to minimum %u\n" ,LOV_DESC_STRIPE_SIZE_DEFAULT ); *val =LOV_DESC_STRIPE_SIZE_DEFAULT ; }else if (*val & (LOV_MIN_STRIPE_SIZE -1 )) {
@@ -899,8 +897,7 @@ static int lov_cleanup(struct obd_device *obd)/* We should never get here - these should have been removed in the disconnect. */ -CERROR ("lov tgt %d not cleaned!" -" deathrow=%d, lovrc=%d\n" , +CERROR ("lov tgt %d not cleaned! deathrow=%d, lovrc=%d\n" , i, lov->lov_death_row,atomic_read (&lov->lov_refcount));lov_del_target (obd, i,NULL ,0 );
@@ -1175,8 +1172,8 @@ static int lov_getattr_async(struct obd_export *exp, struct obd_info *oinfo,list_for_each (pos, &lovset->set_list) { req = list_entry(pos, struct lov_request, rq_link); -CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx" -"%u\n" ,POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe, +CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx%u\n" , +POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe,POSTID (&req->rq_oi.oi_oa->o_oi), req->rq_idx); rc =obd_getattr_async (lov->lov_tgts[req->rq_idx]->ltd_exp, &req->rq_oi, rqset);
@@ -1255,8 +1252,8 @@ static int lov_setattr_async(struct obd_export *exp, struct obd_info *oinfo,if (oinfo->oi_oa->o_valid &OBD_MD_FLCOOKIE ) oti->oti_logcookies = set->set_cookies + req->rq_stripe; -CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx" -"%u\n" ,POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe, +CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx%u\n" , +POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe,POSTID (&req->rq_oi.oi_oa->o_oi), req->rq_idx); rc = obd_setattr_async(lov->lov_tgts[req->rq_idx]->ltd_exp,
@@ -1567,8 +1564,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len,if (lov->lov_tgts[i]->ltd_active) {CDEBUG (err == -ENOTTY ?D_IOCTL :D_WARNING , -"iocontrol OSC %s on OST " -"idx %d cmd %x: err = %d\n" , +"iocontrol OSC %s on OST idx %d cmd %x: err = %d\n" ,lov_uuid2str (lov, i), i, cmd, err);if (!rc)
@@ -2265,8 +2261,8 @@ static int lov_quotacheck(struct obd_device *obd, struct obd_export *exp,/* Skip quota check on the administratively disabled OSTs. */ if (!lov->lov_tgts[i]->ltd_activate) { -CWARN ("lov idx %d was administratively disabled, " -"skip quotacheck on it.\n" , i); +CWARN ("lov idx %d was administratively disabled, skip quotacheck on it.\n" , + i);continue ; }
drivers/staging/lustre/lustre/mgc/mgc_request.c +2 -4
@@ -734,8 +734,7 @@ static int mgc_setup(struct obd_device *obd, struct lustre_cfg *lcfg) rc =PTR_ERR (kthread_run (mgc_requeue_thread,NULL ,"ll_cfg_requeue" ));if (IS_ERR_VALUE (rc)) { -CERROR ("%s: Cannot start requeue thread (%d)," -"no more log updates!\n" , +CERROR ("%s: Cannot start requeue thread (%d), no more log updates!\n" , obd->obd_name, rc); goto err_cleanup; }
@@ -1019,8 +1018,7 @@ int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,sptlrpc_flavor2name (&cli->cl_flvr_mgc, str,sizeof (str)); -LCONSOLE_ERROR ("asking sptlrpc flavor %s to MGS but " -"currently %s is in use\n" , +LCONSOLE_ERROR ("asking sptlrpc flavor %s to MGS but currently %s is in use\n" , (char *) val, str); rc = -EPERM ; }
drivers/staging/lustre/lustre/obdclass/capa.c +3 -5
@@ -272,8 +272,7 @@ int capa_hmac(__u8 *hmac, struct lustre_capa *capa, __u8 *key) tfm =crypto_alloc_hash (alg->ha_name,0 ,0 );if (IS_ERR (tfm)) { -CERROR ("crypto_alloc_tfm failed, check whether your kernel" -"has crypto support!\n" ); +CERROR ("crypto_alloc_tfm failed, check whether your kernel has crypto support!\n" );return PTR_ERR (tfm); } keylen = alg->ha_keylen;
@@ -412,9 +411,8 @@ void _debug_capa(struct lustre_capa *c,va_list args;va_start (args, fmt);libcfs_debug_vmsg2 (msgdata, fmt, args, -" capability@%p fid " DFID " opc %#llx uid %llu" -" gid %llu flags %u alg %d keyid %u timeout %u " -"expiry %u\n" , c,PFID (capa_fid (c)),capa_opc (c), +" capability@%p fid " DFID " opc %#llx uid %llu gid %llu flags %u alg %d keyid %u timeout %u expiry %u\n" , + c,PFID (capa_fid (c)),capa_opc (c),capa_uid (c),capa_gid (c),capa_flags (c),capa_alg (c),capa_keyid (c),capa_timeout (c),capa_expiry (c));
drivers/staging/lustre/lustre/obdclass/cl_io.c +1 -2
@@ -1622,8 +1622,7 @@ int cl_sync_io_wait(const struct lu_env *env, struct cl_io *io,atomic_read (&anchor->csi_sync_nr) ==0 , &lwi);if (rc <0 ) { -CERROR ("SYNC IO failed with error: %d, try to cancel " -"%d remaining pages\n" , +CERROR ("SYNC IO failed with error: %d, try to cancel %d remaining pages\n" , rc,atomic_read (&anchor->csi_sync_nr)); (void )cl_io_cancel (env, io, queue);
drivers/staging/lustre/lustre/obdclass/cl_lock.c +1 -2
@@ -129,8 +129,7 @@ static void cl_lock_trace0(int level, const struct lu_env *env, const char *func, const int line) {struct cl_object_header *h =cl_object_header (lock->cll_descr.cld_obj); - CDEBUG(level, "%s: %p@(%d %p %d %d %d %d %d %lx)" - "(%p/%d/%d) at %s():%d\n", + CDEBUG(level, "%s: %p@(%d %p %d %d %d %d %d %lx)(%p/%d/%d) at %s():%d\n", prefix, lock, atomic_read(&lock->cll_ref), lock->cll_guarder, lock->cll_depth, lock->cll_state, lock->cll_error, lock->cll_holds,
drivers/staging/lustre/lustre/obdclass/class_obd.c +2 -4
@@ -144,13 +144,11 @@ int obd_alloc_fail(const void *ptr, const char *name, const char *type,CERROR ("%s%salloc of %s (%llu bytes) failed at %s:%d\n" , ptr ?"force " :"" , type, name, (__u64 )size, file, line); -CERROR ("%llu total bytes and %llu total pages " -"(%llu bytes) allocated by Lustre, " -"%d total bytes by LNET\n" , +CERROR ("%llu total bytes and %llu total pages (%llu bytes) allocated by Lustre, %d total bytes by LNET\n" ,obd_memory_sum (),obd_pages_sum () <<PAGE_CACHE_SHIFT ,obd_pages_sum (), -atomic_read (&libcfs_kmemory)); +atomic_read (&libcfs_kmemory));return 1 ; }return 0 ;
drivers/staging/lustre/lustre/obdclass/genops.c +7 -11
@@ -1087,8 +1087,7 @@ void __class_export_del_lock_ref(struct obd_export *exp, struct ldlm_lock *lock)spin_lock (&exp->exp_locks_list_guard);LASSERT (lock->l_exp_refs_nr >0 );if (lock->l_exp_refs_target != exp) { -LCONSOLE_WARN ("lock %p, " -"mismatching export pointers: %p, %p\n" , +LCONSOLE_WARN ("lock %p, mismatching export pointers: %p, %p\n" , lock, lock->l_exp_refs_target, exp); }if (-- lock->l_exp_refs_nr ==0 ) {
@@ -1259,8 +1258,7 @@ static void class_disconnect_export_list(struct list_head *list, }class_export_get (exp); -CDEBUG (D_HA ,"%s: disconnecting export at %s (%p), " -"last request at " CFS_TIME_T "\n" , +CDEBUG (D_HA ,"%s: disconnecting export at %s (%p), last request at " CFS_TIME_T "\n" , exp->exp_obd->obd_name,obd_export_nid2str (exp), exp, exp->exp_last_request_time);/* release one export reference anyway */
@@ -1284,8 +1282,8 @@ void class_disconnect_exports(struct obd_device *obd)spin_unlock (&obd->obd_dev_lock);if (!list_empty (&work_list)) { -CDEBUG (D_HA ,"OBD device %d (%p) has exports, " -"disconnecting them\n" , obd->obd_minor, obd); +CDEBUG (D_HA ,"OBD device %d (%p) has exports, disconnecting them\n" , + obd->obd_minor, obd);class_disconnect_export_list (&work_list,exp_flags_from_obd (obd)); }else
@@ -1422,8 +1420,8 @@ int obd_export_evict_by_nid(struct obd_device *obd, const char *nid)LASSERTF (doomed_exp != obd->obd_self_export,"self-export is hashed by NID?\n" ); exports_evicted++; -LCONSOLE_WARN ("%s: evicting %s (at %s) by administrative " -"request\n" , obd->obd_name, +LCONSOLE_WARN ("%s: evicting %s (at %s) by administrative request\n" , + obd->obd_name,obd_uuid2str (&doomed_exp->exp_client_uuid),obd_export_nid2str (doomed_exp));class_fail_export (doomed_exp);
@@ -1546,9 +1544,7 @@ void obd_exports_barrier(struct obd_device *obd)set_current_state (TASK_UNINTERRUPTIBLE );schedule_timeout (cfs_time_seconds (waited));if (waited >5 &&IS_PO2 (waited)) { -LCONSOLE_WARN ("%s is waiting for obd_unlinked_exports " -"more than %d seconds. " -"The obd refcount = %d. Is it stuck?\n" , +LCONSOLE_WARN ("%s is waiting for obd_unlinked_exports more than %d seconds. The obd refcount = %d. Is it stuck?\n" , obd->obd_name, waited,atomic_read (&obd->obd_refcount));dump_exports (obd,1 );
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +2 -3
@@ -202,9 +202,8 @@ static int proc_max_dirty_pages_in_mb(struct ctl_table *table, int write,/* Don't allow them to let dirty pages exceed 90% of system * memory and set a hard minimum of 4MB. */ if (obd_max_dirty_pages > ((totalram_pages /10 ) *9 )) { -CERROR ("Refusing to set max dirty pages to %u, which " -"is more than 90%% of available RAM; setting " -"to %lu\n" , obd_max_dirty_pages, +CERROR ("Refusing to set max dirty pages to %u, which is more than 90%% of available RAM; setting to %lu\n" , + obd_max_dirty_pages, ((totalram_pages /10 ) *9 )); obd_max_dirty_pages = ((totalram_pages /10 ) *9 ); }else if (obd_max_dirty_pages <4 << (20 -PAGE_CACHE_SHIFT )) {
drivers/staging/lustre/lustre/obdclass/llog.c +2 -2
@@ -346,8 +346,8 @@ repeat: }if (rec->lrh_len ==0 || rec->lrh_len >LLOG_CHUNK_SIZE ) { -CWARN ("invalid length %d in llog record for " -"index %d/%d\n" , rec->lrh_len, +CWARN ("invalid length %d in llog record for index %d/%d\n" , + rec->lrh_len, rec->lrh_index, index); rc = -EINVAL ; goto out;
drivers/staging/lustre/lustre/obdclass/llog_cat.c +4 -6
@@ -228,8 +228,7 @@ int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle) (llh->llh_count == 1)) { rc =llog_destroy (env, loghandle);if (rc) -CERROR ("%s: failure destroying log during " -"cleanup: rc = %d\n" , +CERROR ("%s: failure destroying log during cleanup: rc = %d\n" , loghandle->lgh_ctxt->loc_obd->obd_name, rc);
@@ -746,8 +745,7 @@ int llog_cat_cleanup(const struct lu_env *env, struct llog_handle *cathandle,llog_cat_set_first_idx (cathandle, index); rc =llog_cancel_rec (env, cathandle, index);if (rc ==0 ) -CDEBUG (D_HA ,"cancel plain log at index" -" %u of catalog " DOSTID "\n" , +CDEBUG (D_HA ,"cancel plain log at index %u of catalog " DOSTID "\n" , index,POSTID (&cathandle->lgh_id.lgl_oi));return rc; }
@@ -810,8 +808,8 @@ int llog_cat_init_and_process(const struct lu_env *env, rc =llog_process_or_fork (env, llh, cat_cancel_cb,NULL ,NULL , false);if (rc) -CERROR ("%s: llog_process() with cat_cancel_cb failed: rc = " -"%d\n" , llh->lgh_ctxt->loc_obd->obd_name, rc); +CERROR ("%s: llog_process() with cat_cancel_cb failed: rc = %d\n" , + llh->lgh_ctxt->loc_obd->obd_name, rc);return 0 ; }EXPORT_SYMBOL (llog_cat_init_and_process);
drivers/staging/lustre/lustre/obdclass/llog_swab.c +1 -2
@@ -400,8 +400,7 @@ void lustre_swab_cfg_marker(struct cfg_marker *marker, int swab, int size) } marker->cm_createtime = createtime; marker->cm_canceltime = canceltime; -CDEBUG (D_CONFIG ,"Find old cfg_marker(Srv32b,Clt64b) " -"for target %s, converting\n" , +CDEBUG (D_CONFIG ,"Find old cfg_marker(Srv32b,Clt64b) for target %s, converting\n" , marker->cm_tgtname); }else if (swab) {__swab64s (&marker->cm_createtime);
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +4 -6
@@ -1400,8 +1400,8 @@ int lprocfs_alloc_obd_stats(struct obd_device *obd, unsigned num_private_stats)* LPROCFS_OBD_OP_INIT(.., .., opname) * is missing from the list above. */ LASSERTF (stats->ls_cnt_header[i].lc_name !=NULL , -"Missing obd_stat initializer obd_op " -"operation at offset %d.\n" , i - num_private_stats); +"Missing obd_stat initializer obd_op operation at offset %d.\n" , + i - num_private_stats); } rc =lprocfs_register_stats (obd->obd_proc_entry,"stats" , stats);if (rc <0 ) {
@@ -1486,8 +1486,7 @@ int lprocfs_alloc_md_stats(struct obd_device *obd,for (i = num_private_stats; i < num_stats; i++) {if (stats->ls_cnt_header[i].lc_name ==NULL ) { -CERROR ("Missing md_stat initializer md_op " -"operation at offset %d. Aborting.\n" , +CERROR ("Missing md_stat initializer md_op operation at offset %d. Aborting.\n" , i - num_private_stats);LBUG (); }
@@ -1607,8 +1606,7 @@ LPROC_SEQ_FOPS_RO(lproc_exp_hash);int lprocfs_nid_stats_clear_read (struct seq_file *m,void *data) {return seq_printf (m,"%s\n" , -"Write into this file to clear all nid stats and " -"stale nid entries" ); +"Write into this file to clear all nid stats and stale nid entries" ); }EXPORT_SYMBOL (lprocfs_nid_stats_clear_read);
drivers/staging/lustre/lustre/obdclass/lu_object.c +1 -2
@@ -866,8 +866,7 @@ static int lu_htable_order(void)/* clear off unreasonable cache setting. */ if (lu_cache_percent ==0 || lu_cache_percent >LU_CACHE_PERCENT_MAX ) { -CWARN ("obdclass: invalid lu_cache_percent: %u, it must be in" -" the range of (0, %u]. Will use default value: %u.\n" , +CWARN ("obdclass: invalid lu_cache_percent: %u, it must be in the range of (0, %u]. Will use default value: %u.\n" , lu_cache_percent,LU_CACHE_PERCENT_MAX ,LU_CACHE_PERCENT_DEFAULT );
drivers/staging/lustre/lustre/obdclass/obd_config.c +3 -6
@@ -1443,8 +1443,7 @@ int class_config_llog_handler(const struct lu_env *env,if (!(clli->cfg_flags &CFG_F_COMPAT146 ) && !(clli->cfg_flags &CFG_F_MARKER ) && (lcfg->lcfg_command !=LCFG_MARKER )) { -CWARN ("Config not inside markers, ignoring! " -"(inst: %p, uuid: %s, flags: %#x)\n" , +CWARN ("Config not inside markers, ignoring! (inst: %p, uuid: %s, flags: %#x)\n" , clli->cfg_instance, clli->cfg_uuid.uuid, clli->cfg_flags); clli->cfg_flags |=CFG_F_SKIP ;
@@ -1467,14 +1466,12 @@ int class_config_llog_handler(const struct lu_env *env,if ((lcfg->lcfg_command ==LCFG_ATTACH && typename &&strcmp (typename,"mds" ) ==0 )) { -CWARN ("For 1.8 interoperability, rename obd " -"type from mds to mdt\n" ); +CWARN ("For 1.8 interoperability, rename obd type from mds to mdt\n" ); typename[2 ] ='t' ; }if ((lcfg->lcfg_command ==LCFG_SETUP && index &&strcmp (index,"type" ) ==0 )) { -CDEBUG (D_INFO ,"For 1.8 interoperability, " -"set this index to '0'\n" ); +CDEBUG (D_INFO ,"For 1.8 interoperability, set this index to '0'\n" ); index[0 ] ='0' ; index[1 ] =0 ; }
drivers/staging/lustre/lustre/obdclass/obd_mount.c +11 -27
@@ -100,19 +100,12 @@ int lustre_process_log(struct super_block *sb, char *logname,OBD_FREE_PTR (bufs);if (rc == -EINVAL ) -LCONSOLE_ERROR_MSG (0x15b ,"%s: The configuration from log '%s'" -"failed from the MGS (%d). Make sure this " -"client and the MGS are running compatible " -"versions of Lustre.\n" , +LCONSOLE_ERROR_MSG (0x15b ,"%s: The configuration from log '%s'failed from the MGS (%d). Make sure this client and the MGS are running compatible versions of Lustre.\n" , mgc->obd_name, logname, rc);if (rc) -LCONSOLE_ERROR_MSG (0x15c ,"%s: The configuration from log '%s' " -"failed (%d). This may be the result of " -"communication errors between this node and " -"the MGS, a bad configuration, or other " -"errors. See the syslog for more " -"information.\n" , mgc->obd_name, logname, +LCONSOLE_ERROR_MSG (0x15c ,"%s: The configuration from log '%s' failed (%d). This may be the result of communication errors between this node and the MGS, a bad configuration, or other errors. See the syslog for more information.\n" , + mgc->obd_name, logname, rc);/* class_obd_list(); */
@@ -297,11 +290,8 @@ int lustre_start_mgc(struct super_block *sb)if (has_ir ^ !(*flags &LMD_FLG_NOIR )) {/* LMD_FLG_NOIR is for test purpose only */ LCONSOLE_WARN ( -"Trying to mount a client with IR setting " -"not compatible with current mgc. " -"Force to use current mgc setting that is " -"IR %s.\n" , - has_ir ?"enabled" :"disabled" ); +"Trying to mount a client with IR setting not compatible with current mgc. Force to use current mgc setting that is IR %s.\n" , + has_ir ?"enabled" :"disabled" );if (has_ir) *flags &= ~LMD_FLG_NOIR ;else
@@ -998,16 +988,14 @@ static int lmd_parse(char *options, struct lustre_mount_data *lmd)LASSERT (lmd);if (!options) { -LCONSOLE_ERROR_MSG (0x162 ,"Missing mount data: check that " -"/sbin/mount.lustre is installed.\n" ); +LCONSOLE_ERROR_MSG (0x162 ,"Missing mount data: check that /sbin/mount.lustre is installed.\n" );return -EINVAL ; }/* Options should be a string - try to detect old lmd data */ if ((raw->lmd_magic &0xffffff00 ) == (LMD_MAGIC &0xffffff00 )) { -LCONSOLE_ERROR_MSG (0x163 ,"You're using an old version of " -"/sbin/mount.lustre. Please install " -"version %s\n" ,LUSTRE_VERSION_STRING ); +LCONSOLE_ERROR_MSG (0x163 ,"You're using an old version of /sbin/mount.lustre. Please install version %s\n" , +LUSTRE_VERSION_STRING );return -EINVAL ; } lmd->lmd_magic =LMD_MAGIC ;
@@ -1139,8 +1127,7 @@ static int lmd_parse(char *options, struct lustre_mount_data *lmd) }if (!devname) { -LCONSOLE_ERROR_MSG (0x164 ,"Can't find the device name " -"(need mount option 'device=...')\n" ); +LCONSOLE_ERROR_MSG (0x164 ,"Can't find the device name (need mount option 'device=...')\n" ); goto invalid; }
@@ -1232,9 +1219,7 @@ int lustre_fill_super(struct super_block *sb, void *data, int silent)if (client_fill_super ==NULL )request_module ("lustre" );if (client_fill_super ==NULL ) { -LCONSOLE_ERROR_MSG (0x165 ,"Nothing registered for " -"client mount! Is the 'lustre' " -"module loaded?\n" ); +LCONSOLE_ERROR_MSG (0x165 ,"Nothing registered for client mount! Is the 'lustre' module loaded?\n" );lustre_put_lsi (sb); rc = -ENODEV ; }else {
@@ -1249,8 +1234,7 @@ int lustre_fill_super(struct super_block *sb, void *data, int silent)/* c_f_s will call lustre_common_put_super on failure */ } }else { -CERROR ("This is client-side-only module, " -"cannot handle server mount.\n" ); +CERROR ("This is client-side-only module, cannot handle server mount.\n" ); rc = -EINVAL ; }
drivers/staging/lustre/lustre/obdecho/echo_client.c +1 -2
@@ -871,8 +871,7 @@ static struct lu_device *echo_device_free(const struct lu_env *env,spin_lock (&ec->ec_lock);while (!list_empty (&ec->ec_objects)) {spin_unlock (&ec->ec_lock); -CERROR ("echo_client still has objects at cleanup time, " -"wait for 1 second\n" ); +CERROR ("echo_client still has objects at cleanup time, wait for 1 second\n" );set_current_state (TASK_UNINTERRUPTIBLE );schedule_timeout (cfs_time_seconds (1 ));lu_site_purge (env, &ed->ed_site->cs_lu,-1 );
drivers/staging/lustre/lustre/osc/osc_cache.c +2 -2
@@ -1560,8 +1560,8 @@ void osc_wake_cache_waiters(struct client_obd *cli)if ((cli->cl_dirty +PAGE_CACHE_SIZE > cli->cl_dirty_max) || (atomic_read (&obd_dirty_pages) +1 > obd_max_dirty_pages)) { -CDEBUG (D_CACHE ,"no dirty room: dirty: %ld " -"osc max %ld, sys max %d\n" , cli->cl_dirty, +CDEBUG (D_CACHE ,"no dirty room: dirty: %ld osc max %ld, sys max %d\n" , + cli->cl_dirty, cli->cl_dirty_max, obd_max_dirty_pages); goto wakeup; }
drivers/staging/lustre/lustre/osc/osc_lock.c +2 -4
@@ -1067,14 +1067,12 @@ static int osc_lock_enqueue_wait(const struct lu_env *env,* conflicts, we do not wait but return 0 so the * request is send to the server */ -CDEBUG (D_DLMTRACE ,"group lock %p is conflicted " -"with %p, no wait, send to server\n" , +CDEBUG (D_DLMTRACE ,"group lock %p is conflicted with %p, no wait, send to server\n" , lock, conflict);cl_lock_put (env, conflict); rc =0 ; }else { -CDEBUG (D_DLMTRACE ,"lock %p is conflicted with %p, " -"will wait\n" , +CDEBUG (D_DLMTRACE ,"lock %p is conflicted with %p, will wait\n" , lock, conflict);LASSERT (lock->cll_conflict ==NULL ); lu_ref_add(&conflict->cll_reference, "cancel-wait",
drivers/staging/lustre/lustre/osc/osc_object.c +1 -2
@@ -140,8 +140,7 @@ static int osc_object_print(const struct lu_env *env, void *cookie,struct lov_oinfo *oinfo = osc->oo_oinfo;struct osc_async_rc *ar = &oinfo->loi_ar; - (*p)(env, cookie,"id: " DOSTID " " -"idx: %d gen: %d kms_valid: %u kms %llu rc: %d force_sync: %d min_xid: %llu " , + (*p)(env, cookie,"id: " DOSTID " idx: %d gen: %d kms_valid: %u kms %llu rc: %d force_sync: %d min_xid: %llu " ,POSTID (&oinfo->loi_oi), oinfo->loi_ost_idx, oinfo->loi_ost_gen, oinfo->loi_kms_valid, oinfo->loi_kms, ar->ar_rc, ar->ar_force_sync, ar->ar_min_xid);
drivers/staging/lustre/lustre/osc/osc_page.c +3 -8
@@ -369,12 +369,7 @@ static int osc_page_print(const struct lu_env *env,struct osc_object *obj =cl2osc (slice->cpl_obj);struct client_obd *cli = &osc_export (obj)->exp_obd->u.cli; - return (*printer)(env, cookie, LUSTRE_OSC_NAME"-page@%p: " - "1< %#x %d %u %s %s > " - "2< %llu %u %u %#x %#x | %p %p %p > " - "3< %s %p %d %lu %d > " - "4< %d %d %d %lu %s | %s %s %s %s > " - "5< %s %s %s %s | %d %s | %d %s %s>\n", + return (*printer)(env, cookie, LUSTRE_OSC_NAME "-page@%p: 1< %#x %d %u %s %s > 2< %llu %u %u %#x %#x | %p %p %p > 3< %s %p %d %lu %d > 4< %d %d %d %lu %s | %s %s %s %s > 5< %s %s %s %s | %d %s | %d %s %s>\n", opg, /* 1 */ oap->oap_magic, oap->oap_cmd,
@@ -550,8 +545,8 @@ void osc_page_submit(const struct lu_env *env, struct osc_page *opg,LINVRNT (osc_page_protected (env, opg, crt ==CRT_WRITE ?CLM_WRITE :CLM_READ ,1 )); -LASSERTF (oap->oap_magic ==OAP_MAGIC ,"Bad oap magic: oap %p, " -"magic 0x%x\n" , oap, oap->oap_magic); +LASSERTF (oap->oap_magic ==OAP_MAGIC ,"Bad oap magic: oap %p, magic 0x%x\n" , + oap, oap->oap_magic);LASSERT (oap->oap_async_flags &ASYNC_READY );LASSERT (oap->oap_async_flags &ASYNC_COUNT_STABLE );
drivers/staging/lustre/lustre/osc/osc_request.c +21 -26
109 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/client.c +19 -25
106 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/events.c +3 -4
@@ -128,8 +128,8 @@ void reply_in_callback(lnet_event_t *ev) ((lustre_msghdr_get_flags(req->rq_reqmsg) & MSGHDR_AT_SUPPORT))) {/* Early reply */ DEBUG_REQ(D_ADAPTTO, req, - "Early reply received: mlen=%u offset=%d replen=%d " - "replied=%d unlinked=%d", ev->mlength, ev->offset, + "Early reply received: mlen=%u offset=%d replen=%d replied=%d unlinked=%d", + ev->mlength, ev->offset,
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/import.c +41 -67
108 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/layout.c +8 -12
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/llog_client.c +1 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +5 -8
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/niobuf.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/nrs.c +12 -21
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +14 -19
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/pinger.c +4 -12
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/recover.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec.c +10 -12
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c +1 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c +2 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/service.c +39 -51
90 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Part of the diff is not shown here. View the raw message.
Greg Kroah-Hartman
maintainerQuoted 10 lines · Joe Perches
Join the string fragments to make it easier to grep.
Ignored all the 80+ column lines.
Added many missing spaces when coalescing formats.Signed-off-by Joe Perches <[email protected]>---
I used this directory as a test for a new "coalesce string fragments" checkpatch rule. Might as well submit the change.
Doesn't apply to my staging-testing branch anymore due to other changes that were sent in before yours :(
PATCH v2 1/1 staging: lustre: Coalesce string fragments
Join the string fragments to make it easier to grep.
Ignored all the 80+ column lines.
Added many missing spaces when coalescing formats.
---
Quoted 2 lines
Doesn't apply to my staging-testing branch anymore due to other changes that were sent in before yours :(
Fixup rejects
Couple more lines coalesced, spaces added/deleted.
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 12 +- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 34 ++--- .../lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c | 3 +- .../staging/lustre/lnet/klnds/socklnd/socklnd.c | 49 +++--- .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 89 +++++------ .../lustre/lnet/klnds/socklnd/socklnd_proto.c | 15 +- drivers/staging/lustre/lnet/lnet/lib-move.c | 82 +++++----- drivers/staging/lustre/lnet/lnet/lib-ptl.c | 3 +- drivers/staging/lustre/lnet/lnet/router.c | 34 ++--- drivers/staging/lustre/lnet/lnet/router_proc.c | 9 +- drivers/staging/lustre/lnet/selftest/console.c | 6 +- drivers/staging/lustre/lnet/selftest/framework.c | 25 ++- drivers/staging/lustre/lnet/selftest/module.c | 4 +- drivers/staging/lustre/lnet/selftest/rpc.c | 29 ++-- drivers/staging/lustre/lustre/include/linux/obd.h | 3 +- .../staging/lustre/lustre/include/lustre_disk.h | 3 +- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 3 +- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 4 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 168 +++++++++------------ drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 11 +- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 10 +- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 37 ++--- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 19 +-- drivers/staging/lustre/lustre/libcfs/debug.c | 8 +- drivers/staging/lustre/lustre/libcfs/hash.c | 3 +- .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 32 ++-- .../lustre/lustre/libcfs/linux/linux-debug.c | 6 +- .../lustre/lustre/libcfs/linux/linux-tcpip.c | 3 +- drivers/staging/lustre/lustre/libcfs/tracefile.c | 38 +++-- drivers/staging/lustre/lustre/llite/dcache.c | 6 +- drivers/staging/lustre/lustre/llite/dir.c | 25 ++- drivers/staging/lustre/lustre/llite/file.c | 16 +- drivers/staging/lustre/lustre/llite/llite_capa.c | 3 +- drivers/staging/lustre/lustre/llite/llite_close.c | 16 +- .../staging/lustre/lustre/llite/llite_internal.h | 12 +- drivers/staging/lustre/lustre/llite/llite_lib.c | 58 +++---- drivers/staging/lustre/lustre/llite/llite_mmap.c | 9 +- drivers/staging/lustre/lustre/llite/llite_rmtacl.c | 7 +- drivers/staging/lustre/lustre/llite/lloop.c | 4 +- drivers/staging/lustre/lustre/llite/lproc_llite.c | 29 ++-- drivers/staging/lustre/lustre/llite/namei.c | 14 +- drivers/staging/lustre/lustre/llite/rw.c | 20 +-- drivers/staging/lustre/lustre/llite/statahead.c | 11 +- drivers/staging/lustre/lustre/llite/symlink.c | 4 +- drivers/staging/lustre/lustre/llite/vvp_io.c | 5 +- drivers/staging/lustre/lustre/llite/vvp_page.c | 3 +- drivers/staging/lustre/lustre/llite/xattr.c | 3 +- drivers/staging/lustre/lustre/lmv/lmv_fld.c | 3 +- drivers/staging/lustre/lustre/lmv/lmv_intent.c | 8 +- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 36 ++--- drivers/staging/lustre/lustre/lov/lov_ea.c | 5 +- drivers/staging/lustre/lustre/lov/lov_obd.c | 32 ++-- drivers/staging/lustre/lustre/mgc/mgc_request.c | 6 +- drivers/staging/lustre/lustre/obdclass/capa.c | 8 +- drivers/staging/lustre/lustre/obdclass/cl_io.c | 3 +- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 3 +- drivers/staging/lustre/lustre/obdclass/class_obd.c | 6 +- drivers/staging/lustre/lustre/obdclass/genops.c | 18 +-- .../lustre/lustre/obdclass/linux/linux-sysctl.c | 5 +- drivers/staging/lustre/lustre/obdclass/llog.c | 4 +- drivers/staging/lustre/lustre/obdclass/llog_cat.c | 10 +- drivers/staging/lustre/lustre/obdclass/llog_swab.c | 3 +- .../lustre/lustre/obdclass/lprocfs_status.c | 10 +- drivers/staging/lustre/lustre/obdclass/lu_object.c | 3 +- .../staging/lustre/lustre/obdclass/obd_config.c | 9 +- drivers/staging/lustre/lustre/obdclass/obd_mount.c | 38 ++--- .../staging/lustre/lustre/obdecho/echo_client.c | 3 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +- drivers/staging/lustre/lustre/osc/osc_lock.c | 6 +- drivers/staging/lustre/lustre/osc/osc_object.c | 3 +- drivers/staging/lustre/lustre/osc/osc_page.c | 11 +- drivers/staging/lustre/lustre/osc/osc_request.c | 47 +++--- drivers/staging/lustre/lustre/ptlrpc/client.c | 44 +++--- drivers/staging/lustre/lustre/ptlrpc/events.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/import.c | 115 ++++++-------- drivers/staging/lustre/lustre/ptlrpc/layout.c | 24 ++- drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 3 +- .../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 13 +- drivers/staging/lustre/lustre/ptlrpc/niobuf.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/nrs.c | 33 ++-- .../staging/lustre/lustre/ptlrpc/pack_generic.c | 33 ++-- drivers/staging/lustre/lustre/ptlrpc/pinger.c | 18 +-- drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/recover.c | 7 +- drivers/staging/lustre/lustre/ptlrpc/sec.c | 22 ++- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 3 +- drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 4 +- drivers/staging/lustre/lustre/ptlrpc/service.c | 90 +++++------ 88 files changed, 688 insertions(+), 1013 deletions(-)
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c +4 -8
@@ -930,8 +930,7 @@ kiblnd_close_peer_conns_locked (kib_peer_t *peer, int why) list_for_each_safe (ctmp, cnxt, &peer->ibp_conns) { conn =list_entry (ctmp, kib_conn_t, ibc_list); -CDEBUG (D_NET ,"Closing conn -> %s, " -"version: %x, reason: %d\n" , +CDEBUG (D_NET ,"Closing conn -> %s, version: %x, reason: %d\n" ,libcfs_nid2str (peer->ibp_nid), conn->ibc_version, why);
@@ -958,8 +957,7 @@ kiblnd_close_stale_conns_locked (kib_peer_t *peer, conn->ibc_incarnation == incarnation)continue ; -CDEBUG (D_NET ,"Closing stale conn -> %s version: %x, " -"incarnation:%#llx(%x, %#llx)\n" , +CDEBUG (D_NET ,"Closing stale conn -> %s version: %x, incarnation:%#llx(%x, %#llx)\n" ,libcfs_nid2str (peer->ibp_nid), conn->ibc_version, conn->ibc_incarnation, version, incarnation);
@@ -1599,8 +1597,7 @@ kiblnd_fmr_pool_map(kib_fmr_poolset_t *fps, __u64 *pages, int npages,if (fps->fps_increasing) {spin_unlock (&fps->fps_lock); -CDEBUG (D_NET ,"Another thread is allocating new " -"FMR pool, waiting for her to complete\n" ); +CDEBUG (D_NET ,"Another thread is allocating new FMR pool, waiting for her to complete\n" );schedule (); goto again;
@@ -1801,8 +1798,7 @@ kiblnd_pool_alloc_node(kib_poolset_t *ps)if (ps->ps_increasing) {/* another thread is allocating a new pool */ spin_unlock (&ps->ps_lock); -CDEBUG (D_NET ,"Another thread is allocating new " -"%s pool, waiting for her to complete\n" , +CDEBUG (D_NET ,"Another thread is allocating new %s pool, waiting for her to complete\n" , ps->ps_name);schedule (); goto again;
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c +12 -22
@@ -1116,8 +1116,7 @@ kiblnd_init_rdma (kib_conn_t *conn, kib_tx_t *tx, int type, }if (tx->tx_nwrq ==IBLND_RDMA_FRAGS (conn->ibc_version)) { - CERROR("RDMA too fragmented for %s (%d): " - "%d/%d src %d/%d dst frags\n", + CERROR("RDMA too fragmented for %s (%d): %d/%d src %d/%d dst frags\n", libcfs_nid2str(conn->ibc_peer->ibp_nid), IBLND_RDMA_FRAGS(conn->ibc_version), srcidx, srcrd->rd_nfrags,
@@ -2254,8 +2253,8 @@ kiblnd_passive_connect (struct rdma_cm_id *cmid, void *priv, int priv_nob)if (ni ==NULL ||/* no matching net */ ni->ni_nid != reqmsg->ibm_dstnid ||/* right NET, wrong NID! */ net->ibn_dev != ibdev) {/* wrong device */ - CERROR("Can't accept %s on %s (%s:%d:%pI4h): " - "bad dst nid %s\n", libcfs_nid2str(nid), + CERROR("Can't accept %s on %s (%s:%d:%pI4h): bad dst nid %s\n", + libcfs_nid2str(nid), ni == NULL ? "NA" : libcfs_nid2str(ni->ni_nid), ibdev->ibd_ifname, ibdev->ibd_nnets, &ibdev->ibd_ifip,
@@ -2295,8 +2294,7 @@ kiblnd_passive_connect (struct rdma_cm_id *cmid, void *priv, int priv_nob)if (reqmsg->ibm_u.connparams.ibcp_max_frags !=IBLND_RDMA_FRAGS (version)) { -CERROR ("Can't accept %s(version %x): " -"incompatible max_frags %d (%d wanted)\n" , +CERROR ("Can't accept %s(version %x): incompatible max_frags %d (%d wanted)\n" ,libcfs_nid2str (nid), version, reqmsg->ibm_u.connparams.ibcp_max_frags,IBLND_RDMA_FRAGS (version));
@@ -2502,8 +2500,7 @@ kiblnd_reconnect (kib_conn_t *conn, int version,break ; } - CNETERR("%s: retrying (%s), %x, %x, " - "queue_dep: %d, max_frag: %d, msg_size: %d\n", + CNETERR("%s: retrying (%s), %x, %x, queue_dep: %d, max_frag: %d, msg_size: %d\n", libcfs_nid2str(peer->ibp_nid), reason, IBLND_MSG_VERSION, version, cp != NULL? cp->ibcp_queue_depth :IBLND_MSG_QUEUE_SIZE(version),
@@ -2679,8 +2676,7 @@ kiblnd_check_connreply (kib_conn_t *conn, void *priv, int priv_nob) }if (ver != msg->ibm_version) { -CERROR ("%s replied version %x is different with " -"requested version %x\n" , +CERROR ("%s replied version %x is different with requested version %x\n" ,libcfs_nid2str (peer->ibp_nid), msg->ibm_version, ver); rc = -EPROTO ; goto failed;
@@ -2724,8 +2720,7 @@ kiblnd_check_connreply (kib_conn_t *conn, void *priv, int priv_nob)read_unlock_irqrestore (&kiblnd_data.kib_global_lock, flags);if (rc !=0 ) { -CERROR ("Bad connection reply from %s, rc = %d, " -"version: %x max_frags: %d\n" , +CERROR ("Bad connection reply from %s, rc = %d, version: %x max_frags: %d\n" ,libcfs_nid2str (peer->ibp_nid), rc, msg->ibm_version, msg->ibm_u.connparams.ibcp_max_frags); goto failed;
@@ -3060,8 +3055,7 @@ kiblnd_check_conns (int idx) }if (timedout) { - CERROR("Timed out RDMA with %s (%lu): " - "c: %u, oc: %u, rc: %u\n", + CERROR("Timed out RDMA with %s (%lu): c: %u, oc: %u, rc: %u\n", libcfs_nid2str(peer->ibp_nid), cfs_duration_sec(cfs_time_current() - peer->ibp_last_alive),
@@ -3334,10 +3328,8 @@ kiblnd_scheduler(void *arg) rc =cfs_cpt_bind (lnet_cpt_table (), sched->ibs_cpt);if (rc !=0 ) { -CWARN ("Failed to bind on CPT %d, please verify whether " -"all CPUs are healthy and reload modules if necessary, " -"otherwise your system might under risk of low " -"performance\n" , sched->ibs_cpt); +CWARN ("Failed to bind on CPT %d, please verify whether all CPUs are healthy and reload modules if necessary, otherwise your system might under risk of low performance\n" , + sched->ibs_cpt); }spin_lock_irqsave (&sched->ibs_lock, flags);
@@ -3369,8 +3361,7 @@ kiblnd_scheduler(void *arg) rc =ib_req_notify_cq (conn->ibc_cq,IB_CQ_NEXT_COMP );if (rc <0 ) { -CWARN ("%s: ib_req_notify_cq failed: %d, " -"closing connection\n" , +CWARN ("%s: ib_req_notify_cq failed: %d, closing connection\n" ,libcfs_nid2str (conn->ibc_peer->ibp_nid), rc);kiblnd_close_conn (conn, -EIO );kiblnd_conn_decref (conn);
@@ -3383,8 +3374,7 @@ kiblnd_scheduler(void *arg) }if (rc <0 ) { -CWARN ("%s: ib_poll_cq failed: %d, " -"closing connection\n" , +CWARN ("%s: ib_poll_cq failed: %d, closing connection\n" ,libcfs_nid2str (conn->ibc_peer->ibp_nid), rc);kiblnd_close_conn (conn, -EIO );
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c +1 -2
@@ -222,8 +222,7 @@ kiblnd_tunables_init (void) *kiblnd_tunables.kib_concurrent_sends = *kiblnd_tunables.kib_peertxcredits /2 ;if (*kiblnd_tunables.kib_concurrent_sends < *kiblnd_tunables.kib_peertxcredits) { -CWARN ("Concurrent sends %d is lower than message queue size: %d, " -"performance may drop slightly.\n" , +CWARN ("Concurrent sends %d is lower than message queue size: %d, performance may drop slightly.\n" , *kiblnd_tunables.kib_concurrent_sends, *kiblnd_tunables.kib_peertxcredits); }
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c +20 -29
103 lines not on this page · raw message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c +35 -54
184 lines not on this page · raw message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_proto.c +7 -8
@@ -515,8 +515,8 @@ ksocknal_send_hello_v1 (ksock_conn_t *conn, ksock_hello_msg_t *hello) hello->kshm_nips *sizeof (__u32), lnet_acceptor_timeout());if (rc !=0 ) { -CNETERR ("Error %d sending HELLO payload (%d)" -" to %pI4h/%d\n" , rc, hello->kshm_nips, +CNETERR ("Error %d sending HELLO payload (%d) to %pI4h/%d\n" , + rc, hello->kshm_nips, &conn->ksnc_ipaddr, conn->ksnc_port); } out:
@@ -560,8 +560,8 @@ ksocknal_send_hello_v2 (ksock_conn_t *conn, ksock_hello_msg_t *hello) hello->kshm_nips *sizeof (__u32), lnet_acceptor_timeout());if (rc !=0 ) { -CNETERR ("Error %d sending HELLO payload (%d)" -" to %pI4h/%d\n" , rc, hello->kshm_nips, +CNETERR ("Error %d sending HELLO payload (%d) to %pI4h/%d\n" , + rc, hello->kshm_nips, &conn->ksnc_ipaddr, conn->ksnc_port); }
@@ -595,10 +595,9 @@ ksocknal_recv_hello_v1(ksock_conn_t *conn, ksock_hello_msg_t *hello,/* ...and check we got what we expected */ if (hdr->type !=cpu_to_le32 (LNET_MSG_HELLO )) { -CERROR ("Expecting a HELLO hdr," -" but got type %d from %pI4h\n" , -le32_to_cpu (hdr->type), - &conn->ksnc_ipaddr); +CERROR ("Expecting a HELLO hdr, but got type %d from %pI4h\n" , +le32_to_cpu (hdr->type), + &conn->ksnc_ipaddr); rc = -EPROTO ; goto out; }
drivers/staging/lustre/lnet/lnet/lib-move.c +34 -48
174 lines not on this page · raw message
drivers/staging/lustre/lnet/lnet/lib-ptl.c +1 -2
@@ -192,8 +192,7 @@ lnet_try_match_md(lnet_libmd_t *md, }/* Commit to this ME/MD */ -CDEBUG (D_NET ,"Incoming %s index %x from %s of " -"length %d/%d into md %#llx [%d] + %d\n" , +CDEBUG (D_NET ,"Incoming %s index %x from %s of length %d/%d into md %#llx [%d] + %d\n" , (info->mi_opc ==LNET_MD_OP_PUT ) ?"put" :"get" , info->mi_portal,libcfs_id2str (info->mi_id), mlength, info->mi_rlength, md->md_lh.lh_cookie, md->md_niov, offset);
drivers/staging/lustre/lnet/lnet/router.c +14 -20
@@ -457,8 +457,7 @@ lnet_check_routes(void)lnet_net_unlock (cpt); -CERROR ("Routes to %s via %s and %s not " -"supported\n" , +CERROR ("Routes to %s via %s and %s not supported\n" ,libcfs_net2str (net),libcfs_nid2str (nid1),libcfs_nid2str (nid2));
@@ -959,8 +958,7 @@ lnet_ping_router_locked (lnet_peer_t *rtr) secs =lnet_router_check_interval (rtr);CDEBUG (D_NET , -"rtr %s %d: deadline %lu ping_notsent %d alive %d " -"alive_count %d lp_ping_timestamp %lu\n" , +"rtr %s %d: deadline %lu ping_notsent %d alive %d alive_count %d lp_ping_timestamp %lu\n" ,libcfs_nid2str (rtr->lp_nid), secs, rtr->lp_ping_deadline, rtr->lp_ping_notsent, rtr->lp_alive, rtr->lp_alive_count, rtr->lp_ping_timestamp);
@@ -1010,9 +1008,7 @@ lnet_router_checker_start(void)if (check_routers_before_use && dead_router_check_interval <=0 ) { -LCONSOLE_ERROR_MSG (0x10a ,"'dead_router_check_interval' must be" -" set if 'check_routers_before_use' is set" -"\n" ); +LCONSOLE_ERROR_MSG (0x10a ,"'dead_router_check_interval' must be set if 'check_routers_before_use' is set\n" );return -EINVAL ; }
@@ -1370,8 +1366,8 @@ lnet_nrb_tiny_calculate(int npages)if (tiny_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"tiny_router_buffers=%d invalid when " -"routing enabled\n" , tiny_router_buffers); +"tiny_router_buffers=%d invalid when routing enabled\n" , + tiny_router_buffers);return -1 ; }
@@ -1389,8 +1385,8 @@ lnet_nrb_small_calculate(int npages)if (small_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"small_router_buffers=%d invalid when " -"routing enabled\n" , small_router_buffers); +"small_router_buffers=%d invalid when routing enabled\n" , + small_router_buffers);return -1 ; }
@@ -1408,8 +1404,8 @@ lnet_nrb_large_calculate(int npages)if (large_router_buffers <0 ) {LCONSOLE_ERROR_MSG (0x10c , -"large_router_buffers=%d invalid when " -"routing enabled\n" , large_router_buffers); +"large_router_buffers=%d invalid when routing enabled\n" , + large_router_buffers);return -1 ; }
@@ -1442,8 +1438,7 @@ lnet_rtrpools_alloc(int im_a_router) }else if (!strcmp (forwarding,"enabled" )) {/* explicitly enabled */ }else { -LCONSOLE_ERROR_MSG (0x10b ,"'forwarding' not set to either " -"'enabled' or 'disabled'\n" ); +LCONSOLE_ERROR_MSG (0x10b ,"'forwarding' not set to either 'enabled' or 'disabled'\n" );return -EINVAL ; }
@@ -1520,11 +1515,10 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)/* can't do predictions... */ if (cfs_time_after (when, now)) { -CWARN ("Ignoring prediction from %s of %s %s " -"%ld seconds in the future\n" , - (ni ==NULL ) ?"userspace" :libcfs_nid2str (ni->ni_nid), -libcfs_nid2str (nid), alive ?"up" :"down" , -cfs_duration_sec (cfs_time_sub (when, now))); +CWARN ("Ignoring prediction from %s of %s %s %ld seconds in the future\n" , + (ni ==NULL ) ?"userspace" :libcfs_nid2str (ni->ni_nid), +libcfs_nid2str (nid), alive ?"up" :"down" , +cfs_duration_sec (cfs_time_sub (when, now)));return -EINVAL ; }
drivers/staging/lustre/lnet/lnet/router_proc.c +3 -6
@@ -791,20 +791,17 @@ static struct lnet_portal_rotors portal_rotors[] = { { .pr_value = LNET_PTL_ROTOR_ON, .pr_name = "ON", - .pr_desc ="round-robin dispatch all PUT messages for " -"wildcard portals" + .pr_desc ="round-robin dispatch all PUT messages for wildcard portals" }, { .pr_value = LNET_PTL_ROTOR_RR_RT, .pr_name = "RR_RT", - .pr_desc ="round-robin dispatch routed PUT message for " -"wildcard portals" + .pr_desc ="round-robin dispatch routed PUT message for wildcard portals" }, { .pr_value = LNET_PTL_ROTOR_HASH_RT, .pr_name = "HASH_RT", - .pr_desc ="dispatch routed PUT message by hashing source " -"NID for wildcard portals" + .pr_desc ="dispatch routed PUT message by hashing source NID for wildcard portals" }, { .pr_value = -1,
drivers/staging/lustre/lnet/selftest/console.c +2 -4
@@ -1208,8 +1208,7 @@ again:lstcon_rpc_trans_destroy (trans);/* return if any error */ -CDEBUG (D_NET ,"Failed to add test %s, " -"RPC error %d, framework error %d\n" , +CDEBUG (D_NET ,"Failed to add test %s, RPC error %d, framework error %d\n" , transop ==LST_TRANS_TSBCLIADD ?"client" :"server" ,lstcon_trans_stat ()->trs_rpc_errno,lstcon_trans_stat ()->trs_fwk_errno);
@@ -1885,8 +1884,7 @@ lstcon_session_feats_check(unsigned feats)spin_unlock (&console_session.ses_rpc_lock);if (rc !=0 ) { -CERROR ("remote features %x do not match with " -"session features %x of console\n" , +CERROR ("remote features %x do not match with session features %x of console\n" , feats, console_session.ses_features); }
drivers/staging/lustre/lnet/selftest/framework.c +9 -16
@@ -291,8 +291,7 @@ sfw_server_rpc_done(struct srpc_server_rpc *rpc)int status = rpc->srpc_status;CDEBUG (D_NET , -"Incoming framework RPC done: " -"service %s, peer %s, status %s:%d\n" , +"Incoming framework RPC done: service %s, peer %s, status %s:%d\n" , sv->sv_name,libcfs_id2str (rpc->srpc_peer),swi_state2str (rpc->srpc_wi.swi_state), status);
@@ -310,8 +309,7 @@ sfw_client_rpc_fini (srpc_client_rpc_t *rpc)LASSERT (atomic_read (&rpc->crpc_refcount) ==0 );CDEBUG (D_NET , -"Outgoing framework RPC done: " -"service %d, peer %s, status %s:%d:%d\n" , +"Outgoing framework RPC done: service %d, peer %s, status %s:%d:%d\n" , rpc->crpc_service,libcfs_id2str (rpc->crpc_dest),swi_state2str (rpc->crpc_wi.swi_state), rpc->crpc_aborted, rpc->crpc_status);
@@ -575,8 +573,8 @@ sfw_load_test(struct sfw_test_instance *tsi) rc =srpc_service_add_buffers (svc, nbuf);if (rc !=0 ) { -CWARN ("Failed to reserve enough buffers: " -"service %s, %d needed: %d\n" , svc->sv_name, nbuf, rc); +CWARN ("Failed to reserve enough buffers: service %s, %d needed: %d\n" , + svc->sv_name, nbuf, rc);/* NB: this error handler is not strictly correct, because * it may release more buffers than already allocated, * but it doesn't matter because request portal should
@@ -1270,8 +1268,7 @@ sfw_handle_server_rpc(struct srpc_server_rpc *rpc)if (sn !=NULL && sn->sn_features != request->msg_ses_feats) { -CNETERR ("Features of framework RPC don't match " -"features of current session: %x/%x\n" , +CNETERR ("Features of framework RPC don't match features of current session: %x/%x\n" , request->msg_ses_feats, sn->sn_features); reply->msg_body.reply.status =EPROTO ; reply->msg_body.reply.sid = sn->sn_id;
@@ -1348,8 +1345,7 @@ sfw_bulk_ready(struct srpc_server_rpc *rpc, int status)spin_lock (&sfw_data.fw_lock);if (status !=0 ) { -CERROR ("Bulk transfer failed for RPC: " -"service %s, peer %s, status %d\n" , +CERROR ("Bulk transfer failed for RPC: service %s, peer %s, status %d\n" , sv->sv_name,libcfs_id2str (rpc->srpc_peer), status);spin_unlock (&sfw_data.fw_lock);return -EIO ;
@@ -1664,12 +1660,10 @@ sfw_startup (void) }if (session_timeout ==0 ) -CWARN ("Zero session_timeout specified " -"- test sessions never expire.\n" ); +CWARN ("Zero session_timeout specified - test sessions never expire.\n" );if (rpc_timeout ==0 ) -CWARN ("Zero rpc_timeout specified " -"- test RPC never expire.\n" ); +CWARN ("Zero rpc_timeout specified - test RPC never expire.\n" );memset (&sfw_data,0 ,sizeof (struct smoketest_framework ));
@@ -1727,8 +1721,7 @@ sfw_startup (void) rc =srpc_service_add_buffers (sv, sv->sv_wi_total);if (rc !=0 ) { -CWARN ("Failed to reserve enough buffers: " -"service %s, %d needed: %d\n" , +CWARN ("Failed to reserve enough buffers: service %s, %d needed: %d\n" , sv->sv_name, sv->sv_wi_total, rc); error = -ENOMEM ; }
drivers/staging/lustre/lnet/selftest/module.c +2 -2
@@ -119,8 +119,8 @@ lnet_selftest_init(void) rc =cfs_wi_sched_create ("lst_t" ,lnet_cpt_table (), i, nthrs, &lst_sched_test[i]);if (rc !=0 ) { -CERROR ("Failed to create CPT affinity WI scheduler " -"%d for LST\n" , i); +CERROR ("Failed to create CPT affinity WI scheduler %d for LST\n" , + i); goto error; } }
drivers/staging/lustre/lnet/selftest/rpc.c +12 -17
@@ -678,9 +678,7 @@ srpc_finish_service(struct srpc_service *sv) rpc =list_entry (scd->scd_rpc_active.next, struct srpc_server_rpc, srpc_list); - CNETERR("Active RPC %p on shutdown: sv %s, peer %s, " - "wi %s scheduled %d running %d, " - "ev fired %d type %d status %d lnet %d\n", + CNETERR("Active RPC %p on shutdown: sv %s, peer %s, wi %s scheduled %d running %d, ev fired %d type %d status %d lnet %d\n", rpc, sv->sv_name, libcfs_id2str(rpc->srpc_peer), swi_state2str(rpc->srpc_wi.swi_state), rpc->srpc_wi.swi_workitem.wi_scheduled,
@@ -1236,20 +1234,18 @@ srpc_send_rpc (swi_workitem_t *wi)if (reply->msg_type != type || (reply->msg_magic !=SRPC_MSG_MAGIC && reply->msg_magic !=__swab32 (SRPC_MSG_MAGIC ))) { -CWARN ("Bad message from %s: type %u (%d expected)," -" magic %u (%d expected).\n" , -libcfs_id2str (rpc->crpc_dest), - reply->msg_type, type, - reply->msg_magic,SRPC_MSG_MAGIC ); +CWARN ("Bad message from %s: type %u (%d expected), magic %u (%d expected).\n" , +libcfs_id2str (rpc->crpc_dest), + reply->msg_type, type, + reply->msg_magic,SRPC_MSG_MAGIC ); rc = -EBADMSG ;break ; }if (do_bulk && reply->msg_body.reply.status !=0 ) { -CWARN ("Remote error %d at %s, unlink bulk buffer in " -"case peer didn't initiate bulk transfer\n" , - reply->msg_body.reply.status, -libcfs_id2str (rpc->crpc_dest)); +CWARN ("Remote error %d at %s, unlink bulk buffer in case peer didn't initiate bulk transfer\n" , + reply->msg_body.reply.status, +libcfs_id2str (rpc->crpc_dest));LNetMDUnlink (rpc->crpc_bulk.bk_mdh); }
@@ -1504,11 +1500,10 @@ srpc_lnet_ev_handler(lnet_event_t *ev) msg->msg_type != __swab32(type)) || (msg->msg_magic != SRPC_MSG_MAGIC && msg->msg_magic != __swab32(SRPC_MSG_MAGIC))) { -CERROR ("Dropping RPC (%s) from %s: " -"status %d mlength %d type %u magic %u.\n" , - sv->sv_name,libcfs_id2str (ev->initiator), - ev->status, ev->mlength, - msg->msg_type, msg->msg_magic); +CERROR ("Dropping RPC (%s) from %s: status %d mlength %d type %u magic %u.\n" , + sv->sv_name,libcfs_id2str (ev->initiator), + ev->status, ev->mlength, + msg->msg_type, msg->msg_magic);/* NB can't call srpc_service_recycle_buffer here since * it may call LNetM[DE]Attach. The invalid magic tells
drivers/staging/lustre/lustre/include/linux/obd.h +1 -2
@@ -87,8 +87,7 @@ static inline void __client_obd_list_lock(client_obd_lock_t *lock,if (task ==NULL )continue ; - LCONSOLE_WARN("%s:%d: lock %p was acquired" - " by <%s:%d:%s:%d> for %lu seconds.\n", + LCONSOLE_WARN("%s:%d: lock %p was acquired by <%s:%d:%s:%d> for %lu seconds.\n", current->comm, current->pid, lock, task->comm, task->pid, lock->func, lock->line,
drivers/staging/lustre/lustre/include/lustre_disk.h +1 -2
@@ -368,8 +368,7 @@ static inline void check_lcd(char *obd_name, int index,if (strnlen ((char *)lcd->lcd_uuid, length) == length) { lcd->lcd_uuid[length -1 ] ='\0' ; -LCONSOLE_ERROR ("the client UUID (%s) on %s for exports" -"stored in last_rcvd(index = %d) is bad!\n" , +LCONSOLE_ERROR ("the client UUID (%s) on %s for exports stored in last_rcvd(index = %d) is bad!\n" , lcd->lcd_uuid, obd_name, index); } }
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c +1 -2
@@ -619,8 +619,7 @@ ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)return 0 ; } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"sleeping" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, sleeping" ); fwd.fwd_lock = lock; obd =class_exp2obd (lock->l_conn_export);
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c +2 -2
@@ -858,8 +858,8 @@ void ldlm_dump_export_locks(struct obd_export *exp)if (!list_empty (&exp->exp_locks_list)) {struct ldlm_lock *lock; -CERROR ("dumping locks for export %p," -"ignore if the unmount doesn't hang\n" , exp); +CERROR ("dumping locks for export %p,ignore if the unmount doesn't hang\n" , + exp);list_for_each_entry (lock, &exp->exp_locks_list, l_exp_refs_link)LDLM_ERROR (lock,"lock:" );
drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +74 -94
222 lines not on this page · raw message
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +4 -7
@@ -210,9 +210,7 @@ static void ldlm_handle_cp_callback(struct ptlrpc_request *req,LASSERT (lock->l_lvb_data !=NULL );if (unlikely (lock->l_lvb_len < lvb_len)) { -LDLM_ERROR (lock,"Replied LVB is larger than " -"expectation, expected = %d, " -"replied = %d" , +LDLM_ERROR (lock,"Replied LVB is larger than expectation, expected = %d, replied = %d" , lock->l_lvb_len, lvb_len); rc = -EINVAL ; goto out;
@@ -639,8 +637,8 @@ static int ldlm_callback_handler(struct ptlrpc_request *req) lock =ldlm_handle2lock_long (&dlm_req->lock_handle[0 ],0 );if (!lock) { -CDEBUG (D_DLMTRACE ,"callback on lock %#llx - lock " -"disappeared\n" , dlm_req->lock_handle[0 ].cookie); +CDEBUG (D_DLMTRACE ,"callback on lock %#llx - lock disappeared\n" , + dlm_req->lock_handle[0 ].cookie); rc =ldlm_callback_reply (req, -EINVAL );ldlm_callback_errmsg (req,"Operate with invalid parameter" , rc, &dlm_req->lock_handle[0 ]);
@@ -663,8 +661,7 @@ static int ldlm_callback_handler(struct ptlrpc_request *req)if (((lock->l_flags &LDLM_FL_CANCELING ) && (lock->l_flags &LDLM_FL_BL_DONE )) || (lock->l_flags &LDLM_FL_FAILED )) { -LDLM_DEBUG (lock,"callback on lock " -"%#llx - lock disappeared\n" , +LDLM_DEBUG (lock,"callback on lock %#llx - lock disappeared\n" , dlm_req->lock_handle[0 ].cookie);unlock_res_and_lock (lock);LDLM_LOCK_RELEASE (lock);
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c +4 -6
@@ -614,8 +614,8 @@ int ldlm_pool_shrink(struct ldlm_pool *pl, int nr,lprocfs_counter_add (pl->pl_stats,LDLM_POOL_SHRINK_FREED_STAT , cancel); -CDEBUG (D_DLMTRACE ,"%s: request to shrink %d locks, " -"shrunk %d\n" , pl->pl_name, nr, cancel); +CDEBUG (D_DLMTRACE ,"%s: request to shrink %d locks, shrunk %d\n" , + pl->pl_name, nr, cancel); } }return cancel;
@@ -1194,10 +1194,8 @@ int ldlm_pools_recalc(ldlm_side_t client)* of limit. */ if (nr_l >=2 * (LDLM_POOL_HOST_L /3 )) { -CWARN ("\"Modest\" pools eat out 2/3 of server locks " -"limit (%d of %lu). This means that you have too " -"many clients for this amount of server RAM. " -"Upgrade server!\n" , nr_l,LDLM_POOL_HOST_L ); +CWARN ("\"Modest\" pools eat out 2/3 of server locks limit (%d of %lu). This means that you have too many clients for this amount of server RAM. Upgrade server!\n" , + nr_l,LDLM_POOL_HOST_L ); equal =1 ; }
drivers/staging/lustre/lustre/ldlm/ldlm_request.c +13 -24
@@ -102,9 +102,7 @@ int ldlm_expired_completion_wait(void *data) lock->l_last_activity,cfs_time_sub (get_seconds (), lock->l_last_activity)); -LDLM_DEBUG (lock,"lock timed out (enqueued at " CFS_TIME_T ", " -CFS_DURATION_T "s ago); not entering recovery in " -"server code, just going back to sleep" , +LDLM_DEBUG (lock,"lock timed out (enqueued at " CFS_TIME_T ", " CFS_DURATION_T "s ago); not entering recovery in server code, just going back to sleep" , lock->l_last_activity,cfs_time_sub (get_seconds (), lock->l_last_activity));
@@ -191,8 +189,7 @@ int ldlm_completion_ast_async(struct ldlm_lock *lock, __u64 flags, void *data)return ldlm_completion_tail (lock); } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"going forward" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, going forward" );ldlm_reprocess_all (lock->l_resource);return 0 ; }
@@ -240,8 +237,7 @@ int ldlm_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data)return 0 ; } -LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, " -"sleeping" ); +LDLM_DEBUG (lock,"client-side enqueue returned a blocked lock, sleeping" ); noreproc:
@@ -324,8 +320,7 @@ int ldlm_blocking_ast_nocheck(struct ldlm_lock *lock)if (rc <0 )CERROR ("ldlm_cli_cancel: %d\n" , rc); }else { -LDLM_DEBUG (lock,"Lock still has references, will be " -"cancelled later" ); +LDLM_DEBUG (lock,"Lock still has references, will be cancelled later" ); }return 0 ; }
@@ -483,8 +478,7 @@ static void failed_lock_cleanup(struct ldlm_namespace *ns,if (need_cancel)LDLM_DEBUG (lock, -"setting FL_LOCAL_ONLY | LDLM_FL_FAILED | " -"LDLM_FL_ATOMIC_CB | LDLM_FL_CBPENDING" ); +"setting FL_LOCAL_ONLY | LDLM_FL_FAILED | LDLM_FL_ATOMIC_CB | LDLM_FL_CBPENDING" );else LDLM_DEBUG (lock,"lock was granted or failed in race" );
@@ -557,8 +551,7 @@ int ldlm_cli_enqueue_fini(struct obd_export *exp, struct ptlrpc_request *req, rc = size; goto cleanup; }else if (unlikely (size > lvb_len)) { -LDLM_ERROR (lock,"Replied LVB is larger than " -"expectation, expected = %d, replied = %d" , +LDLM_ERROR (lock,"Replied LVB is larger than expectation, expected = %d, replied = %d" , lvb_len, size); rc = -EINVAL ; goto cleanup;
@@ -1107,8 +1100,7 @@ static __u64 ldlm_cli_cancel_local(struct ldlm_lock *lock)unlock_res_and_lock (lock);if (local_only) { -CDEBUG (D_DLMTRACE ,"not sending request (at caller's " -"instruction)\n" ); +CDEBUG (D_DLMTRACE ,"not sending request (at caller's instruction)\n" ); rc =LDLM_FL_LOCAL_ONLY ; }ldlm_lock_cancel (lock);
@@ -1223,8 +1215,7 @@ int ldlm_cli_cancel_req(struct obd_export *exp, struct list_head *cancels, rc =ptlrpc_queue_wait (req); }if (rc ==LUSTRE_ESTALE ) { -CDEBUG (D_DLMTRACE ,"client/server (nid %s) " -"out of sync -- not fatal\n" , +CDEBUG (D_DLMTRACE ,"client/server (nid %s) out of sync -- not fatal\n" ,libcfs_nid2str (req->rq_import-> imp_connection->c_peer.nid)); rc =0 ;
@@ -1235,8 +1226,8 @@ int ldlm_cli_cancel_req(struct obd_export *exp, struct list_head *cancels, }else if (rc !=ELDLM_OK ) {/* -ESHUTDOWN is common on umount */ CDEBUG_LIMIT (rc == -ESHUTDOWN ?D_DLMTRACE :D_ERROR , -"Got rc %d from cancel RPC: " -"canceling anyway\n" , rc); +"Got rc %d from cancel RPC: canceling anyway\n" , + rc);break ; } sent = count;
@@ -2114,8 +2105,7 @@ static int replay_lock_interpret(const struct lu_env *env, lock =ldlm_handle2lock (&aa->lock_handle);if (!lock) { -CERROR ("received replay ack for unknown local cookie %#llx" -" remote cookie %#llx from server %s id %s\n" , +CERROR ("received replay ack for unknown local cookie %#llx remote cookie %#llx from server %s id %s\n" , aa->lock_handle.cookie, reply->lock_handle.cookie, req->rq_export->exp_client_uuid.uuid,libcfs_id2str (req->rq_peer));
@@ -2243,9 +2233,8 @@ static void ldlm_cancel_unused_locks_for_replay(struct ldlm_namespace *ns)int canceled;LIST_HEAD (cancels); -CDEBUG (D_DLMTRACE ,"Dropping as many unused locks as possible before" -"replay for namespace %s (%d)\n" , -ldlm_ns_name (ns), ns->ns_nr_unused); +CDEBUG (D_DLMTRACE ,"Dropping as many unused locks as possible before replay for namespace %s (%d)\n" , +ldlm_ns_name (ns), ns->ns_nr_unused);/* We don't need to care whether or not LRU resize is enabled * because the LDLM_CANCEL_NO_WAIT policy doesn't use the
drivers/staging/lustre/lustre/ldlm/ldlm_resource.c +8 -11
@@ -215,8 +215,8 @@ static ssize_t lprocfs_lru_size_seq_write(struct file *file, LDLM_CANCEL_PASSED);if (canceled < unused) {CDEBUG (D_DLMTRACE , -"not all requested locks are canceled, " -"requested: %d, canceled: %d\n" , unused, +"not all requested locks are canceled, requested: %d, canceled: %d\n" , + unused, canceled);return -EINVAL ; }
@@ -735,8 +735,7 @@ static void cleanup_resource(struct ldlm_resource *res, struct list_head *q, }else {ldlm_resource_unlink_lock (lock);unlock_res (res); -LDLM_DEBUG (lock,"Freeing a lock still held by a " -"client node" ); +LDLM_DEBUG (lock,"Freeing a lock still held by a client node" );ldlm_lock_destroy (lock); }LDLM_LOCK_RELEASE (lock);
@@ -818,16 +817,14 @@ force_wait:/* Forced cleanups should be able to reclaim all references, * so it's safe to wait forever... we can't leak locks... */ if (force && rc == -ETIMEDOUT ) { -LCONSOLE_ERROR ("Forced cleanup waiting for %s " -"namespace with %d resources in use, " -"(rc=%d)\n" ,ldlm_ns_name (ns), +LCONSOLE_ERROR ("Forced cleanup waiting for %s namespace with %d resources in use, (rc=%d)\n" , +ldlm_ns_name (ns),atomic_read (&ns->ns_bref), rc); goto force_wait; }if (atomic_read (&ns->ns_bref)) { -LCONSOLE_ERROR ("Cleanup waiting for %s namespace " -"with %d resources in use, (rc=%d)\n" , +LCONSOLE_ERROR ("Cleanup waiting for %s namespace with %d resources in use, (rc=%d)\n" ,ldlm_ns_name (ns),atomic_read (&ns->ns_bref), rc);return ELDLM_NAMESPACE_EXISTS ;
@@ -1404,8 +1401,8 @@ void ldlm_resource_dump(int level, struct ldlm_resource *res)LDLM_DEBUG_LIMIT (level, lock,"###" );if (!(level &D_CANTMASK ) && ++granted > ldlm_dump_granted_max) { -CDEBUG (level,"only dump %d granted locks to " -"avoid DDOS.\n" , granted); +CDEBUG (level,"only dump %d granted locks to avoid DDOS.\n" , + granted);break ; } }
drivers/staging/lustre/lustre/libcfs/debug.c +3 -5
@@ -318,9 +318,7 @@ libcfs_debug_str2mask(int *mask, const char *str, int is_subsys)if (t >=1 && matched == n) {/* don't print warning for lctl set_param debug=0 or -1 */ if (m !=0 && m !=-1 ) -CWARN ("You are trying to use a numerical value for the " -"mask - this will be deprecated in a future " -"release.\n" ); +CWARN ("You are trying to use a numerical value for the mask - this will be deprecated in a future release.\n" ); *mask = m;return 0 ; }
@@ -375,8 +373,8 @@ void libcfs_debug_dumplog(void) (void *)(long )current_pid (), "libcfs_debug_dumper");if (IS_ERR (dumper)) -pr_err ("LustreError: cannot start log dump thread:" -" %ld\n" ,PTR_ERR (dumper)); +pr_err ("LustreError: cannot start log dump thread: %ld\n" , +PTR_ERR (dumper));else schedule ();
drivers/staging/lustre/lustre/libcfs/hash.c +1 -2
@@ -1121,8 +1121,7 @@ cfs_hash_destroy(struct cfs_hash *hs)cfs_hash_bd_for_each_hlist (hs, &bd, hhead) {hlist_for_each_safe (hnode, pos, hhead) {LASSERTF (!cfs_hash_with_assert_empty (hs), -"hash %s bucket %u(%u) is not " -" empty: %u items left\n" , +"hash %s bucket %u(%u) is not empty: %u items left\n" , hs->hs_name, bd.bd_bucket->hsb_index, bd.bd_offset, bd.bd_bucket->hsb_count);/* can't assert key valicate, because we
drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c +12 -20
@@ -333,8 +333,8 @@ cfs_cpt_unset_cpu(struct cfs_cpt_table *cptab, int cpt, int cpu)/* caller doesn't know the partition ID */ cpt = cptab->ctb_cpu2cpt[cpu];if (cpt <0 ) {/* not set in this CPT-table */ -CDEBUG (D_INFO ,"Try to unset cpu %d which is " -"not in CPT-table %p\n" , cpt, cptab); +CDEBUG (D_INFO ,"Try to unset cpu %d which is not in CPT-table %p\n" , + cpt, cptab);return ; }
@@ -384,8 +384,8 @@ cfs_cpt_set_cpumask(struct cfs_cpt_table *cptab, int cpt, cpumask_t *mask)int i;if (cpus_weight (*mask) ==0 ||any_online_cpu (*mask) ==NR_CPUS ) { -CDEBUG (D_INFO ,"No online CPU is found in the CPU mask " -"for CPU partition %d\n" , cpt); +CDEBUG (D_INFO ,"No online CPU is found in the CPU mask for CPU partition %d\n" , + cpt);return 0 ; }
@@ -579,9 +579,8 @@ cfs_cpt_bind(struct cfs_cpt_table *cptab, int cpt) }if (any_online_cpu (*cpumask) ==NR_CPUS ) { -CERROR ("No online CPU found in CPU partition %d, did someone " -"do CPU hotplug on system? You might need to reload " -"Lustre modules to keep system working well.\n" , cpt); +CERROR ("No online CPU found in CPU partition %d, did someone do CPU hotplug on system? You might need to reload Lustre modules to keep system working well.\n" , + cpt);return -EINVAL ; }
@@ -737,16 +736,12 @@ cfs_cpt_table_create(int ncpt) ncpt = rc;if (ncpt >num_online_cpus () || ncpt >4 * rc) { -CWARN ("CPU partition number %d is larger than suggested " -"value (%d), your system may have performance" -"issue or run out of memory while under pressure\n" , +CWARN ("CPU partition number %d is larger than suggested value (%d), your system may have performance issue or run out of memory while under pressure\n" , ncpt, rc); }if (num_online_cpus () % ncpt !=0 ) { -CERROR ("CPU number %d is not multiple of cpu_npartition %d, " -"please try different cpu_npartitions value or" -"set pattern string by cpu_pattern=STRING\n" , +CERROR ("CPU number %d is not multiple of cpu_npartition %d, please try different cpu_npartitions value or set pattern string by cpu_pattern=STRING\n" , (int )num_online_cpus (), ncpt); goto failed; }
@@ -796,8 +791,7 @@ cfs_cpt_table_create(int ncpt)if (cpt != ncpt || num !=cpus_weight (*cptab->ctb_parts[ncpt -1 ].cpt_cpumask)) { -CERROR ("Expect %d(%d) CPU partitions but got %d(%d), " -"CPU hotplug/unplug while setting?\n" , +CERROR ("Expect %d(%d) CPU partitions but got %d(%d), CPU hotplug/unplug while setting?\n" , cptab->ctb_nparts, num, cpt,cpus_weight (*cptab->ctb_parts[ncpt -1 ].cpt_cpumask)); goto failed;
@@ -808,8 +802,7 @@ cfs_cpt_table_create(int ncpt)return cptab; failed: -CERROR ("Failed to setup CPU-partition-table with %d " -"CPU-partitions, online HW nodes: %d, HW cpus: %d.\n" , +CERROR ("Failed to setup CPU-partition-table with %d CPU-partitions, online HW nodes: %d, HW cpus: %d.\n" , ncpt,num_online_nodes (),num_online_cpus ());if (mask !=NULL )
@@ -975,9 +968,8 @@ cfs_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu) warn =any_online_cpu (*cpt_data.cpt_cpumask) >= nr_cpu_ids;mutex_unlock (&cpt_data.cpt_mutex);CDEBUG (warn ?D_WARNING :D_INFO , -"Lustre: can't support CPU plug-out well now, " -"performance and stability could be impacted " -"[CPU %u action: %lx]\n" , cpu, action); +"Lustre: can't support CPU plug-out well now, performance and stability could be impacted [CPU %u action: %lx]\n" , + cpu, action); }return NOTIFY_OK ;
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c +2 -4
@@ -87,8 +87,7 @@ void libcfs_run_debug_log_upcall(char *file) rc =call_usermodehelper (argv[0 ], argv, envp,1 );if (rc <0 && rc != -ENOENT ) { -CERROR ("Error %d invoking LNET debug log upcall %s %s; " -"check /proc/sys/lnet/debug_log_upcall\n" , +CERROR ("Error %d invoking LNET debug log upcall %s %s; check /proc/sys/lnet/debug_log_upcall\n" , rc, argv[0 ], argv[1 ]); }else { CDEBUG(D_HA, "Invoked LNET debug log upcall %s %s\n",
@@ -114,8 +113,7 @@ void libcfs_run_upcall(char **argv) rc =call_usermodehelper (argv[0 ], argv, envp,1 );if (rc <0 && rc != -ENOENT ) { - CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; " - "check /proc/sys/lnet/upcall\n", + CERROR("Error %d invoking LNET upcall %s %s%s%s%s%s%s%s%s; check /proc/sys/lnet/upcall\n", rc, argv[0], argv[1], argc < 3 ? "" : ",", argc < 3 ? "" : argv[2], argc < 4 ? "" : ",", argc < 4 ? "" : argv[3],
drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c +1 -2
@@ -279,8 +279,7 @@ libcfs_sock_write (struct socket *sock, void *buffer, int nob, int timeout) rc =kernel_setsockopt (sock,SOL_SOCKET ,SO_SNDTIMEO , (char *)&tv,sizeof (tv));if (rc !=0 ) { -CERROR ("Can't set socket send timeout " -"%ld.%06d: %d\n" , +CERROR ("Can't set socket send timeout %ld.%06d: %d\n" , (long )tv.tv_sec, (int )tv.tv_usec, rc);return rc; }
drivers/staging/lustre/lustre/libcfs/tracefile.c +18 -20
@@ -196,8 +196,7 @@ static void cfs_tcd_shrink(struct cfs_trace_cpu_data *tcd)*/ if (printk_ratelimit ()) -printk (KERN_WARNING "debug daemon buffer overflowed; " -"discarding 10%% of pages (%d of %ld)\n" , +printk (KERN_WARNING "debug daemon buffer overflowed; discarding 10%% of pages (%d of %ld)\n" , pgcount +1 , tcd->tcd_cur_pages);INIT_LIST_HEAD (&pc.pc_pages);
@@ -357,8 +356,8 @@ int libcfs_debug_vmsg2(struct libcfs_debug_msg_data *msgdata, }if (*(string_buf+needed-1 ) !='\n' ) -printk (KERN_INFO "format at %s:%d:%s doesn't end in " -"newline\n" , file, msgdata->msg_line, msgdata->msg_fn); +printk (KERN_INFO "format at %s:%d:%s doesn't end in newline\n" , + file, msgdata->msg_line, msgdata->msg_fn); header.ph_len = known_size + needed; debug_buf = (char *)page_address (tage->page) + tage->used;
@@ -715,8 +714,8 @@ int cfs_tracefile_dump_all_pages(char *filename)kunmap (tage->page);if (rc != (int )tage->used) { -printk (KERN_WARNING "wanted to write %u but wrote " -"%d\n" , tage->used, rc); +printk (KERN_WARNING "wanted to write %u but wrote %d\n" , + tage->used, rc);put_pages_back (&pc);__LASSERT (list_empty (&pc.pc_pages));break ;
@@ -875,8 +874,8 @@ int cfs_trace_daemon_command(char *str)strcpy (cfs_tracefile, str);printk (KERN_INFO -"Lustre: debug daemon will attempt to start writing " -"to %s (%lukB max)\n" , cfs_tracefile, +"Lustre: debug daemon will attempt to start writing to %s (%lukB max)\n" , + cfs_tracefile, (long )(cfs_tracefile_size >>10 ));cfs_trace_start_thread ();
@@ -914,15 +913,15 @@ int cfs_trace_set_debug_mb(int mb)if (mb <num_possible_cpus ()) {printk (KERN_WARNING -"Lustre: %d MB is too small for debug buffer size, " -"setting it to %d MB.\n" , mb,num_possible_cpus ()); +"Lustre: %d MB is too small for debug buffer size, setting it to %d MB.\n" , + mb,num_possible_cpus ()); mb =num_possible_cpus (); }if (mb > limit) {printk (KERN_WARNING -"Lustre: %d MB is too large for debug buffer size, " -"setting it to %d MB.\n" , mb, limit); +"Lustre: %d MB is too large for debug buffer size, setting it to %d MB.\n" , + mb, limit); mb = limit; }
@@ -1004,8 +1003,8 @@ static int tracefiled(void *arg)if (IS_ERR (filp)) { rc =PTR_ERR (filp); filp =NULL ; -printk (KERN_WARNING "couldn't open %s: " -"%d\n" , cfs_tracefile, rc); +printk (KERN_WARNING "couldn't open %s: %d\n" , + cfs_tracefile, rc); } }cfs_tracefile_read_unlock ();
@@ -1034,8 +1033,8 @@ static int tracefiled(void *arg)kunmap (tage->page);if (rc != (int )tage->used) { -printk (KERN_WARNING "wanted to write %u " -"but wrote %d\n" , tage->used, rc); +printk (KERN_WARNING "wanted to write %u but wrote %d\n" , + tage->used, rc);put_pages_back (&pc);__LASSERT (list_empty (&pc.pc_pages)); }
@@ -1047,8 +1046,7 @@ static int tracefiled(void *arg)if (!list_empty (&pc.pc_pages)) {int i; -printk (KERN_ALERT "Lustre: trace pages aren't " -" empty\n" ); +printk (KERN_ALERT "Lustre: trace pages aren't empty\n" );printk (KERN_ERR "total cpus(%d): " ,num_possible_cpus ());for (i =0 ; i <num_possible_cpus (); i++)
@@ -1061,8 +1059,8 @@ static int tracefiled(void *arg) i =0 ;list_for_each_entry_safe (tage, tmp, &pc.pc_pages, linkage) -printk (KERN_ERR "page %d belongs to cpu " -"%d\n" , ++i, tage->cpu); +printk (KERN_ERR "page %d belongs to cpu %d\n" , + ++i, tage->cpu);printk (KERN_ERR "There are %d pages unwritten\n" , i); }
drivers/staging/lustre/lustre/llite/dcache.c +3 -3
@@ -259,9 +259,9 @@ void ll_invalidate_aliases(struct inode *inode)ll_lock_dcache (inode);ll_d_hlist_for_each_entry (dentry, p, &inode->i_dentry, d_alias) { -CDEBUG (D_DENTRY ,"dentry in drop %.*s (%p) parent %p " -"inode %p flags %d\n" , dentry->d_name.len, - dentry->d_name.name, dentry, dentry->d_parent, +CDEBUG (D_DENTRY ,"dentry in drop %.*s (%p) parent %p inode %p flags %d\n" , + dentry->d_name.len, dentry->d_name.name, + dentry, dentry->d_parent, dentry->d_inode, dentry->d_flags);if (unlikely (dentry == dentry->d_sb->s_root)) {
drivers/staging/lustre/lustre/llite/dir.c +11 -14
@@ -228,8 +228,8 @@ static int ll_dir_filler(void *_hash, struct page *page0)if (ll_pagevec_add (&lru_pvec, page) ==0 )ll_pagevec_lru_add_file (&lru_pvec); }else { -CDEBUG (D_VFSTRACE ,"page %lu add to page cache failed:" -" %d\n" , offset, ret); +CDEBUG (D_VFSTRACE ,"page %lu add to page cache failed: %d\n" , + offset, ret); }page_cache_release (page); }
@@ -600,8 +600,8 @@ static int ll_readdir(struct file *filp, struct dir_context *ctx)int api32 =ll_need_32bit_api (sbi);int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:inode=%lu/%u(%p) pos %lu/%llu " -" 32bit_api %d\n" , inode->i_ino, inode->i_generation, +CDEBUG (D_VFSTRACE ,"VFS Op:inode=%lu/%u(%p) pos %lu/%llu 32bit_api %d\n" , + inode->i_ino, inode->i_generation, inode, (unsigned long )lfd->lfd_pos,i_size_read (inode), api32);if (lfd->lfd_pos ==MDS_DIR_END_OFF ) {
@@ -715,10 +715,9 @@ int ll_dir_setstripe(struct inode *inode, struct lov_user_md *lump,break ; }default : { -CDEBUG (D_IOCTL ,"bad userland LOV MAGIC:" -" %#08x != %#08x nor %#08x\n" , - lump->lmm_magic,LOV_USER_MAGIC_V1 , -LOV_USER_MAGIC_V3 ); +CDEBUG (D_IOCTL ,"bad userland LOV MAGIC: %#08x != %#08x nor %#08x\n" , + lump->lmm_magic,LOV_USER_MAGIC_V1 , +LOV_USER_MAGIC_V3 );return -EINVAL ; } }
@@ -814,8 +813,8 @@ int ll_dir_getstripe(struct inode *inode, struct lov_mds_md **lmmp, rc =md_getattr (sbi->ll_md_exp, op_data, &req);ll_finish_md_op_data (op_data);if (rc <0 ) { -CDEBUG (D_INFO ,"md_getattr failed on inode " -"%lu/%u: rc %d\n" , inode->i_ino, +CDEBUG (D_INFO ,"md_getattr failed on inode %lu/%u: rc %d\n" , + inode->i_ino, inode->i_generation, rc); goto out; }
@@ -1013,8 +1012,7 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy) copy->hc_hai.hai_action == HSMA_ARCHIVE);iput (inode);if (rc) { -CDEBUG (D_HSM ,"Could not read file data version. " -"Request could not be confirmed.\n" ); +CDEBUG (D_HSM ,"Could not read file data version. Request could not be confirmed.\n" );if (hpk.hpk_errval ==0 ) hpk.hpk_errval = -rc; goto progress;
@@ -1028,8 +1026,7 @@ static int ll_ioc_copy_end(struct super_block *sb, struct hsm_copy *copy)* to check anyway. */ if ((copy->hc_hai.hai_action ==HSMA_ARCHIVE ) && (copy->hc_data_version != data_version)) { -CDEBUG (D_HSM ,"File data version mismatched. " -"File content was changed during archiving. " +CDEBUG (D_HSM ,"File data version mismatched. File content was changed during archiving. " DFID ", start:%#llx current:%#llx\n" ,PFID (©->hc_hai.hai_fid), copy->hc_data_version, data_version);
drivers/staging/lustre/lustre/llite/file.c +8 -8
@@ -170,8 +170,8 @@ static int ll_close_inode_openhandle(struct obd_export *md_exp,* OSTs and send setattr to back to MDS. */ rc =ll_som_update (inode, op_data);if (rc) { -CERROR ("inode %lu mdc Size-on-MDS update failed: " -"rc = %d\n" , inode->i_ino, rc); +CERROR ("inode %lu mdc Size-on-MDS update failed: rc = %d\n" , + inode->i_ino, rc); rc =0 ; } }else if (rc) {
@@ -989,8 +989,8 @@ int ll_inode_getattr(struct inode *inode, struct obdo *obdo,struct ost_id *oi = lsm ? &lsm->lsm_oi : &obdo->o_oi;obdo_refresh_inode (inode, obdo, obdo->o_valid); -CDEBUG (D_INODE ,"objid " DOSTID " size %llu, blocks %llu," -" blksize %lu\n" ,POSTID (oi),i_size_read (inode), +CDEBUG (D_INODE ,"objid " DOSTID " size %llu, blocks %llu, blksize %lu\n" , +POSTID (oi),i_size_read (inode), (unsigned long long )inode->i_blocks,1UL << inode->i_blkbits); }
@@ -1418,8 +1418,8 @@ int ll_lov_getstripe_ea_info(struct inode *inode, const char *filename, rc =md_getattr_name (sbi->ll_md_exp, op_data, &req);ll_finish_md_op_data (op_data);if (rc <0 ) { -CDEBUG (D_INFO ,"md_getattr_name failed " -"on %s: rc %d\n" , filename, rc); +CDEBUG (D_INFO ,"md_getattr_name failed on %s: rc %d\n" , + filename, rc); goto out; }
@@ -2233,8 +2233,8 @@ ll_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg)if (cmd ==LL_IOC_SETFLAGS ) {if ((flags &LL_FILE_IGNORE_LOCK ) && !(file->f_flags &O_DIRECT )) { -CERROR ("%s: unable to disable locking on " -"non-O_DIRECT file\n" , current->comm); +CERROR ("%s: unable to disable locking on non-O_DIRECT file\n" , + current->comm);return -EINVAL ; }
drivers/staging/lustre/lustre/llite/llite_capa.c +1 -2
@@ -540,8 +540,7 @@ static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa)if (rc == -EIO && !capa_is_expired (ocapa)) {delay_capa_renew (ocapa,120 );DEBUG_CAPA (D_ERROR , &ocapa->c_capa, -"renewal failed: -EIO, " -"retry in 2 mins" ); +"renewal failed: -EIO, retry in 2 mins" ); ll_capa_renewal_retries++; goto retry; }else {
drivers/staging/lustre/lustre/llite/llite_close.c +7 -9
@@ -90,8 +90,7 @@ void ll_queue_done_writing(struct inode *inode, unsigned long flags)struct ll_close_queue *lcq =ll_i2sbi (inode)->ll_lcq;if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CWARN ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , +CWARN ("ino %lu/%u(flags %u) som valid it just after recovery\n" , inode->i_ino, inode->i_generation, lli->lli_flags);/* DONE_WRITING is allowed and inode has no dirty page. */
@@ -124,8 +123,8 @@ void ll_done_writing_attr(struct inode *inode, struct md_op_data *op_data) op_data->op_flags |=MF_SOM_CHANGE ;/* Check if Size-on-MDS attributes are valid. */ if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CERROR ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , inode->i_ino, inode->i_generation, +CERROR ("ino %lu/%u(flags %u) som valid it just after recovery\n" , + inode->i_ino, inode->i_generation, lli->lli_flags);if (!cl_local_size (inode)) {
@@ -218,8 +217,8 @@ int ll_som_update(struct inode *inode, struct md_op_data *op_data)LASSERT (op_data !=NULL );if (lli->lli_flags &LLIF_MDS_SIZE_LOCK ) -CERROR ("ino %lu/%u(flags %u) som valid it just after " -"recovery\n" , inode->i_ino, inode->i_generation, +CERROR ("ino %lu/%u(flags %u) som valid it just after recovery\n" , + inode->i_ino, inode->i_generation, lli->lli_flags);OBDO_ALLOC (oa);
@@ -238,9 +237,8 @@ int ll_som_update(struct inode *inode, struct md_op_data *op_data)if (rc) { oa->o_valid =0 ;if (rc != -ENOENT ) -CERROR ("inode_getattr failed (%d): unable to " -"send a Size-on-MDS attribute update " -"for inode %lu/%u\n" , rc, inode->i_ino, +CERROR ("inode_getattr failed (%d): unable to send a Size-on-MDS attribute update for inode %lu/%u\n" , + rc, inode->i_ino, inode->i_generation); }else { CDEBUG(D_INODE, "Size-on-MDS update on "DFID"\n",
drivers/staging/lustre/lustre/llite/llite_internal.h +6 -6
@@ -1435,8 +1435,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode,* case the dcache being cleared */ if (it->d.lustre.it_remote_lock_mode) { handle.cookie = it->d.lustre.it_remote_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode %p" -"(%lu/%u) for remote lock %#llx\n" , inode, +CDEBUG (D_DLMTRACE ,"setting l_data to inode %p(%lu/%u) for remote lock %#llx\n" , + inode, inode->i_ino, inode->i_generation, handle.cookie);md_set_lock_data (exp, &handle.cookie, inode,NULL );
@@ -1444,8 +1444,8 @@ static inline void ll_set_lock_data(struct obd_export *exp, struct inode *inode, handle.cookie = it->d.lustre.it_lock_handle; -CDEBUG (D_DLMTRACE ,"setting l_data to inode %p (%lu/%u)" -" for lock %#llx\n" , inode, inode->i_ino, +CDEBUG (D_DLMTRACE ,"setting l_data to inode %p (%lu/%u) for lock %#llx\n" , + inode, inode->i_ino, inode->i_generation, handle.cookie); md_set_lock_data(exp, &handle.cookie, inode,
@@ -1489,8 +1489,8 @@ static inline void __d_lustre_invalidate(struct dentry *dentry)*/ static inline void d_lustre_invalidate (struct dentry *dentry,int nested) { -CDEBUG (D_DENTRY ,"invalidate dentry %.*s (%p) parent %p inode %p " -"refc %d\n" , dentry->d_name.len, dentry->d_name.name, dentry, +CDEBUG (D_DENTRY ,"invalidate dentry %.*s (%p) parent %p inode %p refc %d\n" , + dentry->d_name.len, dentry->d_name.name, dentry, dentry->d_parent, dentry->d_inode,d_count (dentry)); spin_lock_nested(&dentry->d_lock,
drivers/staging/lustre/lustre/llite/llite_lib.c +22 -36
142 lines not on this page · raw message
drivers/staging/lustre/lustre/llite/llite_mmap.c +3 -6
@@ -234,8 +234,7 @@ static int ll_page_mkwrite0(struct vm_area_struct *vma, struct page *vmpage,*/ unlock_page (vmpage); -CDEBUG (D_MMAP ,"Race on page_mkwrite %p/%lu, page has " -"been written out, retry.\n" , +CDEBUG (D_MMAP ,"Race on page_mkwrite %p/%lu, page has been written out, retry.\n" , vmpage, vmpage->index); *retry = true;
@@ -366,8 +365,7 @@ restart: vmf->page =NULL ;if (!printed && ++count >16 ) { -CWARN ("the page is under heavy contention," -"maybe your app(%s) needs revising :-)\n" , +CWARN ("the page is under heavy contention, maybe your app(%s) needs revising :-)\n" , current->comm); printed = true; }
@@ -393,8 +391,7 @@ static int ll_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) result =ll_page_mkwrite0 (vma, vmf->page, &retry);if (!printed && ++count >16 ) { -CWARN ("app(%s): the page %lu of file %lu is under heavy" -" contention.\n" , +CWARN ("app(%s): the page %lu of file %lu is under heavy contention.\n" , current->comm, vmf->pgoff, vma->vm_file->f_dentry->d_inode->i_ino); printed = true;
drivers/staging/lustre/lustre/llite/llite_rmtacl.c +3 -4
@@ -131,8 +131,8 @@ int rct_add(struct rmtacl_ctl_table *rct, pid_t key, int ops)spin_lock (&rct->rct_lock); e =__rct_search (rct, key);if (unlikely (e !=NULL )) { -CWARN ("Unexpected stale rmtacl_entry found: " -"[key: %d] [ops: %d]\n" , (int )key, ops); +CWARN ("Unexpected stale rmtacl_entry found: [key: %d] [ops: %d]\n" , + (int )key, ops);rce_free (e); }list_add_tail (&rce->rce_list, &rct->rct_entries[rce_hashfunc (key)]);
@@ -263,8 +263,7 @@ int ee_add(struct eacl_table *et, pid_t key, struct lu_fid *fid, int type,spin_lock (&et->et_lock); e =__et_search_del (et, key, fid, type);if (unlikely (e !=NULL )) { -CWARN ("Unexpected stale eacl_entry found: " -"[key: %d] [fid: " DFID "] [type: %d]\n" , +CWARN ("Unexpected stale eacl_entry found: [key: %d] [fid: " DFID "] [type: %d]\n" , (int )key,PFID (fid), type);ee_free (e); }
drivers/staging/lustre/lustre/llite/lloop.c +2 -2
@@ -778,8 +778,8 @@ static int __init lloop_init(void)if (max_loop <1 || max_loop >256 ) { max_loop =MAX_LOOP_DEFAULT ; -CWARN ("lloop: invalid max_loop (must be between" -" 1 and 256), using default (%u)\n" , max_loop); +CWARN ("lloop: invalid max_loop (must be between 1 and 256), using default (%u)\n" , + max_loop); } lloop_major =register_blkdev (0 ,"lloop" );
drivers/staging/lustre/lustre/llite/lproc_llite.c +12 -17
@@ -284,8 +284,7 @@ static ssize_t ll_max_readahead_per_file_mb_seq_write(struct file *file,if (pages_number <0 || pages_number > sbi->ll_ra_info.ra_max_pages) { -CERROR ("can't set file readahead more than" -"max_read_ahead_mb %lu MB\n" , +CERROR ("can't set file readahead more than max_read_ahead_mb %lu MB\n" , sbi->ll_ra_info.ra_max_pages);return -ERANGE ; }
@@ -330,9 +329,8 @@ static ssize_t ll_max_read_ahead_whole_mb_seq_write(struct file *file,* algorithm does this anyway so it's pointless to set it larger. */ if (pages_number <0 || pages_number > sbi->ll_ra_info.ra_max_pages_per_file) { -CERROR ("can't set max_read_ahead_whole_mb more than " -"max_read_ahead_per_file_mb: %lu\n" , - sbi->ll_ra_info.ra_max_pages_per_file >> (20 -PAGE_CACHE_SHIFT )); +CERROR ("can't set max_read_ahead_whole_mb more than max_read_ahead_per_file_mb: %lu\n" , + sbi->ll_ra_info.ra_max_pages_per_file >> (20 -PAGE_CACHE_SHIFT ));return -ERANGE ; }
@@ -619,8 +617,8 @@ static ssize_t ll_statahead_max_seq_write(struct file *file,if (val >=0 && val <=LL_SA_RPC_MAX ) sbi->ll_sa_max = val;else -CERROR ("Bad statahead_max value %d. Valid values are in the " -"range [0, %d]\n" , val,LL_SA_RPC_MAX ); +CERROR ("Bad statahead_max value %d. Valid values are in the range [0, %d]\n" , + val,LL_SA_RPC_MAX );return count; }
@@ -770,8 +768,8 @@ static int ll_sbi_flags_seq_show(struct seq_file *m, void *v)while (flags !=0 ) {if (ARRAY_SIZE (str) <= i) { -CERROR ("%s: Revise array LL_SBI_FLAGS to match sbi " -"flags please.\n" ,ll_get_fsname (sb,NULL ,0 )); +CERROR ("%s: Revise array LL_SBI_FLAGS to match sbi flags please.\n" , +ll_get_fsname (sb,NULL ,0 ));return -EINVAL ; }
@@ -1143,8 +1141,8 @@ static void ll_display_extents_info(struct ll_rw_extents_info *io_extents, read_cum += r; write_cum += w; end =1 << (i +LL_HIST_START - units); -seq_printf (seq,"%4lu%c - %4lu%c%c: %14lu %4lu %4lu | " -"%14lu %4lu %4lu\n" , start, *unitp, end, *unitp, +seq_printf (seq,"%4lu%c - %4lu%c%c: %14lu %4lu %4lu | %14lu %4lu %4lu\n" , + start, *unitp, end, *unitp, (i ==LL_HIST_MAX -1 ) ?'+' :' ' , r,pct (r, read_tot),pct (read_cum, read_tot), w,pct (w, write_tot),pct (write_cum, write_tot));
@@ -1170,8 +1168,7 @@ static int ll_rw_extents_stats_pp_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; } seq_printf(seq, "snapshot_time: %lu.%lu (secs.usecs)\n",
@@ -1249,8 +1246,7 @@ static int ll_rw_extents_stats_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; } seq_printf(seq, "snapshot_time: %lu.%lu (secs.usecs)\n",
@@ -1428,8 +1424,7 @@ static int ll_rw_offset_stats_seq_show(struct seq_file *seq, void *v)if (!sbi->ll_rw_stats_on) {seq_printf (seq,"disabled\n" -"write anything in this file to activate, " -"then 0 or \"[D/d]isabled\" to deactivate\n" ); +"write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n" );return 0 ; }spin_lock (&sbi->ll_process_lock);
drivers/staging/lustre/lustre/llite/namei.c +6 -8
@@ -104,8 +104,8 @@ static int ll_set_inode(struct inode *inode, void *opaque) lli->lli_fid = body->fid1;if (unlikely (!(body->valid &OBD_MD_FLTYPE ))) { -CERROR ("Can not initialize inode " DFID " without object type: " -"valid = %#llx\n" ,PFID (&lli->lli_fid), body->valid); +CERROR ("Can not initialize inode " DFID " without object type: valid = %#llx\n" , +PFID (&lli->lli_fid), body->valid);return -EINVAL ; }
@@ -619,8 +619,7 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry,long long lookup_flags =LOOKUP_OPEN ;int rc =0 ; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%.*s,dir=%lu/%u(%p),file %p," -"open_flags %x,mode %x opened %d\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:name=%.*s,dir=%lu/%u(%p),file %p,open_flags %x,mode %x opened %d\n" , dentry->d_name.len, dentry->d_name.name, dir->i_ino, dir->i_generation, dir, file, open_flags, mode, *opened);
@@ -863,8 +862,7 @@ static int ll_create_nd(struct inode *dir, struct dentry *dentry, {int rc; -CDEBUG (D_VFSTRACE ,"VFS Op:name=%.*s,dir=%lu/%u(%p)," -"flags=%u, excl=%d\n" , +CDEBUG (D_VFSTRACE ,"VFS Op:name=%.*s,dir=%lu/%u(%p),flags=%u, excl=%d\n" , dentry->d_name.len, dentry->d_name.name, dir->i_ino, dir->i_generation, dir, mode, want_excl);
@@ -1151,8 +1149,8 @@ static int ll_rename_generic(struct inode *src, struct dentry *src_dparent,int err;CDEBUG (D_VFSTRACE , -"VFS Op:oldname=%.*s,src_dir=%lu/%u(%p),newname=%.*s," -"tgt_dir=%lu/%u(%p)\n" , src_name->len, src_name->name, +"VFS Op:oldname=%.*s,src_dir=%lu/%u(%p),newname=%.*s,tgt_dir=%lu/%u(%p)\n" , + src_name->len, src_name->name, src->i_ino, src->i_generation, src, tgt_name->len, tgt_name->name, tgt->i_ino, tgt->i_generation, tgt);
drivers/staging/lustre/lustre/llite/rw.c +10 -10
@@ -121,8 +121,8 @@ static struct ll_cl_context *ll_cl_init(struct file *file,/* this is too bad. Someone is trying to write the * page w/o holding inode mutex. This means we can * add dirty pages into cache during truncate */ -CERROR ("Proc %s is dirting page w/o inode lock, this" -"will break truncate.\n" , current->comm); +CERROR ("Proc %s is dirtying page w/o inode lock, this will break truncate\n" , + current->comm);dump_stack ();LBUG ();return ERR_PTR (-EIO );
@@ -606,8 +606,8 @@ stride_pg_count(pgoff_t st_off, unsigned long st_len, unsigned long st_pgs,else pg_count = start_left + st_pgs * (end - start -1 ) + end_left; -CDEBUG (D_READA ,"st_off %lu, st_len %lu st_pgs %lu off %lu length %lu" -"pgcount %lu\n" , st_off, st_len, st_pgs, off, length, pg_count); +CDEBUG (D_READA ,"st_off %lu, st_len %lu st_pgs %lu off %lu length %lu pgcount %lu\n" , + st_off, st_len, st_pgs, off, length, pg_count);return pg_count; }
@@ -667,10 +667,10 @@ static int ll_read_ahead_pages(const struct lu_env *env,/* FIXME: This assertion only is valid when it is for * forward read-ahead, it will be fixed when backward * read-ahead is implemented */ -LASSERTF (page_idx > ria->ria_stoff,"Invalid page_idx %lu" -"rs %lu re %lu ro %lu rl %lu rp %lu\n" , page_idx, - ria->ria_start, ria->ria_end, ria->ria_stoff, - ria->ria_length, ria->ria_pages); +LASSERTF (page_idx > ria->ria_stoff,"Invalid page_idx %lu rs %lu re %lu ro %lu rl %lu rp %lu\n" , + page_idx, + ria->ria_start, ria->ria_end, ria->ria_stoff, + ria->ria_length, ria->ria_pages); offset = page_idx - ria->ria_stoff; offset = offset % (ria->ria_length);if (offset > ria->ria_pages) {
@@ -927,8 +927,8 @@ static void ras_stride_increase_window(struct ll_readahead_state *ras,LASSERT (ras->ras_stride_length >0 );LASSERTF (ras->ras_window_start + ras->ras_window_len - >= ras->ras_stride_offset,"window_start %lu, window_len %lu" -" stride_offset %lu\n" , ras->ras_window_start, + >= ras->ras_stride_offset,"window_start %lu, window_len %lu stride_offset %lu\n" , + ras->ras_window_start, ras->ras_window_len, ras->ras_stride_offset); stride_len = ras->ras_window_start + ras->ras_window_len -
drivers/staging/lustre/lustre/llite/statahead.c +3 -8
@@ -1491,10 +1491,7 @@ ll_sai_unplug(struct ll_statahead_info *sai, struct ll_sa_entry *entry) sai->sai_consecutive_miss++;if (sa_low_hit (sai) &&thread_is_running (thread)) {atomic_inc (&sbi->ll_sa_wrong); -CDEBUG (D_READA ,"Statahead for dir " DFID " hit " -"ratio too low: hit/miss %llu/%llu" -", sent/replied %llu/%llu, stopping " -"statahead thread\n" , +CDEBUG (D_READA ,"Statahead for dir " DFID " hit ratio too low: hit/miss %llu/%llu, sent/replied %llu/%llu, stopping statahead thread\n" ,PFID (&lli->lli_fid), sai->sai_hit, sai->sai_miss, sai->sai_sent, sai->sai_replied);
@@ -1612,8 +1609,7 @@ int do_statahead_enter(struct inode *dir, struct dentry **dentryp, }else if ((*dentryp)->d_inode != inode) {/* revalidate, but inode is recreated */ CDEBUG(D_READA, - "stale dentry %.*s inode %lu/%u, " - "statahead inode %lu/%u\n", + "stale dentry %.*s inode %lu/%u, statahead inode %lu/%u\n", (*dentryp)->d_name.len, (*dentryp)->d_name.name, (*dentryp)->d_inode->i_ino,
@@ -1666,8 +1662,7 @@ int do_statahead_enter(struct inode *dir, struct dentry **dentryp,if (unlikely (sai->sai_inode != parent->d_inode)) {struct ll_inode_info *nlli =ll_i2info (parent->d_inode); -CWARN ("Race condition, someone changed %.*s just now: " -"old parent " DFID ", new parent " DFID "\n" , +CWARN ("Race condition, someone changed %.*s just now: old parent " DFID ", new parent " DFID "\n" , (*dentryp)->d_name.len, (*dentryp)->d_name.name,PFID (&lli->lli_fid),PFID (&nlli->lli_fid));dput (parent);
drivers/staging/lustre/lustre/llite/symlink.c +2 -2
@@ -100,8 +100,8 @@ static int ll_readlink_internal(struct inode *inode,if (*symname ==NULL ||strnlen (*symname, symlen) != symlen -1 ) {/* not full/NULL terminated */ -CERROR ("inode %lu: symlink not NULL terminated string" -"of length %d\n" , inode->i_ino, symlen -1 ); +CERROR ("inode %lu: symlink not NULL terminated string of length %d\n" , + inode->i_ino, symlen -1 ); rc = -EPROTO ; goto failed; }
drivers/staging/lustre/lustre/llite/vvp_io.c +2 -3
@@ -720,9 +720,8 @@ static int vvp_io_fault_start(const struct lu_env *env, last_index =cl_index (obj, size -1 );if (last_index < fio->ft_index) {CDEBUG (D_PAGE , -"llite: mkwrite and truncate race happened: " -"%p: 0x%lx 0x%lx\n" , - vmpage->mapping, fio->ft_index, last_index); +"llite: mkwrite and truncate race happened: %p: 0x%lx 0x%lx\n" , + vmpage->mapping, fio->ft_index, last_index);/* * We need to return if we are * passed the end of the file. This will propagate
drivers/staging/lustre/lustre/llite/vvp_page.c +1 -2
@@ -376,8 +376,7 @@ static int vvp_page_print(const struct lu_env *env,struct ccc_page *vp =cl2ccc_page (slice);struct page *vmpage = vp->cpg_page; - (*printer)(env, cookie,LUSTRE_VVP_NAME "-page@%p(%d:%d:%d) " -"vm@%p " , + (*printer)(env, cookie,LUSTRE_VVP_NAME "-page@%p(%d:%d:%d) vm@%p " , vp, vp->cpg_defer_uptodate, vp->cpg_ra_used, vp->cpg_write_queued, vmpage);if (vmpage !=NULL ) {
drivers/staging/lustre/lustre/llite/xattr.c +1 -2
@@ -201,8 +201,7 @@ int ll_setxattr_common(struct inode *inode, const char *name,#endif if (rc) {if (rc == -EOPNOTSUPP && xattr_type ==XATTR_USER_T ) { -LCONSOLE_INFO ("Disabling user_xattr feature because " -"it is not supported on the server\n" ); +LCONSOLE_INFO ("Disabling user_xattr feature because it is not supported on the server\n" ); sbi->ll_flags &= ~LL_SBI_USER_XATTR ; }return rc;
drivers/staging/lustre/lustre/lmv/lmv_fld.c +1 -2
@@ -75,8 +75,7 @@ int lmv_fld_lookup(struct lmv_obd *lmv, *mds, PFID(fid));if (*mds >= lmv->desc.ld_tgt_count) { -CERROR ("FLD lookup got invalid mds #%x (max: %x) " -"for fid=" DFID "\n" , *mds, lmv->desc.ld_tgt_count, +CERROR ("FLD lookup got invalid mds #%x (max: %x) for fid=" DFID "\n" , *mds, lmv->desc.ld_tgt_count,PFID (fid)); rc = -EINVAL ; }
drivers/staging/lustre/lustre/lmv/lmv_intent.c +4 -4
@@ -186,8 +186,8 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,return rc; } -CDEBUG (D_INODE ,"OPEN_INTENT with fid1=" DFID ", fid2=" DFID "," -" name='%s' -> mds #%d\n" ,PFID (&op_data->op_fid1), +CDEBUG (D_INODE ,"OPEN_INTENT with fid1=" DFID ", fid2=" DFID ", name='%s' -> mds #%d\n" , +PFID (&op_data->op_fid1),PFID (&op_data->op_fid2), op_data->op_name, tgt->ltd_idx); rc = md_intent_lock(tgt->ltd_exp, op_data, lmm, lmmsize, it, flags,
@@ -226,8 +226,8 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,* this is normal situation, we should not print error here, * only debug info. */ -CDEBUG (D_INODE ,"Can't handle remote %s: dir " DFID "(" DFID "):" -"%*s: %d\n" ,LL_IT2STR (it),PFID (&op_data->op_fid2), +CDEBUG (D_INODE ,"Can't handle remote %s: dir " DFID "(" DFID "):%*s: %d\n" , +LL_IT2STR (it),PFID (&op_data->op_fid2),PFID (&op_data->op_fid1), op_data->op_namelen, op_data->op_name, rc);return rc;
drivers/staging/lustre/lustre/lmv/lmv_obd.c +16 -20
@@ -325,8 +325,8 @@ static int lmv_init_ea_size(struct obd_export *exp, int easize, rc =md_init_ea_size (lmv->tgts[i]->ltd_exp, easize, def_easize, cookiesize, def_cookiesize);if (rc) { -CERROR ("%s: obd_init_ea_size() failed on MDT target %d:" -" rc = %d.\n" , obd->obd_name, i, rc); +CERROR ("%s: obd_init_ea_size() failed on MDT target %d: rc = %d.\n" , + obd->obd_name, i, rc);break ; } }
@@ -427,8 +427,7 @@ int lmv_connect_mdc(struct obd_device *obd, struct lmv_tgt_desc *tgt) mdc_obd->obd_type->typ_name, mdc_obd->obd_name);if (mdc_symlink ==NULL ) { -CERROR ("Could not register LMV target " -"/proc/fs/lustre/%s/%s/target_obds/%s." , +CERROR ("Could not register LMV target /proc/fs/lustre/%s/%s/target_obds/%s." , obd->obd_type->typ_name, obd->obd_name, mdc_obd->obd_name);lprocfs_remove (&lmv_proc_dir);
@@ -474,8 +473,8 @@ static int lmv_add_target(struct obd_device *obd, struct obd_uuid *uuidp,if ((index < lmv->tgts_size) && (lmv->tgts[index] !=NULL )) { tgt = lmv->tgts[index]; -CERROR ("%s: UUID %s already assigned at LOV target index %d:" -" rc = %d\n" , obd->obd_name, +CERROR ("%s: UUID %s already assigned at LOV target index %d: rc = %d\n" , + obd->obd_name,obd_uuid2str (&tgt->ltd_uuid), index, -EEXIST );lmv_init_unlock (lmv);return -EEXIST ;
@@ -600,8 +599,7 @@ int lmv_check_connect(struct obd_device *obd) --lmv->desc.ld_active_tgt_count; rc2 =obd_disconnect (tgt->ltd_exp);if (rc2) { -CERROR ("LMV target %s disconnect on " -"MDC idx %d: error %d\n" , +CERROR ("LMV target %s disconnect on MDC idx %d: error %d\n" , tgt->ltd_uuid.uuid, i, rc2); } }
@@ -865,10 +863,9 @@ static int lmv_hsm_ct_register(struct lmv_obd *lmv, unsigned int cmd, int len,if (err) {if (lmv->tgts[i]->ltd_active) {/* permanent error */ -CERROR ("error: iocontrol MDC %s on MDT" -"idx %d cmd %x: err = %d\n" , - lmv->tgts[i]->ltd_uuid.uuid, - i, cmd, err); +CERROR ("error: iocontrol MDC %s on MDTidx %d cmd %x: err = %d\n" , + lmv->tgts[i]->ltd_uuid.uuid, + i, cmd, err); rc = err; lk->lk_flags |=LK_FLG_STOP ;/* unregister from previous MDS */
@@ -1147,10 +1144,9 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,return err; }else if (err) {if (lmv->tgts[i]->ltd_active) { -CERROR ("error: iocontrol MDC %s on MDT" -"idx %d cmd %x: err = %d\n" , - lmv->tgts[i]->ltd_uuid.uuid, - i, cmd, err); +CERROR ("error: iocontrol MDC %s on MDTidx %d cmd %x: err = %d\n" , + lmv->tgts[i]->ltd_uuid.uuid, + i, cmd, err);if (!rc) rc = err; }
@@ -1234,8 +1230,8 @@ static int lmv_placement_policy(struct obd_device *obd,if (lum->lum_type ==LMV_STRIPE_TYPE && lum->lum_stripe_offset !=-1 ) {if (lum->lum_stripe_offset >= lmv->desc.ld_tgt_count) { -CERROR ("%s: Stripe_offset %d > MDT count %d:" -" rc = %d\n" , obd->obd_name, +CERROR ("%s: Stripe_offset %d > MDT count %d: rc = %d\n" , + obd->obd_name, lum->lum_stripe_offset, lmv->desc.ld_tgt_count, -ERANGE );return -ERANGE ;
@@ -1298,8 +1294,8 @@ int lmv_fid_alloc(struct obd_export *exp, struct lu_fid *fid, rc =lmv_placement_policy (obd, op_data, &mds);if (rc) { -CERROR ("Can't get target for allocating fid, " -"rc %d\n" , rc); +CERROR ("Can't get target for allocating fid, rc %d\n" , + rc);return rc; }
drivers/staging/lustre/lustre/lov/lov_ea.c +2 -3
@@ -348,9 +348,8 @@ const struct lsm_operations lsm_v3_ops = {void dump_lsm (unsigned int level,const struct lov_stripe_md *lsm) { - CDEBUG(level, "lsm %p, objid "DOSTID", maxbytes %#llx, magic 0x%08X," - " stripe_size %u, stripe_count %u, refc: %d," - " layout_gen %u, pool ["LOV_POOLNAMEF"]\n", lsm, + CDEBUG(level, "lsm %p, objid " DOSTID ", maxbytes %#llx, magic 0x%08X, stripe_size %u, stripe_count %u, refc: %d, layout_gen %u, pool [" LOV_POOLNAMEF "]\n", + lsm, POSTID(&lsm->lsm_oi), lsm->lsm_maxbytes, lsm->lsm_magic, lsm->lsm_stripe_size, lsm->lsm_stripe_count, atomic_read(&lsm->lsm_refc), lsm->lsm_layout_gen,
drivers/staging/lustre/lustre/lov/lov_obd.c +14 -18
@@ -168,8 +168,8 @@ int lov_connect_obd(struct obd_device *obd, __u32 index, int activate,if (imp->imp_invalid) { -CDEBUG (D_CONFIG ,"not connecting OSC %s; administratively " -"disabled\n" ,obd_uuid2str (tgt_uuid)); +CDEBUG (D_CONFIG ,"not connecting OSC %s; administratively disabled\n" , +obd_uuid2str (tgt_uuid));return 0 ; }
@@ -201,10 +201,9 @@ int lov_connect_obd(struct obd_device *obd, __u32 index, int activate, osc_obd->obd_type->typ_name, osc_obd->obd_name);if (osc_symlink ==NULL ) { -CERROR ("could not register LOV target " -"/proc/fs/lustre/%s/%s/target_obds/%s." , - obd->obd_type->typ_name, obd->obd_name, - osc_obd->obd_name); +CERROR ("could not register LOV target /proc/fs/lustre/%s/%s/target_obds/%s." , + obd->obd_type->typ_name, obd->obd_name, + osc_obd->obd_name);lprocfs_remove (&lov_proc_dir); obd->obd_proc_private =NULL ; }
@@ -726,8 +725,7 @@ void lov_fix_desc_stripe_size(__u64 *val) {if (*val <LOV_MIN_STRIPE_SIZE ) {if (*val !=0 ) -LCONSOLE_INFO ("Increasing default stripe size to " -"minimum %u\n" , +LCONSOLE_INFO ("Increasing default stripe size to minimum %u\n" ,LOV_DESC_STRIPE_SIZE_DEFAULT ); *val =LOV_DESC_STRIPE_SIZE_DEFAULT ; }else if (*val & (LOV_MIN_STRIPE_SIZE -1 )) {
@@ -899,8 +897,7 @@ static int lov_cleanup(struct obd_device *obd)/* We should never get here - these should have been removed in the disconnect. */ -CERROR ("lov tgt %d not cleaned!" -" deathrow=%d, lovrc=%d\n" , +CERROR ("lov tgt %d not cleaned! deathrow=%d, lovrc=%d\n" , i, lov->lov_death_row,atomic_read (&lov->lov_refcount));lov_del_target (obd, i,NULL ,0 );
@@ -1175,8 +1172,8 @@ static int lov_getattr_async(struct obd_export *exp, struct obd_info *oinfo,list_for_each (pos, &lovset->set_list) { req = list_entry(pos, struct lov_request, rq_link); -CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx" -"%u\n" ,POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe, +CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx%u\n" , +POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe,POSTID (&req->rq_oi.oi_oa->o_oi), req->rq_idx); rc =obd_getattr_async (lov->lov_tgts[req->rq_idx]->ltd_exp, &req->rq_oi, rqset);
@@ -1255,8 +1252,8 @@ static int lov_setattr_async(struct obd_export *exp, struct obd_info *oinfo,if (oinfo->oi_oa->o_valid &OBD_MD_FLCOOKIE ) oti->oti_logcookies = set->set_cookies + req->rq_stripe; -CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx" -"%u\n" ,POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe, +CDEBUG (D_INFO ,"objid " DOSTID "[%d] has subobj " DOSTID " at idx%u\n" , +POSTID (&oinfo->oi_oa->o_oi), req->rq_stripe,POSTID (&req->rq_oi.oi_oa->o_oi), req->rq_idx); rc = obd_setattr_async(lov->lov_tgts[req->rq_idx]->ltd_exp,
@@ -1567,8 +1564,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len,if (lov->lov_tgts[i]->ltd_active) {CDEBUG (err == -ENOTTY ?D_IOCTL :D_WARNING , -"iocontrol OSC %s on OST " -"idx %d cmd %x: err = %d\n" , +"iocontrol OSC %s on OST idx %d cmd %x: err = %d\n" ,lov_uuid2str (lov, i), i, cmd, err);if (!rc)
@@ -2265,8 +2261,8 @@ static int lov_quotacheck(struct obd_device *obd, struct obd_export *exp,/* Skip quota check on the administratively disabled OSTs. */ if (!lov->lov_tgts[i]->ltd_activate) { -CWARN ("lov idx %d was administratively disabled, " -"skip quotacheck on it.\n" , i); +CWARN ("lov idx %d was administratively disabled, skip quotacheck on it.\n" , + i);continue ; }
drivers/staging/lustre/lustre/mgc/mgc_request.c +2 -4
@@ -734,8 +734,7 @@ static int mgc_setup(struct obd_device *obd, struct lustre_cfg *lcfg) rc =PTR_ERR (kthread_run (mgc_requeue_thread,NULL ,"ll_cfg_requeue" ));if (IS_ERR_VALUE (rc)) { -CERROR ("%s: Cannot start requeue thread (%d)," -"no more log updates!\n" , +CERROR ("%s: Cannot start requeue thread (%d),no more log updates!\n" , obd->obd_name, rc); goto err_cleanup; }
@@ -1019,8 +1018,7 @@ int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,sptlrpc_flavor2name (&cli->cl_flvr_mgc, str,sizeof (str)); -LCONSOLE_ERROR ("asking sptlrpc flavor %s to MGS but " -"currently %s is in use\n" , +LCONSOLE_ERROR ("asking sptlrpc flavor %s to MGS but currently %s is in use\n" , (char *) val, str); rc = -EPERM ; }
drivers/staging/lustre/lustre/obdclass/capa.c +3 -5
@@ -272,8 +272,7 @@ int capa_hmac(__u8 *hmac, struct lustre_capa *capa, __u8 *key) tfm =crypto_alloc_hash (alg->ha_name,0 ,0 );if (IS_ERR (tfm)) { -CERROR ("crypto_alloc_tfm failed, check whether your kernel" -"has crypto support!\n" ); +CERROR ("crypto_alloc_tfm failed, check whether your kernel has crypto support!\n" );return PTR_ERR (tfm); } keylen = alg->ha_keylen;
@@ -412,9 +411,8 @@ void _debug_capa(struct lustre_capa *c,va_list args;va_start (args, fmt);libcfs_debug_vmsg2 (msgdata, fmt, args, -" capability@%p fid " DFID " opc %#llx uid %llu" -" gid %llu flags %u alg %d keyid %u timeout %u " -"expiry %u\n" , c,PFID (capa_fid (c)),capa_opc (c), +" capability@%p fid " DFID " opc %#llx uid %llu gid %llu flags %u alg %d keyid %u timeout %u expiry %u\n" , + c,PFID (capa_fid (c)),capa_opc (c),capa_uid (c),capa_gid (c),capa_flags (c),capa_alg (c),capa_keyid (c),capa_timeout (c),capa_expiry (c));
drivers/staging/lustre/lustre/obdclass/cl_io.c +1 -2
@@ -1622,8 +1622,7 @@ int cl_sync_io_wait(const struct lu_env *env, struct cl_io *io,atomic_read (&anchor->csi_sync_nr) ==0 , &lwi);if (rc <0 ) { -CERROR ("SYNC IO failed with error: %d, try to cancel " -"%d remaining pages\n" , +CERROR ("SYNC IO failed with error: %d, try to cancel %d remaining pages\n" , rc,atomic_read (&anchor->csi_sync_nr)); (void )cl_io_cancel (env, io, queue);
drivers/staging/lustre/lustre/obdclass/cl_lock.c +1 -2
@@ -129,8 +129,7 @@ static void cl_lock_trace0(int level, const struct lu_env *env, const char *func, const int line) {struct cl_object_header *h =cl_object_header (lock->cll_descr.cld_obj); - CDEBUG(level, "%s: %p@(%d %p %d %d %d %d %d %lx)" - "(%p/%d/%d) at %s():%d\n", + CDEBUG(level, "%s: %p@(%d %p %d %d %d %d %d %lx)(%p/%d/%d) at %s():%d\n", prefix, lock, atomic_read(&lock->cll_ref), lock->cll_guarder, lock->cll_depth, lock->cll_state, lock->cll_error, lock->cll_holds,
drivers/staging/lustre/lustre/obdclass/class_obd.c +2 -4
@@ -144,13 +144,11 @@ int obd_alloc_fail(const void *ptr, const char *name, const char *type,CERROR ("%s%salloc of %s (%llu bytes) failed at %s:%d\n" , ptr ?"force " :"" , type, name, (__u64 )size, file, line); -CERROR ("%llu total bytes and %llu total pages " -"(%llu bytes) allocated by Lustre, " -"%d total bytes by LNET\n" , +CERROR ("%llu total bytes and %llu total pages (%llu bytes) allocated by Lustre, %d total bytes by LNET\n" ,obd_memory_sum (),obd_pages_sum () <<PAGE_CACHE_SHIFT ,obd_pages_sum (), -atomic_read (&libcfs_kmemory)); +atomic_read (&libcfs_kmemory));return 1 ; }return 0 ;
drivers/staging/lustre/lustre/obdclass/genops.c +7 -11
@@ -1087,8 +1087,7 @@ void __class_export_del_lock_ref(struct obd_export *exp, struct ldlm_lock *lock)spin_lock (&exp->exp_locks_list_guard);LASSERT (lock->l_exp_refs_nr >0 );if (lock->l_exp_refs_target != exp) { -LCONSOLE_WARN ("lock %p, " -"mismatching export pointers: %p, %p\n" , +LCONSOLE_WARN ("lock %p, mismatching export pointers: %p, %p\n" , lock, lock->l_exp_refs_target, exp); }if (-- lock->l_exp_refs_nr ==0 ) {
@@ -1259,8 +1258,7 @@ static void class_disconnect_export_list(struct list_head *list, }class_export_get (exp); -CDEBUG (D_HA ,"%s: disconnecting export at %s (%p), " -"last request at " CFS_TIME_T "\n" , +CDEBUG (D_HA ,"%s: disconnecting export at %s (%p), last request at " CFS_TIME_T "\n" , exp->exp_obd->obd_name,obd_export_nid2str (exp), exp, exp->exp_last_request_time);/* release one export reference anyway */
@@ -1284,8 +1282,8 @@ void class_disconnect_exports(struct obd_device *obd)spin_unlock (&obd->obd_dev_lock);if (!list_empty (&work_list)) { -CDEBUG (D_HA ,"OBD device %d (%p) has exports, " -"disconnecting them\n" , obd->obd_minor, obd); +CDEBUG (D_HA ,"OBD device %d (%p) has exports, disconnecting them\n" , + obd->obd_minor, obd);class_disconnect_export_list (&work_list,exp_flags_from_obd (obd)); }else
@@ -1422,8 +1420,8 @@ int obd_export_evict_by_nid(struct obd_device *obd, const char *nid)LASSERTF (doomed_exp != obd->obd_self_export,"self-export is hashed by NID?\n" ); exports_evicted++; -LCONSOLE_WARN ("%s: evicting %s (at %s) by administrative " -"request\n" , obd->obd_name, +LCONSOLE_WARN ("%s: evicting %s (at %s) by administrative request\n" , + obd->obd_name,obd_uuid2str (&doomed_exp->exp_client_uuid),obd_export_nid2str (doomed_exp));class_fail_export (doomed_exp);
@@ -1546,9 +1544,7 @@ void obd_exports_barrier(struct obd_device *obd)set_current_state (TASK_UNINTERRUPTIBLE );schedule_timeout (cfs_time_seconds (waited));if (waited >5 &&IS_PO2 (waited)) { -LCONSOLE_WARN ("%s is waiting for obd_unlinked_exports " -"more than %d seconds. " -"The obd refcount = %d. Is it stuck?\n" , +LCONSOLE_WARN ("%s is waiting for obd_unlinked_exports more than %d seconds. The obd refcount = %d. Is it stuck?\n" , obd->obd_name, waited,atomic_read (&obd->obd_refcount));dump_exports (obd,1 );
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +2 -3
@@ -202,9 +202,8 @@ static int proc_max_dirty_pages_in_mb(struct ctl_table *table, int write,/* Don't allow them to let dirty pages exceed 90% of system * memory and set a hard minimum of 4MB. */ if (obd_max_dirty_pages > ((totalram_pages /10 ) *9 )) { -CERROR ("Refusing to set max dirty pages to %u, which " -"is more than 90%% of available RAM; setting " -"to %lu\n" , obd_max_dirty_pages, +CERROR ("Refusing to set max dirty pages to %u, which is more than 90%% of available RAM; setting to %lu\n" , + obd_max_dirty_pages, ((totalram_pages /10 ) *9 )); obd_max_dirty_pages = ((totalram_pages /10 ) *9 ); }else if (obd_max_dirty_pages <4 << (20 -PAGE_CACHE_SHIFT )) {
drivers/staging/lustre/lustre/obdclass/llog.c +2 -2
@@ -346,8 +346,8 @@ repeat: }if (rec->lrh_len ==0 || rec->lrh_len >LLOG_CHUNK_SIZE ) { -CWARN ("invalid length %d in llog record for " -"index %d/%d\n" , rec->lrh_len, +CWARN ("invalid length %d in llog record for index %d/%d\n" , + rec->lrh_len, rec->lrh_index, index); rc = -EINVAL ; goto out;
drivers/staging/lustre/lustre/obdclass/llog_cat.c +4 -6
@@ -228,8 +228,7 @@ int llog_cat_close(const struct lu_env *env, struct llog_handle *cathandle) (llh->llh_count == 1)) { rc =llog_destroy (env, loghandle);if (rc) -CERROR ("%s: failure destroying log during " -"cleanup: rc = %d\n" , +CERROR ("%s: failure destroying log during cleanup: rc = %d\n" , loghandle->lgh_ctxt->loc_obd->obd_name, rc);
@@ -746,8 +745,7 @@ int llog_cat_cleanup(const struct lu_env *env, struct llog_handle *cathandle,llog_cat_set_first_idx (cathandle, index); rc =llog_cancel_rec (env, cathandle, index);if (rc ==0 ) -CDEBUG (D_HA ,"cancel plain log at index" -" %u of catalog " DOSTID "\n" , +CDEBUG (D_HA ,"cancel plain log at index %u of catalog " DOSTID "\n" , index,POSTID (&cathandle->lgh_id.lgl_oi));return rc; }
@@ -810,8 +808,8 @@ int llog_cat_init_and_process(const struct lu_env *env, rc =llog_process_or_fork (env, llh, cat_cancel_cb,NULL ,NULL , false);if (rc) -CERROR ("%s: llog_process() with cat_cancel_cb failed: rc = " -"%d\n" , llh->lgh_ctxt->loc_obd->obd_name, rc); +CERROR ("%s: llog_process() with cat_cancel_cb failed: rc = %d\n" , + llh->lgh_ctxt->loc_obd->obd_name, rc);return 0 ; }EXPORT_SYMBOL (llog_cat_init_and_process);
drivers/staging/lustre/lustre/obdclass/llog_swab.c +1 -2
@@ -400,8 +400,7 @@ void lustre_swab_cfg_marker(struct cfg_marker *marker, int swab, int size) } marker->cm_createtime = createtime; marker->cm_canceltime = canceltime; -CDEBUG (D_CONFIG ,"Find old cfg_marker(Srv32b,Clt64b) " -"for target %s, converting\n" , +CDEBUG (D_CONFIG ,"Find old cfg_marker(Srv32b,Clt64b) for target %s, converting\n" , marker->cm_tgtname); }else if (swab) {__swab64s (&marker->cm_createtime);
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +4 -6
@@ -1400,8 +1400,8 @@ int lprocfs_alloc_obd_stats(struct obd_device *obd, unsigned num_private_stats)* LPROCFS_OBD_OP_INIT(.., .., opname) * is missing from the list above. */ LASSERTF (stats->ls_cnt_header[i].lc_name !=NULL , -"Missing obd_stat initializer obd_op " -"operation at offset %d.\n" , i - num_private_stats); +"Missing obd_stat initializer obd_op operation at offset %d.\n" , + i - num_private_stats); } rc =lprocfs_register_stats (obd->obd_proc_entry,"stats" , stats);if (rc <0 ) {
@@ -1486,8 +1486,7 @@ int lprocfs_alloc_md_stats(struct obd_device *obd,for (i = num_private_stats; i < num_stats; i++) {if (stats->ls_cnt_header[i].lc_name ==NULL ) { -CERROR ("Missing md_stat initializer md_op " -"operation at offset %d. Aborting.\n" , +CERROR ("Missing md_stat initializer md_op operation at offset %d. Aborting.\n" , i - num_private_stats);LBUG (); }
@@ -1607,8 +1606,7 @@ LPROC_SEQ_FOPS_RO(lproc_exp_hash);int lprocfs_nid_stats_clear_read (struct seq_file *m,void *data) {return seq_printf (m,"%s\n" , -"Write into this file to clear all nid stats and " -"stale nid entries" ); +"Write into this file to clear all nid stats and stale nid entries" ); }EXPORT_SYMBOL (lprocfs_nid_stats_clear_read);
drivers/staging/lustre/lustre/obdclass/lu_object.c +1 -2
@@ -866,8 +866,7 @@ static int lu_htable_order(void)/* clear off unreasonable cache setting. */ if (lu_cache_percent ==0 || lu_cache_percent >LU_CACHE_PERCENT_MAX ) { -CWARN ("obdclass: invalid lu_cache_percent: %u, it must be in" -" the range of (0, %u]. Will use default value: %u.\n" , +CWARN ("obdclass: invalid lu_cache_percent: %u, it must be in the range of (0, %u]. Will use default value: %u.\n" , lu_cache_percent,LU_CACHE_PERCENT_MAX ,LU_CACHE_PERCENT_DEFAULT );
drivers/staging/lustre/lustre/obdclass/obd_config.c +3 -6
@@ -1443,8 +1443,7 @@ int class_config_llog_handler(const struct lu_env *env,if (!(clli->cfg_flags &CFG_F_COMPAT146 ) && !(clli->cfg_flags &CFG_F_MARKER ) && (lcfg->lcfg_command !=LCFG_MARKER )) { -CWARN ("Config not inside markers, ignoring! " -"(inst: %p, uuid: %s, flags: %#x)\n" , +CWARN ("Config not inside markers, ignoring! (inst: %p, uuid: %s, flags: %#x)\n" , clli->cfg_instance, clli->cfg_uuid.uuid, clli->cfg_flags); clli->cfg_flags |=CFG_F_SKIP ;
@@ -1467,14 +1466,12 @@ int class_config_llog_handler(const struct lu_env *env,if ((lcfg->lcfg_command ==LCFG_ATTACH && typename &&strcmp (typename,"mds" ) ==0 )) { -CWARN ("For 1.8 interoperability, rename obd " -"type from mds to mdt\n" ); +CWARN ("For 1.8 interoperability, rename obd type from mds to mdt\n" ); typename[2 ] ='t' ; }if ((lcfg->lcfg_command ==LCFG_SETUP && index &&strcmp (index,"type" ) ==0 )) { -CDEBUG (D_INFO ,"For 1.8 interoperability, " -"set this index to '0'\n" ); +CDEBUG (D_INFO ,"For 1.8 interoperability, set this index to '0'\n" ); index[0 ] ='0' ; index[1 ] =0 ; }
drivers/staging/lustre/lustre/obdclass/obd_mount.c +11 -27
@@ -100,19 +100,12 @@ int lustre_process_log(struct super_block *sb, char *logname,OBD_FREE_PTR (bufs);if (rc == -EINVAL ) -LCONSOLE_ERROR_MSG (0x15b ,"%s: The configuration from log '%s'" -"failed from the MGS (%d). Make sure this " -"client and the MGS are running compatible " -"versions of Lustre.\n" , +LCONSOLE_ERROR_MSG (0x15b ,"%s: The configuration from log '%s' failed from the MGS (%d). Make sure this client and the MGS are running compatible versions of Lustre.\n" , mgc->obd_name, logname, rc);if (rc) -LCONSOLE_ERROR_MSG (0x15c ,"%s: The configuration from log '%s' " -"failed (%d). This may be the result of " -"communication errors between this node and " -"the MGS, a bad configuration, or other " -"errors. See the syslog for more " -"information.\n" , mgc->obd_name, logname, +LCONSOLE_ERROR_MSG (0x15c ,"%s: The configuration from log '%s' failed (%d). This may be the result of communication errors between this node and the MGS, a bad configuration, or other errors. See the syslog for more information.\n" , + mgc->obd_name, logname, rc);/* class_obd_list(); */
@@ -297,11 +290,8 @@ int lustre_start_mgc(struct super_block *sb)if (has_ir ^ !(*flags &LMD_FLG_NOIR )) {/* LMD_FLG_NOIR is for test purpose only */ LCONSOLE_WARN ( -"Trying to mount a client with IR setting " -"not compatible with current mgc. " -"Force to use current mgc setting that is " -"IR %s.\n" , - has_ir ?"enabled" :"disabled" ); +"Trying to mount a client with IR setting not compatible with current mgc. Force to use current mgc setting that is IR %s.\n" , + has_ir ?"enabled" :"disabled" );if (has_ir) *flags &= ~LMD_FLG_NOIR ;else
@@ -998,16 +988,14 @@ static int lmd_parse(char *options, struct lustre_mount_data *lmd)LASSERT (lmd);if (!options) { -LCONSOLE_ERROR_MSG (0x162 ,"Missing mount data: check that " -"/sbin/mount.lustre is installed.\n" ); +LCONSOLE_ERROR_MSG (0x162 ,"Missing mount data: check that /sbin/mount.lustre is installed.\n" );return -EINVAL ; }/* Options should be a string - try to detect old lmd data */ if ((raw->lmd_magic &0xffffff00 ) == (LMD_MAGIC &0xffffff00 )) { -LCONSOLE_ERROR_MSG (0x163 ,"You're using an old version of " -"/sbin/mount.lustre. Please install " -"version %s\n" ,LUSTRE_VERSION_STRING ); +LCONSOLE_ERROR_MSG (0x163 ,"You're using an old version of /sbin/mount.lustre. Please install version %s\n" , +LUSTRE_VERSION_STRING );return -EINVAL ; } lmd->lmd_magic =LMD_MAGIC ;
@@ -1139,8 +1127,7 @@ static int lmd_parse(char *options, struct lustre_mount_data *lmd) }if (!devname) { -LCONSOLE_ERROR_MSG (0x164 ,"Can't find the device name " -"(need mount option 'device=...')\n" ); +LCONSOLE_ERROR_MSG (0x164 ,"Can't find the device name (need mount option 'device=...')\n" ); goto invalid; }
@@ -1232,9 +1219,7 @@ int lustre_fill_super(struct super_block *sb, void *data, int silent)if (client_fill_super ==NULL )request_module ("lustre" );if (client_fill_super ==NULL ) { -LCONSOLE_ERROR_MSG (0x165 ,"Nothing registered for " -"client mount! Is the 'lustre' " -"module loaded?\n" ); +LCONSOLE_ERROR_MSG (0x165 ,"Nothing registered for client mount! Is the 'lustre' module loaded?\n" );lustre_put_lsi (sb); rc = -ENODEV ; }else {
@@ -1249,8 +1234,7 @@ int lustre_fill_super(struct super_block *sb, void *data, int silent)/* c_f_s will call lustre_common_put_super on failure */ } }else { -CERROR ("This is client-side-only module, " -"cannot handle server mount.\n" ); +CERROR ("This is client-side-only module, cannot handle server mount.\n" ); rc = -EINVAL ; }
drivers/staging/lustre/lustre/obdecho/echo_client.c +1 -2
@@ -871,8 +871,7 @@ static struct lu_device *echo_device_free(const struct lu_env *env,spin_lock (&ec->ec_lock);while (!list_empty (&ec->ec_objects)) {spin_unlock (&ec->ec_lock); -CERROR ("echo_client still has objects at cleanup time, " -"wait for 1 second\n" ); +CERROR ("echo_client still has objects at cleanup time, wait for 1 second\n" );set_current_state (TASK_UNINTERRUPTIBLE );schedule_timeout (cfs_time_seconds (1 ));lu_site_purge (env, &ed->ed_site->cs_lu,-1 );
drivers/staging/lustre/lustre/osc/osc_cache.c +2 -2
@@ -1560,8 +1560,8 @@ void osc_wake_cache_waiters(struct client_obd *cli)if ((cli->cl_dirty +PAGE_CACHE_SIZE > cli->cl_dirty_max) || (atomic_read (&obd_dirty_pages) +1 > obd_max_dirty_pages)) { -CDEBUG (D_CACHE ,"no dirty room: dirty: %ld " -"osc max %ld, sys max %d\n" , cli->cl_dirty, +CDEBUG (D_CACHE ,"no dirty room: dirty: %ld osc max %ld, sys max %d\n" , + cli->cl_dirty, cli->cl_dirty_max, obd_max_dirty_pages); goto wakeup; }
drivers/staging/lustre/lustre/osc/osc_lock.c +2 -4
@@ -1067,14 +1067,12 @@ static int osc_lock_enqueue_wait(const struct lu_env *env,* conflicts, we do not wait but return 0 so the * request is send to the server */ -CDEBUG (D_DLMTRACE ,"group lock %p is conflicted " -"with %p, no wait, send to server\n" , +CDEBUG (D_DLMTRACE ,"group lock %p is conflicted with %p, no wait, send to server\n" , lock, conflict);cl_lock_put (env, conflict); rc =0 ; }else { -CDEBUG (D_DLMTRACE ,"lock %p is conflicted with %p, " -"will wait\n" , +CDEBUG (D_DLMTRACE ,"lock %p is conflicted with %p, will wait\n" , lock, conflict);LASSERT (lock->cll_conflict ==NULL ); lu_ref_add(&conflict->cll_reference, "cancel-wait",
drivers/staging/lustre/lustre/osc/osc_object.c +1 -2
@@ -140,8 +140,7 @@ static int osc_object_print(const struct lu_env *env, void *cookie,struct lov_oinfo *oinfo = osc->oo_oinfo;struct osc_async_rc *ar = &oinfo->loi_ar; - (*p)(env, cookie,"id: " DOSTID " " -"idx: %d gen: %d kms_valid: %u kms %llu rc: %d force_sync: %d min_xid: %llu " , + (*p)(env, cookie,"id: " DOSTID " idx: %d gen: %d kms_valid: %u kms %llu rc: %d force_sync: %d min_xid: %llu " ,POSTID (&oinfo->loi_oi), oinfo->loi_ost_idx, oinfo->loi_ost_gen, oinfo->loi_kms_valid, oinfo->loi_kms, ar->ar_rc, ar->ar_force_sync, ar->ar_min_xid);
drivers/staging/lustre/lustre/osc/osc_page.c +3 -8
@@ -369,12 +369,7 @@ static int osc_page_print(const struct lu_env *env,struct osc_object *obj =cl2osc (slice->cpl_obj);struct client_obd *cli = &osc_export (obj)->exp_obd->u.cli; - return (*printer)(env, cookie, LUSTRE_OSC_NAME"-page@%p: " - "1< %#x %d %u %s %s > " - "2< %llu %u %u %#x %#x | %p %p %p > " - "3< %s %p %d %lu %d > " - "4< %d %d %d %lu %s | %s %s %s %s > " - "5< %s %s %s %s | %d %s | %d %s %s>\n", + return (*printer)(env, cookie, LUSTRE_OSC_NAME "-page@%p: 1< %#x %d %u %s %s > 2< %llu %u %u %#x %#x | %p %p %p > 3< %s %p %d %lu %d > 4< %d %d %d %lu %s | %s %s %s %s > 5< %s %s %s %s | %d %s | %d %s %s>\n", opg, /* 1 */ oap->oap_magic, oap->oap_cmd,
@@ -550,8 +545,8 @@ void osc_page_submit(const struct lu_env *env, struct osc_page *opg,LINVRNT (osc_page_protected (env, opg, crt ==CRT_WRITE ?CLM_WRITE :CLM_READ ,1 )); -LASSERTF (oap->oap_magic ==OAP_MAGIC ,"Bad oap magic: oap %p, " -"magic 0x%x\n" , oap, oap->oap_magic); +LASSERTF (oap->oap_magic ==OAP_MAGIC ,"Bad oap magic: oap %p, magic 0x%x\n" , + oap, oap->oap_magic);LASSERT (oap->oap_async_flags &ASYNC_READY );LASSERT (oap->oap_async_flags &ASYNC_COUNT_STABLE );
drivers/staging/lustre/lustre/osc/osc_request.c +21 -26
109 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/client.c +19 -25
94 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/events.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/import.c +44 -71
115 lines not on this page · raw message
drivers/staging/lustre/lustre/ptlrpc/layout.c +10 -14
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/llog_client.c +1 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c +5 -8
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/niobuf.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/nrs.c +12 -21
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +14 -19
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/pinger.c +4 -14
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/recover.c +3 -4
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec.c +10 -12
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c +1 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/sec_plain.c +2 -2
Lines of this file are not shown. View the raw message.
drivers/staging/lustre/lustre/ptlrpc/service.c +39 -51
90 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Part of the diff is not shown here. View the raw message.