Skip to contentSkip to conversation

sched: fix start hrtick for short schedule slices on UP

PATCH New Wanpeng Li 1 participant 1 message Nov 21, 2014 Scheduler

lore
Share & tools
lore

Wanpeng Li

author
#0 lore raw

PATCH 1/1 sched: fix start hrtick for short schedule slices on UP

Start hrtick for schedule slices shorter than 10000ns doesn't make any sense and can cause timer DoS.

The commit 177ef2a6315e ("sched/deadline: Fix a precision problem in the microseconds range") fixes the shorter slices issue for dl class. Both the UP and SMP sides of hrtick_start() will handle the shorter slices issue before the commit, however, the UP side of hrtick_start() doesn't handle shorter slides issue any more after the commit applied.

This patch fix it by making sure the scheduling slice won't be smaller than 10us in the UP side of hrtick_start() for fair and dl schedule class.

---
 kernel/sched/core.c | 5 +++++
 1 file changed, 5 insertions(+)
kernel/sched/core.c +5 -0
index d44d0c5..dbfcca6 100644
@@ -490,6 +490,11 @@ static __init void init_hrtick(void)
  */
 void hrtick_start(struct rq *rq, u64 delay)
 {
+	/*
+	 * Don't schedule slices shorter than 10000ns, that just
+	 * doesn't make sense. Rely on vruntime for fairness.
+	 */
+	delay = max_t(u64, delay, 10000LL);
 	__hrtimer_start_range_ns(&rq->hrtick_timer, ns_to_ktime(delay), 0,
 			HRTIMER_MODE_REL_PINNED, 0);
 }
Signature · 1 line
1.9.1