Skip to contentSkip to conversation

drivers:gpu:qlx: Change incorrect return value of EINVAL to ENODEV in qxl_drv.c

PATCH New Nicholas Krause 1 participant 1 message Nov 21, 2014

Subsystems (3)
DRM drivers DRM misc DRM driver for QXL virtual GPU
lore
Share & tools
lore

Nicholas Krause

author
#0 lore raw

PATCH 1/1 drivers:gpu:qlx: Change incorrect return value of EINVAL to ENODEV in qxl_drv.c

Fixes not returning correct error code value in qxl_drv.c for the function, qxl_pci_probe as this is a error with the device rather then an incorrect value as stated by the DRM_ERROR statement above the return if this function returns a error.

Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/qxl/qxl_drv.c +1 -1
index 1d9b80c..bbe2a34 100644
@@ -65,7 +65,7 @@ qxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (pdev->revision < 4) {
 		DRM_ERROR("qxl too old, doesn't support client_monitors_config,"
 			  " use xf86-video-qxl in user mode");
-		return -EINVAL; /* TODO: ENODEV ? */
+		return -ENODEV;
 	}
 	return drm_get_pci_dev(pdev, ent, &qxl_driver);
 }
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel