Skip to contentSkip to conversation

NVMe: Update module version major number

PATCH New Keith Busch 2 participants 2 messages Nov 21, 2014 – Nov 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NVMe: Update module version major number

It's already near impossible to tell what bits someone is running based on a 'modinfo nvme', and I don't want to try guessing if someone is running blk-mq or bio-based. Let's make it obvious with the module version that the blk-mq conversion is a major change. Future bio-based versions can increment to 0.10 in a fork if revisions occur.

Cc Jens Axboe <axboe at kernel.dk>
Signed-off-by Keith Busch <keith.busch at intel.com>

---
Based on linux-block for-next

 drivers/block/nvme-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/nvme-core.c +1 -1
index dbb4aae..0da7756 100644
@@ -2966,6 +2966,6 @@ static void __exit nvme_exit(void)
 
 MODULE_AUTHOR("Matthew Wilcox <willy at linux.intel.com>");
 MODULE_LICENSE("GPL");
-MODULE_VERSION("0.9");
+MODULE_VERSION("1.0");
 module_init(nvme_init);
 module_exit(nvme_exit);
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

PATCH 1/1 NVMe: Update module version major number

Quoted 5 lines · Keith Busch

It's already near impossible to tell what bits someone is running based on a 'modinfo nvme', and I don't want to try guessing if someone is running blk-mq or bio-based. Let's make it obvious with the module version that the blk-mq conversion is a major change. Future bio-based versions can increment to 0.10 in a fork if revisions occur.

Thanks, added to the mix. In general I don't put much faith into version numbers, you should be able to tell when people report what kernel they are running. Distro backports sometimes make that difficult, though.

Signature · 1 line
Jens Axboe