Order root fsck after dracut-pre-mount.service

PATCH New Andrei Borzenkov 1 participant 1 message Nov 22, 2014

Share & tools

Andrei Borzenkov

author

2014-11-22 16:43 UTC #0 lore raw

PATCH 1/1 Order root fsck after dracut-pre-mount.service

Currently root fsck runs concurrently with dracut-pre-mount and so races with resume from disk (started by dracut-pre-mount). This leads to data corruption if fsck changes filesystem.

Make sure root fsck runs after dracut-pre-mount.service.

Details including console logs:
https://bugzilla.suse.com/show_bug.cgi?id=906592

Signed-off-by Andrei Borzenkov <[email protected]>

---
 modules.d/98systemd/rootfs-generator.sh | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

modules.d/98systemd/rootfs-generator.sh +20 -1

index 9523729..a2d26b9 100755
@@ -32,6 +32,22 @@ generator_wait_for_dev()
     fi
 }
 
+generator_fsck_after_pre_mount()
+{
+    local _name
+
+    [ -z "$1" ] && return 0
+
+    _name=$(dev_unit_name "$1")
+    [ -d /run/systemd/generator/systemd-fsck@${_name}.service.d ] || mkdir -p /run/systemd/generator/systemd-fsck@${_name}.service.d
+    if ! [ -f /run/systemd/generator/systemd-fsck@${_name}.service.d/after-pre-mount.conf ]; then
+        {
+            echo "[Unit]"
+            echo "After=dracut-pre-mount.service"
+        } > /run/systemd/generator/systemd-fsck@${_name}.service.d/after-pre-mount.conf
+    fi
+}
+
 root=$(getarg root=)
 case "$root" in
     block:LABEL=*|LABEL=*)

@@ -58,6 +74,9 @@ case "$root" in
         rootok=1 ;;
 esac
 
-[ "${root%%:*}" = "block" ] && generator_wait_for_dev "${root#block:}"
+if [ "${root%%:*}" = "block" ]; then
+    generator_wait_for_dev "${root#block:}"
+    generator_fsck_after_pre_mount "${root#block:}"
+fi
 
 exit 0

Signature · 1 line

tg: (778b354..) u/root-fsck-after-pre-mount (depends on: master)