Skip to contentSkip to conversation

gpu/drm/drm_sysfs.c: Export drm_sysfs_connector_add and drm_sysfs_connector_remove

PATCH In review Mike Looijmans 2 participants 2 messages Nov 24, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu/drm/drm_sysfs.c: Export drm_sysfs_connector_add and drm_sysfs_connector_remove

Building the adi_axi_hdmi driver as a module failed:
ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/adi_axi_hdmi/adi_axi_hdmi.ko] undefined!

Mark drm_sysfs_connector_remove for export to fix this. Also mark drm_sysfs_connector_add for export, for symetry and because at least one other module uses it (xylon_connector.c).

---
 drivers/gpu/drm/drm_sysfs.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/drm_sysfs.c +2 -0
index ab1a5f6..d0296cc 100644
@@ -438,6 +438,7 @@ err_out_files:
 out:
 	return ret;
 }
+EXPORT_SYMBOL(drm_sysfs_connector_add);
 
 /**
  * drm_sysfs_connector_remove - remove an connector device from sysfs
@@ -467,6 +468,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector)
 	device_unregister(connector->kdev);
 	connector->kdev = NULL;
 }
+EXPORT_SYMBOL(drm_sysfs_connector_remove);
 
 /**
  * drm_sysfs_hotplug_event - generate a DRM uevent
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 6 lines · Mike Looijmans

Building the adi_axi_hdmi driver as a module failed:
ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/adi_axi_hdmi/adi_axi_hdmi.ko] undefined!

Mark drm_sysfs_connector_remove for export to fix this. Also mark drm_sysfs_connector_add for export, for symetry and because at least one other module uses it (xylon_connector.c).

no.. you should be using drm_connector_{register,unregister}() now, and not calling the drm_sysfs_connector_{add,remove}() fxns directly..

BR,
-R

Quoted 28 lines
---
 drivers/gpu/drm/drm_sysfs.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/drm_sysfs.c +2 -1
index ab1a5f6..d0296cc 100644
@@ -438,6 +438,7 @@ err_out_files:
 out:
        return ret;
 }
+EXPORT_SYMBOL(drm_sysfs_connector_add);
 
 /**
  * drm_sysfs_connector_remove - remove an connector device from sysfs
@@ -467,6 +468,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector)
        device_unregister(connector->kdev);
        connector->kdev = NULL;
 }
+EXPORT_SYMBOL(drm_sysfs_connector_remove);
 
 /**
  * drm_sysfs_hotplug_event - generate a DRM uevent
--

1.7.9.5

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel