perf tool: Add sort key symoff for perf diff
PATCH v5 1/3 perf tool: Add sort key symoff for perf diff
From: Kan Liang <[email protected]>
Sometime, especially debugging scaling issue, the function level diff may be high granularity. The user may want to do deeper diff analysis for some cache or lock issue. The "symoff" key can let the user sort differential profile by ips.
Here is an example.
The source code for example_v1.c is as below:
noinline void f3(void)
{
volatile int i;
for (i = 0; i < 10000;) {
if(i%2)
i++;
else
i++;
}
}noinline void f2(void)
{
volatile int a = 100, b, c;
for (b = 0; b < 10000; b++)
c = a * b;}
noinline void f1(void)
{
f2();
f3();
}int main()
{
int i;
for (i = 0; i < 100000; i++)
f1();
}We run the example twice. (That's a simplified case. Of course, we cannot find the scaling issue here. )
[lk@localhost perf_diff]$ gcc example_v1.c -o example [lk@localhost perf_diff]$ perf record -o example_symoff_1.data ./example [ perf record: Woken up 4 times to write data ]
[ perf record: Captured and wrote 0.808 MB example_symoff_1.data (~35314 samples) ]
[lk@localhost perf_diff]$ perf record -o example_symoff_2.data ./example [ perf record: Woken up 4 times to write data ]
[ perf record: Captured and wrote 0.814 MB example_symoff_2.data (~35580 samples) ]
[lk@localhost perf_diff]$ perf diff -s symoff example_symoff_1.data example_symoff_2.data
Event 'cycles'
Baseline Delta Symbol + Offset
........ ....... ....................................
0.00% _raw_spin_lock+0x13
account_process_tick+0x15a
apic_timer_interrupt+0x0
check_preempt_wakeup+0x174
0.00% f1+0x0
0.00% f1+0x1
0.00% f1+0xe
0.00% f2+0xb
0.03% +0.02% f2+0x14
0.02% f2+0x1a
30.75% -0.18% f2+0x1d
7.66% -0.18% f2+0x20
0.00% f2+0x29
7.69% +0.12% f2+0x2c
0.01% f2+0x33
0.01% f2+0x34
0.00% f3+0x0
7.67% +0.15% f3+0xd
0.01% f3+0x10
f3+0x13
3.95% -0.21% f3+0x17
3.91% -0.05% f3+0x20
3.74% +0.04% f3+0x22
4.00% -0.10% f3+0x2b
30.44% +0.45% f3+0x2e
0.02% f3+0x35
0.02% f3+0x36
0.00% ktime_get+0x9c
0.00% main+0x1a
main+0x21
0.00% native_read_tsc+0x6
0.00% native_write_msr_safe+0xa
rcu_irq_enter+0x88
0.00% rcu_note_context_switch+0x12
0.00% run_timer_softirq+0x292
timekeeping_update.constprop.7+0x9c
0.00% timerqueue_add+0x50---
The patch is seperated from "[PATCH V4 0/3] perf tool: perf diff sort changes" patch set.
The first patch of the patch set has been merged.
The second patch to support perf diff different binaries was submitted by another thread.
This is the third patch to support symoff.
Changes since V4:
- Seperate from old patch set
- Symoff print format
- Check build_id
- Update man page
tools/perf/Documentation/perf-diff.txt | 2 +- tools/perf/Documentation/perf-report.txt | 1 + tools/perf/builtin-diff.c | 2 +- tools/perf/util/hist.c | 7 ++++ tools/perf/util/hist.h | 1 + tools/perf/util/sort.c | 67 ++++++++++++++++++++++++++++++++ tools/perf/util/sort.h | 2 + 7 files changed, 80 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-diff.txt +1 -1
@@ -50,7 +50,7 @@ OPTIONS -s:: --sort=:: - Sort by key(s): pid, comm, dso, symbol, cpu, parent, srcline. + Sort by key(s): pid, comm, dso, symbol, cpu, parent, srcline, symoff. Please see description of --sort in the perf-report man page. -t::
tools/perf/Documentation/perf-report.txt +1 -0
@@ -70,6 +70,7 @@ OPTIONS - pid: command and tid of the task - dso: name of library or module executed at the time of sample - symbol: name of function executed at the time of sample + - symoff: exact symbol + offset address executed at the time of sample. - parent: name of function matched to the parent regex filter. Unmatched entries are displayed as "[other]". - cpu: cpu number the task ran at the time of sample
tools/perf/builtin-diff.c +1 -1
@@ -744,7 +744,7 @@ static const struct option options[] = {OPT_STRING ('S' ,"symbols" , &symbol_conf.sym_list_str,"symbol[,symbol...]" ,"only consider these symbols" ),OPT_STRING ('s' ,"sort" , &sort_order,"key[,key2...]" , -"sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ..." +"sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, symoff, ..." " Please refer the man page for the complete list." ),OPT_STRING ('t' ,"field-separator" , &symbol_conf.field_sep,"separator" , "separator for columns, no spaces will be added between "
tools/perf/util/hist.c +7 -0
@@ -59,6 +59,7 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)u16 len;/* +* +6 accounts for '"+0xYYY ' symoff info * +4 accounts for '[x] ' priv level info * +2 accounts for 0x prefix on raw addresses * +3 accounts for ' y ' symtab origin info
@@ -68,10 +69,16 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h)if (verbose) symlen +=BITS_PER_LONG /4 +2 +3 ;hists__new_col_len (hists,HISTC_SYMBOL , symlen); + + symlen = h->ms.sym->namelen +6 ; +hists__new_col_len (hists,HISTC_SYMOFF , symlen); }else { symlen = unresolved_col_width +4 +2 ;hists__new_col_len (hists,HISTC_SYMBOL , symlen);hists__set_unres_dso_col_len (hists,HISTC_DSO ); + + symlen = unresolved_col_width +2 ; +hists__new_col_len (hists,HISTC_SYMOFF , symlen); } len =thread__comm_len (h->thread);
tools/perf/util/hist.h +1 -0
@@ -24,6 +24,7 @@ enum hist_filter {enum hist_column {HISTC_SYMBOL , +HISTC_SYMOFF ,HISTC_DSO ,HISTC_THREAD ,HISTC_COMM ,
tools/perf/util/sort.c +67 -0
85 lines not on this page · raw message
tools/perf/util/sort.h +2 -0
@@ -38,6 +38,7 @@ extern enum sort_mode sort__mode;extern struct sort_entry sort_comm;extern struct sort_entry sort_dso;extern struct sort_entry sort_sym; +extern struct sort_entry sort_symoff;extern struct sort_entry sort_parent;extern struct sort_entry sort_dso_from;extern struct sort_entry sort_dso_to;
@@ -161,6 +162,7 @@ enum sort_type {SORT_COMM ,SORT_DSO ,SORT_SYM , +SORT_SYMOFF ,SORT_PARENT ,SORT_CPU , SORT_SRCLINE,
Signature · 1 line
1.8.3.2
PATCH v5 2/3 perf tool: new function to compare build_ids
From: Arnaldo Carvalho de Melo <[email protected]>
New function to compare the build_ids between different DSOs
--- tools/perf/util/dso.c | 33 +++++++++++++++++++++++++++++++++ tools/perf/util/dso.h | 3 +++ 2 files changed, 36 insertions(+)
tools/perf/util/dso.c +33 -0
@@ -1087,3 +1087,36 @@ enum dso_type dso__type(struct dso *dso, struct machine *machine)return dso__type_fd (fd); } + +bool dsos__build_ids_equal (struct dsos *dsos_a,struct dsos *dsos_b) +{ +bool ret; +struct dso *dso_a, *dso_b; + +list_for_each_entry (dso_a, &dsos_a->head, node) { + dso_b =dsos__find (dsos_b, dso_a->long_name, false); +if (dso_b ==NULL ) +return false; + +if (memcmp (dso_a->build_id, dso_b->build_id,sizeof (dso_a->build_id))) +return false; + +/* Mark that we compared this one */ + dso_b->visited =1 ; + } + +/* +* Now check if there are dsos in dsos_b that are not in +* dsos_a +*/ + + ret = true; +list_for_each_entry (dso_b, &dsos_b->head, node) { +if (!dso_b->visited) + ret = false; +else + dso_b->visited =0 ; + } + +return ret; +}
tools/perf/util/dso.h +3 -0
@@ -117,6 +117,7 @@ struct dso { u8 has_build_id:1; u8 has_srcline:1; u8 hit:1; + u8 visited:1; u8 annotate_warned:1; u8 short_name_allocated:1; u8 long_name_allocated:1;
@@ -278,4 +279,6 @@ void dso__free_a2l(struct dso *dso);enum dso_type dso__type (struct dso *dso,struct machine *machine); +bool dsos__build_ids_equal (struct dsos *dsos_a,struct dsos *dsos_b); +#endif /* __PERF_DSO */
Signature · 1 line
1.8.3.2
PATCH v5 3/3 perf tool: check buildid for symoff
In reply to Kan LiangFrom: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
--- tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++ tools/perf/util/sort.c | 3 +++ tools/perf/util/sort.h | 1 + 3 files changed, 29 insertions(+)
tools/perf/builtin-diff.c +25 -0
@@ -678,6 +678,28 @@ static void data__free(struct data__file *d) } } +static void buildid_check (void ) +{ +struct dsos *base_k_dsos = &data__files[0 ].session->machines.host.kernel_dsos; +struct dsos *base_u_dsos = &data__files[0 ].session->machines.host.user_dsos; +struct dsos *k_dsos_tmp, *u_dsos_tmp; +struct data__file *d; +int i; + +data__for_each_file_new (i, d) { + k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) +pr_warning ("The perf.data come from different kernel. " +"The kernel symbol offset may vary for different kernel.\n" ); + +if (!dsos__build_ids_equal (base_u_dsos, u_dsos_tmp)) +pr_warning ("The perf.data come from different user binary. " +"The user space symbol offset may vary for different binaries.\n" ); + } +} +static int __cmd_diff (void ) {struct data__file *d;
@@ -700,6 +722,9 @@ static int __cmd_diff(void)perf_evlist__collapse_resort (d->session->evlist); } +if (sort__has_symoff) +buildid_check (); +data_process (); out_delete:
tools/perf/util/sort.c +3 -0
@@ -21,6 +21,7 @@ int sort__need_collapse = 0;int sort__has_parent =0 ;int sort__has_sym =0 ;int sort__has_dso =0 ; +int sort__has_symoff =0 ;enum sort_mode sort__mode =SORT_MODE__NORMAL ;
@@ -1493,6 +1494,7 @@ int sort_dimension__add(const char *tok) }else if (sd->entry == &sort_dso) { sort__has_dso =1 ; }else if (sd->entry == &sort_symoff) { + sort__has_symoff =1 ;/* * For symoff sort key, not only the offset but also the * symbol name should be compared.
@@ -1877,6 +1879,7 @@ void reset_output_field(void) sort__has_parent =0 ; sort__has_sym =0 ; sort__has_dso =0 ; + sort__has_symoff =0 ; field_order =NULL ; sort_order =NULL ;
tools/perf/util/sort.h +1 -0
@@ -34,6 +34,7 @@ extern int have_ignore_callees;extern int sort__need_collapse;extern int sort__has_parent;extern int sort__has_sym; +extern int sort__has_symoff;extern enum sort_mode sort__mode;extern struct sort_entry sort_comm;extern struct sort_entry sort_dso;
Signature · 1 line
1.8.3.2
Re: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 31 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Signed-off-by Kan Liang <[email protected]>--- tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++ tools/perf/util/sort.c | 3 +++ tools/perf/util/sort.h | 1 + 3 files changed, 29 insertions(+)tools/perf/builtin-diff.c +9
-0@@ -678,6 +678,28 @@ static void data__free(struct data__file *d) } } +static void buildid_check (void ) +{ +struct dsos *base_k_dsos = &data__files[0 ].session->machines.host.kernel_dsos; +struct dsos *base_u_dsos = &data__files[0 ].session->machines.host.user_dsos; +struct dsos *k_dsos_tmp, *u_dsos_tmp; +struct data__file *d; +int i; + +data__for_each_file_new (i, d) {
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 699
Quoted 10 lines
tools/perf/builtin-diff.c +10
-0+ k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) +pr_warning ("The perf.data come from different kernel. " +"The kernel symbol offset may vary for different kernel.\n" ); + +if (!dsos__build_ids_equal (base_u_dsos, u_dsos_tmp)) +pr_warning ("The perf.data come from different user binary. " +"The user space symbol offset may vary for different binaries.\n" );
we dont specify the kernel version or dso path in the warning message, maybe we want to print it out just once? In case there's more than 2 not matching data?
jirka
RE: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 48 lines · Kan Liang
Quoted 28 lines
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Signed-off-by Kan Liang <[email protected]>--- tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++ tools/perf/util/sort.c | 3 +++ tools/perf/util/sort.h | 1 + 3 files changed, 29 insertions(+)tools/perf/builtin-diff.c +4
-0@@ -678,6 +678,28 @@ static void data__free(struct data__file *d) } } +static void buildid_check (void ) +{ +struct dsos *base_k_dsos = &data__files[0 ].session- machines.host.kernel_dsos; +struct dsos *base_u_dsos = &data__files[0 ].session- machines.host.user_dsos;tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 696
Quoted 10 lines
tools/perf/builtin-diff.c +10
-0+struct dsos *k_dsos_tmp, *u_dsos_tmp; +struct data__file *d; +int i; + +data__for_each_file_new (i, d) { + k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) + pr_warning("The perf.data come from differentkernel. "
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 697
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+ "The kernel symbol offset may vary fordifferent kernel.\n");
tools/perf/builtin-diff.c static void data__free(struct data__file *d)
Quoted 3 lines
tools/perf/builtin-diff.c +3
-0+ +if (!dsos__build_ids_equal (base_u_dsos, u_dsos_tmp)) + pr_warning("The perf.data come from differentuser binary. "
Quoted 7 lines
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 701
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+ "The user space symbol offset may varyfor different
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 702
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+binaries.\n");we dont specify the kernel version or dso path in the warning message, maybe we want to print it out just once? In case there's more than 2 not matching data?
Could we print the header instead? It should be more informative. Maybe we can print it with --verbose.
What do you think about the patch as below?
+static void buildid_check(void)
+{
+ struct dsos *base_k_dsos = &data__files[0].session->machines.host.kernel_dsos; + struct dsos *base_u_dsos = &data__files[0].session->machines.host.user_dsos; + struct dsos *k_dsos_tmp, *u_dsos_tmp; + struct data__file *d; + bool k_warn, u_warn; + bool first = true; + int i;
+
+ data__for_each_file_new(i, d) {
+ k_dsos_tmp = &d->session->machines.host.kernel_dsos;
+ u_dsos_tmp = &d->session->machines.host.user_dsos;
+
+ k_warn = !dsos__build_ids_equal(base_k_dsos, k_dsos_tmp);
+ u_warn = !dsos__build_ids_equal(base_u_dsos, u_dsos_tmp);
+
+ if (k_warn || u_warn) {
+ pr_warning("The perf.data come from different %s%s%s. "
+ "The symbol offset may vary.\n",
+ k_warn ? "kernel" : "",
+ (k_warn && u_warn) ? " and " : "",
+ u_warn ? "user bunary" : "");
+
+ if (verbose) {
+ if (first) {
+ fprintf(stdout, "# ========%s (Baseline)\n", data__files[0].file.path);
+ perf_header__fprintf_info(data__files[0].session, stdout, false);
+ fprintf(stdout, "# ========\n#\n");
+ first = false;
+ }
+ fprintf(stdout, "# ========%s\n", d->file.path);
+ perf_header__fprintf_info(d->session, stdout, false);
+ fprintf(stdout, "# ========\n#\n");+ }
+ }
+ }
+}
Quoted 2 lines
jirka
Re: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 50 lines · Kan
Quoted 50 lines · Kan Liang
Quoted 28 lines
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Signed-off-by Kan Liang <[email protected]>--- tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++ tools/perf/util/sort.c | 3 +++ tools/perf/util/sort.h | 1 + 3 files changed, 29 insertions(+)tools/perf/builtin-diff.c +4
-0@@ -678,6 +678,28 @@ static void data__free(struct data__file *d) } } +static void buildid_check (void ) +{ +struct dsos *base_k_dsos = &data__files[0 ].session- machines.host.kernel_dsos; +struct dsos *base_u_dsos = &data__files[0 ].session- machines.host.user_dsos;tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 696
Quoted 10 lines
tools/perf/builtin-diff.c +10
-0+struct dsos *k_dsos_tmp, *u_dsos_tmp; +struct data__file *d; +int i; + +data__for_each_file_new (i, d) { + k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) + pr_warning("The perf.data come from differentkernel. "
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 697
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+ "The kernel symbol offset may vary fordifferent kernel.\n");
tools/perf/builtin-diff.c static void data__free(struct data__file *d)
Quoted 3 lines
tools/perf/builtin-diff.c +3
-0+ +if (!dsos__build_ids_equal (base_u_dsos, u_dsos_tmp)) + pr_warning("The perf.data come from differentuser binary. "
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 701
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+ "The user space symbol offset may varyfor different
Quoted 8 lines
Quoted 5 lines
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 702
Quoted 1 line
tools/perf/builtin-diff.c +1
-0+binaries.\n");we dont specify the kernel version or dso path in the warning message, maybe we want to print it out just once? In case there's more than 2 not matching data?
Could we print the header instead? It should be more informative. Maybe we can print it with --verbose.
IMO one (WARN_ONCE style) warning by default if we see buildids discrepancy and detailed comparison for --verbose
jirka
Re: [PATCH V5 3/3] perf tool: check buildid for symoff
In reply to Kan LiangQuoted 29 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Signed-off-by Kan Liang <[email protected]>--- tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++ tools/perf/util/sort.c | 3 +++ tools/perf/util/sort.h | 1 + 3 files changed, 29 insertions(+)tools/perf/builtin-diff.c +7
-0@@ -678,6 +678,28 @@ static void data__free(struct data__file *d) } } +static void buildid_check (void ) +{ +struct dsos *base_k_dsos = &data__files[0 ].session->machines.host.kernel_dsos; +struct dsos *base_u_dsos = &data__files[0 ].session->machines.host.user_dsos; +struct dsos *k_dsos_tmp, *u_dsos_tmp; +struct data__file *d; +int i;
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 697
Quoted 10 lines
tools/perf/builtin-diff.c +10
-0+ +data__for_each_file_new (i, d) { + k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) +pr_warning ("The perf.data come from different kernel. " +"The kernel symbol offset may vary for different kernel.\n" ); + +if (!dsos__build_ids_equal (base_u_dsos, u_dsos_tmp))
looks like at this time not all dsos on the list have the buildids read..
I tried to put in here the perf_session__read_build_ids call but it keeps showing me warning below:
tools/perf/builtin-diff.c static void data__free(struct data__file *d) · line 699
Quoted 2 lines
tools/perf/builtin-diff.c +2
-0+pr_warning ("The perf.data come from different user binary. " +"The user space symbol offset may vary for different binaries.\n" );
for following workload:
[jolsa@krava perf]$ ./perf record ls
...
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ]
[jolsa@krava perf]$ ./perf record ls
...
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ]
[jolsa@krava perf]$ ./perf diff -s symoff
The perf.data come from different user binary. The user space symbol offset may vary for different binaries. # Event 'cycles'
...
jirka
RE: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 9 lines
tools/perf/builtin-diff.c static void data__free(struct data__file *d)
Quoted 8 lines
tools/perf/builtin-diff.c +6
-0+data__for_each_file_new (i, d) { + k_dsos_tmp = &d->session->machines.host.kernel_dsos; + u_dsos_tmp = &d->session->machines.host.user_dsos; + +if (!dsos__build_ids_equal (base_k_dsos, k_dsos_tmp)) + pr_warning("The perf.data come from differentkernel. "
Quoted 7 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ "The kernel symbol offset may vary fordifferent kernel.\n");
Review
Quoted 2 lines
(quoted diff) +2
-0+ + if (!dsos__build_ids_equal(base_u_dsos, u_dsos_tmp))looks like at this time not all dsos on the list have the buildids read..
Right, I shouldn't assume all dsos have biuldids. I will modify the dsos__build_ids_equal to check has_build_id.
If neither dsos have build_id, it will printpr_debug ("Cannot get build_id for all dsos\n") once, and continue to do next dso compare.
All the buildid compare related warnings will also be printed once.
Quoted 11 lines
I tried to put in here the
perf_session__read_build_idscall but it keeps showing me warning below:Review
Quoted 1 line
(quoted diff) +1
-0+ pr_warning("The perf.data come from differentuser binary. "
Review
Quoted 1 line
(quoted diff) +1
-0+ "The user space symbol offset may varyfor different
Quoted 1 line
+binaries.\n");
for following workload:
Quoted 11 lines
[jolsa@krava perf]$ ./perf record ls
...
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ] [jolsa@krava perf]$ ./perf record ls ...
[ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ] [jolsa@krava perf]$ ./perf diff - s symoff The perf.data come from different user binary. The user space symbol offset may vary for different binaries.
# Event 'cycles'
...
Another reason for the false warning is that we use long_name to find the dso_b. However, the long_name is not unique.
The vmlinux dso is added when processing header. Its long name and short name are same. (E.g. /lib/modules/3.18.0-rc3-01635-g05066a2-dirty/build/vmlinux) When processing sample, vmlinux is loaded. Two new dsos are added for section "init.text" and "exit.text". They also have the long name /lib/modules/3.18.0-rc3-01635-g05066a2-dirty/build/vmlinux. But their short name are different, [kernel.vmlinux].init.text and [kernel.vmlinux].exit.text.
So I will change the dsos__build_ids_equal to find the dso by short_name.
Kan
Quoted 3 lines
jirka
Namhyung Kim
maintainerRe: [PATCH V5 3/3] perf tool: check buildid for symoff
In reply to Kan LiangHi Kan,
Quoted 6 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Hmm.. I think that perf diff is supposed to compare performance between different (i.e. modified) binaries. So there's a little point to print the warning IMHO - but I'm not insist it strongly..
Anyway, I think what we really need for the warning is different version of same binary. For example, if data file 1 has DSO A and B, and data file 2 has DSO B and C, we should not consider they're different (unless build-ids of B in data file 1 and 2 are different) since A and C won't affect symoff comparision.
Thanks,
Namhyung
RE: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 16 lines
Hi Kan,
Quoted 6 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Hmm.. I think that perf diff is supposed to compare performance between different (i.e. modified) binaries. So there's a little point to print the warning IMHO - but I'm not insist it strongly..
Quoted 6 lines
Anyway, I think what we really need for the warning is different version of same binary. For example, if data file 1 has DSO A and B, and data file 2 has DSO B and C, we should not consider they're different (unless build-ids of B in data file 1 and 2 are different) since A and C won't affect symoff comparision.
It looks good.
But I still slightly prefer to warn/inform the user if there are any different dsos, not just from common part. But it's not a strong option.
I'd like to hear from others.
Arnaldo? Jirka?
Thanks,
Kan
Quoted 2 lines
Thanks,
Namhyung
Re: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 16 lines · Kan
Quoted 16 lines
Hi Kan,
Quoted 6 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Hmm.. I think that perf diff is supposed to compare performance between different (i.e. modified) binaries. So there's a little point to print the warning IMHO - but I'm not insist it strongly..
Quoted 5 lines
Quoted 5 lines
Anyway, I think what we really need for the warning is different version of same binary. For example, if data file 1 has DSO A and B, and data file 2 has DSO B and C, we should not consider they're different (unless build-ids of B in data file 1 and 2 are different) since A and C won't affect symoff comparision.
that sounds good to me
Quoted 8 lines
Quoted 1 line
It looks good.
But I still slightly prefer to warn/inform the user if there are any different dsos, not just from common part. But it's not a strong option.
I'd like to hear from others.Arnaldo? Jirka?
sorry for late reply.. anyway like I said in the other email
---
IMO one (WARN_ONCE style) warning by default if we see buildids discrepancy and detailed comparison for --verbose
---
I think the breakage of the check (that Namhyung described) could be mentioned/labeled somehow as serious issue in the warning and we could also 'inform' about "any different dsos" as you mentioned
jirka
Quoted 6 lines
Thanks,
KanQuoted 2 lines
Thanks,
Namhyung
RE: [PATCH V5 3/3] perf tool: check buildid for symoff
Quoted 39 lines · Kan
Quoted 16 lines
Quoted 16 lines
Hi Kan,
Quoted 6 lines · Kan Liang
From: Kan Liang <[email protected]>
symoff can support both same binaries and different binaries. However, the offset may be changed for different binaries. This patch checks the buildid of perf.data. If they are from different binaries, print a warning to notify the user.
Hmm.. I think that perf diff is supposed to compare performance between different (i.e. modified) binaries. So there's a little point to print the warning IMHO - but I'm not insist it strongly..
Quoted 5 lines
Quoted 5 lines
Anyway, I think what we really need for the warning is different version of same binary. For example, if data file 1 has DSO A and B, and data file 2 has DSO B and C, we should not consider they're different (unless build-ids of B in data file 1 and 2 are different) since A and C won't affect symoff comparision.
that sounds good to me
Quoted 8 lines
Quoted 1 line
It looks good.
But I still slightly prefer to warn/inform the user if there are any different dsos, not just from common part. But it's not a strong option. I'd like to hear from others.Arnaldo? Jirka?
sorry for late reply.. anyway like I said in the other email
Quoted 9 lines
---
IMO one (WARN_ONCEstyle) warning by default if we see buildids discrepancy and detailed comparison for --verbose
---I think the breakage of the check (that Namhyung described) could be mentioned/labeled somehow as serious issue in the warning and we could also 'inform' about "any different dsos" as you mentioned
I c. Thanks Namhyung and Jirka's suggestion.
So for next version, only the common part of the dsos will be checked and warned once.
For the details of dsos, the user can apply --verbose to get a full list of dsos. I will also change the man menu for diff accordingly as below. "--verbose:: Be verbose, for instance, show the raw counts and all build-ids in addition to the diff"
Thanks,
Kan
Quoted 8 lines
jirka
Quoted 6 lines
Thanks,
KanQuoted 2 lines
Thanks,
Namhyung