Skip to contentSkip to conversation

cgroups: Documentation: fix wrong cgroupfs paths

PATCH In review SeongJae Park 2 participants 3 messages Nov 24, 2014

Subsystems (2)
Documentation cgroup
lore
Share & tools
lore

SeongJae Park

author
#0 lore raw

PATCH 1/1 cgroups: Documentation: fix wrong cgroupfs paths

Few paths used as example to describe cgroupfs usage have been wrong from f6e07d38078e ("Documentation: update cgroupfs mount point") by mistake. This patch fix those trivial wrong paths.

Signed-off-by SeongJae Park <[email protected]>
---
 Documentation/cgroups/cgroups.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/cgroups/cgroups.txt +2 -2
index 10c949b..f935fac 100644
@@ -312,10 +312,10 @@ the "cpuset" cgroup subsystem, the steps are something like:
  2) mkdir /sys/fs/cgroup/cpuset
  3) mount -t cgroup -ocpuset cpuset /sys/fs/cgroup/cpuset
  4) Create the new cgroup by doing mkdir's and write's (or echo's) in
-    the /sys/fs/cgroup virtual file system.
+    the /sys/fs/cgroup/cpuset virtual file system.
  5) Start a task that will be the "founding father" of the new job.
  6) Attach that task to the new cgroup by writing its PID to the
-    /sys/fs/cgroup/cpuset/tasks file for that cgroup.
+    /sys/fs/cgroup/cpuset tasks file for that cgroup.
  7) fork, exec or clone the job tasks from this founding father task.
 
 For example, the following sequence of commands will setup a cgroup
Signature · 1 line
1.9.1
maintainer
#1 lore raw

Documentation/cgroups/cgroups.txt the "cpuset" cgroup subsystem, the steps are something like: · line 318

Quoted 3 lines · On Tue, 25 Nov 2014 01:39:19 +0900 SeongJae Park <[email protected]> wrote:

6) Attach that task to the new cgroup by writing its PID to the

Documentation/cgroups/cgroups.txt +1 -1
-    /sys/fs/cgroup/cpuset/tasks file for that cgroup.
+    /sys/fs/cgroup/cpuset tasks file for that cgroup.

That one looks like it was correct before the change...? What am I missing here?

Thanks,

jon

author
#2 lore raw
Quoted 9 lines · Jonathan Corbet

Documentation/cgroups/cgroups.txt the "cpuset" cgroup subsystem, the steps are something like: · line 318

Quoted 3 lines · On Tue, 25 Nov 2014 01:39:19 +0900 SeongJae Park <[email protected]> wrote:

6) Attach that task to the new cgroup by writing its PID to the

Documentation/cgroups/cgroups.txt +1 -1
-    /sys/fs/cgroup/cpuset/tasks file for that cgroup.
+    /sys/fs/cgroup/cpuset tasks file for that cgroup.

That one looks like it was correct before the change...? What am I missing here?

It should represents /sys/fs/cgroup/cpuset/<*new cgroup name*>/tasks, not /sys/fs/cgroup/cpuset/tasks.

If there are better suggestions or anything I am missing, please let me know.

Thanks,
SeongJae Park

Quoted 4 lines

Thanks,

jon