Drivers:staging:vt6656: Fixed checkpatch warning
PATCH 1/1 Drivers:staging:vt6656: Fixed checkpatch warning
Fixed the checkpatch warning:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
Signed-off-by Athira Lekshmi C V <[email protected]>
--- drivers/staging/vt6656/rxtx.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/staging/vt6656/rxtx.c +9 -9
@@ -392,8 +392,8 @@ static int vnt_fill_ieee80211_rts(struct vnt_usb_send_context *tx_context, rts->frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_RTS ); -memcpy (rts->ra, hdr->addr1,ETH_ALEN ); -memcpy (rts->ta, hdr->addr2,ETH_ALEN ); +ether_addr_copy (rts->ra, hdr->addr1); +ether_addr_copy (rts->ta, hdr->addr2);return 0 ; }
@@ -552,7 +552,7 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context, buf->data.frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_CTS ); -memcpy (buf->data.ra, priv->current_net_addr,ETH_ALEN ); +ether_addr_copy (buf->data.ra, priv->current_net_addr);return vnt_rxtx_datahead_g_fb (tx_context, &buf->data_head); }else {
@@ -570,7 +570,7 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context, buf->data.frame_control =cpu_to_le16 (IEEE80211_FTYPE_CTL |IEEE80211_STYPE_CTS ); -memcpy (buf->data.ra, priv->current_net_addr,ETH_ALEN ); +ether_addr_copy (buf->data.ra, priv->current_net_addr);return vnt_rxtx_datahead_g (tx_context, &buf->data_head); }
@@ -739,7 +739,7 @@ static void vnt_fill_txkey(struct vnt_usb_send_context *tx_context, mic_hdr->id =0x59 ; mic_hdr->payload_len =cpu_to_be16 (payload_len); -memcpy (mic_hdr->mic_addr2, hdr->addr2,ETH_ALEN ); +ether_addr_copy (mic_hdr->mic_addr2, hdr->addr2);ieee80211_get_key_tx_seq (tx_key, &seq);
@@ -750,9 +750,9 @@ static void vnt_fill_txkey(struct vnt_usb_send_context *tx_context,else mic_hdr->hlen =cpu_to_be16 (22 ); -memcpy (mic_hdr->addr1, hdr->addr1,ETH_ALEN ); -memcpy (mic_hdr->addr2, hdr->addr2,ETH_ALEN ); -memcpy (mic_hdr->addr3, hdr->addr3,ETH_ALEN ); +ether_addr_copy (mic_hdr->addr1, hdr->addr1); +ether_addr_copy (mic_hdr->addr2, hdr->addr2); +ether_addr_copy (mic_hdr->addr3, hdr->addr3); mic_hdr->frame_control =cpu_to_le16 (le16_to_cpu (hdr->frame_control) &0xc78f );
@@ -760,7 +760,7 @@ static void vnt_fill_txkey(struct vnt_usb_send_context *tx_context, le16_to_cpu(hdr->seq_ctrl) & 0xf);if (ieee80211_has_a4 (hdr->frame_control)) -memcpy (mic_hdr->addr4, hdr->addr4,ETH_ALEN ); +ether_addr_copy (mic_hdr->addr4, hdr->addr4);memcpy (key_buffer, tx_key->key,WLAN_KEY_LEN_CCMP );
Signature · 1 line
1.7.9.5
Quoted 2 lines · Athira Lekshmi C V
Fixed the checkpatch warning:
WARNING: Preferether_addr_copy()overmemcpy()if the Ethernet addresses are__aligned(2)
For these changes the change log must say how you determined both source and destination are aligned correctly.
regards,
dan carpenter