x86: bpf_jit_comp: simplify trivial boolean return

PATCH New Quentin Lambert 1 participant 1 message Nov 26, 2014

Subsystems (5)

Networking Network drivers x86 BPF +1 more subsystems

lore

Share & tools

lore

Quentin Lambert

author

2014-11-26 09:14 UTC #0 lore raw

PATCH 1/1 x86: bpf_jit_comp: simplify trivial boolean return

Remove if then else statements preceding
boolean return. Occurences were found using
Coccinelle.

The semantic patch used was:

@@
expression expr;
@@

- if ( expr )
- return true;
- else
- return false;
+ return expr;

Signed-off-by Quentin Lambert <[email protected]>

---
 arch/x86/net/bpf_jit_comp.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

arch/x86/net/bpf_jit_comp.c +3 -5

index 3f62734..1542f39 100644
@@ -135,11 +135,9 @@ static const int reg2hex[] = {
  */
 static inline bool is_ereg(u32 reg)
 {
-	if (reg == BPF_REG_5 || reg == AUX_REG ||
-	    (reg >= BPF_REG_7 && reg <= BPF_REG_9))
-		return true;
-	else
-		return false;
+	return (reg == BPF_REG_5 ||
+		reg == AUX_REG ||
+		(reg >= BPF_REG_7 && reg <= BPF_REG_9));
 }
 
 /* add modifiers if 'reg' maps to x64 registers r8..r15 */