Skip to contentSkip to conversation

mtd: gpmi: Remove "We support only one NAND chip" from bindings doc

PATCH In review Stefan Roese 6 participants 12 messages Nov 27, 2014 – Dec 18, 2014 8 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: gpmi: Remove "We support only one NAND chip" from bindings doc

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not confuse anyone.

Cc Huang Shijie <[email protected]>
Cc Brian Norris <[email protected]>
---
 Documentation/devicetree/bindings/mtd/gpmi-nand.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mtd/gpmi-nand.txt +1 -1
index a011fdf..d02acaf 100644
@@ -1,7 +1,7 @@
 * Freescale General-Purpose Media Interface (GPMI)
 
 The GPMI nand controller provides an interface to control the
-NAND flash chips. We support only one NAND chip now.
+NAND flash chips.
 
 Required properties:
   - compatible : should be "fsl,<chip>-gpmi-nand"
Signature · 6 lines
2.2.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

A message that is not in the archive (sent off-list or not yet received): 1417097929-17832-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org

#2 lore raw
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20141128014832.GA3113-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

#4 lore raw
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 5 lines · Stefan Roese
Quoted 4 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

Quoted 7 lines
Quoted 2 lines

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

The "one chip" here is means the "one package" (TSOP or BGA ....).

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20141129024047.GA5056-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

#8 lore raw
Quoted 6 lines · Huang Shijie
Quoted 5 lines · Stefan Roese
Quoted 4 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

Quoted 2 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#9 lore raw
Quoted 14 lines · Brian Norris
Quoted 13 lines · Huang Shijie
Quoted 12 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Quoted 6 lines
Quoted 1 line

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

yes. It is okay to send a patch to make it more clear.

Quoted 6 lines
Quoted 3 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

The gpmi can only connect with one physical chip now, but there maybe two DIEs in this chip.

thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20141130154255.GB14834-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

#11 lore raw
Quoted 25 lines · Huang Shijie
Quoted 14 lines · Brian Norris
Quoted 13 lines · Huang Shijie
Quoted 12 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Quoted 6 lines
Quoted 1 line

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

yes. It is okay to send a patch to make it more clear.

Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

The gpmi can only connect with one physical chip now, but there maybe two DIEs in this chip.

I really fail to see why you make this distinction between two chips on a die and two external chips. For the SoC this should really look identical, right?

Please explain again, why exactly only two chips on one die are supported.

BTW: We have a custom i.MX6DL based board with 2 NAND chips connected. And Linux seems to support both chips just fine. Here the boot log:

[    1.085812] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
[    1.092218] nand: Micron MT29F4G08ABADAH4
[    1.096245] nand: 512MiB, SLC, page size: 2048, OOB size: 64
[    1.102171] nand: 2 chips detected
[    1.106156] gpmi-nand 112000.gpmi-nand: enable the asynchronous EDO mode 5
[    1.113094] Scanning device for bad blocks

Comments welcome...

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#13 lore raw
Quoted 31 lines · Stefan Roese
Quoted 30 lines · Huang Shijie
Quoted 14 lines · Brian Norris
Quoted 13 lines · Huang Shijie
Quoted 12 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Quoted 6 lines
Quoted 1 line

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

yes. It is okay to send a patch to make it more clear.

Quoted 6 lines
Quoted 3 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

Quoted 7 lines
Quoted 2 lines

The gpmi can only connect with one physical chip now, but there maybe two DIEs in this chip.

I really fail to see why you make this distinction between two chips on a die and two external chips. For the SoC this should really look identical, right?

Please explain again, why exactly only two chips on one die are supported.

There are only 8 data lines for gpmi. I guess there may bugs in the gpmi driver to support the two external chips in such case:
Two different processes access different NAND chips at the same time.

I even did not have enough time to test the "two chips on a die" case very carefully before I left freescale.

Quoted 2 lines

BTW: We have a custom i.MX6DL based board with 2 NAND chips connected. And

Very good. Please test this board with the UBIFS in the multi processes case. (I ever used the bonnie++)

Quoted 8 lines

Linux seems to support both chips just fine. Here the boot log:

[    1.085812] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
[    1.092218] nand: Micron MT29F4G08ABADAH4
[    1.096245] nand: 512MiB, SLC, page size: 2048, OOB size: 64
[    1.102171] nand: 2 chips detected
[    1.106156] gpmi-nand 112000.gpmi-nand: enable the asynchronous EDO mode 5
[    1.113094] Scanning device for bad blocks

could you please post more log?

thanks
Huang Shijie

Quoted 10 lines

Comments welcome...

Thanks,
Stefan

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20141202003840.GA11370-eV5aV+vWts7EmYkesOTNgGFmcEqAMTzPQQ4Iyu8u01E@public.gmane.org

#15 lore raw
Quoted 35 lines · Huang Shijie
Quoted 34 lines · Stefan Roese
Quoted 32 lines · Huang Shijie
Quoted 14 lines · Brian Norris
Quoted 13 lines · Huang Shijie
Quoted 12 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Quoted 6 lines
Quoted 1 line

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

yes. It is okay to send a patch to make it more clear.

Quoted 6 lines
Quoted 3 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

The gpmi can only connect with one physical chip now, but there maybe two DIEs in this chip.

Quoted 8 lines
Quoted 4 lines

I really fail to see why you make this distinction between two chips on a die and two external chips. For the SoC this should really look identical, right?

Please explain again, why exactly only two chips on one die are supported.

There are only 8 data lines for gpmi. I guess there may bugs in the gpmi driver to support the two external chips in such case:
Two different processes access different NAND chips at the same
time.

I don't see why this should be a problem. All SoC's that support multiple NAND chips (I've seen so far) only use 8 data lines for this.

Quoted 2 lines

I even did not have enough time to test the "two chips on a die" case very carefully before I left freescale.

I see. Thanks for the hint. But this "two chips on a die" scenario did pass some basic tests, no?

Quoted 5 lines
Quoted 2 lines

BTW: We have a custom i.MX6DL based board with 2 NAND chips connected. And

Very good. Please test this board with the UBIFS in the multi processes case. (I ever used the bonnie++)

We'll do that.

Quoted 9 lines
Quoted 8 lines

Linux seems to support both chips just fine. Here the boot log:

[    1.085812] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
[    1.092218] nand: Micron MT29F4G08ABADAH4
[    1.096245] nand: 512MiB, SLC, page size: 2048, OOB size: 64
[    1.102171] nand: 2 chips detected
[    1.106156] gpmi-nand 112000.gpmi-nand: enable the asynchronous EDO mode 5
[    1.113094] Scanning device for bad blocks

could you please post more log?

Sure.

...

[    1.068580] loop: module loaded
[    1.085966] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc
[    1.092372] nand: Micron MT29F4G08ABADAH4
[    1.096401] nand: 512MiB, SLC, page size: 2048, OOB size: 64
[    1.102331] nand: 2 chips detected
[    1.106342] gpmi-nand 112000.gpmi-nand: enable the asynchronous EDO mode 5
[    1.113279] Scanning device for bad blocks
[    1.126196] Bad eraseblock 58 at 0x000000740000
[    1.131074] Bad eraseblock 60 at 0x000000780000
[    1.515182] random: nonblocking pool is initialized
[    2.331738] 10 cmdlinepart partitions found on MTD device gpmi-nand
[    2.338028] Creating 10 MTD partitions on "gpmi-nand":
[    2.343210] 0x000000000000-0x000000e00000 : "spl"
[    2.351695] 0x000000e00000-0x000001000000 : "uboot"
[    2.359015] 0x000001000000-0x000001080000 : "env1"
[    2.366272] 0x000001080000-0x000001100000 : "env2"
[    2.373508] 0x000001100000-0x000020000000 : "ubi0"
[    2.381521] 0x000020000000-0x000020e00000 : "res0"
[    2.388781] 0x000020e00000-0x000021000000 : "res1"
[    2.396131] 0x000021000000-0x000021080000 : "res2"
[    2.403458] 0x000021080000-0x000021100000 : "res3"
[    2.410657] 0x000021100000-0x000040000000 : "ubi1"
[    2.418572] gpmi-nand 112000.gpmi-nand: driver registered.
[    2.428911] spi_imx 2008000.ecspi: probed

...

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#17 lore raw
Quoted 39 lines · Stefan Roese
Quoted 38 lines · Huang Shijie
Quoted 37 lines · Stefan Roese
Quoted 25 lines · Huang Shijie
Quoted 14 lines · Brian Norris
Quoted 13 lines · Huang Shijie
Quoted 12 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

Now I'm a bit confused. The i.MX6 supports 4 chips select signals. And isn't "two dies in this single chip" not practically the same as connecting 2 (or more) chips (same device) to multiple chip selects of the SoC? Where is the difference here?

Quoted 6 lines
Quoted 1 line

The "one chip" here is means the "one package" (TSOP or BGA ....).

Then why is this even in the DT binding doc? Isn't that a board-level constraint (and not a chip property) which should be obvious to the user? If so, then should we just drop the language? Or at a minimum, make it more specific so it doesn't confuse readers.

yes. It is okay to send a patch to make it more clear.

Quoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

(In logic, "two dies in this single chip" is same as connecting 2 chips to the gpmi.)

...which means that logically, you can connect more than one chip to the GPMI, right?

The gpmi can only connect with one physical chip now, but there maybe two DIEs in this chip.

I really fail to see why you make this distinction between two chips on a die and two external chips. For the SoC this should really look identical, right?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Please explain again, why exactly only two chips on one die are supported.

There are only 8 data lines for gpmi. I guess there may bugs in the gpmi driver to support the two external chips in such case:
Two different processes access different NAND chips at the same
time.

I don't see why this should be a problem. All SoC's that support multiple NAND chips (I've seen so far) only use 8 data lines for this.

ok.
If your test result can prove that the gpmi can support two chips.

I can ack this patch. (I ever thought the gpmi needs an extra patch to support the multiple chips)

Quoted 6 lines
Quoted 3 lines

I even did not have enough time to test the "two chips on a die" case very carefully before I left freescale.

I see. Thanks for the hint. But this "two chips on a die" scenario did pass some basic tests, no?

yes. It passed the bonnie++ test.

thanks
Huang Shijie
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#18 lore raw
Quoted 14 lines · Huang Shijie
Quoted 13 lines · Stefan Roese
Quoted 12 lines · Huang Shijie
Quoted 11 lines · Stefan Roese
Quoted 10 lines · Huang Shijie
Quoted 9 lines · Brian Norris
Quoted 8 lines · Huang Shijie
Quoted 7 lines · Stefan Roese
Quoted 6 lines · Huang Shijie
Quoted 2 lines · Stefan Roese

This sentence "We support only one NAND chip now" is not true any more. Multiple chips are supported. So lets remove this sentence to not

The gpmi can only supports one chip. Of course, there are maybe two dies in this single chip.

[...]

Quoted 6 lines

If your test result can prove that the gpmi can support two chips.

I can ack this patch. (I ever thought the gpmi needs an extra patch to support the multiple chips)

Quoted 1 line
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines

I even did not have enough time to test the "two chips on a die" case very carefully before I left freescale.

I see. Thanks for the hint. But this "two chips on a die" scenario did pass some basic tests, no?

yes. It passed the bonnie++ test.

If there are no more concrete objections, I'll apply this patch.

Brian

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/