Input: misc: gpio_tilt: Delete driver
Subsystems (3)
PATCH 1/1 Input: misc: gpio_tilt: Delete driver
This driver was merged in 2011 as a tool for detecting the orientation of a screen. The device driver assumes board file setup using the platform data from <linux/input/gpio_tilt.h>. But no boards in the kernel tree defines this platform data.
As I am faced with refactoring drivers to use GPIO descriptors and pass decriptor tables from boards, or use the device tree device drivers like these creates a serious problem: I cannot fix them and cannot test them, not even compile-test them with a system actually using it (no in-tree boardfile).
I suggest to delete this driver and rewrite it using device tree if it is still in use on actively maintained systems.
I can also offer to rewrite it out of the blue using device tree if someone promise to test it and help me iterate it.
---
Heiko: not meaning to be militant here, just contain the situation, as stated: if you like the driver and can test it, I can reimplement it from scratch using device tree.
--- Documentation/gpio/drivers-on-gpio.txt | 5 - Documentation/input/devices/gpio-tilt.rst | 103 --------------- drivers/input/misc/Kconfig | 14 -- drivers/input/misc/Makefile | 1 - drivers/input/misc/gpio_tilt_polled.c | 210 ------------------------------ include/linux/input/gpio_tilt.h | 74 ----------- 6 files changed, 407 deletions(-) delete mode 100644 Documentation/input/devices/gpio-tilt.rst delete mode 100644 drivers/input/misc/gpio_tilt_polled.c delete mode 100644 include/linux/input/gpio_tilt.h
Documentation/gpio/drivers-on-gpio.txt +0 -5
@@ -28,11 +28,6 @@ hardware descriptions such as device tree or ACPI: - gpio-beeper: drivers/input/misc/gpio-beeper.c is used to provide a beep from an external speaker connected to a GPIO line. -- gpio-tilt-polled: drivers/input/misc/gpio_tilt_polled.c provides tilt - detection switches using GPIO, which is useful for your homebrewn pinball - machine if for nothing else. It can detect different tilt angles of the - monitored object. - - extcon-gpio: drivers/extcon/extcon-gpio.c is used when you need to read an external connector status, such as a headset line for an audio driver or an HDMI connector. It will provide a better userspace sysfs interface than GPIO.
Documentation/input/devices/gpio-tilt.rst deleted +0 -103
103 lines not on this page · raw message
drivers/input/misc/Kconfig +0 -14
@@ -268,20 +268,6 @@ config INPUT_GPIO_BEEPER To compile this driver as a module, choose M here: the module will be called gpio-beeper. -config INPUT_GPIO_TILT_POLLED - tristate "Polled GPIO tilt switch" - depends on GPIOLIB || COMPILE_TEST - select INPUT_POLLDEV - help - This driver implements support for tilt switches connected - to GPIO pins that are not capable of generating interrupts. - - The list of gpios to use and the mapping of their states - to specific angles is done via platform data. - - To compile this driver as a module, choose M here: the - module will be called gpio_tilt_polled. - config INPUT_GPIO_DECODER tristate "Polled GPIO Decoder Input driver" depends on GPIOLIB || COMPILE_TEST
drivers/input/misc/Makefile +0 -1
@@ -36,7 +36,6 @@ obj-$(CONFIG_INPUT_DRV2665_HAPTICS) += drv2665.o obj-$(CONFIG_INPUT_DRV2667_HAPTICS) += drv2667.o obj-$(CONFIG_INPUT_GP2A) += gp2ap002a00f.o obj-$(CONFIG_INPUT_GPIO_BEEPER) += gpio-beeper.o -obj-$(CONFIG_INPUT_GPIO_TILT_POLLED) += gpio_tilt_polled.o obj-$(CONFIG_INPUT_GPIO_DECODER) += gpio_decoder.o obj-$(CONFIG_INPUT_HISI_POWERKEY) += hisi_powerkey.o obj-$(CONFIG_HP_SDC_RTC) += hp_sdc_rtc.o
drivers/input/misc/gpio_tilt_polled.c deleted +0 -210
210 lines not on this page · raw message
include/linux/input/gpio_tilt.h deleted +0 -74
74 lines not on this page · raw message
Signature · 1 line
2.14.3
PATCH 1/1 Input: misc: gpio_tilt: Delete driver
Hi Linus,
Am Mittwoch, 27. Dezember 2017, 13:15:47 CET schrieb Linus Walleij:
Quoted 17 lines
This driver was merged in 2011 as a tool for detecting the orientation of a screen. The device driver assumes board file setup using the platform data from <
linux/input/gpio_tilt.h>. But no boards in the kernel tree defines this platform data.As I am faced with refactoring drivers to use GPIO descriptors and pass decriptor tables from boards, or use the device tree device drivers like these creates a serious problem: I cannot fix them and cannot test them, not even compile-test them with a system actually using it (no in-tree boardfile).
I suggest to delete this driver and rewrite it using device tree if it is still in use on actively maintained systems.
I can also offer to rewrite it out of the blue using device tree if someone promise to test it and help me iterate it.
Quoted 6 lines
Cc Heiko St?bner <[email protected]>Signed-off-by Linus Walleij <[email protected]>---
Heiko: not meaning to be militant here, just contain the situation, as stated: if you like the driver and can test it, I can reimplement it from scratch using device tree.
It seems that piece of hardware (gpio-connected orientation-sensors) was really only used in the one s3c24xx-based device I hacked on in 2011.
I somehow lost focus from trying to do the s3c24xx devicetree migration when I started hacking on Rockchip stuff, so while I do have the devices still around, I don't think I'll find the time and energy trying to get a recent kernel to run on them anyway, so I'm fine with dropping the driver. It's simple enough to get reintroduced if someone really finds a device using it or time to redo the ereader support using devicetree.
So long story short
Heiko
PATCH 1/1 Input: misc: gpio_tilt: Delete driver
Quoted 37 lines · Heiko Stuebner
Hi Linus,
Am Mittwoch, 27. Dezember 2017, 13:15:47 CET schrieb Linus Walleij:
Quoted 17 lines
This driver was merged in 2011 as a tool for detecting the orientation of a screen. The device driver assumes board file setup using the platform data from <
linux/input/gpio_tilt.h>. But no boards in the kernel tree defines this platform data.As I am faced with refactoring drivers to use GPIO descriptors and pass decriptor tables from boards, or use the device tree device drivers like these creates a serious problem: I cannot fix them and cannot test them, not even compile-test them with a system actually using it (no in-tree boardfile).
I suggest to delete this driver and rewrite it using device tree if it is still in use on actively maintained systems.
I can also offer to rewrite it out of the blue using device tree if someone promise to test it and help me iterate it.
Quoted 6 lines
Cc Heiko St?bner <[email protected]>Signed-off-by Linus Walleij <[email protected]>---
Heiko: not meaning to be militant here, just contain the situation, as stated: if you like the driver and can test it, I can reimplement it from scratch using device tree.It seems that piece of hardware (gpio-connected orientation-sensors) was really only used in the one s3c24xx-based device I hacked on in 2011.
I somehow lost focus from trying to do the s3c24xx devicetree migration when I started hacking on Rockchip stuff, so while I do have the devices still around, I don't think I'll find the time and energy trying to get a recent kernel to run on them anyway, so I'm fine with dropping the driver. It's simple enough to get reintroduced if someone really finds a device using it or time to redo the ereader support using devicetree.
Quoted 2 lines
So long story short
Acked-by Heiko Stuebner <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry