Skip to contentSkip to conversation

Staging: ft1000 : ft1000-pcmcia: replace __attribute ((__packed__) with __packed macro per coding style guidelines in ft1000_dnld.c

PATCH In review Geoff Darst 2 participants 2 messages Nov 29, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: ft1000 : ft1000-pcmcia: replace __attribute ((__packed__) with __packed macro per coding style guidelines in ft1000_dnld.c

Replace two instances of __attribute ((__packed__) with __packed macro to address the warning found by the checkpatch.pl tool.

---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c +2 -2
index c1856f7..df1cf0c 100644
@@ -99,7 +99,7 @@ struct dsp_file_hdr {
 	u32  version_data_offset;	/* Offset were scrambled version data begins. */
 	u32  version_data_size;	/* Size, in words, of scrambled version data. */
 	u32  nDspImages;	/* Number of DSP images in file. */
-} __attribute__ ((packed));
+} __packed;
 
 struct dsp_image_info {
 	u32  coff_date;		/* Date/time when DSP Coff image was built. */
@@ -110,7 +110,7 @@ struct dsp_image_info {
 	u32  version;		/* Embedded version # of DSP code. */
 	unsigned short checksum;	/* Dsp File checksum */
 	unsigned short pad1;
-} __attribute__ ((packed));
+} __packed;
 
 void card_bootload(struct net_device *dev)
 {
Signature · 1 line
1.9.3
#1 lore raw

Please use shorter summary phrase (which appear an subject) + split commit message to more line (not one long line).

marek

Quoted 32 lines · Geoff Darst

Replace two instances of __attribute ((__packed__) with __packed macro to address the warning found by the checkpatch.pl tool.

---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c +2 -3
index c1856f7..df1cf0c 100644
@@ -99,7 +99,7 @@ struct dsp_file_hdr {
        u32  version_data_offset;       /* Offset were scrambled version data begins. */
        u32  version_data_size; /* Size, in words, of scrambled version data. */
        u32  nDspImages;        /* Number of DSP images in file. */
-} __attribute__ ((packed));
+} __packed;
 
 struct dsp_image_info {
        u32  coff_date;         /* Date/time when DSP Coff image was built. */
@@ -110,7 +110,7 @@ struct dsp_image_info {
        u32  version;           /* Embedded version # of DSP code. */
        unsigned short checksum;        /* Dsp File checksum */
        unsigned short pad1;
-} __attribute__ ((packed));
+} __packed;
 
 void card_bootload(struct net_device *dev)
 {
--

1.9.3

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com