Skip to contentSkip to conversation

mm/zsmalloc: allocate exactly size of struct zs_pool

RFC PATCH In review Ganesh Mahendran 2 participants 2 messages Nov 29, 2014 – Dec 1, 2014

Subsystems (2)
Memory management Zsmalloc compressed slab memory allocator
lore
Share & tools
lore

Ganesh Mahendran

author
#0 lore raw

RFC PATCH 1/1 mm/zsmalloc: allocate exactly size of struct zs_pool

In zs_create_pool(), we allocate memory more then sizeof(struct zs_pool)
ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);

This patch allocate memory of exactly needed size.

Signed-off-by Ganesh Mahendran <[email protected]>
---
 mm/zsmalloc.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
mm/zsmalloc.c +2 -3
index 2021df5..4d0a063 100644
@@ -979,12 +979,11 @@ static bool can_merge(struct size_class *prev, int size, int pages_per_zspage)
  */
 struct zs_pool *zs_create_pool(gfp_t flags)
 {
-	int i, ovhd_size;
+	int i;
 	struct zs_pool *pool;
 	struct size_class *prev_class = NULL;
 
-	ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);
-	pool = kzalloc(ovhd_size, GFP_KERNEL);
+	pool = kzalloc(sizeof(*pool), GFP_KERNEL);
 	if (!pool)
 		return NULL;
Signature · 1 line
1.7.9.5