drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
Subsystems (3)
PATCH 1/1 drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h
Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct is no needed due to never being used in the header file, psb_drv.h and therefore should be removed from this header file.
--- drivers/gpu/drm/gma500/psb_drv.h | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/gma500/psb_drv.h +0 -1
@@ -522,7 +522,6 @@ struct drm_psb_private {struct drm_display_mode *sdvo_lvds_vbt_mode;struct bdb_lvds_backlight *lvds_bl;/* LVDS backlight info from VBT */ -struct psb_intel_i2c_chan *lvds_i2c_bus;/* FIXME: Remove this? */ /* Feature bits from the VBIOS */ unsigned int int_tv_support:1;
Signature · 6 lines
2.1.0 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Patrik Jakobsson
maintainerQuoted 5 lines · Nicholas Krause
Removes unneeeded struct
*lvds_i2c_busof type,psb_intel_i2c_chanas this struct is no needed due to never being used in the header file,psb_drv.hand therefore should be removed from this header file.Signed-off-by Nicholas Krause <[email protected]>
The lvds_i2c_bus is in use and can't be removed. Please at least compile test your patches before submitting them.
Cheers
Patrik
Quoted 17 lines
--- drivers/gpu/drm/gma500/psb_drv.h | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/gma500/psb_drv.h +0
-2@@ -522,7 +522,6 @@ struct drm_psb_private {struct drm_display_mode *sdvo_lvds_vbt_mode;struct bdb_lvds_backlight *lvds_bl;/* LVDS backlight info from VBT */ -struct psb_intel_i2c_chan *lvds_i2c_bus;/* FIXME: Remove this? */ /* Feature bits from the VBIOS */ unsigned int int_tv_support:1; --
Quoted 2 lines
2.1.0
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Sorry about that Patrik. I will resend a v2 with just the FIXME removed. Regards Nick
Quoted 24 lines · Patrik Jakobsson
Quoted 5 lines · Nicholas Krause
Removes unneeeded struct
*lvds_i2c_busof type,psb_intel_i2c_chanas this struct is no needed due to never being used in the header file,psb_drv.hand therefore should be removed from this header file.Signed-off-by Nicholas Krause <[email protected]>The
lvds_i2c_busis in use and can't be removed. Please at least compile test your patches before submitting them.Cheers
PatrikQuoted 11 lines
--- drivers/gpu/drm/gma500/psb_drv.h | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/gma500/psb_drv.h +0
-0@@ -522,7 +522,6 @@ struct drm_psb_private {struct drm_display_mode *sdvo_lvds_vbt_mode;
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/gma500/psb_drv.h +0
-2struct bdb_lvds_backlight *lvds_bl;/* LVDS backlight info from VBT */ -struct psb_intel_i2c_chan *lvds_i2c_bus;/* FIXME: Remove this? */ /* Feature bits from the VBIOS */ unsigned int int_tv_support:1; --2.1.0
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel