MAINTAINERS: Fix up entry for Dell laptop SMM driver

PATCH In review Guenter Roeck 3 participants 8 messages Nov 30, 2014 – Dec 1, 2014

lore

Share & tools

lore

Guenter Roeck

author

2014-11-30 21:00 UTC #0 lore raw

PATCH 1/3 MAINTAINERS: Fix up entry for Dell laptop SMM driver

Mark driver as maintained.

Signed-off-by Guenter Roeck <[email protected]>

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

MAINTAINERS +1 -0

index 0ff630d..a67e223 100644
@@ -2918,6 +2918,7 @@ F:	drivers/platform/x86/dell-laptop.c
 
 DELL LAPTOP SMM DRIVER
 M:	Guenter Roeck <[email protected]>
+S:	Maintained
 F:	drivers/char/i8k.c
 F:	include/uapi/linux/i8k.h

Signature · 7 lines

1.9.1


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

author

2014-11-30 21:00 UTC #1 lore raw

PATCH 2/3 i8k: Rework error retries

SW5zdGVhZCBvZiByZXR1cm5pbmcgYSBwcmV2aW91cyB2YWx1ZSBpZiB0aGUgU01NIGNvZGUgcmV0 dXJucwphbiBlcnJvciB3aGVuIHRyeWluZyB0byByZWFkIGEgdGVtcGVyYXR1cmUsIHJldHJ5IG9u Y2UuCklmIHRoYXQgZmFpbHMgYWdhaW4sIHJldHVybiAtRU5PREFUQS4gQWxzbyByZXR1cm4gLUVO T0RBVEEgaWYgYW4KYXR0ZW1wdCBpcyBtYWRlIHRvIHJlYWQgdGhlIEdQVSB0ZW1wZXJhdHVyZSBi dXQgdGhlIEdQVSBpcwpjdXJyZW50bHkgdHVybmVkIG9mZi4KCkRyb3AgdGhlIEk4S19URU1QRVJB VFVSRV9CVUcgZGVmaW5pdGlvbiBhbmQgaGFuZGxlIHRoZSByZWxhdGVkIGJ1Zwp1bmNvbmRpdGlv bmFsbHkuCgpDYzogUGFsaSBSb2jDoXIgPHBhbGkucm9oYXJAZ21haWwuY29tPgpTaWduZWQtb2Zm LWJ5OiBHdWVudGVyIFJvZWNrIDxsaW51eEByb2Vjay11cy5uZXQ+Ci0tLQpBcHBsaWVzIG9uIHRv cCBvZiBQYWxpJ3MgcGF0Y2ggc2VyaWVzLiAKCiBkcml2ZXJzL2NoYXIvaThrLmMgfCA0NyArKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDI0IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvY2hhci9pOGsuYyBiL2RyaXZlcnMvY2hhci9pOGsuYwppbmRleCAzNDY0MTkyLi5jZGIyZGM3 IDEwMDY0NAotLS0gYS9kcml2ZXJzL2NoYXIvaThrLmMKKysrIGIvZHJpdmVycy9jaGFyL2k4ay5j CkBAIC01LDcgKzUsNyBAQAogICoKICAqIEh3bW9uIGludGVncmF0aW9uOgogICogQ29weXJpZ2h0 IChDKSAyMDExICBKZWFuIERlbHZhcmUgPGpkZWx2YXJlQHN1c2UuZGU+Ci0gKiBDb3B5cmlnaHQg KEMpIDIwMTMgIEd1ZW50ZXIgUm9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KKyAqIENvcHlyaWdo dCAoQykgMjAxMywgMjAxNCAgR3VlbnRlciBSb2VjayA8bGludXhAcm9lY2stdXMubmV0PgogICoK ICAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IgbW9kaWZ5IGl0CiAgKiB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUKQEAgLTIwLDYgKzIwLDcgQEAKIAog I2RlZmluZSBwcl9mbXQoZm10KSBLQlVJTERfTU9ETkFNRSAiOiAiIGZtdAogCisjaW5jbHVkZSA8 bGludXgvZGVsYXkuaD4KICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KICNpbmNsdWRlIDxsaW51 eC90eXBlcy5oPgogI2luY2x1ZGUgPGxpbnV4L2luaXQuaD4KQEAgLTU5LDggKzYwLDYgQEAKICNk ZWZpbmUgSThLX1BPV0VSX0FDCQkweDA1CiAjZGVmaW5lIEk4S19QT1dFUl9CQVRURVJZCTB4MDEK IAotI2RlZmluZSBJOEtfVEVNUEVSQVRVUkVfQlVHCTEKLQogc3RhdGljIERFRklORV9NVVRFWChp OGtfbXV0ZXgpOwogc3RhdGljIGNoYXIgYmlvc192ZXJzaW9uWzRdOwogc3RhdGljIHN0cnVjdCBk ZXZpY2UgKmk4a19od21vbl9kZXY7CkBAIC0zMDAsMzkgKzI5OSw0MSBAQCBzdGF0aWMgaW50IGk4 a19nZXRfdGVtcF90eXBlKGludCBzZW5zb3IpCiAvKgogICogUmVhZCB0aGUgY3B1IHRlbXBlcmF0 dXJlLgogICovCi1zdGF0aWMgaW50IGk4a19nZXRfdGVtcChpbnQgc2Vuc29yKQorc3RhdGljIGlu dCBfaThrX2dldF90ZW1wKGludCBzZW5zb3IpCiB7Ci0Jc3RydWN0IHNtbV9yZWdzIHJlZ3MgPSB7 IC5lYXggPSBJOEtfU01NX0dFVF9URU1QLCB9OwotCWludCByYzsKLQlpbnQgdGVtcDsKKwlzdHJ1 Y3Qgc21tX3JlZ3MgcmVncyA9IHsKKwkJLmVheCA9IEk4S19TTU1fR0VUX1RFTVAsCisJCS5lYngg PSBzZW5zb3IgJiAweGZmLAorCX07CiAKLSNpZmRlZiBJOEtfVEVNUEVSQVRVUkVfQlVHCi0Jc3Rh dGljIGludCBwcmV2WzRdID0geyBJOEtfTUFYX1RFTVArMSwgSThLX01BWF9URU1QKzEsIEk4S19N QVhfVEVNUCsxLCBJOEtfTUFYX1RFTVArMSB9OwotI2VuZGlmCi0JcmVncy5lYnggPSBzZW5zb3Ig JiAweGZmOwotCXJjID0gaThrX3NtbSgmcmVncyk7Ci0JaWYgKHJjIDwgMCkKLQkJcmV0dXJuIHJj OworCXJldHVybiBpOGtfc21tKCZyZWdzKSA/IDogcmVncy5lYXggJiAweGZmOworfQogCi0JdGVt cCA9IHJlZ3MuZWF4ICYgMHhmZjsKK3N0YXRpYyBpbnQgaThrX2dldF90ZW1wKGludCBzZW5zb3Ip Cit7CisJaW50IHRlbXAgPSBfaThrX2dldF90ZW1wKHNlbnNvcik7CiAKLSNpZmRlZiBJOEtfVEVN UEVSQVRVUkVfQlVHCiAJLyoKIAkgKiBTb21ldGltZXMgdGhlIHRlbXBlcmF0dXJlIHNlbnNvciBy ZXR1cm5zIDB4OTksIHdoaWNoIGlzIG91dCBvZiByYW5nZS4KLQkgKiBJbiB0aGlzIGNhc2Ugd2Ug cmV0dXJuIChvbmNlKSB0aGUgcHJldmlvdXMgY2FjaGVkIHZhbHVlLiBGb3IgZXhhbXBsZToKKwkg KiBJbiB0aGlzIGNhc2Ugd2UgcmV0cnkgKG9uY2UpIGJlZm9yZSByZXR1cm5pbmcgYW4gZXJyb3Iu CiAJICMgMTAwMzY1NTEzNyAwMDAwMDA1OCAwMDAwNWE0YgogCSAjIDEwMDM2NTUxMzggMDAwMDAw OTkgMDAwMDNhODAgPC0tLSAweDk5ID0gMTUzIGRlZ3JlZXMKIAkgIyAxMDAzNjU1MTM5IDAwMDAw MDU0IDAwMDA1YzUyCiAJICovCi0JaWYgKHRlbXAgPiBJOEtfTUFYX1RFTVApIHsKLQkJdGVtcCA9 IHByZXZbc2Vuc29yXTsKLQkJcHJldltzZW5zb3JdID0gSThLX01BWF9URU1QKzE7Ci0JfSBlbHNl IHsKLQkJcHJldltzZW5zb3JdID0gdGVtcDsKKwlpZiAodGVtcCA9PSAweDk5KSB7CisJCW1zbGVl cCgxMDApOworCQl0ZW1wID0gX2k4a19nZXRfdGVtcChzZW5zb3IpOwogCX0KKwkvKgorCSAqIFJl dHVybiAtRU5PREFUQSBmb3IgYWxsIGludmFsaWQgdGVtcGVyYXR1cmVzLgorCSAqCisJICogS25v d24gaW5zdGFuY2VzIGFyZSB0aGUgMHg5OSB2YWx1ZSBhcyBzZWVuIGFib3ZlIGFzIHdlbGwgYXMK KwkgKiAweGMxICgxOTMpLCB3aGljaCBtYXkgYmUgcmV0dXJuZWQgd2hlbiB0cnlpbmcgdG8gcmVh ZCB0aGUgR1BVCisJICogdGVtcGVyYXR1cmUgaWYgdGhlIHN5c3RlbSBzdXBwb3J0cyBhIEdQVSBh bmQgaXQgaXMgY3VycmVudGx5CisJICogdHVybmVkIG9mZi4KKwkgKi8KIAlpZiAodGVtcCA+IEk4 S19NQVhfVEVNUCkKIAkJcmV0dXJuIC1FTk9EQVRBOwotI2VuZGlmCiAKIAlyZXR1cm4gdGVtcDsK IH0KLS0gCjEuOS4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbG0tc2Vuc29ycyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpo dHRwOi8vbGlzdHMubG0tc2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz

Pali Rohár

Tested-by on v1 2/3

2014-12-01 19:45 UTC #2 lore raw

Re: [PATCH 2/3] i8k: Rework error retries

Quoted 9 lines · On Sunday 30 November 2014 22:00:39 Guenter Roeck wrote:

Instead of returning a previous value if the SMM code returns an error when trying to read a temperature, retry once. If that fails again, return -ENODATA. Also return -ENODATA if an attempt is made to read the GPU temperature but the GPU is currently turned off.
Drop the I8K_TEMPERATURE_BUG definition and handle the related bug unconditionally.

Quoted 9 lines

Cc Pali Rohár <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---
Applies on top of Pali's patch series.
 drivers/char/i8k.c | 47
++++++++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 23 deletions(-)

Working fine GPU temp (turned on or off).

Tested-by Pali Rohár <[email protected]>

Signature · 2 lines

Pali Rohár
[email protected]

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

author

2014-12-01 20:15 UTC #3 lore raw

Re: [PATCH 2/3] i8k: Rework error retries

Quoted 15 lines · Pali Rohár

Quoted 14 lines · On Sunday 30 November 2014 22:00:39 Guenter Roeck wrote:
Instead of returning a previous value if the SMM code returns an error when trying to read a temperature, retry once. If that fails again, return -ENODATA. Also return -ENODATA if an attempt is made to read the GPU temperature but the GPU is currently turned off.
Drop the I8K_TEMPERATURE_BUG definition and handle the related bug unconditionally.
Cc Pali Rohár <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---
Applies on top of Pali's patch series.

Quoted 9 lines

Quoted 4 lines
 drivers/char/i8k.c | 47
++++++++++++++++++++++++----------------------- 1 file changed, 24 insertions(+), 23 deletions(-)
Working fine GPU temp (turned on or off).
Tested-by Pali Rohár <[email protected]>

Thanks a lot for testing!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Guenter Roeck

author

2014-11-30 21:00 UTC #4 lore raw

PATCH 3/3 i8k: Add support for Dell XPS 13

In reply to Guenter Roeck

WFBTIDEzIGRvZXMgbm90IHN1cHBvcnQgdHVyYm8gc3BlZWQsIHNvIGl0cyBpbml0aWFsaXphdGlv biBkYXRhCm1hdGNoZXMgdGhhdCBvZiBYUFMgTTE0MC4gTWFrZSBYUFMgaW5pdGlhbGl6YXRpb24g ZGF0YSBnZW5lcmljLAphbmQgYWRkIHN1cHBvcnQgZm9yIFhQUyAxMy4KCkNjOiBQYWxpIFJvaMOh ciA8cGFsaS5yb2hhckBnbWFpbC5jb20+ClNpZ25lZC1vZmYtYnk6IEd1ZW50ZXIgUm9lY2sgPGxp bnV4QHJvZWNrLXVzLm5ldD4KLS0tCkFwcGxpZXMgb24gdG9wIG9mIFBhbGkncyBwYXRjaCBzZXJp ZXMuIAoKIGRyaXZlcnMvY2hhci9pOGsuYyB8IDE0ICsrKysrKysrKysrLS0tCiAxIGZpbGUgY2hh bmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2NoYXIvaThrLmMgYi9kcml2ZXJzL2NoYXIvaThrLmMKaW5kZXggY2RiMmRjNy4uNmQyY2Fh OSAxMDA2NDQKLS0tIGEvZHJpdmVycy9jaGFyL2k4ay5jCisrKyBiL2RyaXZlcnMvY2hhci9pOGsu YwpAQCAtNzA1LDcgKzcwNSw3IEBAIGVudW0gaThrX2NvbmZpZ3MgewogCURFTExfTEFUSVRVREVf RTY1NDAsCiAJREVMTF9QUkVDSVNJT05fNDkwLAogCURFTExfU1RVRElPLAotCURFTExfWFBTX00x NDAsCisJREVMTF9YUFMsCiB9OwogCiBzdGF0aWMgY29uc3Qgc3RydWN0IGk4a19jb25maWdfZGF0 YSBpOGtfY29uZmlnX2RhdGFbXSA9IHsKQEAgLTcyNSw3ICs3MjUsNyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGk4a19jb25maWdfZGF0YSBpOGtfY29uZmlnX2RhdGFbXSA9IHsKIAkJLmZhbl9tdWx0 ID0gMSwKIAkJLmZhbl9tYXggPSBJOEtfRkFOX0hJR0gsCiAJfSwKLQlbREVMTF9YUFNfTTE0MF0g PSB7CisJW0RFTExfWFBTXSA9IHsKIAkJLmZhbl9tdWx0ID0gMSwKIAkJLmZhbl9tYXggPSBJOEtf RkFOX0hJR0gsCiAJfSwKQEAgLTgyOSwxMiArODI5LDIwIEBAIHN0YXRpYyBzdHJ1Y3QgZG1pX3N5 c3RlbV9pZCBpOGtfZG1pX3RhYmxlW10gX19pbml0ZGF0YSA9IHsKIAkJLmRyaXZlcl9kYXRhID0g KHZvaWQgKikmaThrX2NvbmZpZ19kYXRhW0RFTExfU1RVRElPXSwKIAl9LAogCXsKKwkJLmlkZW50 ID0gIkRlbGwgWFBTIDEzIiwKKwkJLm1hdGNoZXMgPSB7CisJCQlETUlfTUFUQ0goRE1JX1NZU19W RU5ET1IsICJEZWxsIEluYy4iKSwKKwkJCURNSV9NQVRDSChETUlfUFJPRFVDVF9OQU1FLCAiWFBT MTMiKSwKKwkJfSwKKwkJLmRyaXZlcl9kYXRhID0gKHZvaWQgKikmaThrX2NvbmZpZ19kYXRhW0RF TExfWFBTXSwKKwl9LAorCXsKIAkJLmlkZW50ID0gIkRlbGwgWFBTIE0xNDAiLAogCQkubWF0Y2hl cyA9IHsKIAkJCURNSV9NQVRDSChETUlfU1lTX1ZFTkRPUiwgIkRlbGwgSW5jLiIpLAogCQkJRE1J X01BVENIKERNSV9QUk9EVUNUX05BTUUsICJNWEMwNTEiKSwKIAkJfSwKLQkJLmRyaXZlcl9kYXRh ID0gKHZvaWQgKikmaThrX2NvbmZpZ19kYXRhW0RFTExfWFBTX00xNDBdLAorCQkuZHJpdmVyX2Rh dGEgPSAodm9pZCAqKSZpOGtfY29uZmlnX2RhdGFbREVMTF9YUFNdLAogCX0sCiAJeyB9CiB9Owot LSAKMS45LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6 Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM

Jean Delvare

Reviewed-by on v1 3/3

2014-12-01 12:36 UTC #5 lore raw

Re: [lm-sensors] [PATCH 3/3] i8k: Add support for Dell XPS 13

T24gU3VuLCAzMCBOb3YgMjAxNCAxMzowMDo0MCAtMDgwMCwgR3VlbnRlciBSb2VjayB3cm90ZToK PiBYUFMgMTMgZG9lcyBub3Qgc3VwcG9ydCB0dXJibyBzcGVlZCwgc28gaXRzIGluaXRpYWxpemF0 aW9uIGRhdGEKPiBtYXRjaGVzIHRoYXQgb2YgWFBTIE0xNDAuIE1ha2UgWFBTIGluaXRpYWxpemF0 aW9uIGRhdGEgZ2VuZXJpYywKPiBhbmQgYWRkIHN1cHBvcnQgZm9yIFhQUyAxMy4KPiAKPiBDYzog UGFsaSBSb2jDoXIgPHBhbGkucm9oYXJAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEd1ZW50 ZXIgUm9lY2sgPGxpbnV4QHJvZWNrLXVzLm5ldD4KPiAtLS0KPiBBcHBsaWVzIG9uIHRvcCBvZiBQ YWxpJ3MgcGF0Y2ggc2VyaWVzLiAKPiAKPiAgZHJpdmVycy9jaGFyL2k4ay5jIHwgMTQgKysrKysr KysrKystLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2hhci9pOGsuYyBiL2RyaXZlcnMvY2hhci9p OGsuYwo+IGluZGV4IGNkYjJkYzcuLjZkMmNhYTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jaGFy L2k4ay5jCj4gKysrIGIvZHJpdmVycy9jaGFyL2k4ay5jCj4gQEAgLTcwNSw3ICs3MDUsNyBAQCBl bnVtIGk4a19jb25maWdzIHsKPiAgCURFTExfTEFUSVRVREVfRTY1NDAsCj4gIAlERUxMX1BSRUNJ U0lPTl80OTAsCj4gIAlERUxMX1NUVURJTywKPiAtCURFTExfWFBTX00xNDAsCj4gKwlERUxMX1hQ UywKPiAgfTsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaThrX2NvbmZpZ19kYXRhIGk4a19j b25maWdfZGF0YVtdID0gewo+IEBAIC03MjUsNyArNzI1LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBpOGtfY29uZmlnX2RhdGEgaThrX2NvbmZpZ19kYXRhW10gPSB7Cj4gIAkJLmZhbl9tdWx0ID0g MSwKPiAgCQkuZmFuX21heCA9IEk4S19GQU5fSElHSCwKPiAgCX0sCj4gLQlbREVMTF9YUFNfTTE0 MF0gPSB7Cj4gKwlbREVMTF9YUFNdID0gewo+ICAJCS5mYW5fbXVsdCA9IDEsCj4gIAkJLmZhbl9t YXggPSBJOEtfRkFOX0hJR0gsCj4gIAl9LAo+IEBAIC04MjksMTIgKzgyOSwyMCBAQCBzdGF0aWMg c3RydWN0IGRtaV9zeXN0ZW1faWQgaThrX2RtaV90YWJsZVtdIF9faW5pdGRhdGEgPSB7Cj4gIAkJ LmRyaXZlcl9kYXRhID0gKHZvaWQgKikmaThrX2NvbmZpZ19kYXRhW0RFTExfU1RVRElPXSwKPiAg CX0sCj4gIAl7Cj4gKwkJLmlkZW50ID0gIkRlbGwgWFBTIDEzIiwKPiArCQkubWF0Y2hlcyA9IHsK PiArCQkJRE1JX01BVENIKERNSV9TWVNfVkVORE9SLCAiRGVsbCBJbmMuIiksCj4gKwkJCURNSV9N QVRDSChETUlfUFJPRFVDVF9OQU1FLCAiWFBTMTMiKSwKPiArCQl9LAo+ICsJCS5kcml2ZXJfZGF0 YSA9ICh2b2lkICopJmk4a19jb25maWdfZGF0YVtERUxMX1hQU10sCj4gKwl9LAo+ICsJewo+ICAJ CS5pZGVudCA9ICJEZWxsIFhQUyBNMTQwIiwKPiAgCQkubWF0Y2hlcyA9IHsKPiAgCQkJRE1JX01B VENIKERNSV9TWVNfVkVORE9SLCAiRGVsbCBJbmMuIiksCj4gIAkJCURNSV9NQVRDSChETUlfUFJP RFVDVF9OQU1FLCAiTVhDMDUxIiksCj4gIAkJfSwKPiAtCQkuZHJpdmVyX2RhdGEgPSAodm9pZCAq KSZpOGtfY29uZmlnX2RhdGFbREVMTF9YUFNfTTE0MF0sCj4gKwkJLmRyaXZlcl9kYXRhID0gKHZv aWQgKikmaThrX2NvbmZpZ19kYXRhW0RFTExfWFBTXSwKPiAgCX0sCj4gIAl7IH0KPiAgfTsKCkxv b2tzIHJlYXNvbmFibGUuCgpSZXZpZXdlZC1ieTogSmVhbiBEZWx2YXJlIDxqZGVsdmFyZUBzdXNl LmRlPgoKLS0gCkplYW4gRGVsdmFyZQpTVVNFIEwzIFN1cHBvcnQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0Cmxt LXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxt YW4vbGlzdGluZm8vbG0tc2Vuc29ycw=

Guenter Roeck

author

2014-12-01 16:22 UTC #6 lore raw

Re: [lm-sensors] [PATCH 3/3] i8k: Add support for Dell XPS 13

Quoted 8 lines · Jean Delvare

Quoted 7 lines · Guenter Roeck
XPS 13 does not support turbo speed, so its initialization data matches that of XPS M140. Make XPS initialization data generic, and add support for XPS 13.
Cc Pali Rohár <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
---

[ ... ]

Quoted 5 lines

Looks reasonable.
Reviewed-by Jean Delvare <[email protected]>

Thanks a lot for the reviews!

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Jean Delvare

Reviewed-by on v1 1/3

2014-12-01 11:34 UTC #7 lore raw

In reply to Guenter Roeck

Quoted 12 lines · Guenter Roeck

Mark driver as maintained.
Signed-off-by Guenter Roeck <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 0ff630d..a67e223 100644

MAINTAINERS F: drivers/platform/x86/dell-laptop.c · line 2924

Quoted 7 lines

MAINTAINERS +1 -0

@@ -2918,6 +2918,7 @@ F:	drivers/platform/x86/dell-laptop.c
 
 DELL LAPTOP SMM DRIVER
 M:	Guenter Roeck <[email protected]>
+S:	Maintained
 F:	drivers/char/i8k.c
 F:	include/uapi/linux/i8k.h

Reviewed-by Jean Delvare <[email protected]>

Signature · 7 lines

Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors