No need for parade bridge on peach-pi
Subsystems (2)
v2 cover No need for parade bridge on peach-pi
With current u-boot-samsung HEAD on a peach-pi the following error is printed:
exynos_lcd_power_on: ps8625_init() failed
Which is not surprising given that chip does not exist on these boards.
Changes since v1:
* Only change the DTS for peach-pi not the default config. Further configuration changes will be done seperately
* Use the approach as suggested by Ajay Kumar to fix compilation without parade support
Sjoerd Simons (2):
Exynos5800: The Peach-Pi board does not have a Parade video bridge
exynos5420: fix compilation without parade video
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- arch/arm/include/asm/arch-exynos/system.h | 4 ++++ 2 files changed, 4 insertions(+), 5 deletions(-)
Signature · 1 line
2.1.3
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
---
Changes since v1: Only modify the DTB
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)
arch/arm/dts/exynos5800-peach-pi.dts +0 -5
@@ -63,11 +63,6 @@ reg = <0x20>; compatible = "maxim,max98090-codec"; }; - - edp-lvds-bridge at 48 { - compatible = "parade,ps8625"; - reg = <0x48>; - }; }; sound at 3830000 {
Signature · 1 line
2.1.3
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)
Tested on snow, pit, pi (display does not yet work on Pi).
Quoted 20 lines
arch/arm/dts/exynos5800-peach-pi.dts +0
-6@@ -63,11 +63,6 @@ reg = <0x20>; compatible = "maxim,max98090-codec"; }; - - edp-lvds-bridge at 48 { - compatible = "parade,ps8625"; - reg = <0x48>; - }; }; sound at 3830000 { --2.1.3
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Hey Simon,
Quoted 9 lines · Simon Glass
Quoted 7 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTB
Quoted 6 lines
Quoted 2 lines
arch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
Signature · 9 lines
Sjoerd Simons <[email protected]> Collabora Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6170 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141201/a1b521d0/attachment.bin>
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
+Akshay
Hi Sjoerd,
Quoted 15 lines · Sjoerd Simons
Hey Simon,
Quoted 12 lines · Simon Glass
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)
Quoted 7 lines
Quoted 3 lines
Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
That's right, not in U-Boot. I think this is because some GPIOs need to be enabled to turn on the backlight etc. Maybe you have an EC which turns these on automatically?
If current mainline is supposed to make the display work on Pi then I need to do some debugging. Please let me know.
Regards,
Simon
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Quoted 29 lines · Simon Glass
+Akshay
Hi Sjoerd,
Quoted 15 lines · Sjoerd Simons
Hey Simon,
Quoted 12 lines · Simon Glass
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)Quoted 7 lines
Quoted 3 lines
Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
Quoted 6 lines
That's right, not in U-Boot. I think this is because some GPIOs need to be enabled to turn on the backlight etc. Maybe you have an EC which turns these on automatically?
If current mainline is supposed to make the display work on Pi then I need to do some debugging. Please let me know.
It does work on my machine, so i was wondering if it's a setup difference. I'm using the chained u-boot method (iotw the standard chromeos u-boot in flash starts main-line u-boot from mmc/SD), which might well mean that the GPIOs you're referring to are still turned on by the first u-boot (which it has to do to show me the unverified boot warning screen)?
Signature · 9 lines
Sjoerd Simons <[email protected]> Collabora Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6170 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141201/1f571a62/attachment.bin>
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Hi Sjoerd,
Quoted 37 lines · Sjoerd Simons
Quoted 29 lines · Simon Glass
+Akshay
Hi Sjoerd,
Quoted 15 lines · Sjoerd Simons
Hey Simon,
Quoted 12 lines · Simon Glass
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)Quoted 7 lines
Quoted 3 lines
Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
Quoted 6 lines
That's right, not in U-Boot. I think this is because some GPIOs need to be enabled to turn on the backlight etc. Maybe you have an EC which turns these on automatically?
If current mainline is supposed to make the display work on Pi then I need to do some debugging. Please let me know.
Quoted 6 lines
It does work on my machine, so i was wondering if it's a setup difference. I'm using the chained u-boot method (iotw the standard chromeos u-boot in flash starts main-line u-boot from mmc/SD), which might well mean that the GPIOs you're referring to are still turned on by the first u-boot (which it has to do to show me the unverified boot warning screen)?
Yes that's right. Maybe Akshay / Ajay have ideas, or otherwise I can add this. I think it is two GPIOs, but it might be TPSCHROME also.
Regards,
Simon
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Hi All,
Quoted 48 lines · Simon Glass
Hi Sjoerd,
Quoted 37 lines · Sjoerd Simons
Quoted 29 lines · Simon Glass
+Akshay
Hi Sjoerd,
Quoted 15 lines · Sjoerd Simons
Hey Simon,
Quoted 12 lines · Simon Glass
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)Quoted 7 lines
Quoted 3 lines
Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
Quoted 6 lines
That's right, not in U-Boot. I think this is because some GPIOs need to be enabled to turn on the backlight etc. Maybe you have an EC which turns these on automatically?
If current mainline is supposed to make the display work on Pi then I need to do some debugging. Please let me know.
Quoted 6 lines
It does work on my machine, so i was wondering if it's a setup difference. I'm using the chained u-boot method (iotw the standard chromeos u-boot in flash starts main-line u-boot from mmc/SD), which might well mean that the GPIOs you're referring to are still turned on by the first u-boot (which it has to do to show me the unverified boot warning screen)?
Quoted 2 lines
Yes that's right. Maybe Akshay / Ajay have ideas, or otherwise I can add this. I think it is two GPIOs, but it might be TPSCHROME also.
Now, I have added support for peach_pi display in u-boot. Kindly check the patches.
Ajay
PATCH v2 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge
Hi,
Quoted 51 lines · Ajay kumar
Hi All,
Quoted 48 lines · Simon Glass
Hi Sjoerd,
Quoted 43 lines · Sjoerd Simons
Quoted 29 lines · Simon Glass
+Akshay
Hi Sjoerd,
Quoted 15 lines · Sjoerd Simons
Hey Simon,
Quoted 12 lines · Simon Glass
Quoted 9 lines · Sjoerd Simons
Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1: Only modify the DTBarch/arm/dts/exynos5800-peach-pi.dts | 5 ----- 1 file changed, 5 deletions(-)Quoted 7 lines
Quoted 3 lines
Acked-by Simon Glass <[email protected]>Tested on snow, pit, pi (display does not yet work on Pi).
Just to be clear, in your testing does the display not work on Pi? It seems to be ok here (with u-boot starting chainloaded from one of the KERN partitions)
Quoted 6 lines
That's right, not in U-Boot. I think this is because some GPIOs need to be enabled to turn on the backlight etc. Maybe you have an EC which turns these on automatically?
If current mainline is supposed to make the display work on Pi then I need to do some debugging. Please let me know.
It does work on my machine, so i was wondering if it's a setup difference. I'm using the chained u-boot method (iotw the standard chromeos u-boot in flash starts main-line u-boot from mmc/SD), which might well mean that the GPIOs you're referring to are still turned on by the first u-boot (which it has to do to show me the unverified boot warning screen)?
Quoted 4 lines
Quoted 2 lines
Yes that's right. Maybe Akshay / Ajay have ideas, or otherwise I can add this. I think it is two GPIOs, but it might be TPSCHROME also.
Now, I have added support for
peach_pidisplay in u-boot. Kindly check the patches.
It seems that these have not been applied. So Pi is not in a working state in mainline.
When can these be applied please?
There is also the rpll_sdiv patch.
I found this when testing later patches.
Regards,
Simon
PATCH v2 2/2 exynos5420: fix compilation without parade video
In reply to Sjoerd SimonsNot all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled and CONFIG_VIDEO_PARADE is not.
---
Changes since V1: New patch
arch/arm/include/asm/arch-exynos/system.h | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/include/asm/arch-exynos/system.h +4 -0
@@ -42,6 +42,10 @@ void set_system_display_ctrl(void);int exynos_lcd_early_init (const void *blob);/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE int parade_init (const void *blob); +#else +static inline int parade_init (const void *blob) {return -1 ; } +#endif #endif /* _EXYNOS4_SYSTEM_H */
Signature · 1 line
2.1.3
PATCH v2 2/2 exynos5420: fix compilation without parade video
Quoted 10 lines · Sjoerd Simons
Not all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if
CONFIG_LCDis enabled andCONFIG_VIDEO_PARADEis not.Signed-off-by Sjoerd Simons <[email protected]>---
Changes since V1: New patcharch/arm/include/asm/arch-exynos/system.h | 4 ++++ 1 file changed, 4 insertions(+)
Tested on snow, pit, pi (display does not yet work on Pi):
PATCH v2 2/2 exynos5420: fix compilation without parade video
In reply to Sjoerd SimonsDear Sjoerd Simons,
Quoted 16 lines · Sjoerd Simons
Not all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if
CONFIG_LCDis enabled andCONFIG_VIDEO_PARADEis not.Signed-off-by Sjoerd Simons <[email protected]>---
Changes since V1: New patcharch/arm/include/asm/arch-exynos/system.h | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/include/asm/arch-exynos/system.h +0
-0
arch/arm/include/asm/arch-exynos/system.h void set_system_display_ctrl(void); · line 49
Quoted 8 lines
arch/arm/include/asm/arch-exynos/system.h +4
-0@@ -42,6 +42,10 @@ void set_system_display_ctrl(void);int exynos_lcd_early_init (const void *blob);/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE int parade_init (const void *blob); +#else +static inline int parade_init (const void *blob) {return -1 ; } +#endif
Actually, it does not related with this patch..
and I know that you are not an author.
But.. I'd like ask you, why parade_init function is in exynos header file? If you are agreed, could you please make new header file? (e.g: include/parade.h)
And I think you missed removing the CONFIG_VIDEO_PARADE at peach-pi.h
Thanks,
Minkyu Kang.
PATCH v2 2/2 exynos5420: fix compilation without parade video
Hey Minkyu,
Quoted 5 lines · Minkyu Kang
Quoted 5 lines
arch/arm/include/asm/arch-exynos/system.h +0
-0@@ -42,6 +42,10 @@ void set_system_display_ctrl(void);int exynos_lcd_early_init (const void *blob);
Quoted 11 lines
arch/arm/include/asm/arch-exynos/system.h void set_system_display_ctrl(void); · line 49
Quoted 6 lines
arch/arm/include/asm/arch-exynos/system.h +4
-0/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE int parade_init (const void *blob); +#else +static inline int parade_init (const void *blob) {return -1 ; } +#endif Actually, it does not related with this patch..
and I know that you are not an author.
But.. I'd like ask you, whyparade_initfunction is in exynos header file? If you are agreed, could you please make new header file? (e.g:include/parade.h)
I'm not sure why it's in the exynos header file, it being there surprised me as well. I'm happy to move it around in a next version of the patch though.
Quoted 1 line
And I think you missed removing the
CONFIG_VIDEO_PARADEatpeach-pi.h
That's on purpose, in the discussion with Simon Glass it became clear that the intention is to start minimizing peach-pi.h (and hopefully make it unnecessary). So i left peach-pi.h untouched for now, in order for a later patchset to clean up the configuration more.
Signature · 9 lines
Sjoerd Simons <[email protected]> Collabora Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6170 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141201/ba585a47/attachment.bin>
PATCH v2 2/2 exynos5420: fix compilation without parade video
Hi,
Quoted 24 lines · Sjoerd Simons
Hey Minkyu,
Quoted 5 lines · Minkyu Kang
Quoted 5 lines
arch/arm/include/asm/arch-exynos/system.h +0
-0@@ -42,6 +42,10 @@ void set_system_display_ctrl(void);int exynos_lcd_early_init (const void *blob);Quoted 11 lines
arch/arm/include/asm/arch-exynos/system.h void set_system_display_ctrl(void); · line 49
Quoted 6 lines
arch/arm/include/asm/arch-exynos/system.h +4
-0/* Initialize the Parade dP<->LVDS bridge if present */ +#ifdef CONFIG_VIDEO_PARADE int parade_init (const void *blob); +#else +static inline int parade_init (const void *blob) {return -1 ; } +#endif Actually, it does not related with this patch..
and I know that you are not an author.
But.. I'd like ask you, whyparade_initfunction is in exynos header file? If you are agreed, could you please make new header file? (e.g:include/parade.h)I'm not sure why it's in the exynos header file, it being there surprised me as well. I'm happy to move it around in a next version of the patch though.
Quoted 6 lines
Quoted 1 line
And I think you missed removing the
CONFIG_VIDEO_PARADEatpeach-pi.hThat's on purpose, in the discussion with Simon Glass it became clear that the intention is to start minimizing
peach-pi.h(and hopefully make it unnecessary). So i leftpeach-pi.huntouched for now, in order for a later patchset to clean up the configuration more.
I'll take a look at this next week. Particularly for Pit and Pi we should be able to use the same config (SDRAM is the only barrier).
Regards,
Simon