ARM: dts: Add dts file for odroid XU3 board

PATCH New Sjoerd Simons 4 participants 7 messages Dec 1, 2014 – Dec 4, 2014

Subsystems (3)

Device tree bindings Arm Samsung Exynos Arm and arm64 SoC sub-architectures (common parts)

lore

Share & tools

lore

Sjoerd Simons

author

2014-12-01 12:59 UTC #0 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

Add DTS for the Hardkernel Odroid XU3. The name of the DTS file is kept the same as the vendors naming, which means it's prefixed with exynos5422 instead of exynos5800 as the SoC name even though it includes the exyno5800 dtsi.

Signed-off-by Sjoerd Simons <[email protected]>

---
 arch/arm/boot/dts/Makefile                 |   1 +
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 325 +++++++++++++++++++++++++++++
 2 files changed, 326 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5422-odroidxu3.dts

arch/arm/boot/dts/Makefile +1 -0

index 38c89ca..0a898cc 100644
@@ -86,6 +86,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos5420-arndale-octa.dtb \
 	exynos5420-peach-pit.dtb \
 	exynos5420-smdk5420.dtb \
+	exynos5422-odroidxu3.dtb \
 	exynos5440-sd5v1.dtb \
 	exynos5440-ssdk5440.dtb \
 	exynos5800-peach-pi.dtb

arch/arm/boot/dts/exynos5422-odroidxu3.dts new file +325 -0

325 lines not on this page · raw message

Signature · 1 line

2.1.3

Heesub Shin

2014-12-02 06:17 UTC #1 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

Hello Simons,

arch/arm/boot/dts/exynos5422-odroidxu3.dts line 14

Quoted 7 lines · Sjoerd Simons

+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
arch/arm/boot/dts/exynos5422-odroidxu3.dts new file +4 -0
+*/
+
+/dts-v1/;
+#include "exynos5800.dtsi"

Looking at exynos5800.dtsi, it derives from exynos5420.dtsi and seems having differences on clock and mfc. Is it proper to include exynos5800.dtsi here, instead of exynos5420.dtsi? It's just my curiosity as I am not in a position to know detailed things on the soc. Only semiconductor guys could answer this.

arch/arm/boot/dts/exynos5422-odroidxu3.dts line 22

Quoted 8 lines

arch/arm/boot/dts/exynos5422-odroidxu3.dts new file +8 -0

+
+/ {
+	model = "Hardkernel Odroid XU3";
+	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
+
+	memory {
+		reg = <0x20000000 0x80000000>;
+	};

Start address above should be 0x40000000, not 0x20000000.

One more thing, having bootargs which specifies 'console=xxx' would be better.

regards,
heesub

Sjoerd Simons

author

2014-12-02 08:32 UTC #2 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

Quoted 16 lines · Heesub Shin

Hello Simons,
arch/arm/boot/dts/exynos5422-odroidxu3.dts line 14
Quoted 7 lines · Sjoerd Simons
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
arch/arm/boot/dts/exynos5422-odroidxu3.dts new file +4 -0
+*/
+
+/dts-v1/;
+#include "exynos5800.dtsi"
Looking at exynos5800.dtsi, it derives from exynos5420.dtsi and seems having differences on clock and mfc. Is it proper to include exynos5800.dtsi here, instead of exynos5420.dtsi? It's just my curiosity as I am not in a position to know detailed things on the soc. Only semiconductor guys could answer this.

I would love to get a conclusive answer on this one as the exynos 5422 vs. exynos 5800 question seems to keep coming up (both on this list and the u-boot one where XU3 support is being added as well).

As far as i understand things the Exynos 5800 is a "variant" of the Exynos 5422 for chromebooks[0]. I suspect things are just being called 5800 in the kernel and u-boot as the chromebooks were the first boards based on this SoC to reach mainline...

Which led to interesting things like:
#define EXYNOS5800_SOC_ID 0xE5422000

Iotw, the identifier for the 5800 is 0x5422, which doesn't really make things more clear.

I'm working on the assumption that this SoC variation doesn't expose differences to the OS. I did not yet test the MFC, but should get round to that later this week, which should help in verifying the MFC side of things at least.. I haven't yet seen any issues caused due to the differences in clock setup between samsung,exynos5800-clock and samsung,exynos5420-clock

Quoted 10 lines

arch/arm/boot/dts/exynos5422-odroidxu3.dts line 22
Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroidxu3.dts new file +8 -0
+
+/ {
+	model = "Hardkernel Odroid XU3";
+	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
+
+	memory {
+		reg = <0x20000000 0x80000000>;
+	};
Start address above should be 0x40000000, not 0x20000000.

Indeed, the Hardkernel DTS also starts at 0x40000000, I missed that. Looking at the other exynos5800/5420 based boards in the kernel they all have their start offset at 0x20000000, is this different for the XU3 because it runs with secure firmware or is there some other reason behind this?

Quoted 2 lines

One more thing, having bootargs which specifies 'console=xxx' would be better.

Hrm, i've got a dislike for chosen/bootargs as they typically seem rather random/inconsistent (not sure who they're meant for). However, I should indeed specify chosen/stdout-path to point to the serial console.

Thanks for your review!

0: See table at the bottom of
http://www.samsung.com/global/business/semiconductor/minisite/Exynos/w/solution.html#?v=octa_5422

Signature · 9 lines

Sjoerd Simons <[email protected]>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141202/9be0d0ed/attachment-0001.bin>

Kevin Hilman

2014-12-03 19:53 UTC #3 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

In reply to Sjoerd Simons

Quoted 6 lines · Sjoerd Simons

Add DTS for the Hardkernel Odroid XU3. The name of the DTS file is kept the same as the vendors naming, which means it's prefixed with exynos5422 instead of exynos5800 as the SoC name even though it includes the exyno5800 dtsi.
Signed-off-by Sjoerd Simons <[email protected]>

Tested-by Kevin Hilman <[email protected]>

Tried this on top of linux-next (next-20141125 and next20141203) and boots fine on my odroid-xu3.

Thanks for doing this, I've been meaning to get a DTS upstream for this platform myself. I also noticed that the imprecise aborts I've been seeing when booting this board with the smdk5420 DTS are gone, so I don't have to dig into those now either. Thanks! :)

Kevin

Sjoerd Simons

author

2014-12-03 20:36 UTC #4 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

Quoted 8 lines · Kevin Hilman

Sjoerd Simons <[email protected]> writes:
Tried this on top of linux-next (next-20141125 and next20141203) and boots fine on my odroid-xu3.
Thanks for doing this, I've been meaning to get a DTS upstream for this platform myself. I also noticed that the imprecise aborts I've been seeing when booting this board with the smdk5420 DTS are gone, so I don't have to dig into those now either. Thanks! :)

For completeness, the problem with running the smdk5420 DTS on the XU3 is that the XU3 runs secure firmware while the SMD5420 doesn't.. Hence the imprecise aborts you were seeing.

Signature · 9 lines

Sjoerd Simons <[email protected]>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141203/311ef32f/attachment.bin>

Kevin Hilman

2014-12-04 04:40 UTC #5 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

Quoted 5 lines · Sjoerd Simons

Quoted 4 lines · Kevin Hilman
Sjoerd Simons <[email protected]> writes:
Tried this on top of linux-next (next-20141125 and next20141203) and boots fine on my odroid-xu3.

Quoted 8 lines

Quoted 4 lines
Thanks for doing this, I've been meaning to get a DTS upstream for this platform myself. I also noticed that the imprecise aborts I've been seeing when booting this board with the smdk5420 DTS are gone, so I don't have to dig into those now either. Thanks! :)
For completeness, the problem with running the smdk5420 DTS on the XU3 is that the XU3 runs secure firmware while the SMD5420 doesn't.. Hence the imprecise aborts you were seeing.

OK, that's what I suspected but didn't take the time to verify. Thanks for the update.

BTW, I'll have some DTS updates for the xu3 to enable the on-board INA2xx current sensors for easy power measurements without external instrumentation. Will send a patch for those soon.

Kevin

Tyler Baker

2014-12-03 20:24 UTC #6 lore raw

PATCH 1/1 ARM: dts: Add dts file for odroid XU3 board

In reply to Sjoerd Simons

Quoted 6 lines · Sjoerd Simons

Add DTS for the Hardkernel Odroid XU3. The name of the DTS file is kept the same as the vendors naming, which means it's prefixed with exynos5422 instead of exynos5800 as the SoC name even though it includes the exyno5800 dtsi.
Signed-off-by Sjoerd Simons <[email protected]>

Tested-by Tyler Baker <[email protected]>

Tested this atop of next-20141203 both on exynos_defconfig and multi_v7_defconfig. All configurations boot fine on my odroid-xu3 board, no imprecise aborts observed either.

Thanks!

Tyler