kvm: vmx: enable xsaves for kvm
v4 cover kvm: vmx: enable xsaves for kvm
This patchset is to enable xsaves for kvm part and tested on skylake-client.
v3 -> v4:
* return false from an svm_xsaves_supported function
* prevent setting MSR_IA32_XSS to any non-zero value
v2 -> v3:
* add kvm_get/set for ia32_xss
* fix the type XSS_EXIT_BITMAP
* load host_xss just once in setup_vmcs_config
* add/clear atuo switch ia32_xss msr in kvm_get/clear
* add VMX_XSS_EXIT_BITMAP macro
* add WARN() in handle_xsaves/xrstors
* export xsaves if related vmcs field is set
v1 -> v2:
* auto switch ia32_xss msr just if this msr is present
Wanpeng Li (3):
kvm: vmx: Intel XSAVES vmx and msr handle
kvm: vmx: add kvm_get/set logic to xsaves
kvm: x86: Enable Intel XSAVES for guest
arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/include/asm/vmx.h | 3 +++ arch/x86/include/uapi/asm/vmx.h | 6 ++++- arch/x86/kvm/cpuid.c | 3 ++- arch/x86/kvm/svm.c | 6 +++++ arch/x86/kvm/vmx.c | 57 ++++++++++++++++++++++++++++++++++++++++- 6 files changed, 74 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.1
PATCH v4 1/3 kvm: vmx: Intel XSAVES vmx and msr handle
Intel xsaves vmx and msr handle.
--- arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/include/asm/vmx.h | 3 +++ arch/x86/include/uapi/asm/vmx.h | 6 +++++- arch/x86/kvm/svm.c | 6 ++++++ arch/x86/kvm/vmx.c | 31 ++++++++++++++++++++++++++++++- 5 files changed, 46 insertions(+), 2 deletions(-)
arch/x86/include/asm/kvm_host.h +2 -0
@@ -362,6 +362,7 @@ struct kvm_vcpu_arch {int mp_state;u64 ia32_misc_enable_msr;bool tpr_access_reporting; +u64 ia32_xss;/* * Paging state of the vcpu
@@ -771,6 +772,7 @@ struct kvm_x86_ops { enum x86_intercept_stage stage);void (*handle_external_intr)(struct kvm_vcpu *vcpu);bool (*mpx_supported)(void ); +bool (*xsaves_supported)(void );int (*check_nested_events)(struct kvm_vcpu *vcpu,bool external_intr);
arch/x86/include/asm/vmx.h +3 -0
@@ -69,6 +69,7 @@#define SECONDARY_EXEC_PAUSE_LOOP_EXITING 0x00000400#define SECONDARY_EXEC_ENABLE_INVPCID 0x00001000#define SECONDARY_EXEC_SHADOW_VMCS 0x00004000 +#define SECONDARY_EXEC_XSAVES 0x00100000#define PIN_BASED_EXT_INTR_MASK 0x00000001
@@ -159,6 +160,8 @@ enum vmcs_field {EOI_EXIT_BITMAP3_HIGH =0x00002023 ,VMREAD_BITMAP =0x00002026 ,VMWRITE_BITMAP =0x00002028 , +XSS_EXIT_BITMAP =0x0000202C , +XSS_EXIT_BITMAP_HIGH =0x0000202D ,GUEST_PHYSICAL_ADDRESS =0x00002400 ,GUEST_PHYSICAL_ADDRESS_HIGH =0x00002401 , VMCS_LINK_POINTER = 0x00002800,
arch/x86/include/uapi/asm/vmx.h +5 -1
@@ -72,6 +72,8 @@#define EXIT_REASON_XSETBV 55#define EXIT_REASON_APIC_WRITE 56#define EXIT_REASON_INVPCID 58 +#define EXIT_REASON_XSAVES 63 +#define EXIT_REASON_XRSTORS 64#define VMX_EXIT_REASONS \ { EXIT_REASON_EXCEPTION_NMI, "EXCEPTION_NMI" }, \
@@ -116,6 +118,8 @@ { EXIT_REASON_INVALID_STATE, "INVALID_STATE" }, \ { EXIT_REASON_INVD, "INVD" }, \ { EXIT_REASON_INVVPID, "INVVPID" }, \ - { EXIT_REASON_INVPCID, "INVPCID" } + { EXIT_REASON_INVPCID, "INVPCID" }, \ + { EXIT_REASON_XSAVES, "XSAVES" }, \ + { EXIT_REASON_XRSTORS, "XRSTORS" } #endif /* _UAPIVMX_H */
arch/x86/kvm/svm.c +6 -0
@@ -4127,6 +4127,11 @@ static bool svm_mpx_supported(void)return false; } +static bool svm_xsaves_supported (void ) +{ +return false; +} +static bool svm_has_wbinvd_exit (void ) {return true;
@@ -4414,6 +4419,7 @@ static struct kvm_x86_ops svm_x86_ops = { .rdtscp_supported = svm_rdtscp_supported, .invpcid_supported = svm_invpcid_supported, .mpx_supported = svm_mpx_supported, + .xsaves_supported = svm_xsaves_supported, .set_supported_cpuid = svm_set_supported_cpuid,
arch/x86/kvm/vmx.c +30 -1
@@ -761,6 +761,7 @@ static u64 construct_eptp(unsigned long root_hpa);static void kvm_cpu_vmxon (u64 addr);static void kvm_cpu_vmxoff (void );static bool vmx_mpx_supported (void ); +static bool vmx_xsaves_supported (void );static int vmx_set_tss_addr (struct kvm *kvm,unsigned int addr);static void vmx_set_segment (struct kvm_vcpu *vcpu,struct kvm_segment *var,int seg);
@@ -2895,7 +2896,8 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf)SECONDARY_EXEC_ENABLE_INVPCID |SECONDARY_EXEC_APIC_REGISTER_VIRT |SECONDARY_EXEC_VIRTUAL_INTR_DELIVERY | -SECONDARY_EXEC_SHADOW_VMCS ; +SECONDARY_EXEC_SHADOW_VMCS | +SECONDARY_EXEC_XSAVES ;if (adjust_vmx_controls (min2, opt2,MSR_IA32_VMX_PROCBASED_CTLS2 , &_cpu_based_2nd_exec_control) <0 )
@@ -4337,6 +4339,7 @@ static void ept_set_mmio_spte_mask(void)kvm_mmu_set_mmio_spte_mask ((0x3ull <<62 ) |0x6ull ); } +#define VMX_XSS_EXIT_BITMAP 0/* * Sets up the vmcs for emulated real mode. */
@@ -4446,6 +4449,9 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)vmcs_writel (CR0_GUEST_HOST_MASK , ~0UL );set_cr4_guest_host_mask (vmx); +if (vmx_xsaves_supported ()) +vmcs_write64 (XSS_EXIT_BITMAP ,VMX_XSS_EXIT_BITMAP ); +return 0 ; }
@@ -5334,6 +5340,20 @@ static int handle_xsetbv(struct kvm_vcpu *vcpu)return 1 ; } +static int handle_xsaves (struct kvm_vcpu *vcpu) +{ +skip_emulated_instruction (vcpu); +WARN (1 ,"this should never happen\n" ); +return 1 ; +} + +static int handle_xrstors (struct kvm_vcpu *vcpu) +{ +skip_emulated_instruction (vcpu); +WARN (1 ,"this should never happen\n" ); +return 1 ; +} +static int handle_apic_access (struct kvm_vcpu *vcpu) {if (likely (fasteoi)) {
@@ -6951,6 +6971,8 @@ static int (*const kvm_vmx_exit_handlers[])(struct kvm_vcpu *vcpu) = { [EXIT_REASON_MONITOR_INSTRUCTION] = handle_monitor, [EXIT_REASON_INVEPT] = handle_invept, [EXIT_REASON_INVVPID] = handle_invvpid, + [EXIT_REASON_XSAVES] = handle_xsaves, + [EXIT_REASON_XRSTORS] = handle_xrstors, }; static const int kvm_vmx_max_exit_handlers =
@@ -7553,6 +7575,12 @@ static bool vmx_mpx_supported(void) (vmcs_config.vmentry_ctrl &VM_ENTRY_LOAD_BNDCFGS ); } +static bool vmx_xsaves_supported (void ) +{ +return vmcs_config.cpu_based_2nd_exec_ctrl & +SECONDARY_EXEC_XSAVES ; +} +static void vmx_recover_nmi_blocking (struct vcpu_vmx *vmx) {u32 exit_intr_info;
@@ -9329,6 +9357,7 @@ static struct kvm_x86_ops vmx_x86_ops = { .check_intercept = vmx_check_intercept, .handle_external_intr = vmx_handle_external_intr, .mpx_supported = vmx_mpx_supported, + .xsaves_supported = vmx_xsaves_supported, .check_nested_events = vmx_check_nested_events,
Signature · 1 line
1.9.1
PATCH v4 2/3 kvm: vmx: add kvm_get/set logic to xsaves
In reply to Wanpeng LiAdd kvm_get/set logic to xsaves.
--- arch/x86/kvm/vmx.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
arch/x86/kvm/vmx.c +26 -0
@@ -99,6 +99,8 @@ module_param_named(enable_shadow_vmcs, enable_shadow_vmcs, bool, S_IRUGO);static bool __read_mostly nested =0 ;module_param (nested, bool,S_IRUGO ); +static u64 __read_mostly host_xss; +#define KVM_GUEST_CR0_MASK (X86_CR0_NW | X86_CR0_CD)#define KVM_VM_CR0_ALWAYS_ON_UNRESTRICTED_GUEST (X86_CR0_WP | X86_CR0_NE)#define KVM_VM_CR0_ALWAYS_ON \
@@ -2570,6 +2572,11 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata)if (!nested_vmx_allowed (vcpu))return 1 ;return vmx_get_vmx_msr (vcpu, msr_index, pdata); +case MSR_IA32_XSS : +if (!vmx_xsaves_supported ()) +return 1 ; + data = vcpu->arch.ia32_xss; +break ;case MSR_TSC_AUX :if (!to_vmx (vcpu)->rdtscp_enabled)return 1 ;
@@ -2661,6 +2668,22 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)break ; case MSR_IA32_VMX_BASIC ... MSR_IA32_VMX_VMFUNC:return 1 ;/* they are read-only */ +case MSR_IA32_XSS : +if (!vmx_xsaves_supported ()) +return 1 ; +/* +* The only supported bit as of Skylake is bit 8, but +* it is not supported on KVM. +*/ +if (data !=0 ) +return 1 ; + vcpu->arch.ia32_xss = data; +if (vcpu->arch.ia32_xss != host_xss) +add_atomic_switch_msr (vmx,MSR_IA32_XSS , + vcpu->arch.ia32_xss, host_xss); +else +clear_atomic_switch_msr (vmx,MSR_IA32_XSS ); +break ;case MSR_TSC_AUX :if (!vmx->rdtscp_enabled)return 1 ;
@@ -3020,6 +3043,9 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf) } } +if (cpu_has_xsaves) +rdmsrl (MSR_IA32_XSS , host_xss); +return 0 ; }
Signature · 1 line
1.9.1
PATCH v4 3/3 kvm: x86: Enable Intel XSAVES for guest
In reply to Wanpeng LiExpose intel xsaves feature to guest.
--- arch/x86/kvm/cpuid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/kvm/cpuid.c +2 -1
@@ -267,6 +267,7 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,unsigned f_rdtscp = kvm_x86_ops->rdtscp_supported () ?F (RDTSCP ) :0 ;unsigned f_invpcid = kvm_x86_ops->invpcid_supported () ?F (INVPCID ) :0 ;unsigned f_mpx = kvm_x86_ops->mpx_supported () ?F (MPX ) :0 ; +unsigned f_xsaves = kvm_x86_ops->xsaves_supported () ?F (XSAVES ) :0 ;/* cpuid 1.edx */ const u32 kvm_supported_word0_x86_features =
@@ -322,7 +323,7 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,/* cpuid 0xD.1.eax */ const u32 kvm_supported_word10_x86_features = -F (XSAVEOPT ) |F (XSAVEC ) |F (XGETBV1 ); +F (XSAVEOPT ) |F (XSAVEC ) |F (XGETBV1 ) | f_xsaves;/* all calls to cpuid_count() should be made on the same cpu */ get_cpu ();
Signature · 1 line
1.9.1