Set UID in sess_auth_rawntlmssp_authenticate too
Subsystems (2)
PATCH 1/1 Set UID in sess_auth_rawntlmssp_authenticate too
A user complained that they were unable to login to their cifs share after a kernel update. From the wiretrace we can see that the server returns different UIDs as response to NTLMSSP_NEGOTIATE and NTLMSSP_AUTH phases.
With changes in the authentication code, we no longer set the cifs_sess->Suid returned in response to the NTLM_AUTH phase and continue to use the UID sent in response to the NTLMSSP_NEGOTIATE phase. This results in the server denying access to the user when the user attempts to do a tcon connect.
A test kernel containing patch was tested successfully by the user.
--- fs/cifs/sess.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/cifs/sess.c +5 -0
@@ -1303,6 +1303,11 @@ sess_auth_rawntlmssp_authenticate(struct sess_data *sess_data)if (le16_to_cpu (pSMB->resp.Action) &GUEST_LOGIN )cifs_dbg (FYI ,"Guest login\n" );/* BB mark SesInfo struct? */ +if (ses->Suid != smb_buf->Uid) { + ses->Suid = smb_buf->Uid; +cifs_dbg (FYI ,"UID changed! new UID = %llu\n" , ses->Suid); + } + bytes_remaining =get_bcc (smb_buf); bcc_ptr =pByteArea (smb_buf); blob_len =le16_to_cpu (pSMB->resp.SecurityBlobLength);
Signature · 1 line
2.1.0
A message that is not in the archive (sent off-list or not yet received): 1417609596-23002-1-git-send-email-sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Shirish Pargaonkar
Acked-byQuoted 41 lines · Sachin Prabhu
A user complained that they were unable to login to their cifs share after a kernel update. From the wiretrace we can see that the server returns different UIDs as response to
NTLMSSP_NEGOTIATEandNTLMSSP_AUTHphases.With changes in the authentication code, we no longer set the
cifs_sess->Suidreturned in response to theNTLM_AUTHphase and continue to use the UID sent in response to theNTLMSSP_NEGOTIATEphase. This results in the server denying access to the user when the user attempts to do a tcon connect.A test kernel containing patch was tested successfully by the user.
Signed-off-by Sachin Prabhu <[email protected]>--- fs/cifs/sess.c | 5 +++++ 1 file changed, 5 insertions(+)fs/cifs/sess.c +5
-1@@ -1303,6 +1303,11 @@ sess_auth_rawntlmssp_authenticate(struct sess_data *sess_data)if (le16_to_cpu (pSMB->resp.Action) &GUEST_LOGIN )cifs_dbg (FYI ,"Guest login\n" );/* BB mark SesInfo struct? */ +if (ses->Suid != smb_buf->Uid) { + ses->Suid = smb_buf->Uid; +cifs_dbg (FYI ,"UID changed! new UID = %llu\n" , ses->Suid); + } + bytes_remaining =get_bcc (smb_buf); bcc_ptr =pByteArea (smb_buf); blob_len =le16_to_cpu (pSMB->resp.SecurityBlobLength); --2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html