Skip to contentSkip to conversation

Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <[email protected]>

PATCH In review Arun 3 participants 5 messages Dec 4, 2014 1 message not in the archive Staging

lore
Share & tools
lore

Arun

author
#0 lore raw

PATCH 1/1 Staging: bcm: Fix lines exceeding 80 character limit in CmHost.h This is a patch to CmHost.h that fixes Exceeds 80 Character limits warning found by checkpatch.pl Signed-off-by: Arun Ayyer <[email protected]>

---
 drivers/staging/bcm/CmHost.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/staging/bcm/CmHost.h +5 -3
index 0887d3f..a6e30da 100644
@@ -20,8 +20,8 @@
 #pragma once
 #pragma pack(push, 4)
 
-#define DSX_MESSAGE_EXCHANGE_BUFFER        0xBF60AC84 /* This contains the pointer */
-#define DSX_MESSAGE_EXCHANGE_BUFFER_SIZE   72000      /* 24 K Bytes */
+#define DSX_MESSAGE_EXCHANGE_BUFFER       0xBF60AC84 /* Contains the pointer */
+#define DSX_MESSAGE_EXCHANGE_BUFFER_SIZE  72000      /* 24 K Bytes */
 
 struct bcm_add_indication_alt {
 	u8	u8Type;

@@ -51,7 +51,9 @@ struct bcm_change_indication {
 	u16	u16Padd;
 };
 
-unsigned long StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter, void *pvBuffer, unsigned int *puBufferLength);
+unsigned long StoreCmControlResponseMessage(struct bcm_mini_adapter *Adapter,
+					void *pvBuffer,
+					unsigned int *puBufferLength);
 int AllocAdapterDsxBuffer(struct bcm_mini_adapter *Adapter);
 int FreeAdapterDsxBuffer(struct bcm_mini_adapter *Adapter);
 unsigned long SetUpTargetDsxBuffers(struct bcm_mini_adapter *Adapter);
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 3 lines · Arun
---
 drivers/staging/bcm/CmHost.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

That's a really odd subject, don't you agree?

:)

A message that is not in the archive (sent off-list or not yet received): CAJ8d=beEFz-wKaN4bodZFN9BCrUsZKy=F0e-R7fUVXsf+04g4A@mail.gmail.com

maintainer
#3 lore raw
Quoted 1 line · arun vijayshankar

Hi Greg,

If you turn off HTML email, your message will not get rejected by the mailing lists :)

Quoted 2 lines

I completely agree! I thought of keeping the patch summary as the subject, but I wasn't sure and ending up entering nothing. Git then used this by default.

You forgot a blank line after your first line in the git commit message, which caused it to get all merged together.

Try fixing that up and resending please.

thanks,

greg k-h

#4 lore raw
Quoted 6 lines · Greg KH
Quoted 1 line · arun vijayshankar

Hi Greg,

If you turn off HTML email, your message will not get rejected by the mailing lists :)

Quoted 7 lines
Quoted 2 lines

I completely agree! I thought of keeping the patch summary as the subject, but I wasn't sure and ending up entering nothing. Git then used this by default.

You forgot a blank line after your first line in the git commit message, which caused it to get all merged together.

Try fixing that up and resending please.

No need. This directory has been deleted.

Please work against -next (or Greg's staging tree)

author
#5 lore raw

Thanks Greg and Joe!

I will work against -next

Regards,
Arun.

Quoted 21 lines · Joe Perches
Quoted 6 lines · Greg KH
Quoted 1 line · arun vijayshankar

Hi Greg,

If you turn off HTML email, your message will not get rejected by the mailing lists :)

Quoted 7 lines
Quoted 2 lines

I completely agree! I thought of keeping the patch summary as the subject, but I wasn't sure and ending up entering nothing. Git then used this by default.

You forgot a blank line after your first line in the git commit message, which caused it to get all merged together.

Try fixing that up and resending please.

No need. This directory has been deleted.

Please work against -next (or Greg's staging tree)

Signature · 1 line
Arun.