Skip to contentSkip to conversation

gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

PATCH New Axel Lin 2 participants 3 messages Dec 7, 2014 – Dec 11, 2014 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

Current code does not set gpio output value in ich6_gpio_direction_output(), fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/intel_ich6_gpio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/intel_ich6_gpio.c +2 -0
index b095d17..92c23ae 100644
@@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
 	struct ich6_bank_priv *bank = dev_get_priv(dev);
 	u32 tmplong;
 
+	gpio_set_value(offset, value);
+
 	tmplong = inl(bank->io_sel);
 	tmplong &= ~(1UL << offset);
 	outl(bank->io_sel, tmplong);
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

Quoted 22 lines · Axel Lin

Current code does not set gpio output value in ich6_gpio_direction_output(), fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/intel_ich6_gpio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/intel_ich6_gpio.c +2 -1
index b095d17..92c23ae 100644
@@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
        struct ich6_bank_priv *bank = dev_get_priv(dev);
        u32 tmplong;
 
+       gpio_set_value(offset, value);
+
        tmplong = inl(bank->io_sel);
        tmplong &= ~(1UL << offset);
        outl(bank->io_sel, tmplong);
--
Quoted 2 lines

1.9.1

Acked-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

Quoted 17 lines · Simon Glass
Quoted 16 lines · Axel Lin

Current code does not set gpio output value in ich6_gpio_direction_output(), fix it.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpio/intel_ich6_gpio.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/intel_ich6_gpio.c +0 -0
index b095d17..92c23ae 100644
@@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
        struct ich6_bank_priv *bank = dev_get_priv(dev);
        u32 tmplong;
Quoted 10 lines
Quoted 8 lines
drivers/gpio/intel_ich6_gpio.c +2 -1
+       gpio_set_value(offset, value);
+
        tmplong = inl(bank->io_sel);
        tmplong &= ~(1UL << offset);
        outl(bank->io_sel, tmplong);
--

1.9.1

Acked-by Simon Glass <[email protected]>

Applied to u-boot-x86 - thanks!

- Simon