Skip to contentSkip to conversation

Drivers: memstick: host: Fixed missing a blank line warning

PATCH In review Athira Lekshmi 2 participants 2 messages Dec 7, 2014 – Dec 8, 2014 Sony memorystick

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Drivers: memstick: host: Fixed missing a blank line warning

Added a new line after declaration to fix the warning message 'Missing a blank line after declarations'

---
 drivers/memstick/host/rtsx_usb_ms.c |    1 +
 1 file changed, 1 insertion(+)
drivers/memstick/host/rtsx_usb_ms.c +1 -0
index a7282b7..cefd745 100644
@@ -59,6 +59,7 @@ static inline struct device *ms_dev(struct rtsx_usb_ms *host)
 static inline void ms_clear_error(struct rtsx_usb_ms *host)
 {
 	struct rtsx_ucr *ucr = host->ucr;
+
 	rtsx_usb_ep0_write_register(ucr, CARD_STOP,
 				  MS_STOP | MS_CLR_ERR,
 				  MS_STOP | MS_CLR_ERR);
Signature · 1 line
1.7.9.5
Acked-by on v2 1/1
#1 lore raw

Not a bad attempt.

The subject line should match the subsystem. You can see what that is by issuing git log --oneline -- drivers/memstick/ (supplement drivers/memstick for the subsystem that you're submitting to).

Quoted 7 lines

Added a new line after declaration to fix the warning message 'Missing a blank line after declarations'

---
 drivers/memstick/host/rtsx_usb_ms.c |    1 +
 1 file changed, 1 insertion(+)

Apart from my comment at the top (which a kind maintainer can fix for you on this occasion I'm sure ;) ), the patch looks good:

Now make 3 such changes (you can use checkpatch on some other files) and send them as a patch-set.

Quoted 12 lines
drivers/memstick/host/rtsx_usb_ms.c +1 -0
index a7282b7..cefd745 100644
@@ -59,6 +59,7 @@ static inline struct device *ms_dev(struct rtsx_usb_ms *host)
 static inline void ms_clear_error(struct rtsx_usb_ms *host)
 {
 	struct rtsx_ucr *ucr = host->ucr;
+
 	rtsx_usb_ep0_write_register(ucr, CARD_STOP,
 				  MS_STOP | MS_CLR_ERR,
 				  MS_STOP | MS_CLR_ERR);
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog