Skip to contentSkip to conversation

plugin, down-root: Fix compiler warnings

PATCH In review David Sommerseth 2 participants 4 messages Dec 8, 2014

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 plugin, down-root: Fix compiler warnings

From: David Sommerseth <[email protected]...>

Removed a few compiler warnings:
down-root.c:164:4: warning: implicit declaration of function 'warn' [-Wimplicit-function-declaration] down-root.c:239:5: warning: implicit declaration of function 'err' [-Wimplicit-function-declaration] down-root.c:461:7: warning: unused variable 'i' [-Wunused-variable] down-root.c:460:15: warning: unused variable 'p' [-Wunused-variable]

Signed-off-by David Sommerseth <[email protected]...>
---
 src/plugins/down-root/down-root.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
src/plugins/down-root/down-root.c +1 -3
index ed2636a..f7a49a0 100644
@@ -42,6 +42,7 @@
 #include <signal.h>
 #include <syslog.h>
 #include <errno.h>
+#include <err.h>
 
 #include <openvpn-plugin.h>
 

@@ -457,9 +458,6 @@ openvpn_plugin_abort_v1 (openvpn_plugin_handle_t handle)
 static void
 down_root_server (const int fd, char * const *argv, char * const *envp, const int verb)
 {
-  const char *p[3];
-  int i;
-
   /*
    * Do initialization
    */
Signature · 1 line
1.8.3.1
#1 lore raw

ACK

-Steffan

Quoted 36 lines · David Sommerseth

From: David Sommerseth <[email protected]...>

Removed a few compiler warnings:
down-root.c:164:4: warning: implicit declaration of function 'warn' [-Wimplicit-function-declaration] down-root.c:239:5: warning: implicit declaration of function 'err' [-Wimplicit-function-declaration] down-root.c:461:7: warning: unused variable 'i' [-Wunused-variable] down-root.c:460:15: warning: unused variable 'p' [-Wunused-variable]

Signed-off-by David Sommerseth <[email protected]...>
---
 src/plugins/down-root/down-root.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
src/plugins/down-root/down-root.c +1 -3
index ed2636a..f7a49a0 100644
@@ -42,6 +42,7 @@
 #include <signal.h>
 #include <syslog.h>
 #include <errno.h>
+#include <err.h>
 
 #include <openvpn-plugin.h>
 

@@ -457,9 +458,6 @@ openvpn_plugin_abort_v1 (openvpn_plugin_handle_t handle)
 static void
 down_root_server (const int fd, char * const *argv, char * const *envp, const int verb)
 {
-  const char *p[3];
-  int i;
-
   /*
    * Do initialization
    */
author
#2 lore raw
In reply to David Sommerseth

From: David Sommerseth <[email protected]...>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Your patch has been applied to the master branch.

commit 7dd51f6f50b17ab91cbb724e2d5e96657fab834a

Author: David Sommerseth
Date:   Mon Dec 8 22:31:15 2014 +0100
     plugin, down-root: Fix compiler warnings

     Signed-off-by: David Sommerseth <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: [email protected]...
     URL: http://article.gmane.org/gmane.network.openvpn.devel/9327

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlSGGtAACgkQDC186MBRfrqmCACghKg9mQ/hyQi3G7QyvuKCc7BK AhYAnj4SMJthWUPXCld6nLrKUUbJROc7
=JMTV
-----END PGP SIGNATURE-----

author
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 8 lines · David Sommerseth

From: David Sommerseth <[email protected]...>

Your patch has been applied to the master branch.

commit 7dd51f6f50b17ab91cbb724e2d5e96657fab834a Author: David
Sommerseth Date: Mon Dec 8 22:31:15 2014 +0100

Quoted 8 lines

plugin, down-root: Fix compiler warnings

Signed-off-by David Sommerseth <[email protected]...> Acked-by:

Steffan Karger <[email protected]...> Message-Id:
[email protected]...
URL: http://article.gmane.org/gmane.network.openvpn.devel/9327

Also applied to release/2.3 as commit
e2983bf2db3593ee5711066196f8cae5f5e91013

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlSGG6UACgkQDC186MBRfrpIOgCfZrawi69OZngyOFtZYXLk433q vcQAnjx5Tn51VtBLieWCSkJzoERyvvRN
=ehog
-----END PGP SIGNATURE-----