odroid-XU3: Add entry for DTS EHCI GPIO
Subsystems (2)
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default config
Hyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the list:
Exynos: Move down common USB configuration
arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)
arch/arm/dts/exynos5422-odroidxu3.dts +4 -0
@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };
include/configs/odroid_xu3.h +4 -0
@@ -47,6 +47,10 @@#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" +/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTT
Signature · 1 line
2.1.3
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
Dear Sjoerd,
Quoted 4 lines · On Fri, 05 Dec 2014 21:26:10 +0100 Sjoerd Simons…
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
Quoted 9 lines
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default configHyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
Does it work only with this patch? I applied this patch on top of my patchset, and connected the ethernet cable to the device. But it seemed not working. Is there anything else that I should do for test?
Quoted 31 lines
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the
list: Exynos: Move down common USB configurationarch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)(quoted diff) +0
-0
b/arch/arm/dts/exynos5422-odroidxu3.dtsindex cff32a9..79a7acd 100644arch/arm/dts/exynos5422-odroidxu3.dts +4
-0@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };(quoted diff) +0
-0
b/include/configs/odroid_xu3.hindex 88bb98d..aa0c142 100644include/configs/odroid_xu3.h +0
-0@@ -47,6 +47,10 @@ #define
CONFIG_DEFAULT_CONSOLE"console=ttySAC2,115200n8\0"
include/configs/odroid_xu3.h line 56
Quoted 7 lines
include/configs/odroid_xu3.h +4
-0+/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTT
Best regards,
Hyungwon Hwang
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
Hello Hyungwon Hwang,
Quoted 52 lines · Hyungwon Hwang
Dear Sjoerd,
Quoted 4 lines · On Fri, 05 Dec 2014 21:26:10 +0100 Sjoerd Simons…
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
Quoted 9 lines
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default configHyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
Does it work only with this patch? I applied this patch on top of my patchset, and connected the ethernet cable to the device. But it seemed not working. Is there anything else that I should do for test?
Quoted 29 lines
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the
list: Exynos: Move down common USB configurationarch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)(quoted diff) +0
-0
b/arch/arm/dts/exynos5422-odroidxu3.dtsindex cff32a9..79a7acd 100644arch/arm/dts/exynos5422-odroidxu3.dts +4
-0@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };(quoted diff) +0
-0
b/include/configs/odroid_xu3.hindex 88bb98d..aa0c142 100644include/configs/odroid_xu3.h +0
-0@@ -47,6 +47,10 @@
Quoted 10 lines
include/configs/odroid_xu3.h line 56
Quoted 9 lines
include/configs/odroid_xu3.h +0
-0#define
CONFIG_DEFAULT_CONSOLE"console=ttySAC2,115200n8\0"include/configs/odroid_xu3.h +4
-0+/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTT
In odroid_xu3.h you might want to add the below as well (for LAN + USB storage)
+/* Enable USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_EXYNOS
+#define CONFIG_USB_STORAGE
+#define CONFIG_CMD_DHCP
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_SMSC95XX
Thanks
- Suriyan
Quoted 6 lines
Best regards,
Hyungwon Hwang
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
Dear all,
Quoted 72 lines · On Mon, 08 Dec 2014 19:36:46 -0800 Suriyan Ramasami <[email protected]> wrote:
Hello Hyungwon Hwang,
Quoted 53 lines · Hyungwon Hwang
Dear Sjoerd,
Quoted 4 lines · On Fri, 05 Dec 2014 21:26:10 +0100 Sjoerd Simons…
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
Quoted 9 lines
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default configHyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
Does it work only with this patch? I applied this patch on top of my patchset, and connected the ethernet cable to the device. But it seemed not working. Is there anything else that I should do for test?
Quoted 29 lines
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the list: Exynos: Move down common USB configuration
arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)(quoted diff) +0
-0
b/arch/arm/dts/exynos5422-odroidxu3.dtsindex cff32a9..79a7acd 100644 ---a/arch/arm/dts/exynos5422-odroidxu3.dts+++b/arch/arm/dts/exynos5422-odroidxu3.dtsarch/arm/dts/exynos5422-odroidxu3.dts +4
-0@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };(quoted diff) +0
-0
b/include/configs/odroid_xu3.hindex 88bb98d..aa0c142 100644include/configs/odroid_xu3.h +0
-0@@ -47,6 +47,10 @@Quoted 10 lines
include/configs/odroid_xu3.h line 56
Quoted 9 lines
include/configs/odroid_xu3.h +0
-0#define
CONFIG_DEFAULT_CONSOLE"console=ttySAC2,115200n8\0"include/configs/odroid_xu3.h +4
-0+/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTTIn
odroid_xu3.hyou might want to add the below as well (for LAN + USB storage)
Review
Quoted 8 lines
(quoted diff) +8
-0+/* Enable USB */ +#define CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +#define CONFIG_USB_STORAGE +#define CONFIG_CMD_DHCP +#define CONFIG_USB_HOST_ETHER +#define CONFIG_USB_ETHER_SMSC95XX
Thanks for your reply. It works after above configs added.
It seems all configs which Suriyan specified are needed. Even though DHCP can be useless depending on the network situation. Sjoerd, How about add above configs for odroid_xu3.h?
Also, I think it is better to commit this patch separately with my patchset, because it took too long from when the first patch submitted, and I really want to make it merged with at least minimum functionalities.
Quoted 8 lines
Thanks
- SuriyanQuoted 6 lines
Best regards,
Hyungwon Hwang
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Best regards,
Hyungwon Hwang
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
Hey Hyungwon Hwang,
Quoted 20 lines · Hyungwon Hwang
Dear all,
Review
Quoted 12 lines · On Mon, 08 Dec 2014 19:36:46 -0800 Suriyan Ramasami <[email protected]> wrote:
In
odroid_xu3.hyou might want to add the below as well (for LAN + USB storage)(quoted diff) +8
-0+/* Enable USB */ +#define CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +#define CONFIG_USB_STORAGE +#define CONFIG_CMD_DHCP +#define CONFIG_USB_HOST_ETHER +#define CONFIG_USB_ETHER_SMSC95XXThanks for your reply. It works after above configs added.
Quoted 3 lines
It seems all configs which Suriyan specified are needed. Even though DHCP can be useless depending on the network situation. Sjoerd, How about add above configs for
odroid_xu3.h?
I sent a seperate patch with the title "Exynos: Move down common USB configuration", which adds the common configuration of USB storage/network support + common usb devices into exynos5-common.h so it can be shared among all exynos5 boards which i think is a better solution then adding non-board specific configuration to the XU3 config
Quoted 4 lines
Also, I think it is better to commit this patch separately with my patchset, because it took too long from when the first patch submitted, and I really want to make it merged with at least minimum functionalities.
That's fair enough. I don't mind either way. Thanks for testing!
Signature · 9 lines
Sjoerd Simons <[email protected]> Collabora Ltd. -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6170 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141209/6089c4d2/attachment.bin>
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
In reply to Suriyan RamasamiQuoted 68 lines · Suriyan Ramasami
Hello Hyungwon Hwang,
Quoted 52 lines · Hyungwon Hwang
Dear Sjoerd,
Quoted 4 lines · On Fri, 05 Dec 2014 21:26:10 +0100 Sjoerd Simons…
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
Quoted 9 lines
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default configHyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
Does it work only with this patch? I applied this patch on top of my patchset, and connected the ethernet cable to the device. But it seemed not working. Is there anything else that I should do for test?
Quoted 29 lines
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the
list: Exynos: Move down common USB configurationarch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)(quoted diff) +0
-0
b/arch/arm/dts/exynos5422-odroidxu3.dtsindex cff32a9..79a7acd 100644arch/arm/dts/exynos5422-odroidxu3.dts +4
-0@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };(quoted diff) +0
-0
b/include/configs/odroid_xu3.hindex 88bb98d..aa0c142 100644include/configs/odroid_xu3.h +0
-0@@ -47,6 +47,10 @@Quoted 10 lines
include/configs/odroid_xu3.h line 56
Quoted 9 lines
include/configs/odroid_xu3.h +0
-0#define
CONFIG_DEFAULT_CONSOLE"console=ttySAC2,115200n8\0"include/configs/odroid_xu3.h +4
-0+/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTTIn
odroid_xu3.hyou might want to add the below as well (for LAN + USB storage)
Review
Quoted 8 lines
(quoted diff) +8
-0+/* Enable USB */ +#define CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +#define CONFIG_USB_STORAGE +#define CONFIG_CMD_DHCP +#define CONFIG_USB_HOST_ETHER +#define CONFIG_USB_ETHER_SMSC95XX
+1
I enabled these locally on v10 so that I could DHCP and TFTP boot.
Kevin
PATCH v2 1/1 odroid-XU3: Add entry for DTS EHCI GPIO
In reply to Sjoerd SimonsQuoted 42 lines · Sjoerd Simons
Add samsung,vbus-gpio information for the XU3. This allows the usage of the EHCI controller on the XU3, which is connected to the SMSC LAN9514 chip (usb hub + network).
Signed-off-by Sjoerd Simons <[email protected]>---
Changes since v1:
+ Correct gpio number
+ Add USB configuration in the odroid XU3 default configHyungwon could you add this one to your XU3 patchset if you send a next version (assuming it looks good)?
For usb storage/network support this patch should be combined with the exynos configuration tweaks patch i submited earlier to the list:
Exynos: Move down common USB configurationarch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ include/configs/odroid_xu3.h | 4 ++++ 2 files changed, 8 insertions(+)arch/arm/dts/exynos5422-odroidxu3.dts +4
-0@@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci at 12110000 { + samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */ + }; + serial at 12C20000 { status="okay"; };include/configs/odroid_xu3.h +0
-0
include/configs/odroid_xu3.h line 56
Quoted 10 lines
include/configs/odroid_xu3.h +4
-0@@ -47,6 +47,10 @@#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" +/* USB */ +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_EXYNOS +/* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */ #undef CONFIG_EXYNOS_TMU#undef CONFIG_TMU_CMD_DTT
applied to u-boot-samsung.
Thanks,
Minkyu Kang.