is the commit 571dcfde2371 (net-next) a proper fix?
Subsystems (2)
Hi!
It seems for me that commit 571dcfde2371 (stmmac: platform: fix default values of the filter bins setting) is redundant (moreover, it could be a cause of crash in some cases when there is no platform data defined in case of CONFIG_OF).
In case of no OF the platform data should be provided by platform code where the defaults are set. What did I miss?
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
David Miller
maintainerFrom: Andy Shevchenko <[email protected]>
Date: Mon, 08 Dec 2014 12:23:20 +0200
Quoted 7 lines
It seems for me that commit
571dcfde2371(stmmac: platform: fix default values of the filter bins setting) is redundant (moreover, it could be a cause of crash in some cases when there is no platform data defined in case ofCONFIG_OF).In case of no OF the platform data should be provided by platform code where the defaults are set. What did I miss?
You missed follow-up fix:
commit 28603d13997e2ef47f18589cc9a44553aad49c86
Author: Huacai Chen <[email protected]> Date: Thu Nov 27 21:05:34 2014 +0800
stmmac: platform: Move plat_dat checking earlier
Quoted 8 lines · David Miller
Quoted 7 lines
It seems for me that commit
571dcfde2371(stmmac: platform: fix default values of the filter bins setting) is redundant (moreover, it could be a cause of crash in some cases when there is no platform data defined in case ofCONFIG_OF).In case of no OF the platform data should be provided by platform code where the defaults are set. What did I miss?
Quoted 7 lines
You missed follow-up fix:
commit
28603d13997e2ef47f18589cc9a44553aad49c86Author: Huacai Chen <[email protected]> Date: Thu Nov 27 21:05:34 2014 +0800stmmac: platform: Move
plat_datchecking earlier
Thanks, now it makes sense, indeed.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy