drm/armada: Remove dummy ->load_lut() implementation
Subsystems (7)
DRM drivers DRM misc Tegra architecture support DRM driver for Qualcomm display hardware +3 more subsystems
PATCH 1/5 drm/armada: Remove dummy ->load_lut() implementation
From: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Cc Russell King <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
--- drivers/gpu/drm/armada/armada_crtc.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/armada/armada_crtc.c +0 -5
@@ -653,10 +653,6 @@ static int armada_drm_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,return 0 ; } -static void armada_drm_crtc_load_lut (struct drm_crtc *crtc) -{ -} -/* The mode_config.mutex will be held for this call */ static void armada_drm_crtc_disable (struct drm_crtc *crtc) {
@@ -678,7 +674,6 @@ static const struct drm_crtc_helper_funcs armada_crtc_helper_funcs = { .mode_fixup = armada_drm_crtc_mode_fixup, .mode_set = armada_drm_crtc_mode_set, .mode_set_base = armada_drm_crtc_mode_set_base, - .load_lut = armada_drm_crtc_load_lut, .disable = armada_drm_crtc_disable, };
Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/5 drm/bochs: Remove dummy ->load_lut() implementation
From: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Cc Gerd Hoffmann <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
--- drivers/gpu/drm/bochs/bochs_kms.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/bochs/bochs_kms.c +0 -5
@@ -18,10 +18,6 @@ MODULE_PARM_DESC(defy, "default y resolution");/* ---------------------------------------------------------------------- */ -static void bochs_crtc_load_lut (struct drm_crtc *crtc) -{ -} -static void bochs_crtc_dpms (struct drm_crtc *crtc,int mode) {switch (mode) {
@@ -144,7 +140,6 @@ static const struct drm_crtc_helper_funcs bochs_helper_funcs = { .mode_set_base = bochs_crtc_mode_set_base, .prepare = bochs_crtc_prepare, .commit = bochs_crtc_commit, - .load_lut = bochs_crtc_load_lut, };static void bochs_crtc_init (struct drm_device *dev)
Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/5 drm/msm: Remove dummy ->load_lut() implementation
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Cc Rob Clark <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
--- drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 5 ----- drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 5 ----- 2 files changed, 10 deletions(-)
drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c +0 -5
@@ -323,10 +323,6 @@ static void mdp4_crtc_commit(struct drm_crtc *crtc)drm_crtc_vblank_put (crtc); } -static void mdp4_crtc_load_lut (struct drm_crtc *crtc) -{ -} -static int mdp4_crtc_atomic_check (struct drm_crtc *crtc,struct drm_crtc_state *state) {
@@ -524,7 +520,6 @@ static const struct drm_crtc_helper_funcs mdp4_crtc_helper_funcs = { .mode_set_base = drm_helper_crtc_mode_set_base, .prepare = mdp4_crtc_prepare, .commit = mdp4_crtc_commit, - .load_lut = mdp4_crtc_load_lut, .atomic_check = mdp4_crtc_atomic_check, .atomic_begin = mdp4_crtc_atomic_begin, .atomic_flush = mdp4_crtc_atomic_flush,
drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c +0 -5
@@ -275,10 +275,6 @@ static void mdp5_crtc_commit(struct drm_crtc *crtc)mdp5_disable (get_kms (crtc)); } -static void mdp5_crtc_load_lut (struct drm_crtc *crtc) -{ -} -struct plane_state {struct drm_plane *plane;struct mdp5_plane_state *state;
@@ -407,7 +403,6 @@ static const struct drm_crtc_helper_funcs mdp5_crtc_helper_funcs = { .mode_set_base = drm_helper_crtc_mode_set_base, .prepare = mdp5_crtc_prepare, .commit = mdp5_crtc_commit, - .load_lut = mdp5_crtc_load_lut, .atomic_check = mdp5_crtc_atomic_check, .atomic_begin = mdp5_crtc_atomic_begin, .atomic_flush = mdp5_crtc_atomic_flush,
Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 4/5 drm/sti: Remove dummy ->load_lut() implementation
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Cc Benjamin Gaignard <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
--- drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/gpu/drm/sti/sti_drm_crtc.c +0 -6
@@ -184,11 +184,6 @@ out:return ret; } -static void sti_drm_crtc_load_lut (struct drm_crtc *crtc) -{ -/* do nothing */ -} -static void sti_drm_crtc_disable (struct drm_crtc *crtc) {struct sti_mixer *mixer =to_sti_mixer (crtc);
@@ -243,7 +238,6 @@ static struct drm_crtc_helper_funcs sti_crtc_helper_funcs = { .mode_fixup = sti_drm_crtc_mode_fixup, .mode_set = sti_drm_crtc_mode_set, .mode_set_base = sti_drm_crtc_mode_set_base, - .load_lut = sti_drm_crtc_load_lut, .disable = sti_drm_crtc_disable, };
Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 5/5 drm/tegra: Remove dummy ->load_lut() implementation
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Signed-off-by Thierry Reding <[email protected]>
--- drivers/gpu/drm/tegra/dc.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/tegra/dc.c +0 -5
@@ -1169,10 +1169,6 @@ static void tegra_crtc_commit(struct drm_crtc *crtc)drm_crtc_vblank_on (crtc); } -static void tegra_crtc_load_lut (struct drm_crtc *crtc) -{ -} -static int tegra_crtc_atomic_check (struct drm_crtc *crtc,struct drm_crtc_state *state) {
@@ -1213,7 +1209,6 @@ static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs = { .mode_set_base = drm_helper_crtc_mode_set_base, .prepare = tegra_crtc_prepare, .commit = tegra_crtc_commit, - .load_lut = tegra_crtc_load_lut, .atomic_check = tegra_crtc_atomic_check, .atomic_begin = tegra_crtc_atomic_begin, .atomic_flush = tegra_crtc_atomic_flush,
Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 5/5] drm/tegra: Remove dummy ->load_lut() implementation
Quoted 6 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The ->load_lut() callback is optional, therefore a dummy implementation is not needed.
Signed-off-by Thierry Reding <[email protected]>
All patches merged to drm-misc with the small conflict here resolved, thanks.
Aside: We should rework the fbdev helper to use the main gamma table entry point and ditch this special-purpose gamma table save/restore logic here. But that's a lot more work.
-Daniel
Quoted 34 lines
--- drivers/gpu/drm/tegra/dc.c | 5 ----- 1 file changed, 5 deletions(-)drivers/gpu/drm/tegra/dc.c +0
-5@@ -1169,10 +1169,6 @@ static void tegra_crtc_commit(struct drm_crtc *crtc)drm_crtc_vblank_on (crtc); } -static void tegra_crtc_load_lut (struct drm_crtc *crtc) -{ -} -static int tegra_crtc_atomic_check (struct drm_crtc *crtc,struct drm_crtc_state *state) {@@ -1213,7 +1209,6 @@ static const struct drm_crtc_helper_funcs tegra_crtc_helper_funcs = { .mode_set_base = drm_helper_crtc_mode_set_base, .prepare = tegra_crtc_prepare, .commit = tegra_crtc_commit, - .load_lut = tegra_crtc_load_lut, .atomic_check = tegra_crtc_atomic_check, .atomic_begin = tegra_crtc_atomic_begin, .atomic_flush = tegra_crtc_atomic_flush,Signature · 6 lines
2.1.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel