thermal: imx: Do not print error message in the EPROBE_DEFER case

From: Fabio Estevam <[email protected]>

During imx_thermal probe we have the following log:

[    1.514819] imx_thermal 2000000.aips-bus:tempmon: failed to register cpufreq cooling device: -517
[    1.515064] platform 2000000.aips-bus:tempmon: Driver imx_thermal requests probe deferral

Avoid printing the error message in the EPROBE_DEFER case.

Signed-off-by Fabio Estevam <[email protected]>

---
 drivers/thermal/imx_thermal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/thermal/imx_thermal.c +4 -2

index bb08d6e..c1188ac 100644
@@ -513,8 +513,10 @@ static int imx_thermal_probe(struct platform_device *pdev)
 	data->cdev = cpufreq_cooling_register(cpu_present_mask);
 	if (IS_ERR(data->cdev)) {
 		ret = PTR_ERR(data->cdev);
-		dev_err(&pdev->dev,
-			"failed to register cpufreq cooling device: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
+				"failed to register cpufreq cooling device: %d\n",
+				ret);
 		return ret;
 	}
 

Signature · 1 line

1.9.1

Thanks for your patch. But I am queuing a different patch that does a similar job.

https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=fixes&id=0f1be51c358f740fe5183bd0bcd60076fdfb53d0

Can you please check my -fixes branch? When EPROBE_DEFER happens, we are now printing a debug message only.

Hi Eduardo,

Quoted 3 lines · Eduardo Valentin

Thanks for your patch. But I am queuing a different patch that does a similar job.

Quoted 1 line

https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=fixes&id=0f1be51c358f740fe5183bd0bcd60076fdfb53d0

I am running linux-next 20141211, which has this commit applied.

Quoted 2 lines

Can you please check my -fixes branch? When EPROBE_DEFER happens, we are now printing a debug message only.

On linux-next I am still getting the error, so I still needed my patch.

Thanks