Skip to contentSkip to conversation

net: phy: export fixed_phy_register()

PATCH Applied Mark Salter 3 participants 3 messages Dec 12, 2014

Subsystems (3)
Networking Network drivers Ethernet PHY
lore
Share & tools
lore

Mark Salter

author
#0 lore raw

PATCH 1/1 net: phy: export fixed_phy_register()

When building the bcmgenet driver as module, I get:

ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!

commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device tree") which added a call to fixed_phy_register. But fixed_phy_register needs to be exported if used from a module.

Signed-off-by Mark Salter <[email protected]>
---
 drivers/net/phy/fixed.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/phy/fixed.c +1 -0
index 47872caa..3ad0e6e 100644
@@ -274,6 +274,7 @@ struct phy_device *fixed_phy_register(unsigned int irq,
 
 	return phy;
 }
+EXPORT_SYMBOL_GPL(fixed_phy_register);
 
 static int __init fixed_mdio_bus_init(void)
 {
Signature · 1 line
1.8.3.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Mark Salter

When building the bcmgenet driver as module, I get:

ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!

commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device tree") which added a call to fixed_phy_register. But fixed_phy_register needs to be exported if used from a module.

Signed-off-by Mark Salter <[email protected]>
Acked-by Florian Fainelli <[email protected]>

I will have to rework the GENET/SYSTEMPORT/SF2 dependencies anyway, thanks!

Quoted 17 lines
---
 drivers/net/phy/fixed.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/phy/fixed.c +1 -0
index 47872caa..3ad0e6e 100644
@@ -274,6 +274,7 @@ struct phy_device *fixed_phy_register(unsigned int irq,
 
 	return phy;
 }
+EXPORT_SYMBOL_GPL(fixed_phy_register);
 
 static int __init fixed_mdio_bus_init(void)
 {
maintainer Applied
#2 lore raw
In reply to Mark Salter

From: Mark Salter <[email protected]>
Date: Thu, 11 Dec 2014 23:03:26 -0500

Quoted 9 lines

When building the bcmgenet driver as module, I get:

ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!

commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device tree") which added a call to fixed_phy_register. But fixed_phy_register needs to be exported if used from a module.

Signed-off-by Mark Salter <[email protected]>

APplied.