libata: export ata_get_cmd_descript()
PATCH 1/1 libata: export ata_get_cmd_descript()
The driver sata_dwc_460ex is using this symbol. To build it as a module we have to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that.
--- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)
drivers/ata/libata-eh.c +1 -0
@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)return NULL ; } +EXPORT_SYMBOL (ata_get_cmd_descript);/** * ata_eh_link_report - report error handling to user
Signature · 1 line
2.1.3
Hello.
Quoted 13 lines · Andy Shevchenko
The driver
sata_dwc_460exis using this symbol. To build it as a module we have to have the symbol exported. This patch addsEXPORT_SYMBOL()macro for that.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)drivers/ata/libata-eh.c +0
-0
drivers/ata/libata-eh.c const char *ata_get_cmd_descript(u8 command) · line 2392
Quoted 4 lines
drivers/ata/libata-eh.c +1
-0@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)return NULL ; } +EXPORT_SYMBOL (ata_get_cmd_descript);
Why not EXPORT_SYMBOL_GPL()?
MBR, Sergei
Quoted 18 lines · Sergei Shtylyov
Hello.
Quoted 14 lines · Andy Shevchenko
The driver
sata_dwc_460exis using this symbol. To build it as a module we have to have the symbol exported. This patch addsEXPORT_SYMBOL()macro for that.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)drivers/ata/libata-eh.c +0
-0@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
Quoted 5 lines
drivers/ata/libata-eh.c const char *ata_get_cmd_descript(u8 command) · line 2392
Quoted 3 lines
drivers/ata/libata-eh.c +1
-0return NULL ; } +EXPORT_SYMBOL (ata_get_cmd_descript);Why not
EXPORT_SYMBOL_GPL()?
Some of the symbols are exported in that way. I think better to wait the maintainer to tell which is preferred there.
Quoted 3 lines
MBR, Sergei
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 19 lines · Andy Shevchenko
Quoted 18 lines · Sergei Shtylyov
Hello.
Quoted 14 lines · Andy Shevchenko
The driver
sata_dwc_460exis using this symbol. To build it as a module we have to have the symbol exported. This patch addsEXPORT_SYMBOL()macro for that.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)drivers/ata/libata-eh.c +0
-0@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)
Quoted 8 lines
Quoted 5 lines
drivers/ata/libata-eh.c const char *ata_get_cmd_descript(u8 command) · line 2392
Quoted 3 lines
drivers/ata/libata-eh.c +1
-0return NULL ; } +EXPORT_SYMBOL (ata_get_cmd_descript);Why not
EXPORT_SYMBOL_GPL()?Some of the symbols are exported in that way. I think better to wait the maintainer to tell which is preferred there.
I don't really care. As the sole user is an in-kernel module, I'm gonna append _GPL for now.
Thanks.
Signature · 1 line
tejun
Quoted 26 lines · Tejun Heo
Quoted 25 lines · Andy Shevchenko
Quoted 23 lines · Sergei Shtylyov
Hello.
Quoted 13 lines · Andy Shevchenko
The driver
sata_dwc_460exis using this symbol. To build it as a module we have to have the symbol exported. This patch addsEXPORT_SYMBOL()macro for that.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/ata/libata-eh.c | 1 + 1 file changed, 1 insertion(+)drivers/ata/libata-eh.c +0
-0drivers/ata/libata-eh.c const char *ata_get_cmd_descript(u8 command) · line 2392
Quoted 4 lines
drivers/ata/libata-eh.c +1
-0@@ -2389,6 +2389,7 @@ const char *ata_get_cmd_descript(u8 command)return NULL ; } +EXPORT_SYMBOL (ata_get_cmd_descript);Why not
EXPORT_SYMBOL_GPL()?
Quoted 6 lines
Quoted 2 lines
Some of the symbols are exported in that way. I think better to wait the maintainer to tell which is preferred there.
I don't really care. As the sole user is an in-kernel module, I'm gonna append
_GPLfor now.
I'm okay with GPL. Thanks!
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy