staging:vt6655 Add extern variable in head file
PATCH 1/1 staging:vt6655 Add extern variable in head file
From: Sun Wang <[email protected]>
Subject: [PATCH] staging:vt6655 Add extern variable in head file
Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
Signed-off-by Sun Wang <[email protected]>
--- drivers/staging/vt6655/ioctl.c | 1 - drivers/staging/vt6655/ioctl.h | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-)
drivers/staging/vt6655/ioctl.c +0 -1
@@ -31,7 +31,6 @@*/ #include "ioctl.h" -#include "iocmd.h" #include "mac.h" #include "card.h" #include "hostap.h"
drivers/staging/vt6655/ioctl.h +5 -0
@@ -30,6 +30,11 @@#define __IOCTL_H__#include "device.h" +#include "iocmd.h" + +#ifdef WPA_SM_Transtatus +extern SWPAResult wpa_Result; +#endif int private_ioctl (struct vnt_private *,struct ifreq *rq);
Greg Kroah-Hartman
maintainerQuoted 3 lines · sunwxg
From: Sun Wang <[email protected]>
Subject: [PATCH] staging:vt6655 Add extern variable in head file
Why is this in the middle of the patch? I would have to hand edit it out :(
Quoted 2 lines
Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
Always wrap your changelog at 72 columns.
Please fix up and resend.
thanks,
greg k-h