Skip to contentSkip to conversation

Staging : lustre : replaced seq_printf() with seq_puts and changed include statement

PATCH In review Hariharan Rangasamy 2 participants 2 messages Dec 17, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging : lustre : replaced seq_printf() with seq_puts and changed include statement

Used seq_puts instead of seq_printf()
Used #include <linux/statfs.h> instead of #include <asm/statfs.h>

---
 drivers/staging/lustre/lustre/osc/lproc_osc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/lustre/lustre/osc/lproc_osc.c +5 -5
index 9f719bc..d64a400 100644
@@ -35,7 +35,7 @@
  */
 #define DEBUG_SUBSYSTEM S_CLASS
 
-#include <asm/statfs.h>
+#include <linux/statfs.h>
 #include "../include/obd_cksum.h"
 #include "../include/obd_class.h"
 #include "../include/lprocfs_status.h"
@@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
 		else
 			seq_printf(m, "%s ", cksum_name[i]);
 	}
-	seq_printf(m, "\n");
+	seq_puts(m, "\n");
 	return 0;
 }
 
@@ -590,7 +590,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 	seq_printf(seq, "pending read pages:   %d\n",
 		   atomic_read(&cli->cl_pending_r_pages));
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "pages per rpc	 rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
@@ -613,7 +613,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 			break;
 	}
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "rpcs in flight	rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
@@ -636,7 +636,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 			break;
 	}
 
-	seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
+	seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
 	seq_printf(seq, "offset		rpcs   %% cum %% |");
 	seq_printf(seq, "       rpcs   %% cum %%\n");
 
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 2 lines · Hariharan Rangasamy

Used seq_puts instead of seq_printf()
Used #include <linux/statfs.h> instead of #include <asm/statfs.h>

That's two different things, which means two different patches are needed. Please only do one-thing-per-patch.

thanks,

greg k-h