Skip to contentSkip to conversation

Staging: comedi: fix blank line coding style in comedi_bond.c

PATCH Superseded Frederic Jacob 2 participants 3 messages Dec 18, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: fix blank line coding style in comedi_bond.c

This is a patch to the comedi_bond.c file that fixes up a blank line after declaration warning found by the checkpatch.pl tool

---
This is my first patch that I send. It is for the Eudyptula chalange task 10.

 drivers/staging/comedi/drivers/comedi_bond.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/comedi/drivers/comedi_bond.c +1 -0
index 85b2f4a..221d381 100644
@@ -261,6 +261,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
 			{
 				/* Append dev:subdev to devpriv->name */
 				char buf[20];
+
 				snprintf(buf, sizeof(buf), "%u:%u ",
 					 bdev->minor, bdev->subdev);
 				strlcat(devpriv->name, buf,
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 1 line · Frederic Jacob

This is a patch to the comedi_bond.c file that fixes up a blank line after declaration warning found by the checkpatch.pl tool

Please line-wrap your line properly.

Quoted 1 line

And provide an empty line before the signed-off-by: line.

Can you fix that up and resend?

thanks,

greg k-h

#2 lore raw

PATCH v2 1/1 Staging: comedi: fix blank line coding style in comedi_bond.c

This is a patch to the comedi_bond.c file that fixes up a blank line after declaration warning found by the checkpatch.pl tool

---
v2: Fix description line-wrap and add a line before Signed-off-by

 drivers/staging/comedi/drivers/comedi_bond.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/comedi/drivers/comedi_bond.c +1 -0
index 85b2f4a..221d381 100644
@@ -261,6 +261,7 @@ static int do_dev_config(struct comedi_device *dev, struct comedi_devconfig *it)
 			{
 				/* Append dev:subdev to devpriv->name */
 				char buf[20];
+
 				snprintf(buf, sizeof(buf), "%u:%u ",
 					 bdev->minor, bdev->subdev);
 				strlcat(devpriv->name, buf,
Signature · 1 line
1.9.1