Skip to contentSkip to conversation

at86rf230: cleanup check on trac status

PATCH RESEND In review Alexander Aring 2 participants 3 messages Dec 19, 2014

Subsystems (2)
Network drivers IEEE 802.15.4
lore
Share & tools
lore

Alexander Aring

author maintainer
#0 lore raw

PATCH RESEND 1/1 at86rf230: cleanup check on trac status

Signed-off-by Alexander Aring <[email protected]>
Reviewed-by Stefan Schmidt <[email protected]>
---
 drivers/net/ieee802154/at86rf230.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/net/ieee802154/at86rf230.c +3 -5
index 79fbf38..80632fc 100644
@@ -749,13 +749,11 @@ at86rf230_tx_trac_check(void *context)
 	 * to STATE_FORCE_TRX_OFF then STATE_TX_ON to recover the transceiver
 	 * state to TX_ON.
 	 */
-	if (trac) {
+	if (trac)
 		at86rf230_async_state_change(lp, ctx, STATE_FORCE_TRX_OFF,
 					     at86rf230_tx_trac_error, true);
-		return;
-	}
-
-	at86rf230_tx_on(context);
+	else
+		at86rf230_tx_on(context);
 }
 
 static void
Signature · 1 line
2.2.0
#1 lore raw

Hi Alex,

Quoted 5 lines
Signed-off-by Alexander Aring <[email protected]>
Reviewed-by Stefan Schmidt <[email protected]>

---
drivers/net/ieee802154/at86rf230.c | 8 +++-----

1 file changed, 3 insertions(+), 5 deletions(-)

patch has been applied to bluetooth-next tree.

I would however prefer that even these small patches get a commit message explaining why that is correct and now was wrong before. Does not have to be anything big, but at least some sort of commit message body clearly explaining it would be helpful.

Regards

Marcel

author maintainer
#2 lore raw
Quoted 8 lines · Marcel Holtmann

Hi Alex,

Quoted 5 lines
Signed-off-by Alexander Aring <[email protected]>
Reviewed-by Stefan Schmidt <[email protected]>

---
drivers/net/ieee802154/at86rf230.c | 8 +++-----

1 file changed, 3 insertions(+), 5 deletions(-)
Quoted 4 lines

patch has been applied to bluetooth-next tree.

I would however prefer that even these small patches get a commit message explaining why that is correct and now was wrong before. Does not have to be anything big, but at least some sort of commit message body clearly explaining it would be helpful.

Okay, thanks.

I need to admit that writing commit messages in some cases is more work than to write the programming changes.

Nevertheless I will try to change that.

- Alex