socfpga: Drop redundant save_boot_params

PATCH New Tom Rini 3 participants 9 messages Dec 19, 2014 – Jan 7, 2015

Subsystems (2)

Arm (32-bit) Arm/actions semi architecture

lore

Share & tools

lore

Tom Rini

author

2014-12-19 21:52 UTC #0 lore raw

PATCH 1/3 socfpga: Drop redundant save_boot_params

The save_boot_params function here is the same as the default weak one from arch/arm/cpu/armv7/start.S, drop.

Cc Dinh Nguyen <[email protected]>

Cc Vince Bridgers <[email protected]>

Cc Chin Liang See <[email protected]>

Cc Marek Vasut <[email protected]>

Signed-off-by Tom Rini <[email protected]>

---
 arch/arm/cpu/armv7/socfpga/lowlevel_init.S |    7 -------
 1 file changed, 7 deletions(-)

arch/arm/cpu/armv7/socfpga/lowlevel_init.S +0 -7

index 2f2e9fc..afed773 100644
@@ -7,13 +7,6 @@
 #include <config.h>
 #include <version.h>
 
-/* Save the parameter pass in by previous boot loader */
-.global save_boot_params
-save_boot_params:
-	/* no parameter to save */
-	bx	lr
-
-
 /* Set up the platform, once the cpu has been initialized */
 .globl lowlevel_init
 lowlevel_init:

Signature · 1 line

1.7.9.5

Tom Rini

author

2015-01-07 15:13 UTC #1 lore raw

PATCH 1/3 socfpga: Drop redundant save_boot_params

Quoted 9 lines · Tom Rini

The save_boot_params function here is the same as the default weak one from arch/arm/cpu/armv7/start.S, drop.
Cc Dinh Nguyen <[email protected]>
Cc Vince Bridgers <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Marek Vasut <[email protected]>
Signed-off-by Tom Rini <[email protected]>
Reviewed-by Marek Vasut <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150107/a67b82b9/attachment.pgp>

Tom Rini

author

2014-12-19 21:52 UTC #2 lore raw

PATCH 2/3 am33xx: Drop timer_init call from s_init

In reply to Tom Rini

In both SPL and non-SPL cases we will make a call to timer_init() early on and do not need to call it again within s_init().

Signed-off-by Tom Rini <[email protected]>

---
 arch/arm/cpu/armv7/am33xx/board.c |    1 -
 1 file changed, 1 deletion(-)

arch/arm/cpu/armv7/am33xx/board.c +0 -1

index 29b1d73..eaf09d1 100644
@@ -294,7 +294,6 @@ void s_init(void)
 	save_omap_boot_params();
 #endif
 	watchdog_disable();
-	timer_init();
 	set_uart_mux_conf();
 	setup_clocks_for_console();
 	uart_soft_reset();

Signature · 1 line

1.7.9.5

Simon Glass

2014-12-21 18:52 UTC #3 lore raw

PATCH 2/3 am33xx: Drop timer_init call from s_init

Quoted 7 lines · Tom Rini

In both SPL and non-SPL cases we will make a call to timer_init() early on and do not need to call it again within s_init().
Signed-off-by Tom Rini <[email protected]>
---
 arch/arm/cpu/armv7/am33xx/board.c |    1 -
 1 file changed, 1 deletion(-)

Reviewed-by Simon Glass <[email protected]>

Tom Rini

author

2015-01-07 15:13 UTC #4 lore raw

PATCH 2/3 am33xx: Drop timer_init call from s_init

In reply to Tom Rini

Quoted 5 lines · Tom Rini

In both SPL and non-SPL cases we will make a call to timer_init() early on and do not need to call it again within s_init().
Signed-off-by Tom Rini <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150107/571376ae/attachment.pgp>

Marek Vasut

2014-12-20 02:40 UTC #5 lore raw

PATCH 1/3 socfpga: Drop redundant save_boot_params

In reply to Tom Rini

Quoted 8 lines · Tom Rini

The save_boot_params function here is the same as the default weak one from arch/arm/cpu/armv7/start.S, drop.
Cc Dinh Nguyen <[email protected]>
Cc Vince Bridgers <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Marek Vasut <[email protected]>
Signed-off-by Tom Rini <[email protected]>

Reviewed-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut

Tom Rini

author

2014-12-19 21:52 UTC #6 lore raw

PATCH 3/3 omap-common/hwinit-common.c: timer_init() doesn't need to touch gd

In reply to Tom Rini

The gd will be cleared at first so we don't need to set arch.tbl to 0. In addition, the checks later against lastinc also work fine with an initial value of 0 here. This also brings us in line with sunxi code for example.

Signed-off-by Tom Rini <[email protected]>

---
 arch/arm/cpu/armv7/omap-common/timer.c |    5 -----
 1 file changed, 5 deletions(-)

arch/arm/cpu/armv7/omap-common/timer.c +0 -5

index 7c9924d..032bd2c 100644
@@ -41,11 +41,6 @@ int timer_init(void)
 	writel((CONFIG_SYS_PTV << 2) | TCLR_PRE | TCLR_AR | TCLR_ST,
 		&timer_base->tclr);
 
-	/* reset time, capture current incrementer value time */
-	gd->arch.lastinc = readl(&timer_base->tcrr) /
-					(TIMER_CLOCK / CONFIG_SYS_HZ);
-	gd->arch.tbl = 0;	/* start "advancing" time stamp from 0 */
-
 	return 0;
 }

Signature · 1 line

1.7.9.5

Simon Glass

2014-12-21 18:53 UTC #7 lore raw

PATCH 3/3 omap-common/hwinit-common.c: timer_init() doesn't need to touch gd

Quoted 10 lines · Tom Rini

The gd will be cleared at first so we don't need to set arch.tbl to 0. In addition, the checks later against lastinc also work fine with an initial value of 0 here. This also brings us in line with sunxi code for example.
Signed-off-by Tom Rini <[email protected]>
---
 arch/arm/cpu/armv7/omap-common/timer.c |    5 -----
 1 file changed, 5 deletions(-)

Reviewed-by Simon Glass <[email protected]>

Tom Rini

author

2015-01-07 15:13 UTC #8 lore raw

PATCH 3/3 omap-common/hwinit-common.c: timer_init() doesn't need to touch gd

In reply to Tom Rini

Quoted 7 lines · Tom Rini

The gd will be cleared at first so we don't need to set arch.tbl to 0. In addition, the checks later against lastinc also work fine with an initial value of 0 here. This also brings us in line with sunxi code for example.
Signed-off-by Tom Rini <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150107/b5fa800d/attachment.pgp>