Skip to contentSkip to conversation

Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.

PATCH In review Gangadhar 2 participants 5 messages Dec 20, 2014 Staging

lore
Share & tools
lore

Gangadhar

author
#0 lore raw

PATCH 1/1 Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.

From: gangadharv <[email protected]>

Fixed a Coding style issue.

---
 drivers/staging/rtl8188eu/core/rtw_ap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_ap.c +1 -1
index d61842e..da19145 100644
@@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 		tx_ra_bitmap |= ((raid<<28)&0xf0000000);
 
 		DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
-			__func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
+			__func__, psta->mac_id, raid, tx_ra_bitmap, arg);
 
 		/* bitmap[0:27] = tx_rate_bitmap */
 		/* bitmap[28:31]= Rate Adaptive id */
Signature · 1 line
1.7.9.5
#1 lore raw

Gangadhar,

Quoted 5 lines · Gangadhar

From: gangadharv <[email protected]>

Fixed a Coding style issue.

Your Signed-off-by doesn't much your From line. Also, is this the full name you would use to sign off with on legal documents?

Quoted 25 lines
---
 drivers/staging/rtl8188eu/core/rtw_ap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_ap.c +1 -1
index d61842e..da19145 100644
@@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
 		tx_ra_bitmap |= ((raid<<28)&0xf0000000);
 
 		DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
-			__func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
+			__func__, psta->mac_id, raid, tx_ra_bitmap, arg);
 
 		/* bitmap[0:27] = tx_rate_bitmap */
 		/* bitmap[28:31]= Rate Adaptive id */
Signature · 7 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Signature · 1 line
- Jeremiah Mahler
#2 lore raw
In reply to Gangadhar

Gangadhar,

Quoted 3 lines · Gangadhar

From: gangadharv <[email protected]>

Fixed a Coding style issue.

The description needs to be more specific? What type of issue did you fix? How did you find this issue?

[...]

Signature · 1 line
- Jeremiah Mahler
#3 lore raw

Hi,
It is Space coding Style issue which i found when running checkpatch.pl script on rtw_ap.c.

--Gangadhar V

Quoted 14 lines · Jeremiah Mahler

Gangadhar,

Quoted 3 lines · Gangadhar

From: gangadharv <[email protected]>

Fixed a Coding style issue.

The description needs to be more specific? What type of issue did you fix? How did you find this issue?

[...]

--
- Jeremiah Mahler

#4 lore raw

Gangadhar,

Quoted 4 lines · Gangadhar V

Hi,
It is Space coding Style issue which i found when running checkpatch.pl script on rtw_ap.c.

Quoted 12 lines

--Gangadhar V

Quoted 10 lines · Jeremiah Mahler

Gangadhar,

Quoted 3 lines · Gangadhar

From: gangadharv <[email protected]>

Fixed a Coding style issue.

The description needs to be more specific? What type of issue did you fix? How did you find this issue?

Good, now describe this in the log message and submit a second version of the patch.

Quoted 4 lines
Quoted 4 lines

[...]

--
- Jeremiah Mahler

Signature · 1 line
- Jeremiah Mahler