Skip to contentSkip to conversation

checkpatch Warning fixes in drivers/char/mem.c

PATCH New [email protected] 1 participant 3 messages Dec 20, 2014 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

cover checkpatch Warning fixes in drivers/char/mem.c

From: Rob Ward <[email protected]>

Couple of changes to remove warnings reported by checkpatch.pl within drivers/char/mem.c

Neither of these patches introduce functional changes.

Rob Ward (2):
drivers: char: mem: Replace usage of asm include
drivers: char: mem: Fix Missing blank line issues

 drivers/char/mem.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.0.2
#1 lore raw

PATCH 1/2 drivers: char: mem: Replace usage of asm include

From: Rob Ward <[email protected]>

Replaces the use of asm/uaccess.h with linux/uaccess.h.

---
 drivers/char/mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/mem.c +1 -1
index 4c58333..a04ce78 100644
@@ -28,7 +28,7 @@
 #include <linux/io.h>
 #include <linux/aio.h>
 
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 
 #ifdef CONFIG_IA64
 # include <linux/efi.h>
Signature · 1 line
2.0.2
#2 lore raw

PATCH 2/2 drivers: char: mem: Fix Missing blank line issues

In reply to [email protected]

From: Rob Ward <[email protected]>

Fixes "Missing a blank line after declarations" reported by checkpatch.

This patch introduces no functional changes.

---
 drivers/char/mem.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/char/mem.c +2 -0
index a04ce78..6029d1f 100644
@@ -575,6 +575,7 @@ static ssize_t write_port(struct file *file, const char __user *buf,
 		return -EFAULT;
 	while (count-- > 0 && i < 65536) {
 		char c;
+
 		if (__get_user(c, tmp)) {
 			if (tmp > buf)
 				break;
@@ -631,6 +632,7 @@ static ssize_t read_iter_zero(struct kiocb *iocb, struct iov_iter *iter)
 
 	while (iov_iter_count(iter)) {
 		size_t chunk = iov_iter_count(iter), n;
+
 		if (chunk > PAGE_SIZE)
 			chunk = PAGE_SIZE;	/* Just for latency reasons */
 		n = iov_iter_zero(chunk, iter);
Signature · 1 line
2.0.2