Skip to contentSkip to conversation

kernel: fixed a space coding style issue

PATCH In review Gangadhar Vukkesala 2 participants 2 messages Dec 21, 2014

lore
Share & tools
lore

Gangadhar Vukkesala

author
#0 lore raw

PATCH 1/1 kernel: fixed a space coding style issue

fixed a space coding style issue in pid.c which was found when running checkpatch.pl on pid.c

Signed-off-by Gangadhar Vukkesala <[email protected]>
---
 kernel/pid.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/pid.c +2 -2
index cd36a5e..ad9d780 100644
@@ -72,7 +72,7 @@ struct pid_namespace init_pid_ns = {
 		.refcount       = ATOMIC_INIT(2),
 	},
 	.pidmap = {
-		[ 0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
+		[0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
 	},
 	.last_pid = 0,
 	.nr_hashed = PIDNS_HASH_ADDING,

@@ -267,7 +267,7 @@ void free_pid(struct pid *pid)
 		struct upid *upid = pid->numbers + i;
 		struct pid_namespace *ns = upid->ns;
 		hlist_del_rcu(&upid->pid_chain);
-		switch(--ns->nr_hashed) {
+		switch (--ns->nr_hashed) {
 		case 2:
 		case 1:
 			/* When all that is left in the pid namespace
Signature · 1 line
1.7.9.5
#1 lore raw

Gangadhar,

Quoted 38 lines · Gangadhar Vukkesala

fixed a space coding style issue in pid.c which was found when running checkpatch.pl on pid.c

Signed-off-by Gangadhar Vukkesala <[email protected]>
---
 kernel/pid.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/pid.c +2 -2
index cd36a5e..ad9d780 100644
@@ -72,7 +72,7 @@ struct pid_namespace init_pid_ns = {
 		.refcount       = ATOMIC_INIT(2),
 	},
 	.pidmap = {
-		[ 0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
+		[0 ... PIDMAP_ENTRIES-1] = { ATOMIC_INIT(BITS_PER_PAGE), NULL }
 	},
 	.last_pid = 0,
 	.nr_hashed = PIDNS_HASH_ADDING,

@@ -267,7 +267,7 @@ void free_pid(struct pid *pid)
 		struct upid *upid = pid->numbers + i;
 		struct pid_namespace *ns = upid->ns;
 		hlist_del_rcu(&upid->pid_chain);
-		switch(--ns->nr_hashed) {
+		switch (--ns->nr_hashed) {
 		case 2:
 		case 1:
 			/* When all that is left in the pid namespace
Signature · 7 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

It looks reasonable. But keep in mind that white space fixes may be considered "code churn" [1] in some parts of the kernel. The staging area is much more welcoming of these sorts of changes.

[1]: https://lkml.org/lkml/2014/6/10/819

Signature · 1 line
- Jeremiah Mahler