x86: Fix multiple coding style issues
PATCH 1/1 x86: Fix multiple coding style issues
--- arch/x86/boot/header.S | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
arch/x86/boot/header.S +10 -5
@@ -211,7 +211,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x60500020 # Characteristics (section flags) + .long 0x60500020 # Characteristics + # (section flags) # # The EFI application loader requires a relocation section
@@ -229,7 +230,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x42100040 # Characteristics (section flags) + .long 0x42100040 # Characteristics + # (section flags) # # The offset & size fields are filled in by build.c.
@@ -247,7 +249,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x60500020 # Characteristics (section flags) + .long 0x60500020 # Characteristics + # (section flags) # # The offset & size fields are filled in by build.c.
@@ -266,7 +269,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0xc8000080 # Characteristics (section flags) + .long 0xc8000080 # Characteristics + # (section flags) #endif /* CONFIG_EFI_STUB */
@@ -426,7 +430,8 @@ cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, #added with boot protocol #version 2.06 -hardware_subarch: .long 0 # subarchitecture, added with 2.07 +hardware_subarch: .long 0 # subarchitecture, + # added with 2.07 # default to 0 for normal x86 PC hardware_subarch_data: .quad 0
Signature · 1 line
2.2.1.202.g98acd41
Alexander,
On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
Your description needs to be more specific than just "coding style fixes". What type of problems did you fix? How did you find them?
(more inline...)
Quoted 62 lines
Signed-off-by Alexander Kuleshov <[email protected]>--- arch/x86/boot/header.S | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)arch/x86/boot/header.S +10
-5@@ -211,7 +211,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x60500020 # Characteristics (section flags) + .long 0x60500020 # Characteristics + # (section flags) # # The EFI application loader requires a relocation section@@ -229,7 +230,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x42100040 # Characteristics (section flags) + .long 0x42100040 # Characteristics + # (section flags) # # The offset & size fields are filled in by build.c.@@ -247,7 +249,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0x60500020 # Characteristics (section flags) + .long 0x60500020 # Characteristics + # (section flags) # # The offset & size fields are filled in by build.c.@@ -266,7 +269,8 @@ section_table: .long 0 # PointerToLineNumbers .word 0 # NumberOfRelocations .word 0 # NumberOfLineNumbers - .long 0xc8000080 # Characteristics (section flags) + .long 0xc8000080 # Characteristics + # (section flags) #endif /* CONFIG_EFI_STUB */@@ -426,7 +430,8 @@ cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line, #added with boot protocol #version 2.06 -hardware_subarch: .long 0 # subarchitecture, added with 2.07 +hardware_subarch: .long 0 # subarchitecture, + # added with 2.07 # default to 0 for normal x86 PC hardware_subarch_data: .quad 0Signature · 1 line
2.2.1.202.g98acd41
It looks like your fixes are for lines being over 80 characters. While it is preferrable that lines be less than 80 characters it is still acceptable if they are longer.
If you are looking for things to fix I suggest looking in the drivers/staging directory. There are lots of things that need to be fixed in there.
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 1 line
- Jeremiah Mahler
Hello Jeremiah,
Thank you for feedback. It is my first patches to kernel, so i have a some little questions:
Quoted 8 lines
Jeremiah Mahler <[email protected]>:
Alexander,On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
Your description needs to be more specific than just "coding style fixes". What type of problems did you fix? How did you find them?
There are some lines which more than 80 chars, I found it with scripts/checkpatch.pl.
What is the best place to put this description? In commit message after first line?
Quoted 4 lines
Jeremiah Mahler <[email protected]>:
If you are looking for things to fix I suggest looking in thedrivers/stagingdirectory. There are lots of things that need to be fixed in there.
So i must make this patch for kernel/git/gregkh/staging.git and resend it again or just to add to this thread?
Or i'm wrong?
Thank you.
Quoted 1 line
Jeremiah Mahler <[email protected]>:
If you are looking for things to fix I suggest looking in the drivers/staging directory. There are lots of things that need to be fixed in there.
Ah sorry, read it incorrectly.
2014-12-26 23:09 GMT+06:00 Alexander Kuleshov <[email protected]>:
Quoted 29 lines
Hello Jeremiah,
Thank you for feedback. It is my first patches to kernel, so i have a some little questions:
Quoted 8 lines
Jeremiah Mahler <[email protected]>:
Alexander,On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
Your description needs to be more specific than just "coding style fixes". What type of problems did you fix? How did you find them?
There are some lines which more than 80 chars, I found it with
scripts/checkpatch.pl.
What is the best place to put this description? In commit message after first line?Quoted 4 lines
Jeremiah Mahler <[email protected]>:
If you are looking for things to fix I suggest looking in thedrivers/stagingdirectory. There are lots of things that need to be fixed in there.So i must make this patch for
kernel/git/gregkh/staging.gitand resend it again or just to add to this thread?
Or i'm wrong?Thank you.
Signature · 2 lines
_________________________ 0xAX
Alexander,
Quoted 5 lines · Alexander Kuleshov
Hello Jeremiah,
Thank you for feedback. It is my first patches to kernel, so i have a some little questions:
I recommend checking out Greg Kroah Hartman's presentation on submitting your first patch. It has lots of good tips.
https://www.youtube.com/watch?v=LLBrBBImJt4
Quoted 5 lines
Quoted 5 lines
Jeremiah Mahler <[email protected]>:
Alexander,On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
Quoted 9 lines
Quoted 3 lines
Your description needs to be more specific than just "coding style fixes". What type of problems did you fix? How did you find them?
There are some lines which more than 80 chars, I found it with
scripts/checkpatch.pl.
What is the best place to put this description? In commit message after first line?
Yes, just put that in the log message. The first line is the summary, then a blank line, then the detailed log message. The summary line is what ends up in the subject line of the email.
Quoted 9 lines
Quoted 4 lines
Jeremiah Mahler <[email protected]>:
If you are looking for things to fix I suggest looking in thedrivers/stagingdirectory. There are lots of things that need to be fixed in there.So i must make this patch for
kernel/git/gregkh/staging.gitand resend it again or just to add to this thread?
Or i'm wrong?
You figured this out in your next message :)
Quoted 1 line
Thank you.
Glad I could help :)
Signature · 1 line
- Jeremiah Mahler