Skip to contentSkip to conversation

regulator: core: Avoid negative regulator no & initialize it to -1

PATCH Applied Aniroop Mathur 2 participants 2 messages Dec 28, 2014 – Dec 29, 2014 Voltage and current regulator framework

lore
Share & tools
lore

Aniroop Mathur

author
#0 lore raw

PATCH 1/1 regulator: core: Avoid negative regulator no & initialize it to -1

This patch initializes regulator_no to -1 to avoid extra subtraction operation performed every time we register a regulator and avoid negative regulator no in its name.

Signed-off-by Aniroop Mathur <[email protected]>
---
 drivers/regulator/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/regulator/core.c +3 -3
index a3c3785..b0729ef 100644
@@ -3481,7 +3481,7 @@ regulator_register(const struct regulator_desc *regulator_desc,
 {
 	const struct regulation_constraints *constraints = NULL;
 	const struct regulator_init_data *init_data;
-	static atomic_t regulator_no = ATOMIC_INIT(0);
+	static atomic_t regulator_no = ATOMIC_INIT(-1);
 	struct regulator_dev *rdev;
 	struct device *dev;
 	int ret, i;

@@ -3550,8 +3550,8 @@ regulator_register(const struct regulator_desc *regulator_desc,
 	rdev->dev.class = &regulator_class;
 	rdev->dev.of_node = of_node_get(config->of_node);
 	rdev->dev.parent = dev;
-	dev_set_name(&rdev->dev, "regulator.%d",
-		     atomic_inc_return(&regulator_no) - 1);
+	dev_set_name(&rdev->dev, "regulator.%lu",
+		     atomic_inc_return(&regulator_no));
 	ret = device_register(&rdev->dev);
 	if (ret != 0) {
 		put_device(&rdev->dev);
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Aniroop Mathur

This patch initializes regulator_no to -1 to avoid extra subtraction operation performed every time we register a regulator and avoid negative regulator no in its name.

Applied, thanks.